)]}'
{".zuul.d/jobs.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"249e21991b0dcc524a27f4168422fefa22e8e4f1","unresolved":true,"context_lines":[{"line_number":192,"context_line":"      nodepool_debug: true"},{"line_number":193,"context_line":"      nodepool_diskimage:"},{"line_number":194,"context_line":"        base_element: fedora-container"},{"line_number":195,"context_line":"        release: \u002734\u0027"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"- job:"},{"line_number":198,"context_line":"    name: dib-nodepool-functional-openstack-ubuntu-xenial-src"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5ab945ae_90be4b1f","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":21},"updated":"2021-05-12 11:11:17.000000000","message":"I think it would be best if either\na) the job name continues to be explicit about the release or...\nb) we do not hard-code the release here, signaling it is *expected* to be latest, as it would need to be updated every 6 months (Fedora release cadence). A bump to the default DIB_RELEASE would likewise be needed as well.\n\nAlso, since Fedora supports 2 released versions and so does DIB (at least up to now), we should probably keep testing the latest 2 released versions in CI matching what we have for CentOS, Ubuntu, Debian, etc, hence I lean to option a).\n\nAnother option, or rather complementing to option b), is to instead use the \"latest\" container tag that points to latest released version (34 as of today).\nhttps://hub.docker.com/_/fedora?tab\u003dtags\u0026page\u003d1\u0026ordering\u003dlast_updated\u0026name\u003dlatest","commit_id":"22e2c2f8b555302e990fb649557352f20438c8e1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e3a95520e7ebb9f5bda01479522a91b99152350d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"      nodepool_debug: true"},{"line_number":193,"context_line":"      nodepool_diskimage:"},{"line_number":194,"context_line":"        base_element: fedora-container"},{"line_number":195,"context_line":"        release: \u002734\u0027"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"- job:"},{"line_number":198,"context_line":"    name: dib-nodepool-functional-openstack-ubuntu-xenial-src"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"11dcf989_f4d80b9e","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":21},"in_reply_to":"3be2d880_2ec327d0","updated":"2021-05-14 06:06:00.000000000","message":"agree and will add the release into the name.","commit_id":"22e2c2f8b555302e990fb649557352f20438c8e1"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2cfa1248251e1148620ff6d307708095f0cdbd6","unresolved":true,"context_lines":[{"line_number":192,"context_line":"      nodepool_debug: true"},{"line_number":193,"context_line":"      nodepool_diskimage:"},{"line_number":194,"context_line":"        base_element: fedora-container"},{"line_number":195,"context_line":"        release: \u002734\u0027"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"- job:"},{"line_number":198,"context_line":"    name: dib-nodepool-functional-openstack-ubuntu-xenial-src"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3be2d880_2ec327d0","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":21},"in_reply_to":"5ab945ae_90be4b1f","updated":"2021-05-12 15:57:22.000000000","message":"Sticking with option a) makes sense to me since the container file stuff seems to be explicit about versions too.","commit_id":"22e2c2f8b555302e990fb649557352f20438c8e1"}],"diskimage_builder/elements/fedora-container/README.rst":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"249e21991b0dcc524a27f4168422fefa22e8e4f1","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Create a minimal image based on Fedora container image"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This element sets the ``DIB_RELEASE`` var to \u0027fedora\u0027. The release of"},{"line_number":8,"context_line":"fedora to be installed can be controlled through the ``DIB_RELEASE``"},{"line_number":9,"context_line":"variable, which defaults the latest supported release."}],"source_content_type":"text/x-rst","patch_set":9,"id":"b99bc858_cef5ddb6","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":35},"updated":"2021-05-12 11:11:17.000000000","message":"DISTRO_NAME","commit_id":"22e2c2f8b555302e990fb649557352f20438c8e1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"dbf1a6fd92f50d5f17bc7b0bd9718887f5f325ac","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Create a minimal image based on Fedora container image"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This element sets the ``DIB_RELEASE`` var to \u0027fedora\u0027. The release of"},{"line_number":8,"context_line":"fedora to be installed can be controlled through the ``DIB_RELEASE``"},{"line_number":9,"context_line":"variable, which defaults the latest supported release."}],"source_content_type":"text/x-rst","patch_set":9,"id":"933cb4af_0cda723a","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":35},"in_reply_to":"b99bc858_cef5ddb6","updated":"2021-05-16 23:46:56.000000000","message":"Sorry I missed this comment.  It\u0027s also wrong in fedora-minimal.  I\u0027ll update both.","commit_id":"22e2c2f8b555302e990fb649557352f20438c8e1"}],"diskimage_builder/elements/fedora-container/containerfiles/34":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2cfa1248251e1148620ff6d307708095f0cdbd6","unresolved":true,"context_lines":[{"line_number":7,"context_line":"#  https://src.fedoraproject.org/rpms/systemd/blob/f33/f/systemd.spec#_663"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RUN mkdir -p /etc/systemd/system \u0026\u0026 \\"},{"line_number":10,"context_line":"  ln -sf /dev/null /etc/systemd/system/systemd-resolved.service"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"a09e8261_070a9fbc","line":10,"updated":"2021-05-12 15:57:22.000000000","message":"Does there need to be a finalise.d step that sets this back again so that the booted images have working DNS?","commit_id":"22e2c2f8b555302e990fb649557352f20438c8e1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8ec0718ea672b5ba2cb95750019fa81e6f304a4b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"#  https://src.fedoraproject.org/rpms/systemd/blob/f33/f/systemd.spec#_663"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RUN mkdir -p /etc/systemd/system \u0026\u0026 \\"},{"line_number":10,"context_line":"  ln -sf /dev/null /etc/systemd/system/systemd-resolved.service"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fb28fe45_f62c07bf","line":10,"in_reply_to":"a09e8261_070a9fbc","updated":"2021-05-13 00:10:06.000000000","message":"Hrm I wonder if this pre-dates ...\n\nhttps://src.fedoraproject.org/rpms/systemd/c/0e4b90f1130a3da0989e9251b96090f21ddde878?branch\u003df33\n\nmaybe we don\u0027t need this as I feel like systemd won\u0027t be running in the container","commit_id":"22e2c2f8b555302e990fb649557352f20438c8e1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e3a95520e7ebb9f5bda01479522a91b99152350d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"#  https://src.fedoraproject.org/rpms/systemd/blob/f33/f/systemd.spec#_663"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RUN mkdir -p /etc/systemd/system \u0026\u0026 \\"},{"line_number":10,"context_line":"  ln -sf /dev/null /etc/systemd/system/systemd-resolved.service"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"7dbc2cb1_103dde52","line":10,"in_reply_to":"fb28fe45_f62c07bf","updated":"2021-05-14 06:06:00.000000000","message":"yeah, it came in @ https://review.opendev.org/c/openstack/diskimage-builder/+/722148/18/ which was before the above.  lets\u0027 try without it","commit_id":"22e2c2f8b555302e990fb649557352f20438c8e1"}],"diskimage_builder/elements/fedora-container/package-installs.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2cfa1248251e1148620ff6d307708095f0cdbd6","unresolved":true,"context_lines":[{"line_number":3,"context_line":"dracut-config-generic:"},{"line_number":4,"context_line":"grubby:"},{"line_number":5,"context_line":"kernel:"},{"line_number":6,"context_line":"initscripts:"},{"line_number":7,"context_line":"man-pages:"},{"line_number":8,"context_line":"lsb_release:"},{"line_number":9,"context_line":"redhat-rpm-config:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f462aa7e_385cef55","line":6,"updated":"2021-05-12 15:57:22.000000000","message":"Nit maybe move this entry to the end of the file so that it is adjacent to the related comment.","commit_id":"22e2c2f8b555302e990fb649557352f20438c8e1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e3a95520e7ebb9f5bda01479522a91b99152350d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"dracut-config-generic:"},{"line_number":4,"context_line":"grubby:"},{"line_number":5,"context_line":"kernel:"},{"line_number":6,"context_line":"initscripts:"},{"line_number":7,"context_line":"man-pages:"},{"line_number":8,"context_line":"lsb_release:"},{"line_number":9,"context_line":"redhat-rpm-config:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"13f1ef82_f34db063","line":6,"in_reply_to":"f462aa7e_385cef55","updated":"2021-05-14 06:06:00.000000000","message":"this is a copy of the the fedora-minimal one, for the moment; i\u0027ll re-evaluate as we go on with this.","commit_id":"22e2c2f8b555302e990fb649557352f20438c8e1"}]}