)]}'
{".zuul.d/jobs.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2170bfa132bfcc422e06bcbbc48bad2af8c306e0","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- job:"},{"line_number":71,"context_line":"    name: dib-functests-arm64"},{"line_number":72,"context_line":"    parent: base"},{"line_number":73,"context_line":"    nodeset: ubuntu-focal-arm64"},{"line_number":74,"context_line":"    run: playbooks/dib-functests/run.yaml"},{"line_number":75,"context_line":"    post-run: playbooks/dib-functests/post.yaml"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"4994c23d_7a70b762","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":16},"updated":"2021-05-21 18:48:49.000000000","message":"Why isn\u0027t this based on dib-functests-base?","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c6941b33746d6dc2228ab7fe48c50e4cf23feba6","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- job:"},{"line_number":71,"context_line":"    name: dib-functests-arm64"},{"line_number":72,"context_line":"    parent: base"},{"line_number":73,"context_line":"    nodeset: ubuntu-focal-arm64"},{"line_number":74,"context_line":"    run: playbooks/dib-functests/run.yaml"},{"line_number":75,"context_line":"    post-run: playbooks/dib-functests/post.yaml"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1567c96c_5a831376","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":16},"in_reply_to":"4994c23d_7a70b762","updated":"2021-05-26 03:28:32.000000000","message":"updated to use base job","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2170bfa132bfcc422e06bcbbc48bad2af8c306e0","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    voting: false"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- job:"},{"line_number":104,"context_line":"    name: dib-functests-extras"},{"line_number":105,"context_line":"    description: |"},{"line_number":106,"context_line":"      The extras tests on a Bionic build host with Python 3"},{"line_number":107,"context_line":"    parent: dib-functests-extras"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1fd11bf8_4dd2816d","line":104,"updated":"2021-05-21 18:48:49.000000000","message":"This job has the same name as its parent. I think that needs reorganizing.","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c6941b33746d6dc2228ab7fe48c50e4cf23feba6","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    voting: false"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- job:"},{"line_number":104,"context_line":"    name: dib-functests-extras"},{"line_number":105,"context_line":"    description: |"},{"line_number":106,"context_line":"      The extras tests on a Bionic build host with Python 3"},{"line_number":107,"context_line":"    parent: dib-functests-extras"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5495dd70_33c066aa","line":104,"in_reply_to":"1fd11bf8_4dd2816d","updated":"2021-05-26 03:28:32.000000000","message":"yep, reworked all these.","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2170bfa132bfcc422e06bcbbc48bad2af8c306e0","unresolved":true,"context_lines":[{"line_number":103,"context_line":"- job:"},{"line_number":104,"context_line":"    name: dib-functests-extras"},{"line_number":105,"context_line":"    description: |"},{"line_number":106,"context_line":"      The extras tests on a Bionic build host with Python 3"},{"line_number":107,"context_line":"    parent: dib-functests-extras"},{"line_number":108,"context_line":"    voting: false"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2e85e365_677cdccb","line":106,"range":{"start_line":106,"start_character":28,"end_line":106,"end_character":45},"updated":"2021-05-21 18:48:49.000000000","message":"This is not true anymore.","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c6941b33746d6dc2228ab7fe48c50e4cf23feba6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"- job:"},{"line_number":104,"context_line":"    name: dib-functests-extras"},{"line_number":105,"context_line":"    description: |"},{"line_number":106,"context_line":"      The extras tests on a Bionic build host with Python 3"},{"line_number":107,"context_line":"    parent: dib-functests-extras"},{"line_number":108,"context_line":"    voting: false"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f4514849_a2db4096","line":106,"range":{"start_line":106,"start_character":28,"end_line":106,"end_character":45},"in_reply_to":"2e85e365_677cdccb","updated":"2021-05-26 03:28:32.000000000","message":"removed","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"}],"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2170bfa132bfcc422e06bcbbc48bad2af8c306e0","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":" - we don\u0027t have a container for local testing : if this is of"},{"line_number":32,"context_line":"    interest, someone can contribute a script to build the"},{"line_number":33,"context_line":"    nodepool Dockerfile and then install the current tree."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":" - alternative platforms : if someone wants to contribute and maintain"},{"line_number":36,"context_line":"    alternative container environments to test in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"ebe51c58_acf65603","line":33,"updated":"2021-05-21 18:48:49.000000000","message":"This is probably my biggest concern but even modifying the docker hub nodepool-builder image to install your local dib edits shouldn\u0027t be too difficult so I think we can live with this for now.","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c7124d64e52d3d7a9b71bbc23a1c9b23c1460888","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"f8cda1bd_7bacf220","updated":"2021-10-25 22:48:39.000000000","message":"I\u0027m not so sure on this now -- we have switched all our functional testing to run on bullseye directly, which is very close to the container environment.  this might be enough, without introducing this overhead?","commit_id":"276c7ea601121d4f473bf08092e0170ad0d328e7"}],"roles/dib-functests/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2170bfa132bfcc422e06bcbbc48bad2af8c306e0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    state: directory"},{"line_number":12,"context_line":"    mode: ugo+rw"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# XXX : do this in pre?"},{"line_number":15,"context_line":"- name: Install docker"},{"line_number":16,"context_line":"  include_role:"},{"line_number":17,"context_line":"    name: ensure-docker"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"88203921_16e04574","line":14,"updated":"2021-05-21 18:48:49.000000000","message":"++ to doing this in pre. Then failures with external resources won\u0027t be as large of an impact.","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c6941b33746d6dc2228ab7fe48c50e4cf23feba6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    state: directory"},{"line_number":12,"context_line":"    mode: ugo+rw"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# XXX : do this in pre?"},{"line_number":15,"context_line":"- name: Install docker"},{"line_number":16,"context_line":"  include_role:"},{"line_number":17,"context_line":"    name: ensure-docker"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"cfebcbac_ebcb3bfe","line":14,"in_reply_to":"88203921_16e04574","updated":"2021-05-26 03:28:32.000000000","message":"re-organised things into pre.yaml","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"}],"tests/run_functests_container.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2170bfa132bfcc422e06bcbbc48bad2af8c306e0","unresolved":true,"context_lines":[{"line_number":81,"context_line":"}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# This is needed, because the better \u0027wait -n\u0027 is"},{"line_number":84,"context_line":"# available since bash 4.3 only."},{"line_number":85,"context_line":"function wait_minus_n {"},{"line_number":86,"context_line":"    if [ \"${BASH_VERSINFO[0]}\" -gt 4 \\"},{"line_number":87,"context_line":"                               -o \"${BASH_VERSINFO[0]}\" \u003d 4 \\"}],"source_content_type":"text/x-sh","patch_set":14,"id":"814ec995_2ee73142","line":84,"updated":"2021-05-21 18:48:49.000000000","message":"Seems debian buster\u0027s bash is newer than this? This script is running on the nodepool images which should be based on buster.","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c6941b33746d6dc2228ab7fe48c50e4cf23feba6","unresolved":true,"context_lines":[{"line_number":81,"context_line":"}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# This is needed, because the better \u0027wait -n\u0027 is"},{"line_number":84,"context_line":"# available since bash 4.3 only."},{"line_number":85,"context_line":"function wait_minus_n {"},{"line_number":86,"context_line":"    if [ \"${BASH_VERSINFO[0]}\" -gt 4 \\"},{"line_number":87,"context_line":"                               -o \"${BASH_VERSINFO[0]}\" \u003d 4 \\"}],"source_content_type":"text/x-sh","patch_set":14,"id":"1a045230_98da20e5","line":84,"in_reply_to":"814ec995_2ee73142","updated":"2021-05-26 03:28:32.000000000","message":"This script actually runs outside the container, but yeah, on the focal systems.  I\u0027ll take this as a cleanup for a follow-on","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2170bfa132bfcc422e06bcbbc48bad2af8c306e0","unresolved":true,"context_lines":[{"line_number":222,"context_line":"            echo \"  -t : prefix log messages with timestamp\""},{"line_number":223,"context_line":"            echo \"  -L : output logs into this directory\""},{"line_number":224,"context_line":"            echo \"  \u003ctest\u003e : functional test to run\""},{"line_number":225,"context_line":"            echo \"           Special test \u0027all\u0027 will run all tests\""},{"line_number":226,"context_line":"            exit 0"},{"line_number":227,"context_line":"            ;;"},{"line_number":228,"context_line":"        l)"}],"source_content_type":"text/x-sh","patch_set":14,"id":"52378964_186a3ea3","line":225,"updated":"2021-05-21 18:48:49.000000000","message":"Might want an argument to specify the container image to use, this way it will be a bit easier to run this locally if you have curated an image.","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c6941b33746d6dc2228ab7fe48c50e4cf23feba6","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            echo \"  -t : prefix log messages with timestamp\""},{"line_number":223,"context_line":"            echo \"  -L : output logs into this directory\""},{"line_number":224,"context_line":"            echo \"  \u003ctest\u003e : functional test to run\""},{"line_number":225,"context_line":"            echo \"           Special test \u0027all\u0027 will run all tests\""},{"line_number":226,"context_line":"            exit 0"},{"line_number":227,"context_line":"            ;;"},{"line_number":228,"context_line":"        l)"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3ac54f0f_f0d86098","line":225,"in_reply_to":"52378964_186a3ea3","updated":"2021-05-26 03:28:32.000000000","message":"done, added -C","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2170bfa132bfcc422e06bcbbc48bad2af8c306e0","unresolved":true,"context_lines":[{"line_number":257,"context_line":"done"},{"line_number":258,"context_line":"shift $((OPTIND-1))"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"export DIB_ELEMENTS\u003d$(docker run --rm ${DIB_CONTAINER} python -c \u0027import diskimage_builder.paths; diskimage_builder.paths.show_path(\"elements\")\u0027)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"# cull the list of tests to run into TESTS_TO_RUN"},{"line_number":263,"context_line":"TESTS_TO_RUN\u003d()"}],"source_content_type":"text/x-sh","patch_set":14,"id":"e726dcc5_d0b03d5a","line":260,"updated":"2021-05-21 18:48:49.000000000","message":"Does this need to move above line 196? Seems we use DIB_ELEMENTS there.","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c6941b33746d6dc2228ab7fe48c50e4cf23feba6","unresolved":false,"context_lines":[{"line_number":257,"context_line":"done"},{"line_number":258,"context_line":"shift $((OPTIND-1))"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"export DIB_ELEMENTS\u003d$(docker run --rm ${DIB_CONTAINER} python -c \u0027import diskimage_builder.paths; diskimage_builder.paths.show_path(\"elements\")\u0027)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"# cull the list of tests to run into TESTS_TO_RUN"},{"line_number":263,"context_line":"TESTS_TO_RUN\u003d()"}],"source_content_type":"text/x-sh","patch_set":14,"id":"ea01f42f_b2b5ada8","line":260,"in_reply_to":"e726dcc5_d0b03d5a","updated":"2021-05-26 03:28:32.000000000","message":"reorganised this into functions called in order","commit_id":"5e06c18205f8c8de8ba61a2ef76161f8ee435c8d"}]}