)]}'
{"id":"openstack%2Fdiskimage-builder~797794","triplet_id":"openstack%2Fdiskimage-builder~master~Iad0794d4e658b763685f274de690e5bcea055dbe","project":"openstack/diskimage-builder","branch":"master","topic":"rng-tools","hashtags":[],"change_id":"Iad0794d4e658b763685f274de690e5bcea055dbe","subject":"Revert \"Install rng-tools in Red Hat family distro images\"","status":"ABANDONED","created":"2021-06-24 01:32:16.000000000","updated":"2021-07-05 03:37:16.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d3b0a53fbfdf37ea86e9982d0e44f7728364ab90","_number":797794,"virtual_id_number":797794,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-06-24 03:05:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":-1,"date":"2021-06-29 16:48:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2021-07-02 05:26:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}],"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-24 01:36:20.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-06-24 01:39:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-06-24 03:05:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-29 08:21:14.000000000","updated_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"reviewer":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"state":"CC"},{"updated":"2021-06-29 16:48:46.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"}],"messages":[{"id":"c544e59ec5db7f46a806879fad59dcc42ac56d48","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-06-24 01:32:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4997395213ba5986e2ac8671fa85f99244b20bde","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-24 01:36:20.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 finger://zuul-v3-executor.novalocal/3d6d0180694a4d2db3a407e66d870560 : RETRY_LIMIT in 14s","accounts_in_message":[],"_revision_number":1},{"id":"016507df2edccb5e92ddce34b416a93f0988cf84","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 01:39:44.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/4e98ffe79b1d469fa968bc3f1f367dae : FAILURE in 3m 44s","accounts_in_message":[],"_revision_number":1},{"id":"a0414adece268c5159228c8332a10ace66e6a546","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 03:05:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/36788354d10c442db2ff6e27b95ec1fd : SUCCESS in 4m 55s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5a1368965c444e25ae027ac81d734c7f : SUCCESS in 4m 53s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2814b45e98ad4c3b86c3b973cf949bfe : SUCCESS in 4m 22s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/df850c362a564963a303e497cae5522c : SUCCESS in 52m 53s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/70c2eb00cd384a04abf7c25f97ada6d2 : SUCCESS in 28m 30s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/da14d705b976497397b4a054fdbb9a02 : SUCCESS in 4m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef5a699e19dd4ff19bc972f77cc77f19 : SUCCESS in 5m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5908dc33004f473cb851f1b7e206e328 : SUCCESS in 4m 26s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/44c5cb036d1346eca43d8fb295696000 : SUCCESS in 4m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ac2d83bf903a4ca58e3f6c69c5d6e365 : SUCCESS in 4m 22s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/395d0c8b967d45f383f92e43cd8bcdcb : SUCCESS in 4m 04s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/c51e7a30fa174d20b4924bc90e182eec : SUCCESS in 1h 31m 28s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/175ddd967dc140c395ab8730176016d6 : SUCCESS in 17m 38s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/cd07f7298292476d8c3158cb7b1e98b7 : SUCCESS in 46m 32s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/b9d30f8da1f04c0d92bf845e700bfe38 : SUCCESS in 47m 07s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/af3b7f19ef154cc8a99ff09689c8e09a : SUCCESS in 1h 02m 31s\n- dib-nodepool-functional-openstack-fedora-34-containerfile-src https://zuul.opendev.org/t/openstack/build/4bc7d36416b04a609edc92bc48391d36 : SUCCESS in 31m 18s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/e10fc22db15e4b99b12af5c1356f527f : SUCCESS in 44m 53s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/685847d1e88941718b08f5f92e3527b9 : SUCCESS in 30m 00s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/cce82daf0c964bfcb4e3e7cfddf73bf5 : SUCCESS in 31m 27s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/a0e8b08c4742426da4159bf82678c642 : SUCCESS in 42m 19s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/9e3baf7f532d416ab3c23a095155cff2 : FAILURE in 37m 05s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/e68c11eae4e248009e50b60fa705e0b2 : SUCCESS in 43m 30s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/25dfba9a45f34f4b927cc7adf2d3bd84 : SUCCESS in 36m 00s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/f8a628fa6111454b8bff133208aa0121 : SUCCESS in 33m 54s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/5b18cc5e6efe45bfb384e6eb285e0cf7 : SUCCESS in 10m 39s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/6f45a646742347fabea3a46ae8270be0 : SUCCESS in 8m 54s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/fdcaec35d5db4084bf8c33f25b622556 : SUCCESS in 1h 22m 28s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5a4d0144f2cb3efd0689a6ee72fd3788ba836e4a","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-06-29 09:42:47.000000000","message":"Patch Set 1:\n\nIf I don\u0027t hear otherwise I plan to merge this.  No response from upstream yet, and there seems to be little other chance of getting containerised installation of this happy (even if upstream responded, we\u0027d have to wait for centos to refresh at least).  Currently it is blocking the dib gate, and image building is paused in production for this issue.","accounts_in_message":[],"_revision_number":1},{"id":"132bc01843750afe492195da5499d448129bd976","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2021-06-29 10:00:34.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e If I don\u0027t hear otherwise I plan to merge this.  No response from upstream yet, and there seems to be little other chance of getting containerised installation of this happy (even if upstream responded, we\u0027d have to wait for centos to refresh at least).  Currently it is blocking the dib gate, and image building is paused in production for this issue.\n\nwell, it would affect Octavia Amphora images, they rely on rng-tools. I will impact boot time (we use encrypted tmpfs to store secrets) and TLS connections in the amphora.","accounts_in_message":[],"_revision_number":1},{"id":"eb9c01b09365b3fa92b402f605847061fc70dfb1","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-06-29 10:50:13.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\n\u003e well, it would affect Octavia Amphora images, they rely on rng-tools. I will impact boot time (we use encrypted tmpfs to store secrets) and TLS connections in the amphora.\n\nI think we have to consider building in a container a lowest-common denominator these days.  I guess Octavia builds native and doesn\u0027t get affected by this.  But Octavia can install this in its own elements/packed installs right?  It doesn\u0027t need to be in dib.  Another option is a completely separate element that we don\u0027t gate test/use in opendev production","accounts_in_message":[],"_revision_number":1},{"id":"2b5038ff9ea068aa0a4107bf301f458e7fe491f3","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2021-06-29 11:27:27.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \n\u003e \u003e well, it would affect Octavia Amphora images, they rely on rng-tools. I will impact boot time (we use encrypted tmpfs to store secrets) and TLS connections in the amphora.\n\u003e \n\u003e I think we have to consider building in a container a lowest-common denominator these days.  I guess Octavia builds native and doesn\u0027t get affected by this.  But Octavia can install this in its own elements/packed installs right?  It doesn\u0027t need to be in dib.  Another option is a completely separate element that we don\u0027t gate test/use in opendev production\n\nYeah, installing rng-tools from the elements defined in Octavia would be a work-around if this commit is merged.","accounts_in_message":[],"_revision_number":1},{"id":"cb66f5ae3230f61623da305cadac27b32f744382","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2021-06-29 16:48:46.000000000","message":"Patch Set 1: Code-Review-1\n\nThis will tank CentOS/RHEL boot time performance by removing this. As we saw starting with CentOS 8, more of the boot time services and kernel modules rely on the entropy pool now. The kernel pretty much empties it, which causes the other boot time services to stall waiting for enough entropy. The recommended workaround was to add this package to seed the entropy pool with a hardware random number generator provided via qemu.\n\nHave you considered mapping in the hwrng device into the container?\n--device /dev/hwrng:/dev/hwrng:r\n\nReally, I agree that this package should probably not use the --settle flag and block on the kernel hw_random device. But that is the point of the BZ.\n\nSome background on this package:\nhttps://developers.redhat.com/blog/2017/10/05/entropy-rhel-based-cloud-instances#what_is_entropy_and_why_is_important_","accounts_in_message":[],"_revision_number":1},{"id":"de1ba3474fa34083f8de2d5d52956dc354217ebd","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-07-02 05:26:39.000000000","message":"Patch Set 1: Workflow-1\n\nOk, it looks like a possible workaround is mounting /sys RO which signals to things such as systemd/udevadm/dbus/whatever-the-hell-magic-happens-these-days that we\u0027re in a container.\n\nI need to test more but\n\nhttps://review.opendev.org/c/openstack/diskimage-builder/+/799126\n\nis promising","accounts_in_message":[],"_revision_number":1},{"id":"d3b0a53fbfdf37ea86e9982d0e44f7728364ab90","tag":"autogenerated:gerrit:abandon","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-07-05 03:37:16.000000000","message":"Abandoned\n\nhttps://review.opendev.org/c/openstack/diskimage-builder/+/799126","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"35a0e1bb318efd3130cbb6ebccd5b0fc3a4e3aac","revisions":{"35a0e1bb318efd3130cbb6ebccd5b0fc3a4e3aac":{"kind":"REWORK","_number":1,"created":"2021-06-24 01:32:16.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/94/797794/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/94/797794/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/797794/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/797794/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/797794/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/94/797794/1"}}},"commit":{"parents":[{"commit":"75ee18b01b4e492386b9c31cf8011fcf72a59426","subject":"Merge \"bootloader: remove extlinux/syslinux path\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/75ee18b01b4e492386b9c31cf8011fcf72a59426"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2021-06-24 01:30:15.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2021-06-24 01:32:04.000000000","tz":600},"subject":"Revert \"Install rng-tools in Red Hat family distro images\"","message":"Revert \"Install rng-tools in Red Hat family distro images\"\n\nThis reverts commit 3ff7365ee82fb7664c8fa4619dc47435dea8e222.\n\nIt seems like recent versions of this can not be installed in a\ncontainer as it tries to run udevadm settle from the RPM post script,\nwhich just hangs forever.\n\nThis is mostly an attempt to unbreak the gate.\n\n[1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1975588\n\nChange-Id: Iad0794d4e658b763685f274de690e5bcea055dbe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/35a0e1bb318efd3130cbb6ebccd5b0fc3a4e3aac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/35a0e1bb318efd3130cbb6ebccd5b0fc3a4e3aac"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}