)]}'
{"id":"openstack%2Fdiskimage-builder~802408","triplet_id":"openstack%2Fdiskimage-builder~master~Ic50cfcbcef56ad88ee8d689064037d01f116b0d2","project":"openstack/diskimage-builder","branch":"master","topic":"dib-python","hashtags":[],"change_id":"Ic50cfcbcef56ad88ee8d689064037d01f116b0d2","subject":"Depend on dib-python to set DIB_PYTHON_VERSION","status":"NEW","created":"2021-07-27 00:03:01.000000000","updated":"2021-09-08 06:07:10.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ebdabd7fd4c87e6601b7df61084aff9e0ac0051b","_number":802408,"virtual_id_number":802408,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-07-27 01:39:49.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2021-08-27 01:59:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-27 00:11:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-07-27 01:39:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-27 01:59:06.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"}],"messages":[{"id":"5e69b4429cf987b8a78d8be475f79f8f0449cfd6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-07-27 00:03:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"35fe7dfb4fe96dddfcbe27d8c5aa575268eef707","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-27 00:11:04.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/48a7ada86bb64f83975aa8181ece2445 : FAILURE in 4m 46s","accounts_in_message":[],"_revision_number":1},{"id":"84ec423667a8614af8ae61d989bf0ae2f760853e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-27 01:39:49.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/237553064f9f4c52a2c029201387c86b : SUCCESS in 5m 29s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ded09d9f157749c883952daa02a78daa : SUCCESS in 4m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a04a6734e5e54cd8ae31a37d729fcc45 : SUCCESS in 4m 09s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/96488db5e11b4fa5adec936dac984858 : SUCCESS in 1h 14m 19s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/833836c792e24ed999b3499a9a70c745 : SUCCESS in 38m 07s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/01391c5c075a407694b5b0bb93065ed7 : SUCCESS in 5m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0ff0c56d416a4c968308962206406a8c : SUCCESS in 4m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/666929f210034a6d943446efd692fff3 : SUCCESS in 4m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7df4d0ddc80c4310b77fb548f698f38d : SUCCESS in 4m 15s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/cfac5fc4dbd644598a170920af7e210c : SUCCESS in 4m 01s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/ca5443050d834cefb0056fb808b96533 : SUCCESS in 4m 08s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/655ad701ea6c44a794bcf86af6856882 : SUCCESS in 1h 17m 37s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/0ab8a8318e634f4795fa1b37154b640e : SUCCESS in 16m 15s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/ef45446f041c4c0e8c754649ffeb3462 : SUCCESS in 30m 40s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/01d834a9fa4e4576b53edc6d0dffb1fc : SUCCESS in 33m 54s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/2ab4cda563eb4b7b9a8ba720e0bb5f9f : SUCCESS in 41m 58s\n- dib-nodepool-functional-openstack-fedora-34-containerfile-src https://zuul.opendev.org/t/openstack/build/b9b08695c4014c08b2ba583b0f4fadb5 : SUCCESS in 35m 02s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/a425c0bc6a054974ae9c52b8f4184078 : SUCCESS in 35m 42s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/e4a8e0f62f354c96a6169be6ce83e17c : SUCCESS in 37m 59s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/76c15fc5ef8245298a550f136063d787 : SUCCESS in 34m 11s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/871db50ad09745888a25bdf9c6645e48 : SUCCESS in 47m 22s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/0c1f56b5f0044d54a88b0912c7f012d8 : FAILURE in 41m 49s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/3a766a011362486ca981f752b4b3503b : FAILURE in 18m 24s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/cbfac6284afa462fad27a469009e9bbb : FAILURE in 13m 08s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/a9f881178b524c29a5befa92ed643935 : TIMED_OUT in 1h 31m 01s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/65710676c1224662b5f1b1e6d21309ee : SUCCESS in 11m 36s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/bc54c7ae7abe4ee4ad8774c6f34c0cc0 : SUCCESS in 11m 09s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/06a7d456248640f196395dc64ce2f8d6 : SUCCESS in 1h 24m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"25ab4a317db651fb601083e571792b9fb29ae568","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-08-27 01:59:06.000000000","message":"Patch Set 1: Code-Review-1\n\nI think at this point we\u0027re python3 distros only; instead of having more dependencies on dib-python we we can just strip the package-installs/pkg-map to install python3-yaml","accounts_in_message":[],"_revision_number":1},{"id":"c2101ac1b71853e0db8e4312644aa13cb455d29d","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-08-29 22:43:02.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e I think at this point we\u0027re python3 distros only; instead of having more dependencies on dib-python we we can just strip the package-installs/pkg-map to install python3-yaml\n\nNo because I think its a bootstrap issue, package-installs.yaml can only be parsed when python3-yaml is installed","accounts_in_message":[],"_revision_number":1},{"id":"ebdabd7fd4c87e6601b7df61084aff9e0ac0051b","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-09-08 06:07:10.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e No because I think its a bootstrap issue, package-installs.yaml can only be parsed when python3-yaml is installed\n\nThis is from *outside* the chroot though?  maybe we need to add it to bindep.  i\u0027m not sure why pulling in dib-python helps here?","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"729a2881e808e781434772f7f67f44fdb5bcd921","revisions":{"729a2881e808e781434772f7f67f44fdb5bcd921":{"kind":"REWORK","_number":1,"created":"2021-07-27 00:03:01.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/08/802408/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/08/802408/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/08/802408/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/08/802408/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/08/802408/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/08/802408/1"}}},"commit":{"parents":[{"commit":"0b14750e3feb82ee39bd6e7b1a5653c17d332956","subject":"Merge \"Update IRC networks\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/0b14750e3feb82ee39bd6e7b1a5653c17d332956"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-07-26 23:54:44.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-07-26 23:58:31.000000000","tz":720},"subject":"Depend on dib-python to set DIB_PYTHON_VERSION","message":"Depend on dib-python to set DIB_PYTHON_VERSION\n\ndracut-regenerate is failing on fedora with a missing python yaml\nerror. This is because python3-PyYAML has a dib_python_version filter\non it but DIB_PYTHON_VERSION is only set when the dib-python element\nis included.\n\nThis change adds an explicit dib-python element dependency wherever\ndib_python_version is used in the element package-installs.yaml.\n\nChange-Id: Ic50cfcbcef56ad88ee8d689064037d01f116b0d2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/729a2881e808e781434772f7f67f44fdb5bcd921"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/729a2881e808e781434772f7f67f44fdb5bcd921"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}