)]}'
{"id":"openstack%2Fdiskimage-builder~803123","triplet_id":"openstack%2Fdiskimage-builder~master~I2c5edd2e31fce04c7c35fc925e4474be27255dbf","project":"openstack/diskimage-builder","branch":"master","hashtags":[],"change_id":"I2c5edd2e31fce04c7c35fc925e4474be27255dbf","subject":"WIP: Add ubuntu-containerfile element","status":"NEW","created":"2021-08-01 20:24:00.000000000","updated":"2021-08-03 20:11:56.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3589a4aabfaf44b6b6508ae4ab9258442413817b","_number":803123,"virtual_id_number":803123,"owner":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-08-02 00:58:18.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-01 20:47:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-08-01 21:42:37.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-08-01 22:17:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-03 02:11:16.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"CC"}],"messages":[{"id":"a3f7556ee877f96eeabfd5780aa4d2499f77ae1a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2021-08-01 20:24:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e1121bd8bc840e608be27cc73b6e99d8ba3e359e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-01 20:47:41.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/da7a065c5c1940b9a988d8c473f3ed89 : FAILURE in 3m 48s","accounts_in_message":[],"_revision_number":1},{"id":"cac5481ae6c62b797d4ca547616ad4c6bf6f1bae","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-08-01 21:42:37.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/23/803123/1/check-dib/dib-functests-bionic-python3/208ed75/ : SUCCESS in 1h 16m 30s","accounts_in_message":[],"_revision_number":1},{"id":"8702c79fd335b734c5fa96a675abb1a076724d8e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-01 22:17:19.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d0db3dcb7ceb49bebb1281e954a0e7d5 : SUCCESS in 5m 09s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/412122916084429198040bd57070afa6 : SUCCESS in 5m 31s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c27b90d92fcc432a8fd915dffb04e187 : SUCCESS in 4m 16s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/dc6ad68a75af47428174cf36c07057d8 : SUCCESS in 54m 33s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/aadc88c2b0144a63a5532dfe3e561562 : SUCCESS in 30m 04s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/a70b575903f34484abdac6ceac7a72a2 : SUCCESS in 5m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3534fb9b93c241c3b0c67c4a10e16c90 : FAILURE in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b9c5559163ca48a883b2212bd8312aac : SUCCESS in 4m 20s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d4bb67826a18446b85d09b26a42e5082 : SUCCESS in 4m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0ee90718ab834edba7100a3f4ba98197 : SUCCESS in 4m 08s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/0562bfa6ff5b49999ae276aeec0fb604 : SUCCESS in 4m 09s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/76d7f4bddec84bf6a7284cec9641f3ec : SUCCESS in 1h 52m 10s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/7f9ca5250f6a43a4a8714ac7f90933f9 : SUCCESS in 15m 39s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/a1466c3568b44c01b8765f44cd54864b : SUCCESS in 35m 13s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/495aa6c88c204ca9a352cf634ee424a4 : SUCCESS in 33m 22s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/b33f70e12c444808b307f39166eda178 : SUCCESS in 32m 57s\n- dib-nodepool-functional-openstack-fedora-34-containerfile-src https://zuul.opendev.org/t/openstack/build/f6020828f8524f1d996ab3d6219b1583 : SUCCESS in 34m 11s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/d2d58e5677864cc08b43c545d9d4d7d2 : SUCCESS in 1h 00m 10s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/a27063c961a24019b260feb2ca0468d4 : SUCCESS in 50m 57s\n- dib-nodepool-functional-openstack-ubuntu-focal-containerfile-src https://zuul.opendev.org/t/openstack/build/3c0f6d2a37704b5283c14306b4dc7040 : FAILURE in 25m 31s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/6a867a55e0644b78b32764066b2f940a : SUCCESS in 57m 11s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/b665c3f071c345d29511072c70150f60 : SUCCESS in 1h 29m 32s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/56d819b884ae4ccfad397c821e6b4dd4 : FAILURE in 40m 23s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/e272aabc85cc4242bdeec82764dc4c0f : SUCCESS in 55m 15s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/da5dcef71d3c4e089120541ca11e3477 : FAILURE in 12m 39s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/3d3fe0961e5c4290841980f6ac9394af : TIMED_OUT in 1h 30m 48s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/1749129c8c7045be866c9972292d278b : SUCCESS in 14m 19s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/0628d9e4e1b9460ba544fa6be2725d29 : SUCCESS in 15m 29s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/5ce811b5811942e69fb1cb285b5099ed : SUCCESS in 1h 26m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a42449d8cafaeea647e9c6b1fde2c2d933cc48bb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2021-08-01 22:55:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2d7fdc823f0669326124a034a1b658853511c803","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-01 23:02:14.000000000","message":"Patch Set 2:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/5802a128f191497d8e25d37e7b6ace81 : FAILURE in 5m 09s","accounts_in_message":[],"_revision_number":2},{"id":"ee71a5f4bda0e25507943c7c5dbee04c7097736f","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-08-01 23:47:50.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/23/803123/2/check-dib/dib-functests-bionic-python3/26b2914/ : SUCCESS in 50m 32s","accounts_in_message":[],"_revision_number":2},{"id":"c2a1d43ca92b1ee9c3f17ada743393975aa3750b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-02 00:58:18.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f3f86144b3664374b029ecc86e3dbaae : SUCCESS in 7m 53s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e4144e850875469a89203a7f6786d07c : SUCCESS in 4m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8b149d273cc9444f921779a061bc0950 : SUCCESS in 4m 21s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/67e5c6c1ecbe4409bb4dbed5be91b611 : SUCCESS in 49m 31s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/4202c92023524c368fd22ad9de287781 : SUCCESS in 26m 08s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/e6ef0e89262949569dbda13de8746472 : SUCCESS in 4m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2b609ecbd3c04b8ba294ab55495d3b52 : FAILURE in 4m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fcdcd38ec47842eda14c5187092c5589 : SUCCESS in 4m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2c8cc4943b2d4da88685b2f95ec6d658 : SUCCESS in 6m 19s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/61291285b882483893e985ad30cbbee7 : SUCCESS in 3m 45s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/7e7f332afc8e4ae186a274a626cd5139 : SUCCESS in 4m 20s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/cc44796235a34684aa4259fb00eebed5 : SUCCESS in 1h 17m 12s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/cd14b949a42447caab4621d258fd2fd9 : SUCCESS in 16m 32s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/9d171d052f2c4c3685303227c2d997f8 : SUCCESS in 40m 09s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/39d42fc24ab747cdaf1107daa4387d8d : SUCCESS in 44m 52s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/cb738f3e5bef42b29efa26dcfc74b72c : SUCCESS in 43m 36s\n- dib-nodepool-functional-openstack-fedora-34-containerfile-src https://zuul.opendev.org/t/openstack/build/4d37ee65dbc347f1b0c0cb7e04f9be45 : SUCCESS in 47m 08s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/b57cecf0bef7452c80fa7a916f878256 : SUCCESS in 39m 05s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/2b2feec37f0c430f857444e603acba74 : SUCCESS in 41m 54s\n- dib-nodepool-functional-openstack-ubuntu-focal-containerfile-src https://zuul.opendev.org/t/openstack/build/b02357d051834558b552e5aeb61ef4cc : SUCCESS in 39m 33s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/3b4c841c5af44e3f84a79d0a5b0985b8 : SUCCESS in 43m 33s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/e7c345d75a1b44b1b99f4706cfa4e353 : SUCCESS in 48m 30s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/840ee6027721401ba129ebb0508c72ab : FAILURE in 51m 30s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/5936dc99a8a54b418864f6b73cc95ac7 : SUCCESS in 1h 02m 05s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/196a9646e8d0492fbdd402b012b61fbc : FAILURE in 21m 04s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/02c97c336f3b41a8b63df3f00302d697 : TIMED_OUT in 1h 31m 04s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/551499e0dad84aa4a708657afb3d81d3 : SUCCESS in 9m 29s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/dd71759d18374a23a6bac697b1d884c5 : SUCCESS in 12m 27s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/e06ba11145824d9f87f03fea49f2b9c3 : FAILURE in 1h 59m 13s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"5e2f18b87dac1b07921691fe3184cc8e157a8f83","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2021-08-02 22:09:03.000000000","message":"Patch Set 2:\n\nThis works in reality (I\u0027ve tested it with a real image on a real cloud) and also its test job passes (the failures here are other jobs).  So yay!\n\nBut there\u0027s something missing: when Docker or Podman build an image, they bind-mount in /etc/resolv.conf, based on either the host\u0027s file, or the --dns arguments passed to the build command.  Incorporated into the DIB process, this is the sequence:\n\n* containerfile element is base stage, so it runs first.\n* whatever changes to /etc/resolv.conf happen during \u0027podman build\u0027 are ephemeral due to bind-mount\n* containerfile extracts the built image.  in ubuntu docker base images, /etc/resolv.conf is an empty file, so that\u0027s what DIB starts with\n* DIB copies that file to resolv.conf.ORIG\n* other elements run\n* DIB copies resolv.conf.ORIG to resolv.conf\n* the resulting final image has an empty resolv.conf\n\nWhen booted:\n* glean (assuming the image is built with it) sees systemd running so does not touch resolv.conf\n* the system boots with an empty resolv.conf and is therefore broken.\n\nBecause containerfile runs early, we can\u0027t take advantage of the .ORIG feature to fix this up.\n\nPodman does have a \"--dns\u003dnone\" option which will avoid bind-mounting in resolv.conf, but that would just start the image build with an empty file, and therefore the build would fail.\n\nI *think* what we need to do is put in a finalize script that fixes up the systemd symlink.  Maybe that should be inside of ubuntu-containerfile, so that we can track any potential changes with new releases.\n\nBut I\u0027m wondering what happens with fedora -- it should be subject to the same issue -- unless fedora ships container base images with a working resolv.conf (which would never be used by anyone except us!).  Or maybe it does something on boot to fix it?\n\nAnother option would be to address this in glean.\n\nI\u0027d love some feedback before continuing.","accounts_in_message":[],"_revision_number":2},{"id":"e2624073d9c4bfa117fc7c201383c71467d26aad","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-08-03 02:11:16.000000000","message":"Patch Set 2:\n\nSeveral thoughts\n\n* in opendev gate, we have a nodepool element that puts 127.0.0.1 (unbound) into /etc/resolv.conf.ORIG which gets copied back into the image.  https://opendev.org/openstack/project-config/src/branch/master/nodepool/elements/nodepool-base/finalise.d/89-boot-settings#L220.  Thus production images are immune to this.\n\n* we can see from a build like https://zuul.opendev.org/t/openstack/build/3b4c841c5af44e3f84a79d0a5b0985b8/log/nodepool/builds/test-image-0000000001.log#1554 that minimal ubuntu-focal elements copy a symlink to the .ORIG file (it\u0027s taking the \"-L\" path)\n\n* we can see from a build like https://zuul.opendev.org/t/openstack/build/b02357d051834558b552e5aeb61ef4cc/log/nodepool/builds/test-image-0000000001.log#422 that containerfile ubuntu-focal element puts a file, not a symlink in .ORIG (as noted in comments)\n\n* so why do the ubuntu \u0026 fedora containerfile elements pass in the gate?  it seems they must both be running systemd-resolved with a blank /etc/resolv.conf file; which signals that systemd-resolved should not touch it -- we don\u0027t run production elements here, so nothing would touch it either.\n\n* i think the initial conclusion here is that name resolution is not working in the booted VM\u0027s under test.  I don\u0027t see where we try to access external resources, so I suspect this might be so.\n\nSo I think the first thing we should do is add external DNS testing to the base image tests to validate this theory (i.e. that DNS resolution isn\u0027t working but the test is passing).\n\nIf so, I broadly agree that we should probably be putting in a symlink for systemd-resolved in the base images and we can test a change to do that in the gate.","accounts_in_message":[],"_revision_number":2},{"id":"1f1b71b13869c8c4fda336e739aeca8698bff7ee","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-08-03 08:45:26.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e So I think the first thing we should do is add external DNS testing to the base image tests to validate this theory (i.e. that DNS resolution isn\u0027t working but the test is passing).\n\nThe subnet we currently connect to has no DNS servers, hence the config-drive is blank and glean just skips over writing anything out, leaving an invalid resolv.conf.  So we are not testing what (I at least) assumed we were there.\n\nAdding DNS servers to the subnet so they are in the config-drive metadata in https://review.opendev.org/c/zuul/nodepool/+/803301 does get glean writing /etc/resolv.conf, e.g.\n\nhttps://zuul.opendev.org/t/zuul/build/dced584bf3274d2782d0ba177b6975e6/log/job-output.txt#26724\n\nI was under the impression that VM\u0027s in the demo tenant should be able to get to the internet via masq but that appears to be either not the case, something has broken, or our devstack setup role is not setting things up correctly.","accounts_in_message":[],"_revision_number":2},{"id":"3589a4aabfaf44b6b6508ae4ab9258442413817b","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2021-08-03 20:11:56.000000000","message":"Patch Set 2:\n\nGlean only writes to /etc/resolv.conf if resolved is disabled:\nhttps://opendev.org/opendev/glean/src/branch/master/glean/cmd.py#L981\n\nIn the as-basic-as-possible ubuntu image I built apparently has it enabled since it took that code path.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f8130d054b7740e3ebc85d5e268c19b76f7b8dfb","revisions":{"284b64d56893901b5a594eb1403a71de51c173ea":{"kind":"REWORK","_number":1,"created":"2021-08-01 20:24:00.000000000","uploader":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"ref":"refs/changes/23/803123/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/23/803123/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/23/803123/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/23/803123/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/23/803123/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/23/803123/1"}}},"commit":{"parents":[{"commit":"0b14750e3feb82ee39bd6e7b1a5653c17d332956","subject":"Merge \"Update IRC networks\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/0b14750e3feb82ee39bd6e7b1a5653c17d332956"}]}],"author":{"name":"James E. Blair","email":"jim@acmegating.com","date":"2021-08-01 20:23:23.000000000","tz":-420},"committer":{"name":"James E. Blair","email":"jim@acmegating.com","date":"2021-08-01 20:23:23.000000000","tz":-420},"subject":"WIP: Add ubuntu-containerfile element","message":"WIP: Add ubuntu-containerfile element\n\nBased on fedora-containerfile.\n\nThis is more or less a shot in the dark at this point.\n\nChange-Id: I2c5edd2e31fce04c7c35fc925e4474be27255dbf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/284b64d56893901b5a594eb1403a71de51c173ea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/284b64d56893901b5a594eb1403a71de51c173ea"}]},"branch":"refs/heads/master"},"f8130d054b7740e3ebc85d5e268c19b76f7b8dfb":{"kind":"REWORK","_number":2,"created":"2021-08-01 22:55:01.000000000","uploader":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"ref":"refs/changes/23/803123/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/23/803123/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/23/803123/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/23/803123/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/23/803123/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/23/803123/2"}}},"commit":{"parents":[{"commit":"0b14750e3feb82ee39bd6e7b1a5653c17d332956","subject":"Merge \"Update IRC networks\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/0b14750e3feb82ee39bd6e7b1a5653c17d332956"}]}],"author":{"name":"James E. Blair","email":"jim@acmegating.com","date":"2021-08-01 20:23:23.000000000","tz":-420},"committer":{"name":"James E. Blair","email":"jim@acmegating.com","date":"2021-08-01 22:54:51.000000000","tz":-420},"subject":"WIP: Add ubuntu-containerfile element","message":"WIP: Add ubuntu-containerfile element\n\nBased on fedora-containerfile and ubuntu-minimal.\n\nThis is more or less a shot in the dark at this point.\n\nChange-Id: I2c5edd2e31fce04c7c35fc925e4474be27255dbf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/f8130d054b7740e3ebc85d5e268c19b76f7b8dfb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/f8130d054b7740e3ebc85d5e268c19b76f7b8dfb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}