)]}'
{"diskimage_builder/elements/gentoo/bin/install-packages":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5104986596667115848edc06ce0d0b3df0b6e6bf","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    fi"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"TEMP\u003d\"$(getopt -o huem: -n ${SCRIPTNAME} -- ${@})\""},{"line_number":68,"context_line":"if [[ \"${?}\" !\u003d 0 ]]; then"},{"line_number":69,"context_line":"    echo \u0027Terminating...\u0027 \u003e\u00262"},{"line_number":70,"context_line":"    exit 1"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"6ac9cb2e_c0dbfcc7","line":67,"range":{"start_line":67,"start_character":18,"end_line":67,"end_character":22},"updated":"2021-08-29 22:36:20.000000000","message":"this is missing an r","commit_id":"39080e88dcc97fa14e1969733d70190ff55fedda"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a4aeeb256d2dc7c3508159e8380b911db42bfe27","unresolved":true,"context_lines":[{"line_number":90,"context_line":"            ;;"},{"line_number":91,"context_line":"        -r )"},{"line_number":92,"context_line":"            shift"},{"line_number":93,"context_line":"            ;;"},{"line_number":94,"context_line":"        -m )"},{"line_number":95,"context_line":"            MAP_ELEMENT\u003d\"${2}\""},{"line_number":96,"context_line":"            shift 2"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"249d2b15_fdffedca","line":93,"updated":"2021-08-27 01:28:24.000000000","message":"It\u0027s not clear to me if this is saying that \"install\" (the default ACTION) is equivalent to re-install on gentoo, or we\u0027re deliberately not handling this?\n\nif it is the default action we should add a comment, if it\u0027s not, i don\u0027t think we need to implement it (as this would only affect gentoo+EFI which can be done separately) but this should exit with a sensible error.","commit_id":"39080e88dcc97fa14e1969733d70190ff55fedda"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5a27e0a0bf4216607a9d136e1106cbec13b151a4","unresolved":true,"context_lines":[{"line_number":90,"context_line":"            ;;"},{"line_number":91,"context_line":"        -r )"},{"line_number":92,"context_line":"            shift"},{"line_number":93,"context_line":"            ;;"},{"line_number":94,"context_line":"        -m )"},{"line_number":95,"context_line":"            MAP_ELEMENT\u003d\"${2}\""},{"line_number":96,"context_line":"            shift 2"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"4dffe820_e3906ba8","line":93,"in_reply_to":"249d2b15_fdffedca","updated":"2021-08-29 21:35:43.000000000","message":"I\u0027ve made the assumption that as a source based distro if you tell gentoo to install something it will always (re)install it, so install and reinstall are the same action. If that is wrong it can always be fixed later. But if you follow up on this comment I can replace this with raising an error.","commit_id":"39080e88dcc97fa14e1969733d70190ff55fedda"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5104986596667115848edc06ce0d0b3df0b6e6bf","unresolved":true,"context_lines":[{"line_number":90,"context_line":"            ;;"},{"line_number":91,"context_line":"        -r )"},{"line_number":92,"context_line":"            shift"},{"line_number":93,"context_line":"            ;;"},{"line_number":94,"context_line":"        -m )"},{"line_number":95,"context_line":"            MAP_ELEMENT\u003d\"${2}\""},{"line_number":96,"context_line":"            shift 2"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"f2912856_b15656a4","line":93,"in_reply_to":"4dffe820_e3906ba8","updated":"2021-08-29 22:36:20.000000000","message":"Ah, it looks like emerge --reinstall-atoms is what is required https://dev.gentoo.org/~zmedico/portage/doc/man/emerge.1.html","commit_id":"39080e88dcc97fa14e1969733d70190ff55fedda"}]}