)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5bc584b86e18fce97849465463c8bb9357729f8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bd6270c7_14a232bc","updated":"2021-10-26 03:43:02.000000000","message":"I am not -1, but I have reservations.  \n\n* This is only image based.  I think if we are starting this fresh, I would prefer to see this based on containerfile, as that seems a better way going forward.  I imagine rocky has some sort of container image that could pull from.  \n\n* We have a lot of \"if DISTRO\u003dcentos\" places that this doesn\u0027t cover.  One in particular is in glean, where this isn\u0027t using the NetworkManager path because it doesn\u0027t match any of that.  There is probably other things lying around all over like that.  \n\n* This seems self contained -- but then if we follow the point above it starts becoming less self-contained.  This is always a maintenance burden and we have to honestly trade-off how many resources we have available.\n\n* We\u0027ve accepted OpenEuler, a counterpoint to some of the above points\n\nWhat are the practical plans for this?  Is the goal for this to end up as an OpenDev base platform?  Who is interested?\n","commit_id":"8b458a4a9f6bdd6f9b10d5fabb598709b485841b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c4348f08a3ea33c944326cacc267c1e1eb6094d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5baa2e18_692469f2","in_reply_to":"08b4377c_87572771","updated":"2021-10-26 07:53:06.000000000","message":"\u003e I\u0027ll look into basing that on container file - are there any examples that I should follow?\n\nwe are currently using\n\nhttps://opendev.org/openstack/diskimage-builder/src/branch/master/diskimage_builder/elements/fedora-container\n\nin production to build fedora images\n\nWe have no used image-based builds, that start with the upstream .qcow2, in OpenDev production for quite some time.  The reason is that we found the upstream images tended to change in ways that constantly broke production, especially since they tend to include potentially a lot of things pre-installed.\n\nThis is why we use the \"-minimal\" images.  However, these build using rpm to extract a base chroot -- this can also have it\u0027s own issues.\n\nWe feel that containerfile is a good medium.  We expect the container images to be absolutely minimal, and also to not change very much at all.  So by using them as an initial chroot environment we get the best of both worlds, as it were.\n\n\u003e Practical plan is to use this as OpenDev base platform (OpenStack Kolla has a plan to add support for Rocky Linux 8) - if that\u0027s something that would be accepted.\n\nI feel this is something worth running past a wider audience than this change.  If we are building things and supporting 8-stream -- it feels like this implies that things will work on rocky which is aimed at trailing that.  Maintaining a platform in OpenDev is not *that* hard, but there\u0027s only so much bandwidth","commit_id":"8b458a4a9f6bdd6f9b10d5fabb598709b485841b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"671ad4a2fbcab879bd9cd63a85e669d92aad890b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cead1265_972cc0d2","in_reply_to":"5baa2e18_692469f2","updated":"2021-10-26 07:57:36.000000000","message":"Thanks, you might be right it might just too much of a burden to maintain those images in opendev CI - just to get through Kolla-Ansible host prechecks (that check Ansible distribution facts).\nBut anyway - I\u0027ll rework this change to use containerfile (because we - StackHPC rely on diskimage-builder to build the images for actual deployments).","commit_id":"8b458a4a9f6bdd6f9b10d5fabb598709b485841b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9624bc75a213302aa143bcd35f83eae1d3e71b2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"08b4377c_87572771","in_reply_to":"bd6270c7_14a232bc","updated":"2021-10-26 05:46:08.000000000","message":"I\u0027ll look into basing that on container file - are there any examples that I should follow?\nPractical plan is to use this as OpenDev base platform (OpenStack Kolla has a plan to add support for Rocky Linux 8) - if that\u0027s something that would be accepted.","commit_id":"8b458a4a9f6bdd6f9b10d5fabb598709b485841b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"697bcba6bd951c1b57fc43c01a07aeaa2aaa99fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"506a588e_0f3ace6e","updated":"2022-01-24 08:38:52.000000000","message":"Let\u0027s continue in https://review.opendev.org/c/openstack/diskimage-builder/+/825957","commit_id":"7e0a385a69cc83560a334824cb70249f2bb4e375"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"72e836e95b3dde8a42d87abfbc9a04cf10b185da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"625ebe3b_535394c0","updated":"2022-01-20 03:27:39.000000000","message":"Thank you for creating this new element, Jing, Michal,and Manuel! I left a few comments inline. If you decide to move this to a container-based format, then you can probably disregard these comments. :-)\n\nI agree with Ian\u0027s points on maintenance burden and usage of test resources. Personally, I really like the idea of supporting non-Stream CentOS alternative distributions such as Rocky. I see a trend in OpenStack to switch to CentOS Stream, but from a community perspective, AlmaLinux OS and Rocky Linux have gained a lot of traction lately.","commit_id":"7e0a385a69cc83560a334824cb70249f2bb4e375"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"f3e91d571cbb8c6b922b860556141da7c17663b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"14e5dbdf_3d68ab0a","updated":"2022-01-04 15:19:44.000000000","message":"We have interest from an openstack-ansible contributor to support Rocky Linux, though we have not decided yet as a team if this is something we want to commit to in OSA.\n\nHaving these images would be something that OSA would need if we moved forward with Rocky Linux support.","commit_id":"7e0a385a69cc83560a334824cb70249f2bb4e375"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5ad6fe553c1477f500f18da1e12dec7024176479","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6df1abbe_c9e1377a","in_reply_to":"14e5dbdf_3d68ab0a","updated":"2022-01-14 17:15:08.000000000","message":"I think it is reasonable to have, I\u0027m just wondering if someone is going to rebase the patch and push it forward?","commit_id":"7e0a385a69cc83560a334824cb70249f2bb4e375"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"af731fd1f01cf3c539b7c623ed9dc11b3f1e5544","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"83ccf859_c2c016f2","in_reply_to":"6df1abbe_c9e1377a","updated":"2022-01-14 17:17:49.000000000","message":"Previous comments from Ian Wienand point to moving to container based build, I will pursue that in two weeks time (next week I\u0027m off).","commit_id":"7e0a385a69cc83560a334824cb70249f2bb4e375"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"be207ca41e74b58fca080b4e90637c7fc768c7aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dd0bb5c5_6b6f12e9","updated":"2023-03-20 19:16:39.000000000","message":"To have that said, I don\u0027t think rocky-container does replace this work, since rocky-container is quite annoying to build in environments with limited connectivity due to dependency on the dockerhub","commit_id":"c58582974da8d9e24cb414a68a2c68c54934b2e1"}],"diskimage_builder/elements/rocky/environment.d/11-yum-dnf.bash":[{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"72e836e95b3dde8a42d87abfbc9a04cf10b185da","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# since Rocky Linux, dnf is the yum replacement."},{"line_number":2,"context_line":"export YUM\u003ddnf"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ef9e8922_0e7a2cee","line":1,"updated":"2022-01-20 03:27:39.000000000","message":"Nit: I believe you copied this comment from the centos element [1], but I don\u0027t think it makes sense here.\n\n[1] https://opendev.org/openstack/diskimage-builder/src/branch/master/diskimage_builder/elements/centos/environment.d/11-yum-dnf.bash#L1","commit_id":"7e0a385a69cc83560a334824cb70249f2bb4e375"}],"diskimage_builder/elements/rocky/package-installs.yaml":[{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"72e836e95b3dde8a42d87abfbc9a04cf10b185da","unresolved":true,"context_lines":[{"line_number":1,"context_line":"net-tools:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6e2a70e4_4e7c8ad4","line":1,"updated":"2022-01-20 03:27:39.000000000","message":"Any specific reason to install net-tools? I\u0027m not sure if OpenDev\u0027s CI uses ifconfig or similar tools, but iproute2 (should ship with Rocky by default) largely superseded net-tools.","commit_id":"7e0a385a69cc83560a334824cb70249f2bb4e375"}],"diskimage_builder/elements/rocky/pre-install.d/00-02-install-python":[{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"72e836e95b3dde8a42d87abfbc9a04cf10b185da","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":3,"context_line":"    set -x"},{"line_number":4,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"04e6db38_b211cbe4","line":1,"updated":"2022-01-20 03:27:39.000000000","message":"Very nit: no space after the shebang.","commit_id":"7e0a385a69cc83560a334824cb70249f2bb4e375"}],"diskimage_builder/elements/rocky/root.d/10-rocky-cloud-image":[{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"72e836e95b3dde8a42d87abfbc9a04cf10b185da","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":14,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-https://download.rockylinux.org/pub/rocky/${DIB_RELEASE}/images}"},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"    echo \u0027centos root element only support the x86_64 for $ARCH\u0027"},{"line_number":17,"context_line":"    exit 1"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"27cc617e_7ad53067","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":16},"updated":"2022-01-20 03:27:39.000000000","message":"rocky","commit_id":"7e0a385a69cc83560a334824cb70249f2bb4e375"}]}