)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e579f1493e8976497bac5e9442b9632729d25550","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Marco Vaschetto \u003cvaschetto.marco@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-09-16 01:46:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allowing use local image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Patch allow to set path for local image source,"},{"line_number":10,"context_line":"instead download latest or use the cached image file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b830c0ff_cb139d00","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":24},"updated":"2021-09-26 21:54:38.000000000","message":"There should really be a mention that this is for the ubuntu element","commit_id":"74642f3d652f016538b086c27d3c46da71689598"},{"author":{"_account_id":33576,"name":"Marco Vaschetto","email":"vaschetto.marco@gmail.com","username":"mvaschetto"},"change_message_id":"41f0d5d6989f85217c1121fae3551a26fa0b2b37","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marco Vaschetto \u003cvaschetto.marco@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-09-16 01:46:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allowing use local image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Patch allow to set path for local image source,"},{"line_number":10,"context_line":"instead download latest or use the cached image file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c3f44a5c_fa000169","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":24},"in_reply_to":"b830c0ff_cb139d00","updated":"2021-09-27 19:06:13.000000000","message":"Done","commit_id":"74642f3d652f016538b086c27d3c46da71689598"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e579f1493e8976497bac5e9442b9632729d25550","unresolved":true,"context_lines":[{"line_number":10,"context_line":"instead download latest or use the cached image file."},{"line_number":11,"context_line":"This permit to build image also in environment without internet access."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added quotation mark on string to string comparision for DIB_RELEASE variable"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Renamed DIB_IMAGE_LOCAL_FILE in DIB_LOCAL_IMAGE to follow the standard of other distros elements"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9422e21c5d0445e31d5a7258aa7310b20e39b929"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b40043b1_d02294a6","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":96},"updated":"2021-09-26 21:54:38.000000000","message":"There is no need to mention changes which happened during the review process in the commit message, its just confusing for those reading the commit log.","commit_id":"74642f3d652f016538b086c27d3c46da71689598"},{"author":{"_account_id":33576,"name":"Marco Vaschetto","email":"vaschetto.marco@gmail.com","username":"mvaschetto"},"change_message_id":"41f0d5d6989f85217c1121fae3551a26fa0b2b37","unresolved":false,"context_lines":[{"line_number":10,"context_line":"instead download latest or use the cached image file."},{"line_number":11,"context_line":"This permit to build image also in environment without internet access."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added quotation mark on string to string comparision for DIB_RELEASE variable"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Renamed DIB_IMAGE_LOCAL_FILE in DIB_LOCAL_IMAGE to follow the standard of other distros elements"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9422e21c5d0445e31d5a7258aa7310b20e39b929"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"599fc27b_ac58bd1c","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":96},"in_reply_to":"b40043b1_d02294a6","updated":"2021-09-27 19:06:13.000000000","message":"Done","commit_id":"74642f3d652f016538b086c27d3c46da71689598"}],"diskimage_builder/elements/ubuntu/root.d/10-cache-ubuntu-tarball":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a0b845b8f9134a09bfec4632aa0fa24f9dedde16","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    fi"},{"line_number":57,"context_line":"    # Extract the base image (use --numeric-owner to avoid UID/GID mismatch between"},{"line_number":58,"context_line":"    # image tarball and host OS e.g. when building Ubuntu image on an openSUSE host)"},{"line_number":59,"context_line":"    if [ $DIB_RELEASE !\u003d \"trusty\" ] \u0026\u0026 [ $DIB_RELEASE !\u003d \"xenial\" ] ; then"},{"line_number":60,"context_line":"        if [ -n \"$DIB_IMAGE_LOCAL_FILE\"] ; then"},{"line_number":61,"context_line":"            sudo unsquashfs -f -d $TARGET_ROOT $DIB_IMAGE_CACHE/$BASE_IMAGE_FILE"},{"line_number":62,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"d4788371_83709646","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":67},"updated":"2021-09-14 21:52:04.000000000","message":"Since it was like this before, I don\u0027t think this is a big deal, but typically, at least I suspect we would typically want the strings wrapped with quotation marks for a string to string comparison... but these are also two core variables and I suspect things would implode quickly if they were wrong.","commit_id":"19efc0e0fd281547d8becd853ae7027b736b0a48"},{"author":{"_account_id":33576,"name":"Marco Vaschetto","email":"vaschetto.marco@gmail.com","username":"mvaschetto"},"change_message_id":"ec92343adfb4b32ce4cd272bb57533306aa334db","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    fi"},{"line_number":57,"context_line":"    # Extract the base image (use --numeric-owner to avoid UID/GID mismatch between"},{"line_number":58,"context_line":"    # image tarball and host OS e.g. when building Ubuntu image on an openSUSE host)"},{"line_number":59,"context_line":"    if [ $DIB_RELEASE !\u003d \"trusty\" ] \u0026\u0026 [ $DIB_RELEASE !\u003d \"xenial\" ] ; then"},{"line_number":60,"context_line":"        if [ -n \"$DIB_IMAGE_LOCAL_FILE\"] ; then"},{"line_number":61,"context_line":"            sudo unsquashfs -f -d $TARGET_ROOT $DIB_IMAGE_CACHE/$BASE_IMAGE_FILE"},{"line_number":62,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0e7fc5a3_1fa7e904","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":67},"in_reply_to":"d4788371_83709646","updated":"2021-09-15 23:42:18.000000000","message":"Hello, thank for your review. I agree with you, I\u0027ll quote this two variables and repropose tha patch.","commit_id":"19efc0e0fd281547d8becd853ae7027b736b0a48"}]}
