)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"65fd8b23a6ffb57a7d01c8d12bb5ec5e2283e716","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-12-22 05:38:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add dnf versionlock support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie6d462a2132e4eaabc8ef85cac010ee4c90a793c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"a9058a2b_07f831da","line":8,"updated":"2022-01-14 17:13:21.000000000","message":"Greetings! Can you please provide some context as to why this is needed and the use cases where it makes sense. I could see it being used to the detriment of keeping systems up to date, but at the same time pinning specific versions *can* be a powerful tool, so understanding why helps us scope the patch when we\u0027re reviewing, and that really starts at the commit message.","commit_id":"70ad1eed809fbc3087b23b7577beda393cd52b8c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a493478f6e51d56fd696cc0e57c35d1b2aab4e4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5981f19_ad7ef719","updated":"2021-10-26 11:50:02.000000000","message":"recheck","commit_id":"3ffc4796379dc355f7a7c13ca1554f68c036385f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2ebefdeb8c2fe8fd2c60ef51c519981e776826d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de2e5032_a58f766f","updated":"2021-10-29 06:57:47.000000000","message":"This needs documentation added to the README.rst","commit_id":"d4cb48e6dcf533d297bf8e4ea724e45243c7830c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"65fd8b23a6ffb57a7d01c8d12bb5ec5e2283e716","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f296059d_ee1d8921","updated":"2022-01-14 17:13:21.000000000","message":"Greetings!\n\nI\u0027d appreciate a little more context into why and the use case behind this. It would also be helpful to have a release note added to convey to people looking at the changes between releases that there is a new feature/capability.\n\nIf you have any questions on how to create a release note, please feel free to reach out to TheJulia on IRC. Thanks!\n","commit_id":"70ad1eed809fbc3087b23b7577beda393cd52b8c"}],"diskimage_builder/elements/yum/pre-install.d/02-dnf-versionlock":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f6e252e2a3c5e3ee477c998b852072230287c3c0","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DIB_DNF_VERSIONLOCK\u003d${DIB_DNF_VERSIONLOCK:-}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [[ ${DIB_DNF_VERSIONLOCK} \u003d\u003d 1 \u0026\u0026 ${DISTRO_NAME} \u003d~ (centos|rhel) \u0026\u0026 ${DIB_RELEASE} \u003e 7 ]]; then"},{"line_number":12,"context_line":"    dnf -y install \u0027dnf-command(versionlock)\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    for package in $DIB_DNF_VERSIONLOCK_PACKAGES; do"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7cedd3f6_17572c2c","line":11,"updated":"2021-11-08 03:55:19.000000000","message":"I admit it\u0027s undocumented, but throughout this element we use ${YUM} to switch.  I think this should be\n\n if [[ ${YUM:-} -eq \"dnf\" ]]; then\n ...\n else\n  echo \"*** Only available on DNF systems\"\n  exit 1\n fi\n\nand that way it works for fedora, etc. that all use this element too.","commit_id":"8ab244d78e9d82c34bcf389f917c08cd4b9fa62e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"65fd8b23a6ffb57a7d01c8d12bb5ec5e2283e716","unresolved":true,"context_lines":[{"line_number":14,"context_line":"            dnf versionlock add $package"},{"line_number":15,"context_line":"        done"},{"line_number":16,"context_line":"    else"},{"line_number":17,"context_line":"        echo \"*** Only available on DNF systems\""},{"line_number":18,"context_line":"        exit 1"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"a0800f59_09e1e70e","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":17},"updated":"2022-01-14 17:13:21.000000000","message":"I feel like something more than this is really required because we need to get the user\u0027s attention when reviewing a very verbose log. \"FATAL ERROR\" seems appropriate.","commit_id":"70ad1eed809fbc3087b23b7577beda393cd52b8c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"65fd8b23a6ffb57a7d01c8d12bb5ec5e2283e716","unresolved":true,"context_lines":[{"line_number":15,"context_line":"        done"},{"line_number":16,"context_line":"    else"},{"line_number":17,"context_line":"        echo \"*** Only available on DNF systems\""},{"line_number":18,"context_line":"        exit 1"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7cf33e2a_387fe156","line":18,"updated":"2022-01-14 17:13:21.000000000","message":"I guess it makes sense to fail the build at this point since invalid expectations and configuration have collided in the build.","commit_id":"70ad1eed809fbc3087b23b7577beda393cd52b8c"}]}