)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33576,"name":"Marco Vaschetto","email":"vaschetto.marco@gmail.com","username":"mvaschetto"},"change_message_id":"e7fc46721a749f666b9feb85956b693495ca9b46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44be27dd_4afbe21c","updated":"2021-11-10 22:30:07.000000000","message":"Hello, \nI\u0027m re-propose the patch: https://review.opendev.org/c/openstack/diskimage-builder/+/809009\nreverted here: https://review.opendev.org/c/openstack/diskimage-builder/+/814094\n\nthis patch fix unbond variable DIB_LOCAL_IMAGE that break the build.\n\nBest regards\nMarco Vaschetto","commit_id":"9404af62bf551bb576e5d90e87d7d5f049c48bf8"}],"diskimage_builder/elements/ubuntu/README.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4ac3e455d2e2a40ce3365161cc43f1564a2d0ae6","unresolved":true,"context_lines":[{"line_number":23,"context_line":"   settings to allow insecure/unuthenticated repositories."},{"line_number":24,"context_line":" * Setting ``DIB_OFFLINE`` will prevent to download again the source image"},{"line_number":25,"context_line":"   if is already present in to $DIB_IMAGE_CACHE path."},{"line_number":26,"context_line":" * Setting ``DIB_LOCAL_IMAGE`` to use a image from a local source (full path and file name) "},{"line_number":27,"context_line":"   and not download image from internet. Local source for release Trusty"},{"line_number":28,"context_line":"   have to be tar.gz format. For other more recent release get the squashfs image."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"81c28b06_e7dc323f","line":26,"updated":"2021-11-23 15:01:05.000000000","message":"minor nit: whitespace","commit_id":"443305ab61655c93ed222ef23d7d0a342bffc6c9"}],"diskimage_builder/elements/ubuntu/root.d/10-cache-ubuntu-tarball":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a7d372174bf55069cbff32bce7eb57a3d99fc6f1","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":"    # Extract the base image (use --numeric-owner to avoid UID/GID mismatch between"},{"line_number":51,"context_line":"    # image tarball and host OS e.g. when building Ubuntu image on an openSUSE host)"},{"line_number":52,"context_line":"    if [ \"$DIB_RELEASE\" !\u003d \"trusty\" ] \u0026\u0026 [ \"$DIB_RELEASE\" !\u003d \"xenial\" ] ; then"},{"line_number":53,"context_line":"        if [ -z \"$DIB_LOCAL_IMAGE\" ] ; then"},{"line_number":54,"context_line":"            sudo unsquashfs -f -d $TARGET_ROOT $DIB_IMAGE_CACHE/$BASE_IMAGE_FILE"},{"line_number":55,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ecc30881_80d0d4ba","line":52,"updated":"2021-11-17 00:24:19.000000000","message":"I might prefer to see this refactored to just keep whatever image is chosen in one variable","commit_id":"9404af62bf551bb576e5d90e87d7d5f049c48bf8"},{"author":{"_account_id":33576,"name":"Marco Vaschetto","email":"vaschetto.marco@gmail.com","username":"mvaschetto"},"change_message_id":"f6419d6900f166a2e67ed04ae97f7258d7aea7aa","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":"    # Extract the base image (use --numeric-owner to avoid UID/GID mismatch between"},{"line_number":51,"context_line":"    # image tarball and host OS e.g. when building Ubuntu image on an openSUSE host)"},{"line_number":52,"context_line":"    if [ \"$DIB_RELEASE\" !\u003d \"trusty\" ] \u0026\u0026 [ \"$DIB_RELEASE\" !\u003d \"xenial\" ] ; then"},{"line_number":53,"context_line":"        if [ -z \"$DIB_LOCAL_IMAGE\" ] ; then"},{"line_number":54,"context_line":"            sudo unsquashfs -f -d $TARGET_ROOT $DIB_IMAGE_CACHE/$BASE_IMAGE_FILE"},{"line_number":55,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"cbe0eb26_7a8540ee","line":52,"in_reply_to":"ecc30881_80d0d4ba","updated":"2021-11-17 19:44:13.000000000","message":"Hello Ian,\nthank you for your feedback. I had simplify this step.\nI had also see that only ubuntu trusty release do not have an image in squashfs format.\nFor this, I think, it would be better to manage a single exception.","commit_id":"9404af62bf551bb576e5d90e87d7d5f049c48bf8"}]}
