)]}'
{"id":"openstack%2Fdiskimage-builder~818851","triplet_id":"openstack%2Fdiskimage-builder~master~Ia0e49980eb50eae29a5377d24ef0b31e4d78d346","project":"openstack/diskimage-builder","branch":"master","topic":"grubby-machine-id","attention_set":{},"removed_from_attention_set":{"7118":{"account":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"last_update":"2021-12-01 23:04:42.000000000","reason":"Ian Wienand replied on the change"}},"hashtags":[],"change_id":"Ia0e49980eb50eae29a5377d24ef0b31e4d78d346","subject":"Fix BLS based bootloader installation","status":"MERGED","created":"2021-11-23 05:31:11.000000000","updated":"2021-12-14 06:14:28.000000000","submitted":"2021-12-02 03:26:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"818851-grubby-machine-id","meta_rev_id":"802bcc896f2b09ebe5e99ed04a9aa69ad029b070","_number":818851,"virtual_id_number":818851,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-12-02 03:26:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"recommended":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-11-30 01:12:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":2,"date":"2021-11-29 20:45:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":1,"date":"2021-12-01 23:04:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-23 05:45:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-11-23 06:55:22.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-11-23 09:42:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-29 20:45:52.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2021-11-30 01:12:06.000000000","updated_by":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"reviewer":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"state":"REVIEWER"}],"messages":[{"id":"bd29ddf229ceed5c30eac6e48d3a0ded06459f21","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-11-23 05:31:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"230bbb102b98f163657bc1fe62d4faa264cd0a47","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-23 05:45:15.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64 https://zuul.opendev.org/t/openstack/build/0f004b869c954b3b8cddb4b9532fa0d0 : FAILURE in 12m 02s","accounts_in_message":[],"_revision_number":1},{"id":"541c87b58d898f90639a6fa7a02ff1038d17088c","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-11-23 06:55:22.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/51/818851/1/check-dib/dib-functests-bionic-python3/270925e/ : FAILURE in 1h 22m 11s","accounts_in_message":[],"_revision_number":1},{"id":"b3399cda4e3ba25de4a317f25ae6265ca3960308","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-11-23 07:32:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6458f07b1cab150e73c20170a4d008a464e6df61","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-23 07:48:03.000000000","message":"Patch Set 2:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64 https://zuul.opendev.org/t/openstack/build/7a3319616ce243ecbdfe6763f462da7a : FAILURE in 13m 49s","accounts_in_message":[],"_revision_number":2},{"id":"f73c50c6aa236d2ad55e691446be18cb3a70b9f5","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-11-23 08:14:39.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/51/818851/2/check-dib/dib-functests-bionic-python3/e453e99/ : FAILURE in 38m 48s","accounts_in_message":[],"_revision_number":2},{"id":"12aaaf698cf44a198280afc3368c4d8e68bc9170","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-23 09:42:06.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/974e55aef18045cd8cbde226549ba10b : SUCCESS in 5m 14s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/436ee697a8c74bb7b61cc4530054dcc5 : SUCCESS in 3m 55s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a83fc691a2b64cafb7b44cb5a5e8450f : SUCCESS in 3m 46s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/814eb38545204f5cbcf83c0bb1519e78 : SUCCESS in 1h 22m 30s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/8395af7762ff4b9c9ec838d4d8e59dc0 : SUCCESS in 41m 17s\n- tripleo-buildimage-overcloud-hardened-uefi-full-centos-8 https://zuul.opendev.org/t/openstack/build/40413f1130c643de9363b148f1ff128e : SUCCESS in 44m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2783b8ed3bdb4b53b4a99a405b1da1b1 : SUCCESS in 3m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/aef9f8f711fd4019ac80b0b564044d58 : SUCCESS in 3m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ee425cf5fa644f0493404c3158d67b5b : SUCCESS in 3m 49s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7bd9fc03306f4172815c5ebe2e77e960 : SUCCESS in 3m 38s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/1d56952347ee48109ee7e910f74f6f23 : SUCCESS in 3m 41s\n- dib-functests https://zuul.opendev.org/t/openstack/build/6cb852545cac433cad9e359f499fa1b1 : FAILURE in 8m 22s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/a0aa6a51f1974e80b9cb0d2583f44498 : SUCCESS in 2h 02m 38s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/eed02b2b49274b77943cd6c67eb69557 : SUCCESS in 17m 51s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/7da1cdd7c5a44b249afa04e6aa8abc77 : FAILURE in 34m 34s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/64c9ae48a25d40298134ee6fb68e1975 : SUCCESS in 34m 27s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/ef5df6b2576e48f79d07413c0532930a : SUCCESS in 37m 49s\n- dib-nodepool-functional-openstack-centos-9-stream-src https://zuul.opendev.org/t/openstack/build/de123c027fd7421d973a60fd76d636a2 : SUCCESS in 40m 17s\n- dib-nodepool-functional-openstack-fedora-35-containerfile-src https://zuul.opendev.org/t/openstack/build/fbf0c448a8254c6eade06d6a880e64c7 : SUCCESS in 44m 02s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/e1880e6fcfee43ad8f9ddd17ebc1e613 : FAILURE in 30m 25s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/4345017b988c455db47facdcee8a6da7 : FAILURE in 33m 13s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/ad4d654ecffa4aaa83d395a8fb3ebf1f : FAILURE in 35m 27s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/d70a20b1f35143f695e1cb24de3dceb3 : FAILURE in 1h 16m 38s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/aa1984d1800f4c5daf88b64018711a86 : FAILURE in 41m 40s (non-voting)\n- dib-nodepool-functional-openstack-gentoo-src https://zuul.opendev.org/t/openstack/build/ad07840008d04539b4d46d13f9d5dffe : FAILURE in 1h 30m 51s (non-voting)\n- dib-nodepool-functional-openstack-debian-bullseye-src https://zuul.opendev.org/t/openstack/build/3323eef68fbb4a2d8d3a3d1cd0a58b8a : FAILURE in 31m 35s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/152c3e6a43a94d169e1b9bada79db6be : SUCCESS in 14m 21s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/9ef6e22b7d874d77a1582c0d5a9aef7e : SUCCESS in 1h 14m 45s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e4bff5bdbb5bdb5346acceffb33eb37da0fc42c7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-11-25 03:27:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d8bd2f27fae140a8736b12828dad3b5b7de847f7","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-25 04:06:55.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64 https://zuul.opendev.org/t/openstack/build/463f2363395146bbaca8c5c695f8a778 : SUCCESS in 37m 45s","accounts_in_message":[],"_revision_number":3},{"id":"2c5777102b76e059a060bd303b3cc06d5e69e3cd","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-11-25 04:43:20.000000000","message":"Patch Set 3:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/51/818851/3/check-dib/dib-functests-bionic-python3/b0fcc7f/ : SUCCESS in 57m 28s","accounts_in_message":[],"_revision_number":3},{"id":"31e81f124dd3cdd95a2c38b1985650b224e88725","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-25 05:12:10.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6e5dfbfdb99b4b849251716d254191a8 : SUCCESS in 6m 10s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/eba2b155a0e9494bb384ef66891158b3 : SUCCESS in 4m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/390ee424c76840139d1804d8ce54ad7c : SUCCESS in 3m 58s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/fc2eb059fa174d8d8c6d408ab36c9ddf : SUCCESS in 52m 43s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/89060290de4f4595bcbceb7d4a44ffb5 : SUCCESS in 38m 38s\n- tripleo-buildimage-overcloud-hardened-uefi-full-centos-8 https://zuul.opendev.org/t/openstack/build/3429299ba0b349dfb60d6ca350a2ab79 : SUCCESS in 37m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/621104f6ed03460bb7048ad8dd0977c4 : SUCCESS in 4m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4178ef717ed94c6ebc078f92600a04b2 : SUCCESS in 3m 52s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1dc1e5b7277d4600b87b009631a8de80 : SUCCESS in 4m 36s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0f83e0d3515348b68cf5b40a136eec57 : SUCCESS in 4m 15s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/2b1c584f1eac4f4fb89a60f103c871b4 : SUCCESS in 4m 14s\n- dib-functests https://zuul.opendev.org/t/openstack/build/c9f978a4d42b4e1eaf890bf34c7406b9 : SUCCESS in 53m 43s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/7b61fb98d8c440229feeacbf8332730e : SUCCESS in 1h 38m 15s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/1bf93387147c4707a43e65fd9d2a1457 : SUCCESS in 16m 35s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/7222c7c370c34a2d87c3b0ba999a1cba : SUCCESS in 32m 59s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/b1a7310ecfa2459aa1f231f549ef129f : SUCCESS in 43m 58s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/2c6c090212654dde8ca3827f30afe752 : SUCCESS in 37m 29s\n- dib-nodepool-functional-openstack-centos-9-stream-src https://zuul.opendev.org/t/openstack/build/e64c57cece40495eb82ea9ab6922e978 : SUCCESS in 33m 17s\n- dib-nodepool-functional-openstack-fedora-35-containerfile-src https://zuul.opendev.org/t/openstack/build/cbc98603b49e49dd95089016af0507ee : SUCCESS in 37m 06s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/866159f7dcd943adbca0b8a8467bed71 : SUCCESS in 31m 28s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/d66b2ba396d44fd7854ef8dad0807de1 : SUCCESS in 30m 15s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/c5272262dbd14b408c907c4e7f74b121 : SUCCESS in 39m 32s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/9cf0040cf3db4a03be26921ddb6c85a7 : SUCCESS in 49m 30s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/e41e947233b7444aae9dd474f52621a6 : FAILURE in 37m 08s (non-voting)\n- dib-nodepool-functional-openstack-gentoo-src https://zuul.opendev.org/t/openstack/build/f24c08364f7a41fca9fd87ee1f42f600 : SUCCESS in 1h 08m 50s (non-voting)\n- dib-nodepool-functional-openstack-debian-bullseye-src https://zuul.opendev.org/t/openstack/build/d38c7bf913c248ddb63edfd1f37a45a1 : SUCCESS in 30m 50s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/a02f750e506847c289a914ec24848650 : SUCCESS in 12m 52s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/fada96ad121940e28842cdcdb79bb405 : SUCCESS in 1h 36m 31s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"b617a304367adba15dab2e3dd1136de6b4b9d937","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2021-11-29 20:45:52.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8513044641ac068fd95873ea6cce5ae7f81a5822","author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"date":"2021-11-30 01:12:06.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"3908d60f3d83205c2a28c2c73b67dfe001fa687d","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-12-01 23:04:42.000000000","message":"Patch Set 3: Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"0cc761433eb4dbcc3557782ee803354718aa2846","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-12-02 02:00:22.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"9744e86e247ea2418325ea46d1ce70952c1586f2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 02:07:09.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"21073d685ccb981ed808c9a6cc50ac864e3bf918","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 03:08:14.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64 https://zuul.opendev.org/t/openstack/build/7de806dedea345479b8e50fb1b2b30d8 : SUCCESS in 30m 45s","accounts_in_message":[],"_revision_number":3},{"id":"5370b570b01bfef8b073ebdd4f58f2373aa3978c","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-12-02 03:12:42.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/51/818851/3/check-dib/dib-functests-bionic-python3/4cf6342/ : FAILURE in 2m 11s","accounts_in_message":[],"_revision_number":3},{"id":"ca790d64e4b384c12844a8981b5c685c51928dbd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 03:26:50.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d6e1636183d648e2ba8605e6e566b96e : SUCCESS in 5m 17s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/32dd1b92c31e4e78898728c6c65cb2dc : SUCCESS in 4m 23s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/9778ec0b4a7a407e9040a0bc16630493 : SUCCESS in 1h 03m 44s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/80ba47f75dfc46cea3fc7b3c657f9c70 : SUCCESS in 32m 41s\n- tripleo-buildimage-overcloud-hardened-uefi-full-centos-8 https://zuul.opendev.org/t/openstack/build/3e5a1e0e8d3344629dc41b6170ca197e : SUCCESS in 41m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ea5379b85fe84adc880e214ae861f811 : SUCCESS in 5m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fd8b6facab0c4d6aa70bc10b36fc160a : SUCCESS in 4m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8170539413ba457f95eb5e7805678354 : SUCCESS in 4m 25s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/173df0da5449401eaefbd801fe04f4b6 : SUCCESS in 4m 10s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/d39ea4aa523f4c9db21c0a085b6f12b3 : SUCCESS in 1h 17m 52s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/be9335ff878f4791b55236764d370cff : SUCCESS in 19m 42s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/f3d7ee6466c44f3c81e9fc053a575474 : SUCCESS in 38m 36s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/a0a4d1b8e979433296f47aa2dd7a9b72 : SUCCESS in 38m 42s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/5e8af8c677114dc1a4d37c7c240e3e79 : SUCCESS in 40m 29s\n- dib-nodepool-functional-openstack-centos-9-stream-src https://zuul.opendev.org/t/openstack/build/55de1180eadc42a384e2bfadeeb17ff5 : SUCCESS in 38m 34s\n- dib-nodepool-functional-openstack-fedora-35-containerfile-src https://zuul.opendev.org/t/openstack/build/b0e83402cc9444c99b03b7eda02f5cf7 : SUCCESS in 42m 13s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/c6b6919a575a4e0792568592e9429548 : SUCCESS in 37m 38s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/40d70d75303d4a1db7291f89f7b404d6 : SUCCESS in 37m 59s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/a790307da7854dd3998242d202a9155e : SUCCESS in 42m 58s\n- dib-functests https://zuul.opendev.org/t/openstack/build/cb5fc639e9044da796288b07018f3c99 : SUCCESS in 59m 44s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/7d820e0bdf124f39a97adfb417170d5b : SUCCESS in 12m 16s","accounts_in_message":[],"_revision_number":3},{"id":"380c9cf9d6461abb3c8ebe8e88c15581cfe8dc16","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 03:26:51.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":3},{"id":"09d35febe107735cbdc97d34f0ee5aca24f52682","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 03:28:50.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3955b12543fb4c668fac092eb9c0429e : SUCCESS in 1m 05s","accounts_in_message":[],"_revision_number":3},{"id":"49f8216ccd0a6b348f958a8853586255dad45449","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-12-02 09:13:14.000000000","message":"Patch Set 3:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/51/818851/3/check-dib/dib-functests-bionic-python3/fe84501/ : SUCCESS in 1h 02m 20s","accounts_in_message":[],"_revision_number":3},{"id":"802bcc896f2b09ebe5e99ed04a9aa69ad029b070","tag":"autogenerated:gerrit:revert","author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"date":"2021-12-14 06:14:28.000000000","message":"Created a revert of this change as I5d7ebbd96cb70ea7da74995ec35c550638fff7f3","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2d47d4157c69e9de84fa3dec9f58bfd82bca6007","revisions":{"e018cc3e0abef29aaabed439bcc7b5522edecf1f":{"kind":"REWORK","_number":1,"created":"2021-11-23 05:31:11.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/51/818851/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/51/818851/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/1"}}},"commit":{"parents":[{"commit":"86682071a8b1de0b697f12ba6edd92c5aefeecf3","subject":"update gentoo source suffix (where it finds the file to download)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/86682071a8b1de0b697f12ba6edd92c5aefeecf3"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2021-11-23 05:30:50.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2021-11-23 05:30:50.000000000","tz":660},"subject":"[dnm] testing grubby machine-id interaction","message":"[dnm] testing grubby machine-id interaction\n\nChange-Id: Ia0e49980eb50eae29a5377d24ef0b31e4d78d346\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/e018cc3e0abef29aaabed439bcc7b5522edecf1f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/e018cc3e0abef29aaabed439bcc7b5522edecf1f"}]},"branch":"refs/heads/master"},"06cd5c27b09c0fa89cf6f90928a3efe420b27eaa":{"kind":"REWORK","_number":2,"created":"2021-11-23 07:32:11.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/51/818851/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/51/818851/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/2"}}},"commit":{"parents":[{"commit":"86682071a8b1de0b697f12ba6edd92c5aefeecf3","subject":"update gentoo source suffix (where it finds the file to download)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/86682071a8b1de0b697f12ba6edd92c5aefeecf3"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2021-11-23 05:30:50.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2021-11-23 07:31:52.000000000","tz":660},"subject":"[dnm] testing grubby machine-id interaction","message":"[dnm] testing grubby machine-id interaction\n\nChange-Id: Ia0e49980eb50eae29a5377d24ef0b31e4d78d346\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/06cd5c27b09c0fa89cf6f90928a3efe420b27eaa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/06cd5c27b09c0fa89cf6f90928a3efe420b27eaa"}]},"branch":"refs/heads/master"},"2d47d4157c69e9de84fa3dec9f58bfd82bca6007":{"kind":"REWORK","_number":3,"created":"2021-11-25 03:27:02.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/51/818851/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/51/818851/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/51/818851/3"}}},"commit":{"parents":[{"commit":"11d25f76d25d6d82fd2391efa12700fdafb7e2e5","subject":"Merge \"Added missing grubby arg DIB_BOOTLOADER_DEFAULT_CMDLINE\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/11d25f76d25d6d82fd2391efa12700fdafb7e2e5"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2021-11-23 05:30:50.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2021-11-25 03:26:23.000000000","tz":660},"subject":"Fix BLS based bootloader installation","message":"Fix BLS based bootloader installation\n\nThis reverts I2701260d54cf6bc79f1ac765b512d99d799e8c43,\nIdf2a471453c5490d927979fb97aa916418172153 and part of\nIecf7f7e4c992bb23437b6461cdd04cdca96aafa6 which added special flags to\nupdate kernels via grubby.\n\nThese changes actually ended up reverting the behaviour on Fedora 35,\nwhich is what led me to investigate what was going on more fully.\n\nAll distros still support setting GRUB_DEVICE in /etc/default/grub;\neven the BLS based ones (i.e. everything !centos7).\n\nThe implementation *is* confusing -- in earlier distros each BLS entry\nwould refer to the variable $kernelopts; which grub2-mkconfig would\nwrite into /boot/grub2/grubenv.  After commit [1] this was reverted,\nand the kernel options are directly written into the BLS entry.\n\nBut the real problem is this bit from [2]\n\n get_sorted_bls()\n {\n     if ! [ -d \"${blsdir}\" ] || ! [ -e /etc/machine-id ]; then\n        return\n     fi\n     ...\n     files\u003d($(for bls in ${blsdir}/${machine_id}-*.conf; do\n     ...\n }\n\ni.e., to avoid overwriting BLS entries for other OS-boots (?),\ngrub2-mkconfig will only update those BLS entries that match the\ncurrent machine-id.\n\nThe problem for DIB is that we are clearing the machine-id early in\nfinalise.d/01-clear-machine-id, but then running the bootloader update\nlater in finalise.d/50-bootloader.\n\nThe result is that the bootloader entry generated when we installed\nthe kernel (which guessed at the root\u003d device, etc.) is *not* updated.\nEven more annoyingly, the gate doesn\u0027t pick this up -- because the\ngate tests run on a DIB image that was booted with\n\"root\u003dLABEL\u003dcloudimg-rootfs\" the kernel initially installed with\n\"install-kernel\" (that we never updated) is actually correct.  But\nthis fails when built on a production host.\n\nThus we don\u0027t need any of the explicit grubby updates; these are\nreverted here.  This moves the machine-id clearing to after the\nbootloader setup, which allows grub2-mkconfig to setup the BLS entries\ncorrectly.\n\n[1] https://src.fedoraproject.org/rpms/grub2/c/4a742183a39f344a7685bccdc76d5e64dea3766a?branch\u003dmaster\n[2] https://src.fedoraproject.org/rpms/grub2/blob/rawhide/f/0062-Add-BLS-support-to-grub-mkconfig.patch\n\nDepends-On: https://review.opendev.org/c/zuul/nodepool/+/818705\nChange-Id: Ia0e49980eb50eae29a5377d24ef0b31e4d78d346\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/2d47d4157c69e9de84fa3dec9f58bfd82bca6007"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/2d47d4157c69e9de84fa3dec9f58bfd82bca6007"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}