)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"dd8d52c1c3407f87734d70e0e07aedf99509503b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d434efc8_3ed8dc81","updated":"2021-12-13 04:17:56.000000000","message":"The other option here is to just fail this like Fedora does and say \"don\u0027t use this\".  I don\u0027t think we gate test this, so I\u0027ll take it that you\u0027ve tested it.\n\nIf others think it\u0027s a good idea, OK","commit_id":"4f151aeeb5034bc3957e7517a2a07a3341d7cfc0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"868dd2cbb5c42185aa99d22f37320d8c3397de51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"135fb30a_33282e04","updated":"2021-12-18 11:37:59.000000000","message":"This patch has broken octavia, I\u0027ll do a follow-up to fix it.","commit_id":"4f151aeeb5034bc3957e7517a2a07a3341d7cfc0"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f1956461e47b6e6dac0ebfeba66203e4d635cd45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ccab046e_3e88300e","updated":"2021-12-14 04:47:02.000000000","message":"recheck","commit_id":"4f151aeeb5034bc3957e7517a2a07a3341d7cfc0"},{"author":{"_account_id":21757,"name":"Xing Zhang","email":"angeiv.zhang@gmail.com","username":"angeiv"},"change_message_id":"8dc234d8b9dc5736e377f8da293c046a42343d64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f5471dec_e0c46c85","updated":"2021-12-16 04:04:08.000000000","message":"recheck","commit_id":"4f151aeeb5034bc3957e7517a2a07a3341d7cfc0"}],"diskimage_builder/elements/pip-and-virtualenv/install.d/pip-and-virtualenv-source-install/04-install-pip":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"774ecceca3fb7a913d7d20003e22a17445a61aae","unresolved":true,"context_lines":[{"line_number":254,"context_line":"    # if installed later."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    python3 /tmp/get-pip.py $pip_args"},{"line_number":257,"context_line":"    python2 /tmp/get-pip.py $pip_args"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    # NOTE(dpawlik) The get-pip.py script is not base on master release."},{"line_number":260,"context_line":"    # Ensure that is uses latest available version."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"f4a80f2f_cf378cf1","line":257,"updated":"2021-12-08 20:10:30.000000000","message":"This element has always been about installing python2 AND python3 and setting up the pip environment (the transition period is what made this such a tremendous PITA)\n\nNow this won\u0027t install the python2 packages but then try and use python2 unconditionally here?\n\nI don\u0027t know what distro is in question here -- but ISTM that this needs to turn into something like the parent \"if\" statement for (opensuse|fedora|centos|centos7|rhel|rhel7) which decides if it can do python2 or python3?\n\nI also don\u0027t know what context you\u0027re in -- but is it strictly necessary to use more than the system-provided packages for pip/virtualenv?  Do you actually need this element to drag in and overwrite the very latest pip/virtualenv, or could it be replaced by a simple package installation of the system packages?  If there is a choice between spending time fixing this and spending time moving to system packages, I\u0027d suggest the latter TBH.","commit_id":"bcaa7ad13daa5a6114db06827e725370db8c1810"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"317e5150b8415010ebc39bbdae62b90e4fb08649","unresolved":true,"context_lines":[{"line_number":254,"context_line":"    # if installed later."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    python3 /tmp/get-pip.py $pip_args"},{"line_number":257,"context_line":"    python2 /tmp/get-pip.py $pip_args"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    # NOTE(dpawlik) The get-pip.py script is not base on master release."},{"line_number":260,"context_line":"    # Ensure that is uses latest available version."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"f7cb0190_615cb291","line":257,"in_reply_to":"c0886cc9_279ce6a6","updated":"2021-12-10 06:25:01.000000000","message":"To your first question, you could try that, or indeed just drop this element completely and arrange for python3-pip/python3-virtualenv to be installed just as regular packages (probably like in an element like  ironic-python-agent-ramdisk?).  Like fedora does, i\u0027m happy to put in a \"this doesn\u0027t work here\" message as well, to avoid others having the same problem.\n\nIf you want to fix this, I think it would need to look like the above bits for redhat platforms.  basically if bullseye, only install a python3 path.  historically, other distros have expected this element to bring in python2, so we shouldn\u0027t regress on that for compatibility.","commit_id":"bcaa7ad13daa5a6114db06827e725370db8c1810"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c27a0569725cda16815bc00c9603921973638860","unresolved":true,"context_lines":[{"line_number":254,"context_line":"    # if installed later."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    python3 /tmp/get-pip.py $pip_args"},{"line_number":257,"context_line":"    python2 /tmp/get-pip.py $pip_args"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    # NOTE(dpawlik) The get-pip.py script is not base on master release."},{"line_number":260,"context_line":"    # Ensure that is uses latest available version."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c0886cc9_279ce6a6","line":257,"in_reply_to":"f4a80f2f_cf378cf1","updated":"2021-12-09 08:07:19.000000000","message":"Hey Ian, thank you for your comment.\nI\u0027ll try to give you the context:\n- the distro in question here is Debian Bullseye\n- we\u0027re recently seeing constant failures when building ironic-python-agent ramdisk using diskimage-builder, for example https://3b4f892d34a0d03f73df-002c6183c0f1ab9234471cb74705bd70.ssl.cf1.rackcdn.com/820311/4/check/bifrost-integration-dibipa-debian-ubuntu-focal/7b92f2b/job-output.txt\n\nI believe using system package would probably be enough, should we use DIB_INSTALLTYPE_pip_and_virtualenv\u003dpackage ?\n\nFinally, if this module is still needed, then adding an \"if\" statement would allow its usage for distributions that removed python2, I could incorporate the change here.","commit_id":"bcaa7ad13daa5a6114db06827e725370db8c1810"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"07e16a812e97dc000ccf5ab73d50c047b39b520a","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    # if installed later."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    python3 /tmp/get-pip.py $pip_args"},{"line_number":257,"context_line":"    python2 /tmp/get-pip.py $pip_args"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    # NOTE(dpawlik) The get-pip.py script is not base on master release."},{"line_number":260,"context_line":"    # Ensure that is uses latest available version."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"b0d95a3a_7e3d7889","line":257,"in_reply_to":"f7cb0190_615cb291","updated":"2021-12-10 14:16:53.000000000","message":"Thanks, I\u0027m resorting on using DIB_INSTALLTYPE_pip_and_virtualenv\u003dpackage as workaround for our use case at the moment and it seems to work.\nAlso giving a try on shuffling things here just in case.","commit_id":"bcaa7ad13daa5a6114db06827e725370db8c1810"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"868dd2cbb5c42185aa99d22f37320d8c3397de51","unresolved":true,"context_lines":[{"line_number":265,"context_line":"        # time and you had to use \"python -m venv\".  Since then virtualenv"},{"line_number":266,"context_line":"        # has gained 3.4 support so the pip install below will work"},{"line_number":267,"context_line":"        if [[ ${DIB_PYTHON_VERSION} \u003d\u003d 3 ]]; then"},{"line_number":268,"context_line":"            packages+\u003d\"python3-pip python3-virtualenv\""},{"line_number":269,"context_line":"        fi"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        apt-get -y install $packages"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"0f6139b3_3de16894","line":268,"updated":"2021-12-18 11:37:59.000000000","message":"This is broken, it is lacking the initial space, leading to apt trying to install \"python-virtualenvpython3-pip\", which fails.","commit_id":"4f151aeeb5034bc3957e7517a2a07a3341d7cfc0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"270f818143ae04ba19cb91ab6097a83963bd7c17","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        # time and you had to use \"python -m venv\".  Since then virtualenv"},{"line_number":266,"context_line":"        # has gained 3.4 support so the pip install below will work"},{"line_number":267,"context_line":"        if [[ ${DIB_PYTHON_VERSION} \u003d\u003d 3 ]]; then"},{"line_number":268,"context_line":"            packages+\u003d\"python3-pip python3-virtualenv\""},{"line_number":269,"context_line":"        fi"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        apt-get -y install $packages"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"19f675e6_f120b147","line":268,"in_reply_to":"0f6139b3_3de16894","updated":"2022-01-17 08:48:41.000000000","message":"Ack","commit_id":"4f151aeeb5034bc3957e7517a2a07a3341d7cfc0"}]}