)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9b28207dd15f12a6021ec2f0f2b67d76dabc9561","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving detection of target EFI support."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6163507cd12e59a90137f1116226f1e5d5faba12"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bcae18fd_b8dc61c3","line":9,"updated":"2022-01-14 18:11:34.000000000","message":"Greetings! It would be kind of helpful if you were to describe how/what/why  in a commit message to give the reviewer context to appropriately review the change and understand where your coming from.","commit_id":"4308d0af3f17e37064b3ed4e9a7461bab5552f09"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9b28207dd15f12a6021ec2f0f2b67d76dabc9561","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"46493adb_f58de32f","updated":"2022-01-14 18:11:34.000000000","message":"Greetings!\n\nThank you for the change set! I\u0027ve left some comments inside the change set. A little more detail and comments are always helpful for reviewers to really understand the change.\n\nAlso, I think this change while well intentioned, may still be the wrong change in that we\u0027re looking at things in a bit of a binary view, except the start and end results are not binary in nature. Another contributor has proposed something similar, and I\u0027ve included that as well. It would be helpful to understand if you believe that would work for you as well.\n\nIf you have any questions, please feel free to reach out to TheJulia on IRC. Thanks!","commit_id":"4308d0af3f17e37064b3ed4e9a7461bab5552f09"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e964e8e31da6be6878c92840ac4ca709655bfcd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f5df44e0_69bf0a84","updated":"2022-02-02 02:37:51.000000000","message":"https://review.opendev.org/c/openstack/diskimage-builder/+/824660 has merged, this should probably be abandoned","commit_id":"4308d0af3f17e37064b3ed4e9a7461bab5552f09"}],"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9b28207dd15f12a6021ec2f0f2b67d76dabc9561","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    # http://www.gnu.org/software/grub/manual/grub.html#Installation"},{"line_number":97,"context_line":"    #"},{"line_number":98,"context_line":"    if [ -d /sys/firmware/efi ]; then"},{"line_number":99,"context_line":"        if [ ! -d /usr/lib/grub/*-efi ] \u0026\u0026 [ \"${DIB_BLOCK_DEVICE}\" !\u003d \"efi\" ]; then"},{"line_number":100,"context_line":"            case $ARCH in"},{"line_number":101,"context_line":"                \"x86_64\"|\"amd64\")"},{"line_number":102,"context_line":"                    GRUB_OPTS\u003d\"$GRUB_OPTS --target\u003di386-pc\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"d9b5cb59_af689ee8","line":99,"updated":"2022-01-14 18:11:34.000000000","message":"so you can actually EFI boot via mbr partitions if the UEFI firmware knows how to read the disk format. We\u0027ve actually seen a bit of this out there, so I believe purely relying upon an EFI block device layout might not be a great idea. Also https://review.opendev.org/c/openstack/diskimage-builder/+/824660/3/diskimage_builder/elements/bootloader/finalise.d/50-bootloader#98 is seeking to kind of clean this up by in essence turning it into a \"is this a whole disk image\"\n\nThe other aspect we\u0027re seeing is signed efi artifacts aren\u0027t really getting dropped into the /usr/lib/grub folder anymore, which means checking for it\u0027s presence or lack their of is becoming pointless.","commit_id":"4308d0af3f17e37064b3ed4e9a7461bab5552f09"}]}