)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"797467060f80999f87dc632c60a5d983186daf30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4963b8ba_77f51f37","updated":"2021-12-21 07:56:13.000000000","message":"Based on my testing here:\nhttps://logserver.rdoproject.org/13/36713/13/check/periodic-tripleo-ci-centos-9-ovb-1ctlr_1comp-featureset002-master/99d7075/logs/undercloud/home/zuul/build.log.txt.gz\n\n```\nIncludes in repo delorean-current: ansible-config_template, ansible-role-container-registry, ansible-role-tripleo*, ansible-tripleo-ipsec, instack, instack-undercloud, openstack-tripleo-*, os-apply-config, os-collect-config, os-net-config, os-refresh-config, puppet-cinder, puppet-glance, puppet-heat, puppet-horizon, puppet-ironic, puppet-keystone, puppet-neutron, puppet-nova, puppet-openstacklib, puppet-oslo, puppet-placement, puppet-swift, puppet-tripleo, python*-tripleo*, tripleo-ansible, tripleo-operator-ansible\n2021-12-21 07:36:10.969 | Package nfs-utils-1:2.5.4-5.el9.x86_64 is already installed.\n2021-12-21 07:36:10.970 | Package chrony-4.1-3.el9.x86_64 is already installed.\n2021-12-21 07:36:10.981 | No match for argument: python-ipaddr\n2021-12-21 07:36:11.025 | Error: Unable to find a match: python-ipaddr\n```\nIt still breaks the package-map as it changes from 9 to 9-stream.\nLet me apply this change https://review.opendev.org/c/openstack/tripleo-puppet-elements/+/822327 here for pkg-map to change from 9-stream","commit_id":"d5d41bb7f01fa24cd45f2759ccd95b95ea9c1948"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8daf88aa262a431a7aeca69edfa907a5915534fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e47bd267_239a6c9b","updated":"2022-01-14 17:32:26.000000000","message":"Marking -1 for visibility and agreement with the prior reviewer\u0027s comment.\n\nThe transition from 8-\u003e8-stream has created some debt, and I think we can start to peel that back.","commit_id":"d5d41bb7f01fa24cd45f2759ccd95b95ea9c1948"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c4bac2ee3481ab5c494c9e792e9cff7fae160f05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81e99c09_692f1c14","updated":"2022-01-24 04:38:43.000000000","message":"check-rdo","commit_id":"d5d41bb7f01fa24cd45f2759ccd95b95ea9c1948"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"64c240bb4c2ecdae3dc36f1449ea13bb39bd9614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a3faf7c7_c31bb5f5","in_reply_to":"4963b8ba_77f51f37","updated":"2021-12-21 09:59:20.000000000","message":"Left the notes here based on my testing: https://bugs.launchpad.net/tripleo/+bug/1954456/comments/18","commit_id":"d5d41bb7f01fa24cd45f2759ccd95b95ea9c1948"}],"diskimage_builder/elements/centos/root.d/10-centos-cloud-image":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6d9ef1aba01ab916f53e3ee059a9dd53eb8c931b","unresolved":true,"context_lines":[{"line_number":30,"context_line":"            ARCH\u003d\"aarch64\""},{"line_number":31,"context_line":"        fi"},{"line_number":32,"context_line":"        if [[ \"${DIB_RELEASE}\" \u003d\u003d \"9\" ]]; then"},{"line_number":33,"context_line":"            dib_release_path\u003d9-stream"},{"line_number":34,"context_line":"        else"},{"line_number":35,"context_line":"            dib_release_path\u003d${DIB_RELEASE}"},{"line_number":36,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5017b725_b1036e13","side":"PARENT","line":33,"updated":"2021-12-21 07:41:09.000000000","message":"same as comment below i think we can just remove the conditional now. this was only here to deal with 9 vs 9-stream\n\nwe can directly use DIB_RELEASE don\u0027t need to create the dib_release_path var\n\n        DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/centos/${DIB_RELEASE}/${ARCH}/images}","commit_id":"f576658a4f405328295e99a9a9a8a8632147aa61"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8daf88aa262a431a7aeca69edfa907a5915534fd","unresolved":true,"context_lines":[{"line_number":30,"context_line":"            ARCH\u003d\"aarch64\""},{"line_number":31,"context_line":"        fi"},{"line_number":32,"context_line":"        if [[ \"${DIB_RELEASE}\" \u003d\u003d \"9\" ]]; then"},{"line_number":33,"context_line":"            dib_release_path\u003d9-stream"},{"line_number":34,"context_line":"        else"},{"line_number":35,"context_line":"            dib_release_path\u003d${DIB_RELEASE}"},{"line_number":36,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"92363c08_71d79729","side":"PARENT","line":33,"in_reply_to":"5017b725_b1036e13","updated":"2022-01-14 17:32:26.000000000","message":"I concur, this is debt from 8-\u003e8-stream which really doesn\u0027t need to be carried forward as-is.","commit_id":"f576658a4f405328295e99a9a9a8a8632147aa61"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6d9ef1aba01ab916f53e3ee059a9dd53eb8c931b","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    if [[ \"${DIB_RELEASE}\" \u003d 7 ]]; then"},{"line_number":57,"context_line":"        BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-CentOS-${DIB_RELEASE}-${ARCH}-${DIB_FLAVOR}.qcow2.xz}"},{"line_number":58,"context_line":"    else"},{"line_number":59,"context_line":"        if [[ \"${DIB_RELEASE}\" \u003d\u003d \"9-stream\" ]]; then"},{"line_number":60,"context_line":"            dib_release_path\u003d9-stream"},{"line_number":61,"context_line":"        else"},{"line_number":62,"context_line":"            dib_release_path\u003d${DIB_RELEASE}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"cb3ff6b6_bb024da4","line":59,"updated":"2021-12-21 07:41:09.000000000","message":"if we are going to always set DIB_RELEASE to 9-stream then i think we can just remove this conditional alltogether? i.e. we no longer even need to capture a dib_release_path and can directly use DIB_RELEASE in the BASE_IMAGE_FILE line 64:\n\n        BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-$(curl -s https://cloud.centos.org/centos/${DIB_RELEASE}/${ARCH}/images/ | grep -o \"CentOS-.[^\u003e]*${DIB_FLAVOR}-.[^\u003e]*.qcow2\" | sort -r | head -1)}\n\ninstead of \n\n        BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-$(curl -s https://cloud.centos.org/centos/${dib_release_path}/${ARCH}/images/ | grep -o \"CentOS-.[^\u003e]*${DIB_FLAVOR}-.[^\u003e]*.qcow2\" | sort -r | head -1)}","commit_id":"d5d41bb7f01fa24cd45f2759ccd95b95ea9c1948"}]}