)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f7737020cdfd9f2cf4b6a8a2fbbf3e868339b3f9","unresolved":true,"context_lines":[{"line_number":16,"context_line":"identical so this change assumes that grub2-efi-x64 doesn\u0027t need to be"},{"line_number":17,"context_line":"installed at this point just to have /etc/grub2-efi.cfg available."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This script is bootloader related so this change also moves it to the"},{"line_number":20,"context_line":"bootloader element finalise phase since it is coupled with"},{"line_number":21,"context_line":"bootloader/finalise.d/50-bootloader."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This change also makes /etc/default/grub changes conditional. Even"},{"line_number":24,"context_line":"though grub2-tools is install it appears that this file is missing on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"8b974981_645a089e","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":36},"updated":"2022-01-19 04:25:09.000000000","message":"This is only supposed to apply on the \"centos\" element, which is using the upstream .qcow2, which comes with these pre-populated BLS entries for a foreign machine-id, which update-grub will refuse to update.  It was doing this early, in that element, for that specific reason.\n\nSo this is not supposed to run for centos-minimal/containerfile builds, which also matches \"DISTRO\u003dcentos\" \"DIB_RELEASE\u003d9-stream\" -- these don\u0027t have that problem.\n\nSo I don\u0027t think this should be moved.","commit_id":"942a4a014e03ce7b5a6a6b90a3d3986b9ff562c3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f7737020cdfd9f2cf4b6a8a2fbbf3e868339b3f9","unresolved":true,"context_lines":[{"line_number":20,"context_line":"bootloader element finalise phase since it is coupled with"},{"line_number":21,"context_line":"bootloader/finalise.d/50-bootloader."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This change also makes /etc/default/grub changes conditional. Even"},{"line_number":24,"context_line":"though grub2-tools is install it appears that this file is missing on"},{"line_number":25,"context_line":"the base image."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: Idc557f29899afed6e43ca06010f008d49b059e2b"},{"line_number":28,"context_line":"Closes-Bug: #1957789"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"cda5bfd0_71466cad","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":15},"updated":"2022-01-19 04:25:09.000000000","message":"Which base image?","commit_id":"942a4a014e03ce7b5a6a6b90a3d3986b9ff562c3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"512cce7889105c20d50860a8d00b598cac0177f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b7d24258_a4f9f302","updated":"2022-01-14 03:03:43.000000000","message":"I think this script needs to be moved into the bootloader element and have a check which skips distros other than centos","commit_id":"1154315830c922eb1f5307e5de967d0e035e0a49"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"a9b30dcc2a9218d021a1a9d3e3ace89eeaaf6c7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1ee2d4c2_a7ed32fe","updated":"2022-01-17 16:28:56.000000000","message":"FYI, this seems to be really, really linked to https://bugs.launchpad.net/tripleo/+bug/1957169 as well.\n\nHarald found out some more logs than I did, and it\u0027s related to missing grub-pc-modules packages, leading to:\n\"grub2-install: error: /usr/lib/grub/x86_64-efi/modinfo.sh doesn\u0027t exist.\"\n\nSooo... guess that\u0027s something we actually need, one way or another.","commit_id":"d5b3dc29655e1aee5a6baddae6d31ed92bffe424"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"573679c808d5fb22500ec6caf53f65186ea4d889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0f9ff027_7234b8bc","updated":"2022-01-17 16:16:21.000000000","message":"Hello Steve Thank you for proposing the patch.\nWhile testing here: https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/824136\n\nWe are seeing two failures:\n* https://bugs.launchpad.net/tripleo/+bug/1957789/comments/1\n* https://bugs.launchpad.net/tripleo/+bug/1957789/comments/2\n\nIt might be linked with the current series of patches getting merged. Please have a look, Thanks!","commit_id":"d5b3dc29655e1aee5a6baddae6d31ed92bffe424"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eb977bd33d1383f9796b39186d764f5951a46866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c5fc4a90_16684a1a","updated":"2022-01-19 04:38:33.000000000","message":"OK I have a local reproducer for the failure in dib-nodepool-functional-openstack-centos-9-stream-src, I\u0027ll look into it tomorrow.","commit_id":"942a4a014e03ce7b5a6a6b90a3d3986b9ff562c3"}],"diskimage_builder/elements/bootloader/finalise.d/03-reset-bls-entries":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e22d639a187eaefd1c9467a97a771e74cd84914e","unresolved":true,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ $DISTRO_NAME !\u003d \"centos\" || $DIB_RELEASE !\u003d \"9-stream\" ]]; then"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ad10ded4_61d4dc13","line":9,"updated":"2022-01-14 17:04:14.000000000","message":"My only concern, and not really with this change itself, but overall is that we\u0027re so tightly limiting scope here, that means we\u0027ll have to adapt this as derivatives emerge such as RHEL9. The bottom line being it takes a long time for our code to really make it out into the field once we \"release\" it upstream, so the closer to the emerging releases we can be with logic, the likely better. Granted, this is all musing.","commit_id":"d5b3dc29655e1aee5a6baddae6d31ed92bffe424"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f57cd5f8197200ce0852cbc27a3e13e398bc5e92","unresolved":true,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ $DISTRO_NAME !\u003d \"centos\" || $DIB_RELEASE !\u003d \"9-stream\" ]]; then"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"8b35c1df_d8085984","line":9,"in_reply_to":"ad10ded4_61d4dc13","updated":"2022-01-17 20:16:15.000000000","message":"yeah, we at least have access to rhel9 images to follow up if necessary. centos and rhel images are often quite different so we may not assume this script will apply","commit_id":"d5b3dc29655e1aee5a6baddae6d31ed92bffe424"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e22d639a187eaefd1c9467a97a771e74cd84914e","unresolved":true,"context_lines":[{"line_number":38,"context_line":"# machine-id.  After this, grub2-mkconfig works as usual."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"if [[ ${DIB_BLOCK_DEVICE} \u003d\u003d \"mbr\" || ${DIB_BLOCK_DEVICE} \u003d\u003d \"gpt\" ]]; then"},{"line_number":41,"context_line":"    install-packages -m bootloader grub-pc"},{"line_number":42,"context_line":"    grub2-switch-to-blscfg --config-file /etc/grub2.cfg"},{"line_number":43,"context_line":"elif [[ ${DIB_BLOCK_DEVICE} \u003d\u003d \"efi\" ]]; then"},{"line_number":44,"context_line":"    install-packages -m bootloader grub-efi-$ARCH"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"625cb518_76797ace","line":41,"updated":"2022-01-14 17:04:14.000000000","message":"so, I think this is backwards. at least package wise.\n\nYou *can* boot a UEFI only system using an MBR partition *or* an GPT partition table (as long as the firmware properly searches for the efi partition label). You can\u0027t... really.. bios boot a GPT partitioned image. At least, as far as I\u0027m aware. Or at least, if it *works* it likely is not a \"good idea\"™","commit_id":"d5b3dc29655e1aee5a6baddae6d31ed92bffe424"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f57cd5f8197200ce0852cbc27a3e13e398bc5e92","unresolved":true,"context_lines":[{"line_number":38,"context_line":"# machine-id.  After this, grub2-mkconfig works as usual."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"if [[ ${DIB_BLOCK_DEVICE} \u003d\u003d \"mbr\" || ${DIB_BLOCK_DEVICE} \u003d\u003d \"gpt\" ]]; then"},{"line_number":41,"context_line":"    install-packages -m bootloader grub-pc"},{"line_number":42,"context_line":"    grub2-switch-to-blscfg --config-file /etc/grub2.cfg"},{"line_number":43,"context_line":"elif [[ ${DIB_BLOCK_DEVICE} \u003d\u003d \"efi\" ]]; then"},{"line_number":44,"context_line":"    install-packages -m bootloader grub-efi-$ARCH"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bace8839_52e5ac8c","line":41,"in_reply_to":"625cb518_76797ace","updated":"2022-01-17 20:16:15.000000000","message":"The only intent with this package installing is to ensure /etc/grub2.cfg or /etc/grub2-efi.cfg is actually installed before running grub2-switch-to-blscfg. (with an explicit --config-file to override the wrong efi detection)\n\n/etc/grub2.cfg and /etc/grub2-efi.cfg are currently identical, and maybe they will be going forward. One option is to assume this, don\u0027t install any packages, and just run:\n\n  grub2-switch-to-blscfg --config-file /etc/grub2.cfg","commit_id":"d5b3dc29655e1aee5a6baddae6d31ed92bffe424"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5259c91fc39b66b68b33b62cef14b9628539675f","unresolved":true,"context_lines":[{"line_number":38,"context_line":"# machine-id.  After this, grub2-mkconfig works as usual."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"if [[ ${DIB_BLOCK_DEVICE} \u003d\u003d \"mbr\" || ${DIB_BLOCK_DEVICE} \u003d\u003d \"gpt\" ]]; then"},{"line_number":41,"context_line":"    install-packages -m bootloader grub-pc"},{"line_number":42,"context_line":"    grub2-switch-to-blscfg --config-file /etc/grub2.cfg"},{"line_number":43,"context_line":"elif [[ ${DIB_BLOCK_DEVICE} \u003d\u003d \"efi\" ]]; then"},{"line_number":44,"context_line":"    install-packages -m bootloader grub-efi-$ARCH"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3bc913ee_c046664e","line":41,"in_reply_to":"bace8839_52e5ac8c","updated":"2022-01-17 22:25:26.000000000","message":"Ahh, and I just noticed the three different tests, I thought there were two. Yeah, just running it seems to be cleaner, I think.","commit_id":"d5b3dc29655e1aee5a6baddae6d31ed92bffe424"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"89bcb02d2492f8906a1d33864e1e4de87d3f8411","unresolved":true,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ $DISTRO_NAME !\u003d \"centos\" || $DIB_RELEASE !\u003d \"9-stream\" ]]; then"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"6ccae984_2b2e0194","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":4},"updated":"2022-01-18 07:12:57.000000000","message":"just a suggestion (to avoid the || and multiple !\u003d)\n\nif [[ \"${DISTRO_NAME}${DIB_RELEASE}\" \u003d~ \"centos9\" ]]; then \n  exit 0\nfi\n\n\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\n(copy/pasta for local test cos you should not trust me :D ):\n\n$ DISTRO_NAME\u003dcentos\n$ DIB_RELEASE\u003d9-stream\n$ if [[ \"${DISTRO_NAME}${DIB_RELEASE}\" \u003d~ \"centos9\" ]]; then echo \"yes\"; fi\nyes\n\n$ if [[ \"${DISTRO_NAME}${DIB_RELEASE}\" \u003d~ \"centos8\" ]]; then echo \"yes\"; fi","commit_id":"942a4a014e03ce7b5a6a6b90a3d3986b9ff562c3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f7737020cdfd9f2cf4b6a8a2fbbf3e868339b3f9","unresolved":true,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ $DISTRO_NAME !\u003d \"centos\" || $DIB_RELEASE !\u003d \"9-stream\" ]]; then"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"658628e7_9b273597","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":4},"in_reply_to":"6ccae984_2b2e0194","updated":"2022-01-19 04:25:09.000000000","message":"TBH I do prefer being able to search for \"9-stream\" and finding things like this, though, for the cost of a little verboseness.","commit_id":"942a4a014e03ce7b5a6a6b90a3d3986b9ff562c3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f7737020cdfd9f2cf4b6a8a2fbbf3e868339b3f9","unresolved":true,"context_lines":[{"line_number":24,"context_line":"# packages to do this.  Another option again would be just to rename"},{"line_number":25,"context_line":"# the exsiting .conf files."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"install-packages -m bootloader grub-pc"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if [[ -a /etc/default/grub ]]; then"},{"line_number":30,"context_line":"    # If this is already set, grub2-switch-to-blscfg will abort"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"06a68277_5f412f02","line":27,"updated":"2022-01-19 04:25:09.000000000","message":"I\u0027m clearly not getting the context where this package isn\u0027t installed, and for below, the /etc/default/grub doesn\u0027t exist.\n\nThis was intended to run against a file-system extracted from the images at\n\nhttps://cloud.centos.org/centos/9-stream/x86_64/images/\n\neither those images have changed, or this is running in a context I don\u0027t understand.","commit_id":"942a4a014e03ce7b5a6a6b90a3d3986b9ff562c3"}]}