)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cb3bcb0d0497be0b47ab4f9a38b5ca7017152791","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fixes for centos-9-stream efi behaviour"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change removes the uninstall grub2-efi which was required for"},{"line_number":10,"context_line":"prerelease rhel-9 images but now breaks current centos-9-stream"},{"line_number":11,"context_line":"images. A different approach may be required for rhel-9 if the base"},{"line_number":12,"context_line":"image remains different to centos-9-stream (such as populating the"},{"line_number":13,"context_line":"empty /boot/efi partition from the base image)"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3b8e1cc0_02c52aca","line":11,"range":{"start_line":10,"start_character":25,"end_line":11,"end_character":6},"updated":"2022-01-19 04:51:29.000000000","message":"it might be good to elaborate on how it breaks","commit_id":"a2cc17ad75c3854250c2e9fa54f4c6be8f83c889"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"55ae126033e9d3414b3c5cf8942f9c5db71c23f3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fixes for centos-9-stream efi behaviour"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change removes the uninstall grub2-efi which was required for"},{"line_number":10,"context_line":"prerelease rhel-9 images but now breaks current centos-9-stream"},{"line_number":11,"context_line":"images. A different approach may be required for rhel-9 if the base"},{"line_number":12,"context_line":"image remains different to centos-9-stream (such as populating the"},{"line_number":13,"context_line":"empty /boot/efi partition from the base image)"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dd3b8ecd_4681b165","line":11,"range":{"start_line":10,"start_character":25,"end_line":11,"end_character":6},"in_reply_to":"3b8e1cc0_02c52aca","updated":"2022-01-19 04:56:04.000000000","message":"its removing a package which is considered core and unremovable, so the dnf remove call fails. But the remove/install is just a hack to populate the empty /boot/efi partition, if the rhel9 image still has this problem we can solve it differently","commit_id":"a2cc17ad75c3854250c2e9fa54f4c6be8f83c889"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cb3bcb0d0497be0b47ab4f9a38b5ca7017152791","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ccd96674_15f1a3ac","updated":"2022-01-19 04:51:29.000000000","message":"I\u0027m not sure this is on the dib testing path.  For now I\u0027ll leave it for someone to merge who wants to watch things it affects","commit_id":"a2cc17ad75c3854250c2e9fa54f4c6be8f83c889"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"55ae126033e9d3414b3c5cf8942f9c5db71c23f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b7142191_ff9b248c","updated":"2022-01-19 04:56:04.000000000","message":"OK, I\u0027ll merge this tomorrow and ensure that overcloud-hardened-image-uefi is happy","commit_id":"a2cc17ad75c3854250c2e9fa54f4c6be8f83c889"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"80b3b384d1aa225a8853aa5561b2b965370c2639","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f728e94b_ef9138d1","updated":"2022-01-17 23:31:54.000000000","message":"recheck fedora mirror SUBRELEASE parsing","commit_id":"a2cc17ad75c3854250c2e9fa54f4c6be8f83c889"}],"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"59ade7c5d0df7465c9100f4e7b1f8b7cb6b1d1c7","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    # http://www.gnu.org/software/grub/manual/grub.html#Installation"},{"line_number":96,"context_line":"    #"},{"line_number":97,"context_line":"    if [ -d /sys/firmware/efi ]; then"},{"line_number":98,"context_line":"        if [[ ${DIB_BLOCK_DEVICE} \u003d\u003d \"mbr\" || ${DIB_BLOCK_DEVICE} \u003d\u003d \"gpt\" ]]; then"},{"line_number":99,"context_line":"            case $ARCH in"},{"line_number":100,"context_line":"                \"x86_64\"|\"amd64\")"},{"line_number":101,"context_line":"                    GRUB_OPTS\u003d\"$GRUB_OPTS --target\u003di386-pc\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"4740e69c_dd879e49","line":98,"updated":"2022-01-14 16:51:35.000000000","message":"Seems logical, almost \"if this is a whole disk image....","commit_id":"2d5b5e1868758447bfb64511b411449f9832ccee"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b20b30d9eca54167f3f4aaa5556c152226f5054d","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    # http://www.gnu.org/software/grub/manual/grub.html#Installation"},{"line_number":96,"context_line":"    #"},{"line_number":97,"context_line":"    if [ -d /sys/firmware/efi ]; then"},{"line_number":98,"context_line":"        if [[ ${DIB_BLOCK_DEVICE} \u003d\u003d \"mbr\" || ${DIB_BLOCK_DEVICE} \u003d\u003d \"gpt\" ]]; then"},{"line_number":99,"context_line":"            case $ARCH in"},{"line_number":100,"context_line":"                \"x86_64\"|\"amd64\")"},{"line_number":101,"context_line":"                    GRUB_OPTS\u003d\"$GRUB_OPTS --target\u003di386-pc\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bff627ae_9064d157","line":98,"updated":"2022-01-18 07:04:54.000000000","message":"can this only ever be mbr, gpt or efi (based on [1])?\nin which case the test may be simpler as \n\nif [[ ${DIB_BLOCK_DEVICE} !\u003d \"efi\" ]] \n\nassuming i understood the intent here correctly.\n\n\n\n\n\n[1] https://codesearch.opendev.org/?q\u003dDIB_BLOCK_DEVICE\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"a2cc17ad75c3854250c2e9fa54f4c6be8f83c889"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"56a9435d84b09881a80221f3dad45528ed7380ba","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    # http://www.gnu.org/software/grub/manual/grub.html#Installation"},{"line_number":96,"context_line":"    #"},{"line_number":97,"context_line":"    if [ -d /sys/firmware/efi ]; then"},{"line_number":98,"context_line":"        if [[ ${DIB_BLOCK_DEVICE} \u003d\u003d \"mbr\" || ${DIB_BLOCK_DEVICE} \u003d\u003d \"gpt\" ]]; then"},{"line_number":99,"context_line":"            case $ARCH in"},{"line_number":100,"context_line":"                \"x86_64\"|\"amd64\")"},{"line_number":101,"context_line":"                    GRUB_OPTS\u003d\"$GRUB_OPTS --target\u003di386-pc\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"57f167eb_23b5f202","line":98,"in_reply_to":"bff627ae_9064d157","updated":"2022-01-18 19:40:59.000000000","message":"yeah a cleanup to do this in a few places would be good, when ianw is back","commit_id":"a2cc17ad75c3854250c2e9fa54f4c6be8f83c889"}]}