)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5095381ea1d79580d426b4af70734d61540edd35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e06c58d_48a03b29","updated":"2022-01-21 04:20:04.000000000","message":"I\u0027m not sure I agree this is the place to do this.  \n\nThe point of this reset of the BLS entries was to make the regular path of \"grub-mkconfig\" in the bootloader \"just work\" as it does on ... every other distro.  And indeed we can remove this when https://bugzilla.redhat.com/show_bug.cgi?id\u003d2032680 is available too.  So I\u0027m not sure why we need to do this here, it just seems to confuse the matter of where the kernel options are being set.","commit_id":"d4ef933b57c6d71d6cff3d6fd428e659e0f285d7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8888eb38f80585e6f62e493a715d3ca863bb66e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8f846b42_3a675279","in_reply_to":"6e06c58d_48a03b29","updated":"2022-01-21 04:31:44.000000000","message":"Bug #1958230 is for an overcloud-full partition image, which doesn\u0027t actually use the bootloader element, so grub2-mkconfig is not actually called to auto-fix it.\n\nI\u0027d frame this as a \"fix the base image\" rather than a \"set kernel options\" thing.","commit_id":"d4ef933b57c6d71d6cff3d6fd428e659e0f285d7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c14a17cbae267cc9dcc4f67b0e16a1aedb218efc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d05f9f6a_539478c4","in_reply_to":"82792509_06cc46c0","updated":"2022-01-21 05:05:20.000000000","message":"I\u0027m not really following ... how has the overcloud-full job been setting the right root\u003d option for all other distros if it\u0027s not using the bootloader?  I\u0027m worried that we\u0027ll get the grub fix in and delete this, and then break the overcloud-full job again.","commit_id":"d4ef933b57c6d71d6cff3d6fd428e659e0f285d7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"250ddd98143c2bb5beaa214b8e914c58f7ccd094","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"82792509_06cc46c0","in_reply_to":"8f846b42_3a675279","updated":"2022-01-21 04:33:18.000000000","message":"I guess the only other place to do this for the bug in question is in the grub2 element :/","commit_id":"d4ef933b57c6d71d6cff3d6fd428e659e0f285d7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"4e78ad4e12cc06289e5a1be617422ef6d8458465","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bb376168_e8ed56c3","updated":"2022-01-25 07:25:02.000000000","message":"Just a quick confirmation: the modified patch[1] works as expected, I could get my OC node provisioned.\nThe image had the right entry, as I could confirm before actually using it[2]\n\n[1] https://paste.opendev.org/show/812333/\n[2] https://paste.opendev.org/show/812332/\n\nPS: I\u0027m using the oooci-image-build role from tripleo-ci, and have some more patches in the loop:\nhttps://paste.opendev.org/show/812335/","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"39bc27ff312ed22b6f7cd56dcbb05633fb5efe46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3989811e_6b099648","updated":"2022-01-21 12:58:46.000000000","message":"Note about the kernel line: with this patch, I don\u0027t have the console output anymore.\nSo while it seems to match \"until the first space\", it seems to remove the console options, leading to a black screen, masking everything happening after the grub prompt. This is a regression from previous state. I\u0027ll try to know more by inspecting the actual content.","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"03afa467e5d6086c1751bfe322db662a8f826b87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8948642_9cd58ca0","updated":"2022-01-24 09:37:02.000000000","message":"OK - after some more investigations:\n- we shouldn\u0027t replace but generate the \"options\" line imho\n- doing so, we\u0027d ensure we get a consistent and valid entry, not depending on how/where we generate the image.\n\nSo, instead of that \"simple\" sed, we should probably do something more invasive, such as:\nsed -i \u0027s|options .*|options root\u003dLABEL\u003d${DIB_ROOT_LABEL} ro console\u003d${SERIAL_CONSOLE} no_timer_check net.ifnames\u003d0 crashkernel\u003d1G-4G:192M,4G-64G:256M,64G-:512M|\u0027\n\nNot sure about the $SERIAL_CONSOLE, it might be $DIB_BOOTLOADER_SERIAL_CONSOLE - to be confirmed.\n\nDoing so, we\u0027ll end up with a 100% known \"options\" line, with the correct values we may expect.\n\n@Steve: any thoughts?","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"894def8639dc8424a7ab0f30559815a2c2c93f0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7c24f6cf_6b562726","updated":"2022-01-25 00:25:45.000000000","message":"This can hopefully be abandoned in favor of https://review.opendev.org/c/openstack/tripleo-common/+/826205\n","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2c0bbf3290491b56e7e89afa568f0949b99cc672","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"63b5ec41_20fdc587","updated":"2022-01-21 13:03:32.000000000","message":"here\u0027s the content of the loader/entries:\ntitle CentOS Stream (5.14.0-44.el9.x86_64) 9\nversion 5.14.0-44.el9.x86_64\nlinux /boot/vmlinuz-5.14.0-44.el9.x86_64\ninitrd /boot/initramfs-5.14.0-44.el9.x86_64.img\noptions root\u003d/dev/mapper/fedora_fedora-root ro rd.lvm.lv\u003dfedora_fedora/root rhgb quiet\ngrub_users $grub_users\ngrub_arg --unrestricted\ngrub_class centos\n\nThat\u0027s a bit weird. As if it took the lvm things from the host that actually built the image... ?!","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e5f7927b042073ed26b8a304aae9a6a66c982ab4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a95d49d_2ee0e8c8","updated":"2022-01-21 07:20:21.000000000","message":"recheck\n\nmirror issue","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e450cde73a93e8037a3507cab42366e9ea759aee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a3c213e2_845f5b1e","updated":"2022-01-21 13:16:55.000000000","message":"removing vote - I\u0027m pretty sure it has something to do with my env.","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"894def8639dc8424a7ab0f30559815a2c2c93f0b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e89e6b4a_6d293613","in_reply_to":"2c6cf357_ad3ae8b7","updated":"2022-01-25 00:25:45.000000000","message":"I\u0027ve made the switch to bootloader here:\n  https://review.opendev.org/c/openstack/tripleo-common/+/826205\n\nThis resulted in the following BLS entry with a local build:\n\n  # cat 5c772024bd164618885e10e8154518ae-5.14.0-44.el9.x86_64.conf \n  title CentOS Stream (5.14.0-44.el9.x86_64) 9\n  version 5.14.0-44.el9.x86_64\n  linux /boot/vmlinuz-5.14.0-44.el9.x86_64\n  initrd /boot/initramfs-5.14.0-44.el9.x86_64.img\n  options root\u003dLABEL\u003dimg-rootfs ro console\u003dttyS0,115200n8 no_timer_check  crashkernel\u003dauto console\u003dtty0 console\u003dttyS0,115200 no_timer_check nofb nomodeset gfxpayload\u003dtext\n  grub_users $grub_users\n  grub_arg --unrestricted\n  grub_class centos","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"30d46bb48ac18955c09ca6df09b41cf47e595fac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2c6cf357_ad3ae8b7","in_reply_to":"b58312ec_7bb03a08","updated":"2022-01-24 21:47:50.000000000","message":"the bootloader is where we properly set up the kernel arguments, but this element is only used by overcloud-hardened-uefi-full. The overcloud-full image only uses the grub2 element, which is very simple and quite different to bootloader.\n\nI\u0027m going to look into moving overcloud-full to use the bootloader element. Other than fixing this specific issue, it will reduce our support matrix now that overcloud-full is approaching deprecation.","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2a233f473fc860da52e06d27936057d04f7d5197","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b58312ec_7bb03a08","in_reply_to":"e8948642_9cd58ca0","updated":"2022-01-24 16:18:23.000000000","message":"Note: the SERIAL_CONSOLE has to be set - apparently it\u0027s set in another file, included far, far later:\ndiskimage_builder/elements/bootloader/finalise.d/50-bootloader\n\nSo I\u0027m wondering if we\u0027re not mixing things - why are we setting up these files now instead of \"later\", when we actually hit the bootloader part ?","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"580f63303b1d96b5337d1c8a5b0dfbf570902389","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"43547d3f_b79a50f5","in_reply_to":"e89e6b4a_6d293613","updated":"2022-01-25 06:15:32.000000000","message":"ah, might indeed be better. Lemme first test my current build, this will allow me to see if the logic is correct, then I\u0027ll later test your other patch and add a comment there.\n\nThanks for the hard work!","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"}],"diskimage_builder/elements/centos/pre-install.d/03-reset-bls-entries":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3277fc625db4d24d1dce688d1a084be104587ebc","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    if [[ -n \"${DIB_ROOT_LABEL}\" ]]; then"},{"line_number":32,"context_line":"        echo \"Replacing root device with LABEL\u003d${DIB_ROOT_LABEL}\""},{"line_number":33,"context_line":"        sed -i \"s/root\u003dUUID\u003d[^ ]*/root\u003dLABEL\u003d${DIB_ROOT_LABEL}/\" $new_entry"},{"line_number":34,"context_line":"    fi"},{"line_number":35,"context_line":"done"},{"line_number":36,"context_line":"popd"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1fd2e839_f72d6ab8","line":33,"updated":"2022-01-21 12:56:40.000000000","message":"this seems to remove everything after the root\u003dUUID, leading to the removal of the console option and related things. We probably want a better regexp. A UUID has a standard format, so we can probably match it with a stricter thing, and re-append the line content.","commit_id":"4cb94cd2a3f08aa2d5010983313a7429b3b43317"}]}