)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fc45f80d9ccd7c3f7d2c0fef7752aaa9aa75c44c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4a696dc1_2f046e92","updated":"2022-01-31 08:56:44.000000000","message":"Should we mark grub2 as deprecated if this goes through?\n\nIt feels weird to be using the bootloader element to not install a bootloader.  But if it means we effectively drop another fairly bespoke path for this in a more generic sense, it\u0027s probably worth it.","commit_id":"f3809c79810a3834996d618258826183ad903c79"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cc93d8bda9b68c059cfd2e9d51bfd93d17e56ae2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"af98d670_d32e7b9a","updated":"2022-02-01 04:48:43.000000000","message":"recheck","commit_id":"2b524d3f2403bc55b24a8c8230d39ed1e7bee90f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8da60f0b41de4932c7b2f6d09e8437853be53642","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a5bea39e_f2d01b45","updated":"2022-02-09 03:32:34.000000000","message":"I know I voted on this before, but I\u0027m just really uncomfortable making the bootloader path do this -- it warns that no bootloader will be installed then the next thing that comes out of it is \"Installing GRUB2\"\n\nBut I had a thought, instead of taking this path on the default, could we make a block-device-pre-partitioned or something, and keep this behind that?  I feel like with that, we\u0027re at least keeping it on a separate path that we can reason about?","commit_id":"64bc4a7995b4f0ff8f566eb0467fe1198ec4d28c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"dc10abdf6dde947f9099c158ee7af3aa94cde2dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"67822eeb_ea6a5a85","updated":"2022-02-07 20:50:20.000000000","message":"recheck","commit_id":"64bc4a7995b4f0ff8f566eb0467fe1198ec4d28c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4a440aa35ab6e49b1a6f16517c461c35f8ec650c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f4a78352_e600bc68","updated":"2022-04-20 06:13:34.000000000","message":"Sorry, I should have reviewed this earlier.  I\u0027m still a bit worried about reducing it to a warning, but practically I can\u0027t see anyone using this element outside the context of also using the \"vm\" element, so perhaps that is not warranted","commit_id":"9987d0911a65a8439ecc590dfc934247535c006a"}],"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"56bc3c5ae3593fc8cd9eb40c6b81bb9956ebfd95","unresolved":true,"context_lines":[{"line_number":38,"context_line":"elif [[ \"${DIB_BLOCK_DEVICE}\" \u003d\u003d \"efi\" ]]; then"},{"line_number":39,"context_line":"    install-packages -m bootloader grub-efi grub-efi-$ARCH"},{"line_number":40,"context_line":"else"},{"line_number":41,"context_line":"    install-packages -m bootloader grub-pc"},{"line_number":42,"context_line":"    echo \"WARNING: No bootloader installation will occur.\""},{"line_number":43,"context_line":"    echo \"To install a bootloader ensure you have included a block-device-* element\""},{"line_number":44,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"614967f0_592c4fad","line":41,"updated":"2022-01-31 19:58:07.000000000","message":"Actually this path needs to behave more like the grub2 element, and install the grub-efi things also. Since something else is installing bootloader and there is no way here to know if its legacy BIOS or UEFI, so lets prepare for both","commit_id":"f3809c79810a3834996d618258826183ad903c79"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8e083d08298f61e0904aedabbc8f18e9209d62f4","unresolved":true,"context_lines":[{"line_number":157,"context_line":"        fi"},{"line_number":158,"context_line":"    fi"},{"line_number":159,"context_line":"fi"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e /etc/default/grub"},{"line_number":162,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e /etc/default/grub"},{"line_number":163,"context_line":"echo \"GRUB_TIMEOUT\u003d${DIB_GRUB_TIMEOUT:-5}\" \u003e\u003e/etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"cc2d2c80_ba3c4e81","line":160,"updated":"2022-02-10 00:51:16.000000000","message":"How about moving everything from here on to a new element which both bootloader and grub2 depend on? And it only executes when a variable is set, so bootloader always runs it but grub2 only runs it if the user chooses to?","commit_id":"64bc4a7995b4f0ff8f566eb0467fe1198ec4d28c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4a440aa35ab6e49b1a6f16517c461c35f8ec650c","unresolved":true,"context_lines":[{"line_number":158,"context_line":"if [[ ! \"$ARCH\" \u003d~ \"ppc\" ]] \u0026\u0026 [[ -z  \"${DIB_BLOCK_DEVICE}\" ]]; then"},{"line_number":159,"context_line":"    echo \"WARNING: No bootloader installation will occur.\""},{"line_number":160,"context_line":"    echo \"To install a bootloader ensure you have included a block-device-* element\""},{"line_number":161,"context_line":"    exit 0"},{"line_number":162,"context_line":"fi"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"echo \"Installing GRUB2...\""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"983ed5c7_287bd54f","line":161,"updated":"2022-04-20 06:13:34.000000000","message":"I still don\u0027t really like turning a hard error into a warning that likely nobody will read.  But going back through things, the main way into this is adding the \"vm\" element, and we have backwards compatibility in there that sets \"block-device-mbr\" by default if you haven\u0027t included a block-device anyway.  So it\u0027s probably the case that practically you can\u0027t fall in here without setting this.","commit_id":"9987d0911a65a8439ecc590dfc934247535c006a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"040602ca90cd74019f82204e80277c6b02a97529","unresolved":true,"context_lines":[{"line_number":158,"context_line":"if [[ ! \"$ARCH\" \u003d~ \"ppc\" ]] \u0026\u0026 [[ -z  \"${DIB_BLOCK_DEVICE}\" ]]; then"},{"line_number":159,"context_line":"    echo \"WARNING: No bootloader installation will occur.\""},{"line_number":160,"context_line":"    echo \"To install a bootloader ensure you have included a block-device-* element\""},{"line_number":161,"context_line":"    exit 0"},{"line_number":162,"context_line":"fi"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"echo \"Installing GRUB2...\""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"542ff5ba_a3a0cea6","line":161,"in_reply_to":"983ed5c7_287bd54f","updated":"2022-04-20 14:02:21.000000000","message":"PPC aiui explicitly requires dedicated prep partition... soooo... yeah. :\\\n\nI do kind of concur, I\u0027m not a fan of it, but I think we likely need to ensure the barrier to entry for use is low. Granted.... we need PPC gear for that.  Volunteers?!\n\nAt the same time, some tools (read: ironic) and partition based VMs could still use a partition image I guess so this is actually, likely okay given those cases.","commit_id":"9987d0911a65a8439ecc590dfc934247535c006a"}]}