)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"a62564814e1a260cdac9accad0f0b73cf5779144","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add grow_gpt to growvols"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"grow_gpt allows to match GPT to block device."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I3240eb0ef4dbbb41557985f0129ae4998a846417"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4a6df2ef_d70b748d","line":9,"updated":"2022-02-03 03:20:58.000000000","message":"Could you elaborate on what grow_gpt does and why it is needed?","commit_id":"efb30253972561e08de5914a03d57a93b7c8a8f7"},{"author":{"_account_id":34538,"name":"Ramil Minishev","display_name":"Ramil Minishev","email":"rminishev@itkey.com","username":"rminishev"},"change_message_id":"2f0c8897f2750b0a7e3deb2436a7023f7db5986e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add grow_gpt to growvols"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"grow_gpt allows to match GPT to block device."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I3240eb0ef4dbbb41557985f0129ae4998a846417"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b3c64969_17ca23a6","line":9,"in_reply_to":"4a6df2ef_d70b748d","updated":"2022-02-03 22:18:56.000000000","message":"Done","commit_id":"efb30253972561e08de5914a03d57a93b7c8a8f7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f58f39ac56cc6c15a130d16fe62f18b1a42b9c82","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add grow_gpt to growvols"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Image\u0027s size is almost always lesser than actual (virtual) disk."},{"line_number":10,"context_line":"grow_gpt allows to update GPT and allocate free space on a disk."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3240eb0ef4dbbb41557985f0129ae4998a846417"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"15b677be_18c13b6c","line":10,"updated":"2022-03-17 22:37:47.000000000","message":"The first use-case for growvols was for images deployed to baremetal, so by the time growvols has run, sgdisk -e has already been called by ironic-python-agent[1]. So for the baremetal case this statement doesn\u0027t apply.\n\nIt would be interesting to hear more about your use-case, I\u0027m assuming it is deploying whole-disk images to nova workloads?\n\n[1] https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/extensions/standby.py#L240\n    https://github.com/openstack/ironic-lib/blob/master/ironic_lib/disk_utils.py#L684","commit_id":"6a6b3c6192816785d59f46c791a573e693f4390c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"6f174eb6e2aedb3d58e7bd323e89d84ad2eed81f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6c45852a_189fae3d","updated":"2022-12-23 13:46:47.000000000","message":"OVB jobs still failing in tp[1]. \n\n[1] https://review.rdoproject.org/r/c/testproject/+/46114/8#message-b42c0e2facf8b8da1c2cc2329d622295ef3d8b75","commit_id":"d9b2c1ef7d9b668c0ae89d7e057a7fbb0c1fb630"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c9c134f6db0cbe3973233308452f05d2234c6154","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"62c4cfab_ebca2201","updated":"2022-12-23 08:50:04.000000000","message":"https://review.rdoproject.org/zuul/builds?change\u003d827558 it seems fs01 and fs02 passes.","commit_id":"d9b2c1ef7d9b668c0ae89d7e057a7fbb0c1fb630"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"be90c37b51f1a8ba540b94677966a36609d93750","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c937a348_a1044870","updated":"2023-03-28 22:14:27.000000000","message":"I triggered fs001 with this change[1] and it got beyond the growvols run. @Amol can the -1 be revisited\n\n[1] https://review.rdoproject.org/r/c/testproject/+/47996","commit_id":"9fa139511eb90119a3206fd9c7a6fbc3866e5e79"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"62bb411d0a7adf44a19e38f505baeba056b72cb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9f86cf79_386ddb0b","updated":"2023-03-29 06:03:11.000000000","message":"Job run[1] shows success run for growvols task. Removing -1. \n\nThank you Steve.\n\n[1] https://review.rdoproject.org/r/c/testproject/+/47996/3#message-e9bc6d00bf33e842cc90567a87a7e58e333ff370","commit_id":"9fa139511eb90119a3206fd9c7a6fbc3866e5e79"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"71df615a7df6a0da591d3f7c9c682bed4407e0f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8565a180_1bad348a","updated":"2023-04-11 19:27:04.000000000","message":"This really needs a release note. :)","commit_id":"9fa139511eb90119a3206fd9c7a6fbc3866e5e79"}],"diskimage_builder/elements/growvols/static/usr/local/sbin/growvols":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f58f39ac56cc6c15a130d16fe62f18b1a42b9c82","unresolved":true,"context_lines":[{"line_number":265,"context_line":"    execute(["},{"line_number":266,"context_line":"        \u0027sgdisk\u0027,"},{"line_number":267,"context_line":"        \u0027-e\u0027,"},{"line_number":268,"context_line":"        dev_path])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def find_space(disk_name):"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"b22fc4b0_6f39f033","line":268,"updated":"2022-03-17 22:37:47.000000000","message":"Lets ensure that sgdisk -e is not called when it is unnecessary, by following something similar to this:\nhttps://github.com/openstack/ironic-lib/blob/master/ironic_lib/disk_utils.py#L670-L674","commit_id":"6a6b3c6192816785d59f46c791a573e693f4390c"}]}