)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"897ac45c6cc0b62640debf93ad22054fa75842f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b4f5ea9a_64f48512","updated":"2022-02-21 19:51:14.000000000","message":"recheck","commit_id":"4eefda320c36b2588847ed32a02b0b5d895ae98e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6294019c9f63427cdcd5ab312e95a92fa27cb5f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"881c5e76_91e2c782","updated":"2022-02-24 08:43:37.000000000","message":"From reading \n\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d2032680\n\nand related bugs I honestly have no idea if the whole way the machine-id and booting works might change tomorrow.  But such is life with this stuff.  LGTM","commit_id":"4376f6640743813e609d9d69eacdf675537b68ee"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fe235a0dab4de92a4ab54249cbc4f442f0d5ba0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"06d5a753_925d3d21","updated":"2022-02-23 20:17:10.000000000","message":"Got a question to clarify it in my mind, but otherwise it looks good to me.","commit_id":"4376f6640743813e609d9d69eacdf675537b68ee"}],"diskimage_builder/elements/rhel/pre-install.d/03-reset-bls-entries":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"fe995d84bfcc94e414b8aec9ba8f1b1b3c6ae5d7","unresolved":true,"context_lines":[{"line_number":24,"context_line":"for entry in *.conf; do"},{"line_number":25,"context_line":"    new_entry\u003d$(echo $entry | sed \"s/^[a-f0-9]*/$machine_id/\")"},{"line_number":26,"context_line":"    echo \"renaming $entry to $new_entry for new machine-id\""},{"line_number":27,"context_line":"    mv $entry $new_entry"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # RHEL-9 is unique in having a separate /boot partition, fix the paths to assume"},{"line_number":30,"context_line":"    # /boot will be in the root partition."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"090fd8b4_4bc87bd7","line":27,"updated":"2022-02-22 00:44:14.000000000","message":"There needs to be a check here that the source and destination are different","commit_id":"4eefda320c36b2588847ed32a02b0b5d895ae98e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fe235a0dab4de92a4ab54249cbc4f442f0d5ba0a","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # RHEL-9 is unique in having a separate /boot partition, fix the paths to assume"},{"line_number":32,"context_line":"    # /boot will be in the root partition."},{"line_number":33,"context_line":"    sed -i \"s| /vmlinuz| /boot/vmlinuz|\" $new_entry"},{"line_number":34,"context_line":"    sed -i \"s| /initramfs| /boot/initramfs|\" $new_entry"},{"line_number":35,"context_line":"done"},{"line_number":36,"context_line":"popd"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7d616c91_fc7079bb","line":33,"updated":"2022-02-23 20:17:10.000000000","message":"so the bls config entry, to be updated by grub2-mkconfig, needs to be an absolute path and the files on disk to begin with are a relative path?","commit_id":"4376f6640743813e609d9d69eacdf675537b68ee"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5fde09f36a665df700f304aa63d39800b4768e35","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # RHEL-9 is unique in having a separate /boot partition, fix the paths to assume"},{"line_number":32,"context_line":"    # /boot will be in the root partition."},{"line_number":33,"context_line":"    sed -i \"s| /vmlinuz| /boot/vmlinuz|\" $new_entry"},{"line_number":34,"context_line":"    sed -i \"s| /initramfs| /boot/initramfs|\" $new_entry"},{"line_number":35,"context_line":"done"},{"line_number":36,"context_line":"popd"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"dba7ca9d_a48d26db","line":33,"in_reply_to":"074a5ba3_2da64e81","updated":"2022-02-23 20:32:18.000000000","message":"\u003ccry-laugh-emoji\u003e","commit_id":"4376f6640743813e609d9d69eacdf675537b68ee"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7c596dc599af87bf5518111a9987fa4b954afd40","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # RHEL-9 is unique in having a separate /boot partition, fix the paths to assume"},{"line_number":32,"context_line":"    # /boot will be in the root partition."},{"line_number":33,"context_line":"    sed -i \"s| /vmlinuz| /boot/vmlinuz|\" $new_entry"},{"line_number":34,"context_line":"    sed -i \"s| /initramfs| /boot/initramfs|\" $new_entry"},{"line_number":35,"context_line":"done"},{"line_number":36,"context_line":"popd"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"074a5ba3_2da64e81","line":33,"in_reply_to":"37a0d322_61619a63","updated":"2022-02-23 20:27:07.000000000","message":"Can we please go back to bios booting now?!","commit_id":"4376f6640743813e609d9d69eacdf675537b68ee"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"2ff836e90550c14f261a295a042b2421b9b3e6b5","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # RHEL-9 is unique in having a separate /boot partition, fix the paths to assume"},{"line_number":32,"context_line":"    # /boot will be in the root partition."},{"line_number":33,"context_line":"    sed -i \"s| /vmlinuz| /boot/vmlinuz|\" $new_entry"},{"line_number":34,"context_line":"    sed -i \"s| /initramfs| /boot/initramfs|\" $new_entry"},{"line_number":35,"context_line":"done"},{"line_number":36,"context_line":"popd"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"37a0d322_61619a63","line":33,"in_reply_to":"7d616c91_fc7079bb","updated":"2022-02-23 20:23:41.000000000","message":"No, I think they are both absolute paths, but when there is a dedicated boot partition then it is the only one mounted, so the absolute path prefix is /.\n\nAlso I don\u0027t think grub2-mkconfig changes or corrects the path if the kernel version hasn\u0027t changed. I suspect if the kernel package updates during the image build the paths would be generated correctly by grub2-mkconfig.","commit_id":"4376f6640743813e609d9d69eacdf675537b68ee"}]}
