)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34411,"name":"Neil Hanlon","email":"neil@shrug.pw","username":"nhanlon"},"change_message_id":"b634231a59f4c865db9de34f4f026f33861e0358","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bc1ce3bd_887cf8e1","updated":"2022-02-17 18:45:39.000000000","message":"failure seems related to https://review.opendev.org/c/openstack/diskimage-builder/+/790878 which adds the --target\u003di386-pc; will wait on @ianw for his thoughts\n\n```\n2022-02-17 18:01:57.475 | + \u0027[\u0027 \u0027!\u0027 -d /boot/efi/EFI/ubuntu \u0027]\u0027\n2022-02-17 18:01:57.475 | + echo \u0027WARNING: /boot/efi/EFI/ubuntu does not exist, UEFI secure boot not supported\u0027\n2022-02-17 18:01:57.475 | WARNING: /boot/efi/EFI/ubuntu does not exist, UEFI secure boot not supported\n2022-02-17 18:01:57.475 | + extra_options\u003d--removable\n2022-02-17 18:01:57.475 | + /usr/sbin/grub-install \u0027--modules\u003dpart_msdos part_gpt lvm\u0027 --removable --force --target\u003di386-pc /dev/loop0\n2022-02-17 18:01:57.589 | /usr/sbin/grub-install: error: /usr/lib/grub/i386-pc/modinfo.sh doesn\u0027t exist. Please specify --target or --directory.\n2022-02-17 18:01:57.599 | ++ diskimage_builder/lib/img-functions:run_in_target:59\n```","commit_id":"2522a0954b7a1fb7a7161d4c6e89f18d8465e2b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c9b3ae4ccc7696fb3c71feae90c8bbb60d4176dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eb35090b_60e25966","in_reply_to":"8a71ee91_dfc7fc6f","updated":"2022-02-17 20:24:41.000000000","message":"I think that was in the arm build, which is unrelated\nhttps://5b9a2b05d5fa7d2612ec-db0b8e03a927fdc64915c3e8cff5594e.ssl.cf2.rackcdn.com/829747/1/check-arm64/dib-functests-arm64-deb/0da0c81/logs/ubuntu-minimal_bionic-arm64-build-succeeds.FAIL.log","commit_id":"2522a0954b7a1fb7a7161d4c6e89f18d8465e2b6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"af5b86fd6b89371a3220703c3c7ca01c9e388656","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a71ee91_dfc7fc6f","in_reply_to":"bc1ce3bd_887cf8e1","updated":"2022-02-17 19:49:36.000000000","message":"Where are you seeing that?","commit_id":"2522a0954b7a1fb7a7161d4c6e89f18d8465e2b6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"97bb7f1ef5804e31efb7e237df48256dcbdead93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"695ee186_abbeefeb","in_reply_to":"eb35090b_60e25966","updated":"2022-02-17 20:53:11.000000000","message":"oh .. indeed.  still need to fix that!","commit_id":"2522a0954b7a1fb7a7161d4c6e89f18d8465e2b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e2940f5c51b033aeb05355993e67159808244283","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"161108d6_d7c4ec06","updated":"2022-02-17 20:22:01.000000000","message":"Confirmed locally","commit_id":"c8140e5ce23d730e77917ca40ac797c648fd41d8"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"068aeea25c65bab2b9234ff40938f34c179c5897","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f6ee6c58_43670eb5","updated":"2022-02-18 16:15:21.000000000","message":"I think https://review.opendev.org/c/openstack/diskimage-builder/+/829942 will fix the functests failure. We can wait for that to land and then recheck this. Or rebase this change to get quicker feedback.","commit_id":"309c9bca056cff3795ab5d746b5fa31a8f66e156"},{"author":{"_account_id":34411,"name":"Neil Hanlon","email":"neil@shrug.pw","username":"nhanlon"},"change_message_id":"2d665047009037bf824005fd63e7bbd41040f45b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"437f9544_97a9499a","updated":"2022-02-18 13:47:37.000000000","message":"recheck","commit_id":"309c9bca056cff3795ab5d746b5fa31a8f66e156"},{"author":{"_account_id":34411,"name":"Neil Hanlon","email":"neil@shrug.pw","username":"nhanlon"},"change_message_id":"399db322cda2b1a18064a60acc133210195bf583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"baf02ad3_ff9121f3","updated":"2022-02-18 22:51:21.000000000","message":"\u003e Patch Set 4:\n\u003e \n\u003e I think the idea was that this is intended more as an element for building a minimal virtual machine image, while coreutils-single is intended for container images (and inherited by way of the containerfile solution).\n\nThat is correct. I put the patch here as it\u0027s more of a \u0027mistake\u0027 in the image than a problem with test. However, Ian\u0027s right that they provide the same thing and are produced from the same sources, just -single is by way of a multicall binary. In that respect, it could be sufficient to alias them in the pkg-map as suggested.","commit_id":"827784e312bef9d9f6b7aebf863ff5d9b86b158d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"96673da3b6bac54a1ef8aa016dcb8aeab0534c9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"564fa72a_d31155b8","updated":"2022-02-21 17:09:46.000000000","message":"I approved the downstream fix in the opendev nodepool elements. I\u0027m fine with fixing it there.","commit_id":"827784e312bef9d9f6b7aebf863ff5d9b86b158d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a7a17261c1158b2c6ef792f17591f6474fff278a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"98659fd5_e2f332ae","updated":"2022-02-18 21:20:40.000000000","message":"The problem here is actually in our nodepool/infra-package-needs element, where we are explicitly installing \"coreutils\" which conflicts with \"coreutils-single\".  But they both satisfy the coreutils dependency for any other package that needs it -- it\u0027s just we\u0027re explicitly asking for this version there.\n\nWhy not leave the image as-is, and in the pkg-map for infra-package-needs just make coreutils map to empty on rocky so it doesn\u0027t get installed?  I don\u0027t feel like we need to fix it here in what should be a generic element?","commit_id":"827784e312bef9d9f6b7aebf863ff5d9b86b158d"}],"diskimage_builder/elements/rocky-container/containerfiles/8":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"af5b86fd6b89371a3220703c3c7ca01c9e388656","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"RUN dnf install -y findutils util-linux sudo python3 NetworkManager"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"RUN dnf swap coreutils-single coreutils"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN systemctl unmask console-getty.service dev-hugepages.mount \\"},{"line_number":8,"context_line":"    getty.target sys-fs-fuse-connections.mount systemd-logind.service \\"}],"source_content_type":"text/troff","patch_set":1,"id":"c6bd6b5a_88f2c80c","line":5,"updated":"2022-02-17 19:49:36.000000000","message":"It appears to be failing because this aborts itself\n\n---\n2022-02-17 18:01:34.348 | Total download size: 3.6 M\n2022-02-17 18:01:34.348 | Is this ok [y/N]: Operation aborted.\n2022-02-17 18:01:34.460 | Error: error building at STEP \"RUN dnf swap coreutils-single coreutils\": error while running runtime: exit status 1\n2022-02-17 18:01:34.463 | + podman_cleanup\n---\n\ni\u0027d say it needs a -y\n\nhttps://3c841023c6d465a3f11b-a04b473a9e73bbe99d9221b63a567abf.ssl.cf1.rackcdn.com/829747/1/check/dib-nodepool-functional-openstack-rockylinux-8-containerfile-src/a69ecba/nodepool/builds/test-image-0000000001.log","commit_id":"2522a0954b7a1fb7a7161d4c6e89f18d8465e2b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c9b3ae4ccc7696fb3c71feae90c8bbb60d4176dd","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"RUN dnf install -y findutils util-linux sudo python3 NetworkManager"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"RUN dnf swap coreutils-single coreutils"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN systemctl unmask console-getty.service dev-hugepages.mount \\"},{"line_number":8,"context_line":"    getty.target sys-fs-fuse-connections.mount systemd-logind.service \\"}],"source_content_type":"text/troff","patch_set":1,"id":"0a1d3fac_e6ceab08","line":5,"in_reply_to":"c6bd6b5a_88f2c80c","updated":"2022-02-17 20:24:41.000000000","message":"Ack","commit_id":"2522a0954b7a1fb7a7161d4c6e89f18d8465e2b6"}]}