)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a5b5d0bfe797c298ebdb686c6f3205dd61631ecf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f680db40_b2565c50","updated":"2022-04-11 06:33:28.000000000","message":"Note per [1] the packages referenced here (glibc/bash/ncurses) are all brought in anyway; and indeed this seems to fix the issue I started looking at in that ncurses-base is brought in too, which adds the terminal definitions\n\n[1] https://2274ac86a3143a4ec76a-069cd5ef48a70f1a52238faab3991f24.ssl.cf1.rackcdn.com/837248/1/check/dib-nodepool-functional-openstack-centos-9-stream-src/7c09fa3/nodepool/builds/test-image-0000000001.log\n","commit_id":"ba6ea676787415969e9f1054c9cc776971d54787"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f9d91d94a2f428235e03ee5620d96c8bfc2e39ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c0dc5d9a_2f0f1a29","updated":"2022-04-22 04:40:33.000000000","message":"I\u0027ll take clark\u0027s overview here and we can let this sit for a bit as we move on","commit_id":"27903f90e2648f3dc44a8ba3f88e2aba61c8ca90"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d9a23a230272a502dbacda470a423fbe1be4de57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"850f49c1_dff10aa7","updated":"2022-04-26 06:54:20.000000000","message":"recheck","commit_id":"27903f90e2648f3dc44a8ba3f88e2aba61c8ca90"}],"diskimage_builder/elements/yum-minimal/root.d/08-yum-chroot":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0f69d2e6435ceea0f99f83ff0c011d1f7e0dae88","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    packages+\u003d\"basesystem filesystem setup \""},{"line_number":88,"context_line":"    if [[ ${DISTRO_NAME} \u003d fedora ]]; then"},{"line_number":89,"context_line":"        packages+\u003d\"fedora-release-cloud fedora-release-common \""},{"line_number":90,"context_line":"        packages+\u003d\" fedora-repos fedora-gpg-keys\""},{"line_number":91,"context_line":"    elif [[ ${DISTRO_NAME} \u003d centos \u0026\u0026 ${DIB_RELEASE%-stream} -gt 7 ]]; then"},{"line_number":92,"context_line":"        packages+\u003d\"centos-gpg-keys \""},{"line_number":93,"context_line":"        if [[ \"$DIB_RELEASE\" \u003d~ (stream) ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"2f044527_268ccb52","line":90,"range":{"start_line":90,"start_character":19,"end_line":90,"end_character":20},"updated":"2022-04-19 23:06:44.000000000","message":"Nit on the line above you add the space at the end then we prefix with a space here. Doesn\u0027t matter other than for consistency.","commit_id":"ba6ea676787415969e9f1054c9cc776971d54787"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"90815695a601442bea754b14319800e2ba272d36","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    packages+\u003d\"basesystem filesystem setup \""},{"line_number":88,"context_line":"    if [[ ${DISTRO_NAME} \u003d fedora ]]; then"},{"line_number":89,"context_line":"        packages+\u003d\"fedora-release-cloud fedora-release-common \""},{"line_number":90,"context_line":"        packages+\u003d\" fedora-repos fedora-gpg-keys\""},{"line_number":91,"context_line":"    elif [[ ${DISTRO_NAME} \u003d centos \u0026\u0026 ${DIB_RELEASE%-stream} -gt 7 ]]; then"},{"line_number":92,"context_line":"        packages+\u003d\"centos-gpg-keys \""},{"line_number":93,"context_line":"        if [[ \"$DIB_RELEASE\" \u003d~ (stream) ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3e3563b0_922372b0","line":90,"range":{"start_line":90,"start_character":19,"end_line":90,"end_character":20},"in_reply_to":"2f044527_268ccb52","updated":"2022-04-19 23:08:33.000000000","message":"Done","commit_id":"ba6ea676787415969e9f1054c9cc776971d54787"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0f69d2e6435ceea0f99f83ff0c011d1f7e0dae88","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    else"},{"line_number":102,"context_line":"        # NOTE(ianw) 2022-04-11 : this fallback is probably"},{"line_number":103,"context_line":"        # insufficient as the time writing this comment (it was"},{"line_number":104,"context_line":"        # probably relevant in like fedora \u003c 20 and centos 6 era).  It"},{"line_number":105,"context_line":"        # would probably be better to hard fail here, but for now just"},{"line_number":106,"context_line":"        # leave it until we have a problem."},{"line_number":107,"context_line":"        packages+\u003d\"${DISTRO_NAME}-release \""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9e8ea6d6_e5aa90da","line":104,"range":{"start_line":104,"start_character":52,"end_line":104,"end_character":60},"updated":"2022-04-19 23:06:44.000000000","message":"This would still apply to centos 7 which opendev does still use.","commit_id":"ba6ea676787415969e9f1054c9cc776971d54787"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b103b75aaf69712911c663c367f2778554ee6275","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    else"},{"line_number":102,"context_line":"        # NOTE(ianw) 2022-04-11 : this fallback is probably"},{"line_number":103,"context_line":"        # insufficient as the time writing this comment (it was"},{"line_number":104,"context_line":"        # probably relevant in like fedora \u003c 20 and centos 6 era).  It"},{"line_number":105,"context_line":"        # would probably be better to hard fail here, but for now just"},{"line_number":106,"context_line":"        # leave it until we have a problem."},{"line_number":107,"context_line":"        packages+\u003d\"${DISTRO_NAME}-release \""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"19454c2a_57ecf1f2","line":104,"range":{"start_line":104,"start_character":52,"end_line":104,"end_character":60},"in_reply_to":"9e8ea6d6_e5aa90da","updated":"2022-04-19 23:08:20.000000000","message":"yeah, this is true.  the comment should be reworded to avoid confusion","commit_id":"ba6ea676787415969e9f1054c9cc776971d54787"}]}