)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ecfa3b846addaff647b43027cae027ab8861bc1a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steven (Lotus907efi) DuChene \u003csteven.a.duchene@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-28 13:50:26 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed test to see if DIB_ADD_APT_KEY variable was set in 01-copy-apt-keys"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic36e0e7d1e449f3940d2006101b49b7cbb95a398"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F9cWU%3D","line":7,"updated":"2014-04-04 14:02:08.000000000","message":"nit here (sorry)...but please limit the first lines of commit messages to 50 chars.\n\nsee: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"d34dc89365bc5872ceb7a0ff1e3868bfa6d513ba"}],"elements/dpkg/extra-data.d/01-copy-apt-keys":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ecfa3b846addaff647b43027cae027ab8861bc1a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"set -eu"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if [ -z ${DIB_ADD_APT_KEYS+x} ]; then"},{"line_number":21,"context_line":"    echo \"DIB_ADD_APT_KEYS is not set - not importing keys\""},{"line_number":22,"context_line":"    exit 0"},{"line_number":23,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"AAAAWH%2F9cUs%3D","line":20,"updated":"2014-04-04 14:02:08.000000000","message":"so omitting the colon here before +x means that if $DIB_ADD_APT_KEYS is set, but empty, we continue on.\n\nwhich means further on at line 33, $DIB_ADD_APT_KEYS could be empty, which I don\u0027t think is what we want.","commit_id":"d34dc89365bc5872ceb7a0ff1e3868bfa6d513ba"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ecfa3b846addaff647b43027cae027ab8861bc1a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":"sudo mkdir -p ${DIR}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Verify each key and copy to DIR"},{"line_number":33,"context_line":"for KEY in `find ${DIB_ADD_APT_KEYS} -type f`; do"},{"line_number":34,"context_line":"    if  ! file -b \"${KEY}\" | grep -q \u0027PGP public key block\u0027; then"},{"line_number":35,"context_line":"        echo \"Skipping ${KEY}, not a valid GPG public key\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"AAAAWH%2F9cQ8%3D","line":32,"updated":"2014-04-04 14:02:08.000000000","message":"so if $DIB_ADD_APT_KEYS is empty here, find assumes the current path. Is that what\u0027s intended?\n\nIf this is the intended behavior, can you add a comment to such effect?","commit_id":"d34dc89365bc5872ceb7a0ff1e3868bfa6d513ba"}]}