)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6c5603b5c9190b672da73fba13fad730321fc8fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6f624c9c_e4bb179b","updated":"2022-04-21 16:05:11.000000000","message":"Debian 11 too","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2fc26d52f061b871b8ff8008d36bcc0410fc5f56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ed92b16_77b23415","updated":"2022-04-22 04:36:41.000000000","message":"I do agree disabling this probably not quite right; maybe it needs a flag at least.  see note inline","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e07cdc2059eb72d8f9d97073a283ed9daa543bb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3872284d_8db98974","updated":"2022-04-21 16:18:12.000000000","message":"Maksim have you actually tested setting net.ifnames\u003d0 with debian bullseye?\nCause I did and it didn\u0027t work, that\u0027s why the original patch was proposed (and accepted)","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b90372c9394097d7b523267d3f984fc4fe4ea496","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"931918c8_f87b8648","updated":"2022-04-21 15:54:58.000000000","message":"Reverting to unbreak the other distros and releases makes sense to me. We had to address a similar issue in glean with CentOS 9 that the reverted change attempted to address: https://review.opendev.org/c/opendev/glean/+/836103. Specifically the udev event for the newly named interface is move not add. I wonder if you just need to update rules somewhere to listen for moves?","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":33984,"name":"Stanislav Fedorov","email":"dxit@yandex.ru"},"change_message_id":"24520ee29ebb21906ad27c3287f5dc8b7033f6b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8ffaa709_12cd9971","updated":"2022-04-22 03:27:53.000000000","message":"Works well","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b565ca76d9d912e35ea9c8b0c5b8e518f9a0e3f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8eb67085_39ebeac1","updated":"2022-04-21 14:49:06.000000000","message":"recheck","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"29835bf03390d2949fa24c145b34b125cd93c34b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2aa55715_917aa0d1","in_reply_to":"06551d5c_3118ec4d","updated":"2022-04-22 12:38:41.000000000","message":"I *said* broke because it is. Your \"fix\" force all peoples use persistent interface names. The dhcp-all-interfaces element itself correctly work with predictable interface names on the other Linux distributions. I mean that some peoples want the image built with dhcp-all-interfaces and uses predictable interface names together, but Your \"fix\" broke this combination for all Debian-based distributions.","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a1fd0b04a8e6f15846431dfd18339c850bc988e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"383864e5_2caef831","in_reply_to":"193b7cc5_09a42e99","updated":"2022-04-22 09:56:59.000000000","message":"constructive arguments is that your \"fix\" actually solve only your problem, but in the same time break all other Debain-based OSes. You should fix your problem another way, for example I proposed a switch, but the better way IMHO to fix Udev rules correctly.","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b7d6eb37b9b830b70c78c228be7b97a779567301","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4bc772e6_f75c1c6b","in_reply_to":"1ade4148_f1180c46","updated":"2022-04-22 12:10:34.000000000","message":"Yep, its good idea to add tests for this, but don\u0027t know this would complicate the CI. I don\u0027t have anything personally here, and from my side I propose several solutions for the issue, and the idea with a switch was a simple one, the fix from the glean may be help, but need more testing on all OSes.","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ecc39891c05d1bc0448b82fbd28f3b9742a5ba1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9aa9dead_7771b52b","in_reply_to":"2f4c3aaf_1e40e60a","updated":"2022-04-21 18:11:37.000000000","message":"tested, it work well! https://disk.yandex.ru/i/NtV1V473RC-Www","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"73ede3e3874fb12275d418a57f56c5aadc62f04b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c15d697_e755d940","in_reply_to":"33061590_4362c0d2","updated":"2022-04-22 09:26:11.000000000","message":"dhscp-all-interfaces works fine with predictable names on CentOS and Ubuntu. net.ifnames\u003d0 correctly work on Debian 11, see the screenshot attached. we need first unblock all the broken OSes with you fix, later fix your issue for Debian only!","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8365bc207232c1fdd84a8e9c1383c616b04cb400","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ade4148_f1180c46","in_reply_to":"383864e5_2caef831","updated":"2022-04-22 11:54:36.000000000","message":"I don\u0027t think we need to take anything personally here; if we\u0027ve merged something that has regressed other platforms without a clear solution (like a typo bug, etc.) I think reverting to the prior state as a first step is reasonable so we can re-evaluate.  This is not a failure or aspersion of anyone\u0027s work; as they say you don\u0027t get an omelette without breaking a few eggs.  The only thing at fault here is CI coverage that we\u0027re all responsible for as a community, because ideally such things would never get past the gate.  So if we can find a way forward, and as a bonus make sure we put in checks so we don\u0027t make the same mistake again, we\u0027ll all be better.\n\nI recently spent a bit of time with interface renaming due to glean issues (so did clarkb) and what I do know is that nothing about it is straight forward or universal.\n\nPerhaps the issues have exceeded discussion in here and an openstack-discuss thread of how to move forward would be better?","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d54d64499a71ded2d9060313bdfb91ecaeffadbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f4c3aaf_1e40e60a","in_reply_to":"3872284d_8db98974","updated":"2022-04-21 17:11:44.000000000","message":"No matter what I did or didn\u0027t. Your fix breaks all Debian-based distribution, also it permanently disables udev renaming - this is very bad idea to solve the issue the right way later. If you want to solve the issue permanently disabling predictable names you should add for example the switch, something like DIB_DISABLE_PREDICTABLE_IFNAMES or whatever, set it to False as default and to True for your case.","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0a5552ab9d37a8b90ddb6df13030209e8c76c365","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"06551d5c_3118ec4d","in_reply_to":"4bc772e6_f75c1c6b","updated":"2022-04-22 12:19:29.000000000","message":"You just *said* that this broke other debian-based distributions but as far as I can see you didn\u0027t show any test results.\nYou showed just one screenshot that, as I said already, don\u0027t demonstrate anything cause the interfaces are in DOWN state with no ip assigned.\nYou proposed ONE alternative solution that doesn\u0027t work and you refuse to answer technical questions.\nYou replied using questionable tones directly to me.\nWhat I asked I think it\u0027s reasonable, a proper solution instead of a plain revert without any proof of the failures.","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"954613829a0cea837030458f55c2d5e2bd759cf5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"193b7cc5_09a42e99","in_reply_to":"7c15d697_e755d940","updated":"2022-04-22 09:41:44.000000000","message":"The screenshot that you attached just shows interfaces with the old names in DOWN state without an ip assigned to them, it doesn\u0027t show that the dhcp-all-interfaces element works with net.ifnames\u003d0 \nYou\u0027re still avoiding to answer my questions, you\u0027re not bringing constructive arguments to the discussion, and I definitely don\u0027t like the tone of your last phrase.\nIt\u0027s really unfortunate to see such behavior permitted in our community, I do hope that this revert is not accepted without a proper alternative proposed, but I guess I can\u0027t block it.","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9242024542cc0e7bf285e527942173b5ac48e0a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0efda4f_7b4c6dac","in_reply_to":"931918c8_f87b8648","updated":"2022-04-21 16:02:49.000000000","message":"Sounds good, but I don\u0027t have CentOS 9 to check this, sorry.","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"96e31d228acd513b6f48fc655bf6fe665008e915","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7660aad_adaa59df","in_reply_to":"9aa9dead_7771b52b","updated":"2022-04-22 04:56:09.000000000","message":"do you actually get ip from dhcp doing that?\nI wonder how the fix can break older Debian versions or even current debian-based distributions if older ones were not using predictable interface names and the current ones still have support for that, especially using the dhcp-all-interfaces element that is based on old interface names.\nI don\u0027t think reverting the fix is a good idea cause it\u0027s going to break other people (like us) that are using this just fine.\nMaybe the idea to adding a switch can be implemented instead?","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"380835e0d89d75b50194d86ff65c65f26ab850f7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"33061590_4362c0d2","in_reply_to":"e4e7282c_30372159","updated":"2022-04-22 08:57:58.000000000","message":"You haven\u0027t actually answered my questions, from what I tested the dhscp-all-interfaces module does not work with predictable names nor works with setting net.ifnames\u003d0 because the change is not detected by udev rules.\nCan you please provide an alternative solution before reverting the fix ?\nOtherwise other people will see their CI broken.","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"892c4637b4542e8bee2e3a024878d11a7f8848e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4e7282c_30372159","in_reply_to":"f7660aad_adaa59df","updated":"2022-04-22 06:32:52.000000000","message":"take a look at https://review.opendev.org/c/opendev/glean/+/836103\nmay be this can solve your problem, we need to solve the problem without disable predictable names.","commit_id":"537706ec448d802a48e02c14858f560f715cd653"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"827f410735eaf21240564b588ef375c3079972a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8e22243f_d4bb517b","updated":"2022-04-22 15:54:45.000000000","message":"Trying to reset the conversation a bit so that we can make progress.\n\nIf I understand correctly the thing the reverted change broke is the ability for users to continue using predictable interface names outside of bullseye. Predictable interface names are desirable for a number of reasons as outlined in the systemd docs [0]. Considering that predictable names are desirable and we\u0027ve broken dhcp-all-interface users ability to opt into them I think a revert is still appropriate.\n\nThat said we should also try to continue to support users on bullseye with dhcp-all-interfaces. I strongly suspect that udev triggering on move events will address the problems simply because we had similar issues with centos 9 and that addressed it. To test this I\u0027ve pushed https://review.opendev.org/c/openstack/diskimage-builder/+/839079 to try and confirm bullseye doesn\u0027t work with this revert, then an update to add |move in https://review.opendev.org/c/openstack/diskimage-builder/+/839080 to see if that corrects it. It would also be helpful for ironic to depends on 839080 to check if this also works for them. I don\u0027t know what code base needs that done to it to check.\n\nIf however, the |move doesn\u0027t fix things then we should decide if we are debugging this further or we can just make predictable device names optional. If we do make them optional we should probably use one of the disabling methods indicated in the systemd docs [0] rather than nuking this specific udev file. That way we are using expected interfaces for this behavior toggle.\n\n[0] https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/","commit_id":"c7927b9aec9a057b65d0a8ee555ca8169f2a06d3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"84d31eb480b73a0bcd4bc6581773fa7d0182f16e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"efe268cc_a4882b88","updated":"2022-04-22 12:11:21.000000000","message":"my last try\n","commit_id":"c7927b9aec9a057b65d0a8ee555ca8169f2a06d3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cca09ecc1ce2253ad47fbbdf813e4d8e7d623d50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b1996225_e1a200c2","updated":"2022-04-22 10:18:04.000000000","message":"recheck","commit_id":"c7927b9aec9a057b65d0a8ee555ca8169f2a06d3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"05c98df62d062905bc275e8185650c8a8afc36ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0a920737_330b6951","updated":"2022-04-22 12:10:54.000000000","message":"recheck\n","commit_id":"c7927b9aec9a057b65d0a8ee555ca8169f2a06d3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3a629a7bb1786da04f779d1fe7a70e07cc714845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"25ccab37_63b0ad4d","updated":"2022-04-24 10:22:12.000000000","message":"recheck\n","commit_id":"c7927b9aec9a057b65d0a8ee555ca8169f2a06d3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a28b97e8c62e3e0317267ee69038d8233cb0d650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c0058ce_69936d8f","updated":"2022-04-26 06:52:49.000000000","message":"recheck\n\nI think the follow-on https://review.opendev.org/c/openstack/diskimage-builder/+/839080 addresses concerns ","commit_id":"c7927b9aec9a057b65d0a8ee555ca8169f2a06d3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c9d75c6771386c5e146653ff64ec19b84cea5bc9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c36a77b4_6b4213ba","in_reply_to":"b1996225_e1a200c2","updated":"2022-04-22 11:43:26.000000000","message":"The gate will be broken at the moment until we figure out a way around https://github.com/containers/podman/issues/13968","commit_id":"c7927b9aec9a057b65d0a8ee555ca8169f2a06d3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ee9b05140c0448527f7f497549511d36a2cda7f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"49029817_bbf509e3","in_reply_to":"c36a77b4_6b4213ba","updated":"2022-04-22 11:46:25.000000000","message":"I see, but sometimes it helps, look at 1st patchset, same fail, and recheck helps.","commit_id":"c7927b9aec9a057b65d0a8ee555ca8169f2a06d3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f56e1365448331e2152fb714df606787466005a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a3d5b73f_915fb2a8","updated":"2022-04-27 15:29:47.000000000","message":"\u003e Patch Set 5:\n\u003e \n\u003e Keep the old release note since it appeared in another release already, just make sure the new release note is clear that it\u0027s a reversal due to unforeseen regression. Removing release notes after a release is akin to rewriting history and hiding problems.\n\nwe didn\u0027t remove reno from old releases in pypi files for example. the new release shouldn\u0027t contains two conflicting reno files ihmo.","commit_id":"1a59ae40ffba75f8c9359bfc4bebb1b2dbfb5c94"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1323b347e5d69fba80cfd0acd2d57d9dba20a7db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ea0a5543_cbb42a1a","updated":"2022-05-03 09:24:40.000000000","message":"Can we tag this? We need bump OpenStack requirements to include this. Thanks.","commit_id":"b97dfb8fbd4df0dcb67b69d23926ccc090e95176"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9fc708839242621370d978f5ae2a5ac3ad0de1a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3cf3c7c1_8922a12b","updated":"2022-05-02 23:12:36.000000000","message":"This had external testing with https://review.opendev.org/c/openstack/bifrost/+/839329\n\nLGTM","commit_id":"b97dfb8fbd4df0dcb67b69d23926ccc090e95176"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e3091d5ebba2509a8e774df5a8c0a9843eb404f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"662e80e9_21725050","in_reply_to":"3cf3c7c1_8922a12b","updated":"2022-05-03 09:00:09.000000000","message":"finaly) thanks!","commit_id":"b97dfb8fbd4df0dcb67b69d23926ccc090e95176"}],"diskimage_builder/elements/dhcp-all-interfaces/install.d/dhcp-all-interfaces-udev.rules":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3a4cde52cd84aad78d395ac7c42acefe5f622397","unresolved":true,"context_lines":[{"line_number":1,"context_line":"SUBSYSTEM\u003d\u003d\"net\", KERNEL!\u003d\"lo\", ACTION\u003d\u003d\"add|move\", TAG+\u003d\"systemd\", ENV{SYSTEMD_WANTS}+\u003d\"dhcp-interface@$name.service\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"02ed22b7_ffc4254d","line":1,"range":{"start_line":1,"start_character":44,"end_line":1,"end_character":49},"updated":"2022-04-27 06:35:48.000000000","message":"I know it\u0027s in the release notes, but we might want to call this out as the fix in the change description too?","commit_id":"1a59ae40ffba75f8c9359bfc4bebb1b2dbfb5c94"}],"releasenotes/notes/dhcp-all-interfaces-debian-issue-2ec7f1a5186f0b16.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"380835e0d89d75b50194d86ff65c65f26ab850f7","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    facto making the udev rule of the dhcp-all-interfaces element useless;"},{"line_number":8,"context_line":"    this causes the machine booted with the image including the dhcp-all-interfaces"},{"line_number":9,"context_line":"    element to not get any ip and so being unreachable from the network."},{"line_number":10,"context_line":"    To fix this use the DIB_BOOTLOADER_DEFAULT_CMDLINE with net.ifnames\u003d0 to"},{"line_number":11,"context_line":"    fallback to the persistent names of the interfaces."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5648b446_4737d86e","line":10,"updated":"2022-04-22 08:57:58.000000000","message":"this is wrong and it doesn\u0027t work, the interfaces will use the old names but they won\u0027t get an ip from the dhcp because the change is not detected by the udev rules","commit_id":"c7927b9aec9a057b65d0a8ee555ca8169f2a06d3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"73ede3e3874fb12275d418a57f56c5aadc62f04b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    facto making the udev rule of the dhcp-all-interfaces element useless;"},{"line_number":8,"context_line":"    this causes the machine booted with the image including the dhcp-all-interfaces"},{"line_number":9,"context_line":"    element to not get any ip and so being unreachable from the network."},{"line_number":10,"context_line":"    To fix this use the DIB_BOOTLOADER_DEFAULT_CMDLINE with net.ifnames\u003d0 to"},{"line_number":11,"context_line":"    fallback to the persistent names of the interfaces."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1351dd3a_9c68fcf2","line":10,"in_reply_to":"5648b446_4737d86e","updated":"2022-04-22 09:26:11.000000000","message":"again. your fix break all the working for all other OSes! this revert needed first!","commit_id":"c7927b9aec9a057b65d0a8ee555ca8169f2a06d3"}],"releasenotes/notes/persistent-netifs-fallback-1b861e037dd8a27c.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2fc26d52f061b871b8ff8008d36bcc0410fc5f56","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c14413b1_e7143846","side":"PARENT","line":13,"updated":"2022-04-22 04:36:41.000000000","message":"Just a procedural note that we should leave this but add a new note here, because this has already been released.","commit_id":"65569921bf54da49d7725ee015e74ee0a7960d90"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6ffbe4fdbb32ccf7997b43374364f6526e2ac79b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc40943f_ecd8a2be","side":"PARENT","line":13,"in_reply_to":"c14413b1_e7143846","updated":"2022-04-22 06:28:20.000000000","message":"Done","commit_id":"65569921bf54da49d7725ee015e74ee0a7960d90"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5c6aada9dd921a658db0012c03538d0752c82371","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aceb7426_80d2d428","line":12,"updated":"2022-04-22 07:26:19.000000000","message":"You want to delete this file from the revert, and add a new release note that it was reverted (we probably want one; since we had one to announce the change); we don\u0027t want to update the original changelog, as that\u0027s already published.  i\u0027m fine with it after that","commit_id":"93bdd9c93a9e59862136d4c0011d8c1d645dd3b6"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1514f6361679269246657b0c4a0857f7faf4da55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2c4998a2_7abf4102","line":12,"in_reply_to":"aceb7426_80d2d428","updated":"2022-04-22 07:34:39.000000000","message":"Done","commit_id":"93bdd9c93a9e59862136d4c0011d8c1d645dd3b6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3a4cde52cd84aad78d395ac7c42acefe5f622397","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f8187e55_2a31c2c6","side":"PARENT","line":13,"updated":"2022-04-27 06:35:48.000000000","message":"I\u0027m not sure about deleting release notes; I\u0027d always considered them mostly immutable records of what is in each release.  I\u0027m open to other opinions though?","commit_id":"7b41f8160bb8947f51a7f018a8d888d1aa5f14c4"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"67bcafc9e4dd95b14e2d78377b1aa24d9d121751","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"167ab918_76fe624f","side":"PARENT","line":13,"in_reply_to":"f8187e55_2a31c2c6","updated":"2022-04-27 15:18:10.000000000","message":"Ya I\u0027m not quite sure. I carried this over from the previously provided patches. I\u0027ll ask fungi what he thinks as he groks reno iirc.","commit_id":"7b41f8160bb8947f51a7f018a8d888d1aa5f14c4"}]}