)]}'
{"id":"openstack%2Fdiskimage-builder~839294","triplet_id":"openstack%2Fdiskimage-builder~master~I291627d485a6ee23c74b4eec11380e927748f033","project":"openstack/diskimage-builder","branch":"master","topic":"extract-image-hash-validation","attention_set":{},"removed_from_attention_set":{"7118":{"account":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"last_update":"2022-04-26 10:37:32.000000000","reason":"Ian Wienand replied on the change"}},"hashtags":[],"change_id":"I291627d485a6ee23c74b4eec11380e927748f033","subject":"Move image validation into extract-image","status":"NEW","created":"2022-04-26 03:53:47.000000000","updated":"2022-04-26 10:37:32.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"de576db51bb480e53b471398e82ab74a1ade8ccf","_number":839294,"virtual_id_number":839294,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2022-04-26 09:27:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2022-04-26 10:37:32.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-26 04:11:42.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-04-26 05:04:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-04-26 09:27:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"61cbaa7b5649462d7b6748533b98a3b031564ce9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2022-04-26 03:53:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e5c351d26b88be12bfee7849bbaa8d77ace0c580","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-04-26 04:11:42.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/94/839294/1/check-dib/dib-functests-bionic-python3/87fd8a1/ : FAILURE in 17m 06s","accounts_in_message":[],"_revision_number":1},{"id":"707e7a7cc56e4c0e28a37b8bfb67b382a93c52d1","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-26 05:04:06.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-deb https://zuul.opendev.org/t/openstack/build/761cf7ac9b02432ca1f9d7799ebaab2d : SUCCESS in 29m 40s\n- dib-functests-arm64-rpm https://zuul.opendev.org/t/openstack/build/9a474452c4bf473f883becc96ce13d66 : SUCCESS in 39m 39s","accounts_in_message":[],"_revision_number":1},{"id":"9ef9b68c1124eef204781ed4cd2a6221a9a10df8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2022-04-26 05:07:51.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"da1e4c165925a23f201498df8c2f9cf3b70b9ffb","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-04-26 06:05:54.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/94/839294/2/check-dib/dib-functests-bionic-python3/4f8544e/ : SUCCESS in 57m 31s","accounts_in_message":[],"_revision_number":2},{"id":"4aad0bab01a1da9698bdb2132a3c3e55fc1c6a37","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-26 06:34:28.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-deb https://zuul.opendev.org/t/openstack/build/0a870e378cdf446492cdead15dae45fd : SUCCESS in 1h 13m 00s\n- dib-functests-arm64-rpm https://zuul.opendev.org/t/openstack/build/9c4a0abe2e0b44f9abeec2c36a83b715 : SUCCESS in 34m 02s","accounts_in_message":[],"_revision_number":2},{"id":"1b989080801d5e40808750b0ab88709054cbec14","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2022-04-26 06:46:24.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c931ac098095db2fa5fe8e6e19ba0ed8b47ba799","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-26 07:24:07.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-deb https://zuul.opendev.org/t/openstack/build/7ddf721e93c34500b17d305efadc50b1 : SUCCESS in 32m 48s\n- dib-functests-arm64-rpm https://zuul.opendev.org/t/openstack/build/3ab06798602448499b7bb646069d860c : SUCCESS in 35m 22s","accounts_in_message":[],"_revision_number":3},{"id":"d5c2faed44ac178bb1f9e248d2e37fe0221528aa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2022-04-26 07:34:48.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"98618c7ab93476858adab416f619cf0ea26933b4","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-26 08:14:28.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-deb https://zuul.opendev.org/t/openstack/build/978a42399fb5443a88e6c185024d6546 : SUCCESS in 30m 08s\n- dib-functests-arm64-rpm https://zuul.opendev.org/t/openstack/build/18a5a049feea4b778e6a3a8189ea7c6c : SUCCESS in 37m 22s","accounts_in_message":[],"_revision_number":4},{"id":"c8a7564975b7ff66f7309dcf1f25d72d60e69c23","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-04-26 08:56:47.000000000","message":"Patch Set 4:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/94/839294/4/check-dib/dib-functests-bionic-python3/d51ca5d/ : SUCCESS in 1h 21m 17s","accounts_in_message":[],"_revision_number":4},{"id":"74460301e816b59d1909f87f05507501d443841d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-26 09:27:48.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/85f6e48fb03d4fabb7dfc7ab1e7312a3 : SUCCESS in 5m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fe8b27033cc84dcc888ace4d58f30dda : SUCCESS in 4m 00s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/52c7c1c764d741ff97a53535fb3ba7e7 : SUCCESS in 3m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/47140ce8beb64f6aba66333a5d1f01f8 : SUCCESS in 4m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/89cc3bd492264d6b8c4be06ce2051df6 : SUCCESS in 3m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/12d252e778734572912fe81e9820f572 : SUCCESS in 3m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/af6eb07a209e4e819dc549e3855de2bf : SUCCESS in 3m 53s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/79c1c5ad7ad6457090ef436e858c428f : SUCCESS in 3m 29s\n- dib-functests https://zuul.opendev.org/t/openstack/build/eb8ce42b475e4d8f85ec15cfed10e9b6 : FAILURE in 11m 42s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/b10f5fd82d92495eba86da361315c772 : SUCCESS in 1h 36m 52s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/8586a5d37f6e4bbd9cd4aa00378f9f38 : SUCCESS in 16m 47s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/ddde8a68f58c46a7a2fdc03d598d047e : SUCCESS in 39m 44s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/0350ac20ef2e4abaab182441b6eda4c6 : SUCCESS in 40m 38s\n- dib-nodepool-functional-openstack-centos-9-stream-src https://zuul.opendev.org/t/openstack/build/02aeb4dbc2894b4a9346f794f20b5426 : SUCCESS in 34m 08s\n- dib-nodepool-functional-openstack-fedora-35-containerfile-src https://zuul.opendev.org/t/openstack/build/4dd0966a0abc425988610ce591a47823 : SUCCESS in 37m 28s\n- dib-nodepool-functional-openstack-rockylinux-8-containerfile-src https://zuul.opendev.org/t/openstack/build/3d6c347177d145a89b7bbc1e74ea58b0 : SUCCESS in 32m 35s (non-voting)\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/748578d2d43148b3a602803f66a8e956 : SUCCESS in 28m 24s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/708becb5f51943e6b905a4ed9fdc48b4 : SUCCESS in 30m 10s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/c8c22e40adb54a70823f6295e8bc8b2c : SUCCESS in 32m 04s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/474c263132ef46a5b40aa7b6f00cc9da : FAILURE in 41m 02s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/7949936bd1bb41c9b3f16d0e7dbb21ea : FAILURE in 37m 33s (non-voting)\n- dib-nodepool-functional-openstack-gentoo-src https://zuul.opendev.org/t/openstack/build/5e5a50615ebe4f06981f7aee868b0a14 : FAILURE in 1h 03m 16s (non-voting)\n- dib-nodepool-functional-openstack-debian-bullseye-src https://zuul.opendev.org/t/openstack/build/670497c75338453788c31c03dda815e5 : SUCCESS in 28m 58s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/30b613c89f0f4fa7b7874c037dd02c6a : FAILURE in 3m 58s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/4d69a0b91ffd4c60882c9853392be3bc : SUCCESS in 1h 40m 12s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"de576db51bb480e53b471398e82ab74a1ade8ccf","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2022-04-26 10:37:32.000000000","message":"Patch Set 4: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"040803c97f12ef81328c8c7466c209d5d71569bc","revisions":{"44de5e236890262f66e244a4b371883a4c497bf1":{"kind":"REWORK","_number":1,"created":"2022-04-26 03:53:47.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/94/839294/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/94/839294/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/1"}}},"commit":{"parents":[{"commit":"adc40db9e98e7b59334169786ff282610e12ba3a","subject":"Merge \"Update gentoo python version to 3.9\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/adc40db9e98e7b59334169786ff282610e12ba3a"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-04-26 03:46:51.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-04-26 03:53:32.000000000","tz":600},"subject":"Move image validation into extract-image","message":"Move image validation into extract-image\n\nI noticed in a recent failure that after\nI73d6323aa65cee69a55e54bc53ed682f096dfc89 we are now downloading and\nusing the image file and *then* verifying the checksum; defeating the\npurpose of having the checksum.\n\nMove this into extract-image directly.  I made the input a\nfree-formish string so we can expand it to take different forms of\narguments, but just implemented a simple download+check file combo to\nstart.  Other users are patched up for the new argument as\nappropriate.\n\nI also turned up the default debugging level of this script as I don\u0027t\nthink we need too much info from it by default.\n\nChange-Id: I291627d485a6ee23c74b4eec11380e927748f033\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/44de5e236890262f66e244a4b371883a4c497bf1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/44de5e236890262f66e244a4b371883a4c497bf1"}]},"branch":"refs/heads/master"},"cfed97bb5bd0cb6d2882db1730bfac0dc1431a5a":{"kind":"REWORK","_number":2,"created":"2022-04-26 05:07:51.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/94/839294/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/94/839294/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/2"}}},"commit":{"parents":[{"commit":"adc40db9e98e7b59334169786ff282610e12ba3a","subject":"Merge \"Update gentoo python version to 3.9\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/adc40db9e98e7b59334169786ff282610e12ba3a"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-04-26 03:46:51.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-04-26 05:07:40.000000000","tz":600},"subject":"Move image validation into extract-image","message":"Move image validation into extract-image\n\nI noticed in a recent failure that after\nI73d6323aa65cee69a55e54bc53ed682f096dfc89 we are now downloading and\nusing the image file and *then* verifying the checksum; defeating the\npurpose of having the checksum.\n\nMove this into extract-image directly.  I made the input a\nfree-formish string so we can expand it to take different forms of\narguments, but just implemented a simple download+check file combo to\nstart.  Other users are patched up for the new argument as\nappropriate.\n\nI also turned up the default debugging level of this script as I don\u0027t\nthink we need too much info from it by default.\n\nChange-Id: I291627d485a6ee23c74b4eec11380e927748f033\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/cfed97bb5bd0cb6d2882db1730bfac0dc1431a5a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/cfed97bb5bd0cb6d2882db1730bfac0dc1431a5a"}]},"branch":"refs/heads/master"},"b67cc1dfaa8bed3841ed7f7cddf47f1c6644d792":{"kind":"REWORK","_number":3,"created":"2022-04-26 06:46:24.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/94/839294/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/94/839294/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/3"}}},"commit":{"parents":[{"commit":"adc40db9e98e7b59334169786ff282610e12ba3a","subject":"Merge \"Update gentoo python version to 3.9\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/adc40db9e98e7b59334169786ff282610e12ba3a"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-04-26 03:46:51.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-04-26 06:46:12.000000000","tz":600},"subject":"Move image validation into extract-image","message":"Move image validation into extract-image\n\nI noticed in a recent failure that after\nI73d6323aa65cee69a55e54bc53ed682f096dfc89 we are now downloading and\nusing the image file and *then* verifying the checksum; defeating the\npurpose of having the checksum.\n\nMove this into extract-image directly.  I made the input a\nfree-formish string so we can expand it to take different forms of\narguments, but just implemented a simple download+check file combo to\nstart.  Other users are patched up for the new argument as\nappropriate.\n\nI also turned up the default debugging level of this script as I don\u0027t\nthink we need too much info from it by default.\n\nChange-Id: I291627d485a6ee23c74b4eec11380e927748f033\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/b67cc1dfaa8bed3841ed7f7cddf47f1c6644d792"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/b67cc1dfaa8bed3841ed7f7cddf47f1c6644d792"}]},"branch":"refs/heads/master"},"040803c97f12ef81328c8c7466c209d5d71569bc":{"kind":"REWORK","_number":4,"created":"2022-04-26 07:34:48.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/94/839294/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/94/839294/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/94/839294/4"}}},"commit":{"parents":[{"commit":"adc40db9e98e7b59334169786ff282610e12ba3a","subject":"Merge \"Update gentoo python version to 3.9\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/adc40db9e98e7b59334169786ff282610e12ba3a"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-04-26 03:46:51.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-04-26 07:34:36.000000000","tz":600},"subject":"Move image validation into extract-image","message":"Move image validation into extract-image\n\nI noticed in a recent failure that after\nI73d6323aa65cee69a55e54bc53ed682f096dfc89 we are now downloading and\nusing the image file and *then* verifying the checksum; defeating the\npurpose of having the checksum.\n\nMove this into extract-image directly.  I made the input a\nfree-formish string so we can expand it to take different forms of\narguments, but just implemented a simple download+check file combo to\nstart.  Other users are patched up for the new argument as\nappropriate.\n\nI also turned up the default debugging level of this script as I don\u0027t\nthink we need too much info from it by default.\n\nChange-Id: I291627d485a6ee23c74b4eec11380e927748f033\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/040803c97f12ef81328c8c7466c209d5d71569bc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/040803c97f12ef81328c8c7466c209d5d71569bc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Workflow\u003dMIN"],"failing_atoms":["label:Workflow\u003dMAX"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}