)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5f05a8ac2821129e79889bd6fd5b39956574fed6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"931d8d05_b4d2184d","updated":"2022-08-23 06:57:31.000000000","message":"Just a couple of nit comments","commit_id":"b18fe6df4fba0aa253b1f133ff631d4fe36c02c7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ee01c995159ec6245dad28ebe414826c739d5ebe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1e4a25aa_5e6a1e12","updated":"2022-08-25 01:56:16.000000000","message":"recheck node pool image list timeout for fedora-36","commit_id":"833c5b8ceb7f08477c6203ecf2a65d7a29e6fad0"}],"diskimage_builder/block_device/level1/lvm.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5f05a8ac2821129e79889bd6fd5b39956574fed6","unresolved":true,"context_lines":[{"line_number":210,"context_line":"            size \u003d parse_abs_size_spec(self.size)"},{"line_number":211,"context_line":"            # ensuire size aligns with physical extents"},{"line_number":212,"context_line":"            size \u003d size - size % PHYSICAL_EXTENT_BYTES"},{"line_number":213,"context_line":"            size_arg \u003d self.type \u003d\u003d \u0027thin\u0027 and \u0027-V\u0027 or \u0027-L\u0027"},{"line_number":214,"context_line":"            cmd.extend([size_arg, \u0027%dB\u0027 % size])"},{"line_number":215,"context_line":"        elif self.extents:"},{"line_number":216,"context_line":"            cmd.extend([\u0027-l\u0027, self.extents])"}],"source_content_type":"text/x-python","patch_set":6,"id":"ab76e771_f15cdc64","line":213,"updated":"2022-08-23 06:57:31.000000000","message":"This would seem to read better as\n\n \"-V\" if self.type \u003d\u003d \u0027thin\u0027 else \u0027-L\u0027\n \n?","commit_id":"b18fe6df4fba0aa253b1f133ff631d4fe36c02c7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"34f89a92717cbe27d6660b1b98ed0f8da35cca61","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            size \u003d parse_abs_size_spec(self.size)"},{"line_number":211,"context_line":"            # ensuire size aligns with physical extents"},{"line_number":212,"context_line":"            size \u003d size - size % PHYSICAL_EXTENT_BYTES"},{"line_number":213,"context_line":"            size_arg \u003d self.type \u003d\u003d \u0027thin\u0027 and \u0027-V\u0027 or \u0027-L\u0027"},{"line_number":214,"context_line":"            cmd.extend([size_arg, \u0027%dB\u0027 % size])"},{"line_number":215,"context_line":"        elif self.extents:"},{"line_number":216,"context_line":"            cmd.extend([\u0027-l\u0027, self.extents])"}],"source_content_type":"text/x-python","patch_set":6,"id":"4340f1fb_493fc85e","line":213,"in_reply_to":"ab76e771_f15cdc64","updated":"2022-08-23 22:35:13.000000000","message":"Done","commit_id":"b18fe6df4fba0aa253b1f133ff631d4fe36c02c7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5f05a8ac2821129e79889bd6fd5b39956574fed6","unresolved":true,"context_lines":[{"line_number":406,"context_line":"                               lvs_cfg.get(\u0027options\u0027, None),"},{"line_number":407,"context_line":"                               lvs_cfg.get(\u0027size\u0027, None),"},{"line_number":408,"context_line":"                               lvs_cfg.get(\u0027extents\u0027, None),"},{"line_number":409,"context_line":"                               lvs_cfg.get(\u0027type\u0027, None),"},{"line_number":410,"context_line":"                               lvs_cfg.get(\u0027thin-pool\u0027, None))"},{"line_number":411,"context_line":"            self.lvs.append(lvs_item)"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d1682de3_5e62e62f","line":409,"updated":"2022-08-23 06:57:31.000000000","message":"We seem to just pass this through, which if given a typo, etc. would lead to weird errors coming out of the lv commands.  Should we validate this -- the only value we handle is \"thin\" right?","commit_id":"b18fe6df4fba0aa253b1f133ff631d4fe36c02c7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"34f89a92717cbe27d6660b1b98ed0f8da35cca61","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                               lvs_cfg.get(\u0027options\u0027, None),"},{"line_number":407,"context_line":"                               lvs_cfg.get(\u0027size\u0027, None),"},{"line_number":408,"context_line":"                               lvs_cfg.get(\u0027extents\u0027, None),"},{"line_number":409,"context_line":"                               lvs_cfg.get(\u0027type\u0027, None),"},{"line_number":410,"context_line":"                               lvs_cfg.get(\u0027thin-pool\u0027, None))"},{"line_number":411,"context_line":"            self.lvs.append(lvs_item)"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2346a779_e8acb326","line":409,"in_reply_to":"d1682de3_5e62e62f","updated":"2022-08-23 22:35:13.000000000","message":"we handle \u0027thin\u0027 and \u0027thin-pool\u0027 values, I\u0027ll add some validation","commit_id":"b18fe6df4fba0aa253b1f133ff631d4fe36c02c7"}],"diskimage_builder/block_device/tests/test_lvm.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"96fc76c03f78180955240578ef3696cdd992a130","unresolved":true,"context_lines":[{"line_number":595,"context_line":"                                         state)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        # XXX: todo; test call_order.  Make sure PV\u0027s come before, VG;"},{"line_number":598,"context_line":"        # VG before LV, and that mounts/etc happen afterwards."},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        # Fake state for the two PV\u0027s specified by this config"},{"line_number":601,"context_line":"        state[\u0027blockdev\u0027] \u003d {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"a1dd3b92_3febfff2","line":598,"updated":"2022-08-23 07:01:39.000000000","message":"hrm, I guess assert_has_calls (as used everywhere else) doesn\u0027t do the call order.  It\u0027s been a long time; this may just be a bug?","commit_id":"b18fe6df4fba0aa253b1f133ff631d4fe36c02c7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"34f89a92717cbe27d6660b1b98ed0f8da35cca61","unresolved":false,"context_lines":[{"line_number":595,"context_line":"                                         state)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        # XXX: todo; test call_order.  Make sure PV\u0027s come before, VG;"},{"line_number":598,"context_line":"        # VG before LV, and that mounts/etc happen afterwards."},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        # Fake state for the two PV\u0027s specified by this config"},{"line_number":601,"context_line":"        state[\u0027blockdev\u0027] \u003d {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"32e604db_7d8035e7","line":598,"in_reply_to":"a1dd3b92_3febfff2","updated":"2022-08-23 22:35:13.000000000","message":"It does to call order I believe. That comment is copypasta from another test. I\u0027ll remove it from this one.","commit_id":"b18fe6df4fba0aa253b1f133ff631d4fe36c02c7"}]}