)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6fe6144b052f69e7c437a87658eb84de721f8da0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6950ef58_6da590f4","updated":"2022-05-13 05:13:57.000000000","message":"one thing on the sudo ...\n\nis this really the best place for it?  maybe ubuntu-common is better?  opendev doesn\u0027t use cloud-init so i\u0027m not sure, opinions from others would be helpful","commit_id":"84a36e5dddff2881dcdc77d7402cb0f617d6df56"},{"author":{"_account_id":34833,"name":"A R","display_name":"Alasdair","email":"alasdair@stackhpc.com","username":"alasdair"},"change_message_id":"efe64fc7d3b855a20396f6d33cc070cf4694f273","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"495edda9_ab2e11ab","in_reply_to":"6950ef58_6da590f4","updated":"2022-05-16 10:10:11.000000000","message":"Hi Ian, thanks for the feedback.\n\nFor me I felt that the Ubuntu element was the most natural place for this change as it pertains directly to the Ubuntu install and I believe that cloud-init comes in with the Ubuntu image here.\nAdditionally, it preserves the functioning of the DIB_DISTRIBUTION_MIRROR arg (at least if you are using it to propagate mirrors to the image, not just in the build), which is set on this element. I did consider adding it to the apt-sources element, but decided against it as it was not specific to that element.\n\nCheers,\nAlasdair.","commit_id":"84a36e5dddff2881dcdc77d7402cb0f617d6df56"}],"diskimage_builder/elements/ubuntu/post-install.d/98-prevent-cloud-init-overwrite-sources-list":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6fe6144b052f69e7c437a87658eb84de721f8da0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"if [[ -n \"${DIB_PREVENT_SOURCES_OVERWRITE:-}\" ]]; then"},{"line_number":10,"context_line":"    # Prevent cloud-init from overwriting custom sources list"},{"line_number":11,"context_line":"    echo \u0027creating /etc/cloud/cloud.cfg.d/92-apt-preserve-source-list.cfg\u0027"},{"line_number":12,"context_line":"    sudo sh -c \u0027echo \"apt_preserve_sources_list: true\" \u003e /etc/cloud/cloud.cfg.d/92-apt-preserve-source-list.cfg\u0027"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"e13bdd72_b46fa888","line":12,"updated":"2022-05-13 05:13:57.000000000","message":"this is running inside the chroot as root, so we don\u0027t need to sudo around it","commit_id":"84a36e5dddff2881dcdc77d7402cb0f617d6df56"},{"author":{"_account_id":34833,"name":"A R","display_name":"Alasdair","email":"alasdair@stackhpc.com","username":"alasdair"},"change_message_id":"be4e9e8ddb68f278a4031229a443e5e051fc3017","unresolved":false,"context_lines":[{"line_number":9,"context_line":"if [[ -n \"${DIB_PREVENT_SOURCES_OVERWRITE:-}\" ]]; then"},{"line_number":10,"context_line":"    # Prevent cloud-init from overwriting custom sources list"},{"line_number":11,"context_line":"    echo \u0027creating /etc/cloud/cloud.cfg.d/92-apt-preserve-source-list.cfg\u0027"},{"line_number":12,"context_line":"    sudo sh -c \u0027echo \"apt_preserve_sources_list: true\" \u003e /etc/cloud/cloud.cfg.d/92-apt-preserve-source-list.cfg\u0027"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"46f34b50_b5833349","line":12,"in_reply_to":"e13bdd72_b46fa888","updated":"2022-05-16 10:00:59.000000000","message":"amended bash command to remove sudo usage","commit_id":"84a36e5dddff2881dcdc77d7402cb0f617d6df56"}]}