)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"921b316d5c95387819e80925be33ad68eb7913d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a482488b_a319328a","updated":"2022-07-11 10:41:01.000000000","message":"recheck","commit_id":"4c0f39b649207c83d9778b5df67e57bb7f5df32f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"4b6fb14f3846d45b1d60d2add239990c6fe53648","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4a849b0a_e2b375b6","updated":"2022-08-01 07:34:07.000000000","message":"Hi Ian, can this patch be merged now? The CI looks good.","commit_id":"606103dde67f8dc617bf669f86808116160fa438"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"00e7fd3a7107f52eea01f7b03bd3f63dbd216612","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c5c4715d_bc873bf3","updated":"2022-07-25 00:58:05.000000000","message":"recheck","commit_id":"606103dde67f8dc617bf669f86808116160fa438"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b555a555fa4f59c7131015dd14ea199c510abfa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f66e8f5f_22a5c70d","updated":"2022-07-18 07:14:10.000000000","message":"recheck","commit_id":"606103dde67f8dc617bf669f86808116160fa438"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"1eca18b0843706442e2e2ad9f58de143d32ead2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"65807068_3811cef3","updated":"2022-07-12 07:46:00.000000000","message":"test locally, the image build works well. The CI failure looks relate to opensuse","commit_id":"606103dde67f8dc617bf669f86808116160fa438"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"90feb635d59d35932075d6586de1676fd3f079de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2548be2e_25e8e25a","updated":"2022-08-02 00:59:37.000000000","message":"Looks like opensuse failed again","commit_id":"934a65bc3415a49a8b41ea59258e0a84a49e004e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a37cf28d21fcaa691498e064bbb9da68a8ad278f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d0e8ad5b_ff4c1719","updated":"2022-08-02 06:57:21.000000000","message":"recheck suse disabled","commit_id":"934a65bc3415a49a8b41ea59258e0a84a49e004e"}],"diskimage_builder/elements/openeuler-minimal/environment.d/10-openeuler-minimal.bash":[{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"aba4fd58fabac96e802a7960753ad8683859c5e7","unresolved":true,"context_lines":[{"line_number":3,"context_line":"export EFI_BOOT_DIR\u003d\"EFI/openEuler\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [ -n \"${DIB_DISTRIBUTION_MIRROR:-}\" ]; then"},{"line_number":7,"context_line":"    # Only set the mirror for OS, everything, EPOL and update repositories,"},{"line_number":8,"context_line":"    # The others (debuginfo and source) aren\u0027t mirrored since they do not exist on all mirrors"},{"line_number":9,"context_line":"    sed -i \"/\\(debuginfo\\|source\\)/! {s#http://repo.openeuler.org#$DIB_DISTRIBUTION_MIRROR#g}\" $TARGET_ROOT/etc/yum.repos.d/openEuler.repo"},{"line_number":10,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7a3e34f0_0a74aa82","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":2},"updated":"2022-08-01 08:24:25.000000000","message":"Hi Xiyuan, just one minor comment, scrips in environment.d dir only for set environment vars they will run before each phase[1]. Please move the mirror setting logic to pre-install.d phase like other distros or move to root.d of yum-minimal. Note that the former will not install all the pkgs from mirror repo during root.d phase.\n\nSee [1] for more details about environment.d scripts.\n[1] https://docs.openstack.org/diskimage-builder/latest/developer/developing_elements.html","commit_id":"fed03468a36f7db0352ef842d9644cce114e9089"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a3ba96f38ecd443a1dbf557f6684a967c861b146","unresolved":true,"context_lines":[{"line_number":3,"context_line":"export EFI_BOOT_DIR\u003d\"EFI/openEuler\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [ -n \"${DIB_DISTRIBUTION_MIRROR:-}\" ]; then"},{"line_number":7,"context_line":"    # Only set the mirror for OS, everything, EPOL and update repositories,"},{"line_number":8,"context_line":"    # The others (debuginfo and source) aren\u0027t mirrored since they do not exist on all mirrors"},{"line_number":9,"context_line":"    sed -i \"/\\(debuginfo\\|source\\)/! {s#http://repo.openeuler.org#$DIB_DISTRIBUTION_MIRROR#g}\" $TARGET_ROOT/etc/yum.repos.d/openEuler.repo"},{"line_number":10,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"787baecd_5c35512b","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":2},"in_reply_to":"7a3e34f0_0a74aa82","updated":"2022-08-01 09:29:06.000000000","message":"OK, Got it. I followed debian-minimal in the new PS. It add the MIRROR logic in environment.d, so I thought it\u0027s the right way.","commit_id":"fed03468a36f7db0352ef842d9644cce114e9089"}],"diskimage_builder/elements/yum-minimal/root.d/08-yum-chroot":[{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"5232a22109a895b8dcf632e50e9bbcb9e2ec6b8b","unresolved":true,"context_lines":[{"line_number":167,"context_line":"        # Ensure all the repo is enabled, so that we get the latest packages."},{"line_number":168,"context_line":"        sudo sed -i \u0027s/enabled\u003d0/enabled\u003d1/\u0027 $TARGET_ROOT/etc/yum.repos.d/*.repo"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        if [ -n \"${DIB_DISTRIBUTION_MIRROR:-}\" ]; then"},{"line_number":171,"context_line":"            # Only set the mirror for OS, everything, EPOL and update repositories,"},{"line_number":172,"context_line":"            # The others (debuginfo and source) aren\u0027t mirrored since they do not exist on all mirrors"},{"line_number":173,"context_line":"            sed -i \"/\\(debuginfo\\|source\\)/! {s#http://repo.openeuler.org#$DIB_DISTRIBUTION_MIRROR#g}\" $TARGET_ROOT/etc/yum.repos.d/openEuler.repo"},{"line_number":174,"context_line":"        fi"},{"line_number":175,"context_line":"    fi"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"f5008cb9_8594d392","line":174,"range":{"start_line":170,"start_character":7,"end_line":174,"end_character":10},"updated":"2022-07-06 01:52:57.000000000","message":"This might override DIB_YUM_MINIMAL_BOOTSTRAP_REPOS which will also setup mirror see dib-setup-gate-mirrors role. Please add a check \"-z ${DIB_YUM_MINIMAL_BOOTSTRAP_REPOS:-}\" here.\n\nAnd reference DIB_YUM_MINIMAL_BOOTSTRAP_REPOS logic to backup and recover regular mirrors like below. If users want to set another mirror when there is none.\nOr if you want to keep the mirror setup, no need this backup and recover logic.\n\n # install the bootstrap mirror repos over the default ones, if\n    # set.  we will remove this at the end so the final image has\n    # regular mirrors\n    if [[ -n ${DIB_YUM_MINIMAL_BOOTSTRAP_REPOS:-} ]]; then\n        for repo in $TARGET_ROOT/etc/yum.repos.d/*.repo; do\n            sudo mv $repo $repo.USING_MIRROR\n ..","commit_id":"4c0f39b649207c83d9778b5df67e57bb7f5df32f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"2bcda538a14673de42472e439b037ce912b54c2f","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        # Ensure all the repo is enabled, so that we get the latest packages."},{"line_number":168,"context_line":"        sudo sed -i \u0027s/enabled\u003d0/enabled\u003d1/\u0027 $TARGET_ROOT/etc/yum.repos.d/*.repo"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        if [ -n \"${DIB_DISTRIBUTION_MIRROR:-}\" ]; then"},{"line_number":171,"context_line":"            # Only set the mirror for OS, everything, EPOL and update repositories,"},{"line_number":172,"context_line":"            # The others (debuginfo and source) aren\u0027t mirrored since they do not exist on all mirrors"},{"line_number":173,"context_line":"            sed -i \"/\\(debuginfo\\|source\\)/! {s#http://repo.openeuler.org#$DIB_DISTRIBUTION_MIRROR#g}\" $TARGET_ROOT/etc/yum.repos.d/openEuler.repo"},{"line_number":174,"context_line":"        fi"},{"line_number":175,"context_line":"    fi"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"a8719f7d_1edd3977","line":174,"range":{"start_line":170,"start_character":7,"end_line":174,"end_character":10},"in_reply_to":"f5008cb9_8594d392","updated":"2022-07-12 01:18:48.000000000","message":"I moved the mirror logic to openeuler-minimal element like other distro did","commit_id":"4c0f39b649207c83d9778b5df67e57bb7f5df32f"}]}