)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6129cb0068d251195e6a2ac2556ae22ba7ed3ed6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55dd235f_b6f811c4","updated":"2022-07-25 00:52:07.000000000","message":"I agree with clarkb, often a long time from now we\u0027ll look back at things in a \"git blame\" and have a really hard time figuring out what when wrong.  This needs to describe the why behind what it\u0027s doing.","commit_id":"7c1e31a8f0da730a8526bba824f6bc7375729903"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ed06205c8250253bffc512bc216b0ad1a711b267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe13ec06_fbe0e7c4","updated":"2022-07-15 21:53:14.000000000","message":"It would be helpful to explain why this fixes the issue. The error occurs because the block-device element is missing and the vm element depends on the block device element. But why is the block-device element missing?\n\nSeparately, however this ends up being fixed the rocky-container element was built based on the fedora-container element. We should update the fedora-container element too.","commit_id":"7c1e31a8f0da730a8526bba824f6bc7375729903"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"e46416cbc006c7838f85711e4d6e832b99b4aa4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0669200f_df88c991","updated":"2022-07-28 03:47:24.000000000","message":"What do you mean by baremetal image? Volume boot partition image?\nFor a partition image, it really don\u0027t need vm element which contain the grub bootloader. See[1]\n\n[1] https://docs.openstack.org/ironic/latest/user/creating-images.html","commit_id":"7c1e31a8f0da730a8526bba824f6bc7375729903"},{"author":{"_account_id":23266,"name":"lixuehai","email":"li.xuehai@99cloud.net","username":"lixuehai"},"change_message_id":"8b56c4a95955447471231fda3c247476008e183e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"353032bd_da808339","in_reply_to":"0669200f_df88c991","updated":"2022-08-03 08:33:43.000000000","message":"Yeah, baremetal image means partition image","commit_id":"7c1e31a8f0da730a8526bba824f6bc7375729903"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"f5ac116bb53c1eb1baacbe127358b2c9fb5af788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"04578515_3e290e8b","in_reply_to":"353032bd_da808339","updated":"2022-08-03 09:22:17.000000000","message":"If so, I think you can update the patch only for baremetal partition image and make the git log and notes clear. As the machine-id issue is fixed by Ian: https://review.opendev.org/c/openstack/diskimage-builder/+/851687","commit_id":"7c1e31a8f0da730a8526bba824f6bc7375729903"}]}
