)]}'
{"id":"openstack%2Fdiskimage-builder~853573","triplet_id":"openstack%2Fdiskimage-builder~master~Ia1ef48c24841a86f387ff9603c64fd23d8670193","project":"openstack/diskimage-builder","branch":"master","topic":"testing-rootfs","attention_set":{},"removed_from_attention_set":{"4146":{"account":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"last_update":"2022-08-19 17:53:36.000000000","reason":"Change was submitted"},"7118":{"account":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"last_update":"2022-08-19 17:53:36.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia1ef48c24841a86f387ff9603c64fd23d8670193","subject":"Allow setting ROOT_LABEL from environment","status":"MERGED","created":"2022-08-18 01:19:05.000000000","updated":"2022-08-19 17:54:44.000000000","submitted":"2022-08-19 17:53:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"853573-testing-rootfs","meta_rev_id":"a30e2333f0430fcfa95bea151c0348a02f36d2ce","_number":853573,"virtual_id_number":853573,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-08-19 17:53:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"all":[{"value":2,"date":"2022-08-18 17:04:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-08-19 16:42:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-08-19 16:42:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-18 01:54:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-08-18 03:01:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-18 17:04:05.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2022-08-19 16:42:24.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"REVIEWER"}],"messages":[{"id":"4a844b0b15b5bba4951b595cd4406e8d3d153961","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2022-08-18 01:19:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4a19f42565c01e6cf3f121a26100132963ae2406","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2022-08-18 01:23:05.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d052c1bbc1de17fd32f4d6d42d9f832d8de07262","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-18 01:54:43.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/918c03421e514558b73d058514129054\n\n- dib-functests-arm64-deb https://zuul.opendev.org/t/openstack/build/ab999c5eb35d42d8840bcf3e1f544c04 : SUCCESS in 25m 00s\n- dib-functests-arm64-rpm https://zuul.opendev.org/t/openstack/build/257fdbb90f8046f4acb9855817028138 : SUCCESS in 22m 48s","accounts_in_message":[],"_revision_number":2},{"id":"c0c7d65683d6c8e56a9f39d8594351cf8e2ed7b0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-18 03:01:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e310f335f5274496bfbcdcfc2b85c2ba\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2ce18163ee864e988c43098a3b11fa16 : SUCCESS in 5m 14s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c6a7b089cd804c14b7d2cd89e6869c7b : SUCCESS in 4m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/134c33cc7248459cb6566bfe21a02894 : SUCCESS in 4m 16s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/6238b3303c114ea6a0e4b1dc04114795 : SUCCESS in 4m 07s\n- tox-py36 https://zuul.opendev.org/t/openstack/build/32e96fa7768d432da3ec2833d9f6e0c6 : SUCCESS in 4m 14s\n- tox-py38 https://zuul.opendev.org/t/openstack/build/fbeb9c0e4a2c4d159c8f8cba0a9dfa65 : SUCCESS in 3m 53s\n- tox-py39 https://zuul.opendev.org/t/openstack/build/f4061287983e4b3984be96ce4f220c47 : SUCCESS in 4m 23s\n- tox-py310 https://zuul.opendev.org/t/openstack/build/dec7f1492ef9409d9906c3d2038f85e9 : SUCCESS in 4m 05s\n- dib-functests https://zuul.opendev.org/t/openstack/build/7c3875fe3b8e4a0c840fb3b6822d7721 : SUCCESS in 48m 33s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/63962db2b2474380ac2bae7d0c88f048 : SUCCESS in 1h 36m 29s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/cdb427240fd84c829f93d5eedba80c98 : SUCCESS in 15m 30s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/8d5f79a8b4454f85be23a31e9f971a76 : SUCCESS in 45m 09s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/19f4efcb832c4aa69adacd778d45a494 : SUCCESS in 46m 35s\n- dib-nodepool-functional-openstack-centos-9-stream-src https://zuul.opendev.org/t/openstack/build/044e89fd980241b89057881dfa95e1b7 : SUCCESS in 50m 27s\n- dib-nodepool-functional-openstack-fedora-36-containerfile-src https://zuul.opendev.org/t/openstack/build/087ff82825934a7aaa79d9e6d9377481 : SUCCESS in 56m 16s\n- dib-nodepool-functional-openstack-rockylinux-8-containerfile-src https://zuul.opendev.org/t/openstack/build/703eb3225b4a461db847c6de4c18b991 : SUCCESS in 42m 03s (non-voting)\n- dib-nodepool-functional-openstack-rockylinux-9-containerfile-src https://zuul.opendev.org/t/openstack/build/78f7e74791cd463aa3fac1c77c5898cd : SUCCESS in 49m 10s (non-voting)\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/394e9b6236db45c4bd5f4a158ed3f99f : SUCCESS in 47m 47s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/3941344adf374582aff7c7eb4045eec2 : SUCCESS in 41m 10s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/b216c83ff9a946ca8057fbedebbe244c : SUCCESS in 40m 50s\n- dib-nodepool-functional-openstack-ubuntu-jammy-src https://zuul.opendev.org/t/openstack/build/2e4745a91e034494b5648df581d5a965 : SUCCESS in 47m 49s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/781024bef6424703b345d013b4cf6d30 : POST_FAILURE in 1h 04m 04s (non-voting)\n- dib-nodepool-functional-openstack-gentoo-src https://zuul.opendev.org/t/openstack/build/1e7a1e1fcb22426198a3f50deed5b04d : SUCCESS in 1h 15m 07s (non-voting)\n- dib-nodepool-functional-openstack-debian-bullseye-src https://zuul.opendev.org/t/openstack/build/2c1633939163479f9c61381d891e90e6 : SUCCESS in 46m 12s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/9b532636c57b47b8bbb9a1632880db42 : SUCCESS in 7m 44s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/e401971f5203464a8594fb58b6f5df21 : SUCCESS in 1h 13m 24s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"105ebfe6e20ff88d2cbb1e24ca3081ec25a29610","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2022-08-18 17:04:05.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3b1ccf2a354055bad9936f8c53c820f1db655152","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2022-08-19 00:02:09.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7c40bcd45a938dc0336f217c24205867e0905350","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2022-08-19 16:42:24.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"c31373ec76e116549554cab253f77f88a5d16943","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-19 16:42:50.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"3e340f48381f0db005b23eb8aa247117084f5d61","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-19 17:53:36.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2897e1d25dcd43029637a35cb76ecdcc\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/251e70f7f74b4fb1a5a6846c5c3e6a3c : SUCCESS in 5m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/415ec60c25b547e9b2082e1560172505 : SUCCESS in 3m 08s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/a22de56426e043ef8d2c7d7f74b31777 : SUCCESS in 3m 31s\n- tox-py36 https://zuul.opendev.org/t/openstack/build/d6752a3a282c48fe99eb3490cc8e5cb9 : SUCCESS in 4m 33s\n- tox-py38 https://zuul.opendev.org/t/openstack/build/74d8c2b7f282456cb51551dd722fa447 : SUCCESS in 4m 00s\n- tox-py39 https://zuul.opendev.org/t/openstack/build/f3c519dbc5f34b669a3cb2c1fa6959ca : SUCCESS in 4m 12s\n- tox-py310 https://zuul.opendev.org/t/openstack/build/2d1d9febaecc4df5a7fb2fd9ace42e61 : SUCCESS in 3m 55s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/cef66f9228d1478a9df92dc081529445 : SUCCESS in 1h 10m 08s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/5ed53ca9e43a417888bee771c82640fe : SUCCESS in 15m 07s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/830141ed83c1434d90dd5438533907c2 : SUCCESS in 49m 18s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/1c8e533ddd914f5196649f9773249ee7 : SUCCESS in 40m 44s\n- dib-nodepool-functional-openstack-centos-9-stream-src https://zuul.opendev.org/t/openstack/build/9d0320222c934810b5c2d3b3be8feef7 : SUCCESS in 42m 03s\n- dib-nodepool-functional-openstack-fedora-36-containerfile-src https://zuul.opendev.org/t/openstack/build/8250b0acffac4ab3a9a3b9d104c3486b : SUCCESS in 45m 48s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/70234bb278074063b831be9c17192ead : SUCCESS in 38m 30s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/c7dbe84361954fcd9ec331bc7ecdcd28 : SUCCESS in 32m 44s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/457dbe1bbbd4479c8b07fa3e42c7e00d : SUCCESS in 35m 14s\n- dib-nodepool-functional-openstack-ubuntu-jammy-src https://zuul.opendev.org/t/openstack/build/b4cf7b3bdb7d4e5383d3bac9e51761e8 : SUCCESS in 37m 45s\n- dib-functests https://zuul.opendev.org/t/openstack/build/3e29e22d02b440c580188051e495d20a : SUCCESS in 52m 37s\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/a4aab30d0ea44c5eab2ae48b601cf9aa : SUCCESS in 8m 14s","accounts_in_message":[],"_revision_number":2},{"id":"d140b3a500fc9670f7fa9c6849270023489fa9d5","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-19 17:53:36.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"a30e2333f0430fcfa95bea151c0348a02f36d2ce","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-19 17:54:44.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0952270add3648d29895edf13c1cec59\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/39933445abed4db8ad915d8a639db636 : SUCCESS in 45s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3425624686c20bd80c941daf86a79388413a7272","revisions":{"8507299f95bf68cb5cc5af7a79ea737e4d866f63":{"kind":"REWORK","_number":1,"created":"2022-08-18 01:19:05.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/73/853573/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/73/853573/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/73/853573/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/73/853573/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/73/853573/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/73/853573/1"}}},"commit":{"parents":[{"commit":"6b42cb23eef0ca921ca933f354238f83a45229d8","subject":"Add Rockylinux 9 build configuration and update jobs for 8 and 9","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/6b42cb23eef0ca921ca933f354238f83a45229d8"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-08-18 01:03:12.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-08-18 01:03:12.000000000","tz":600},"subject":"Allow setting ROOT_LABEL from environment","message":"Allow setting ROOT_LABEL from environment\n\n--root-label was added with I596104d1a63b5dc6549e8460a1ae3da00165ef04\n\nThis sets the ROOT_LABEL environment variable.\n\nOver the years how this deploys has become more complex; now this\nvalue gets written into DIB_BLOCK_DEVICE_PARAMS_YAML default values,\nwhich is then loaded into DIB_ROOT_LABEL.\n\nTo override this from the environment you need to specify a full\nDIB_BLOCK_DEVICE_CONFIG -- we don\u0027t have a way to just merge in the\nroot label setting.\n\nUsing the command-line argument is difficult with tools like nodepool\nwhere the command-line is baked into something else.  However we\nalready have methods for overriding environment variables on dib\ncalls.\n\nSeveral of the other variables here accept default values from the\nenvironment, so this is not an outlier.  Making ROOT_LABEL also do\nthis allows us to test with non-default root devices in the gate (see\nthe linked change).\n\nChange-Id: Ia1ef48c24841a86f387ff9603c64fd23d8670193\nNeeded-By: XXX\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/8507299f95bf68cb5cc5af7a79ea737e4d866f63"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/8507299f95bf68cb5cc5af7a79ea737e4d866f63"}]},"branch":"refs/heads/master"},"3425624686c20bd80c941daf86a79388413a7272":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-08-18 01:23:05.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/73/853573/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/73/853573/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/73/853573/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/73/853573/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/73/853573/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/73/853573/2"}}},"commit":{"parents":[{"commit":"6b42cb23eef0ca921ca933f354238f83a45229d8","subject":"Add Rockylinux 9 build configuration and update jobs for 8 and 9","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/6b42cb23eef0ca921ca933f354238f83a45229d8"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-08-18 01:03:12.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2022-08-18 01:21:19.000000000","tz":600},"subject":"Allow setting ROOT_LABEL from environment","message":"Allow setting ROOT_LABEL from environment\n\n--root-label was added with I596104d1a63b5dc6549e8460a1ae3da00165ef04\n\nThis sets the ROOT_LABEL environment variable.\n\nOver the years how this deploys has become more complex; now this\nvalue gets written into DIB_BLOCK_DEVICE_PARAMS_YAML default values,\nwhich is then loaded into DIB_ROOT_LABEL.\n\nTo override this from the environment you need to specify a full\nDIB_BLOCK_DEVICE_CONFIG -- we don\u0027t have a way to just merge in the\nroot label setting.\n\nUsing the command-line argument is difficult with tools like nodepool\nwhere the command-line is baked into something else.  However we\nalready have methods for overriding environment variables on dib\ncalls.\n\nSeveral of the other variables here accept default values from the\nenvironment, so this is not an outlier.  Making ROOT_LABEL also do\nthis allows us to test with non-default root devices in the gate (see\nthe linked change).\n\nChange-Id: Ia1ef48c24841a86f387ff9603c64fd23d8670193\nNeeded-By: https://review.opendev.org/c/zuul/nodepool/+/853574\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/3425624686c20bd80c941daf86a79388413a7272"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/3425624686c20bd80c941daf86a79388413a7272"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}}]}],"submit_requirements":[]}