)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"64bead1d7d543c8bf604d6ca90afaa30a06d4c82","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafal Lewandowski \u003crafal@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-02 15:09:08 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"added elrepo element"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7bc144afa96f45122857ff634c8c19c1fd759450"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"308cc94a_9abb3f42","line":7,"updated":"2022-09-05 03:30:14.000000000","message":"For future reference could you please make this subject/content and add a bit more about what is going on.  It helps reviewers have context of why we are doing things and helps us when we look back and wonder why we added things like this.","commit_id":"35c0c2c6db93a9aef8a945a21dd081c936ef7041"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"2858d73f48c4dd9cd4809ceb5eda95ebf1a896f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafal Lewandowski \u003crafal@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-02 15:09:08 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"added elrepo element"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7bc144afa96f45122857ff634c8c19c1fd759450"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"11927383_05b16d95","line":7,"in_reply_to":"308cc94a_9abb3f42","updated":"2022-09-06 14:21:24.000000000","message":"OK will do, I\u0027m still a bit new to this.","commit_id":"35c0c2c6db93a9aef8a945a21dd081c936ef7041"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4be130f48731ba51d16d01e5ddbd2673f9c936f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fd3b9d76_3b41d65b","updated":"2022-09-16 07:01:21.000000000","message":"recheck (nodepool-build-image-siblings)","commit_id":"35c0c2c6db93a9aef8a945a21dd081c936ef7041"}],"diskimage_builder/elements/elrepo/install.d/95-elrepo-packages":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"734fa4683300834b8f301a110c469067e9d6071f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"set -euo pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ ${DISTRO_NAME} \u003d~ (centos|rhel|rocky) \u0026\u0026 -n ${DIB_ELREPO_PKGLIST} ]]; then"},{"line_number":10,"context_line":"    dnf install -y \"${DIB_ELREPO_PKGLIST}\""},{"line_number":11,"context_line":"else"},{"line_number":12,"context_line":"    echo \"You must set the package list: \\\"$DIB_ELREPO_PKGLIST\\\".\""},{"line_number":13,"context_line":"    exit 1"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"04f840a8_321eec29","line":10,"updated":"2022-09-02 05:59:53.000000000","message":"We shouldn\u0027t need DIB_ELREPO_PKGLIST as we have other ways to install packages.  Enabling the repo is fine, but then we should just be using the standard package-installs/pkg-map methods to install packages in other elements.","commit_id":"ab3437a4f8048b383481cedd145956f00b049c33"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"2858d73f48c4dd9cd4809ceb5eda95ebf1a896f6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -euo pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ ${DISTRO_NAME} \u003d~ (centos|rhel|rocky) \u0026\u0026 -n ${DIB_ELREPO_PKGLIST} ]]; then"},{"line_number":10,"context_line":"    dnf install -y \"${DIB_ELREPO_PKGLIST}\""},{"line_number":11,"context_line":"else"},{"line_number":12,"context_line":"    echo \"You must set the package list: \\\"$DIB_ELREPO_PKGLIST\\\".\""},{"line_number":13,"context_line":"    exit 1"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"cde1b2b4_1e9d56c1","line":10,"in_reply_to":"04f840a8_321eec29","updated":"2022-09-06 14:21:24.000000000","message":"Done","commit_id":"ab3437a4f8048b383481cedd145956f00b049c33"}],"diskimage_builder/elements/elrepo/pre-install.d/01-elrepo":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"734fa4683300834b8f301a110c469067e9d6071f","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"case \"$DISTRO_NAME\" in"},{"line_number":10,"context_line":"    centos* | rhel* | rocky*)"},{"line_number":11,"context_line":"\tdnf install -y elrepo-release.noarch"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\tif [ ${DIB_ELREPO_KERNEL:-0} -eq 1 ]; then"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"c0949ec3_3911efd0","line":11,"updated":"2022-09-02 05:59:53.000000000","message":"Hrm, it\u0027s interesting this didn\u0027t fail linting, but we shouldn\u0027t be using hard tabs","commit_id":"ab3437a4f8048b383481cedd145956f00b049c33"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"2858d73f48c4dd9cd4809ceb5eda95ebf1a896f6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"case \"$DISTRO_NAME\" in"},{"line_number":10,"context_line":"    centos* | rhel* | rocky*)"},{"line_number":11,"context_line":"\tdnf install -y elrepo-release.noarch"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\tif [ ${DIB_ELREPO_KERNEL:-0} -eq 1 ]; then"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"2945c50f_797aeab3","line":11,"in_reply_to":"c0949ec3_3911efd0","updated":"2022-09-06 14:21:24.000000000","message":"Ack","commit_id":"ab3437a4f8048b383481cedd145956f00b049c33"}]}