)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6fa756070b7d803a8cc579019ea90cf7627250ea","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d88ac029_5655a71d","updated":"2022-09-02 05:37:42.000000000","message":"I\u0027m unsure on this -- it seems like the thing that is very bespoke, has a lot of potential to not work (form the env var not passing through things running sudo, to graphical agents popping up if this is like a 1password socket, etc. etc.).  I\u0027m -1 more to discuss what the benefit of this is.\n\nWhy can your element not clone these outside the chroot phase (when it is running as whatever user owns the socket, presumably)?  It could either move them in from a staging location, or I suppose it could just write to build-tree without mounting anything?","commit_id":"36129074a0d1fc6a030313ed726a10efaf7704ce"},{"author":{"_account_id":30748,"name":"Marek Chmiel","email":"marek.chmiel@corp.ovh.com","username":"marek.chmiel"},"change_message_id":"b5ad9c05bc9698ae2b4a9abc2ec002fa7a6ccc8d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2fb14386_dd44a4a6","in_reply_to":"d88ac029_5655a71d","updated":"2022-09-06 08:59:16.000000000","message":"Sure, I don\u0027t push it :-).\n\nInside the chroot phase there is `pip install`, which need to take some dependencies from the non-public repo. I guess if I could \"disable\" chroot and build whole tree - it would solve my case. Do you think it\u0027s possible?","commit_id":"36129074a0d1fc6a030313ed726a10efaf7704ce"}],"diskimage_builder/lib/common-functions":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"178e1c61c7241014c914079797e03120ccfdabf3","unresolved":true,"context_lines":[{"line_number":386,"context_line":"        echo nameserver 8.8.8.8 \u003e $TMP_MOUNT_PATH/etc/resolv.conf"},{"line_number":387,"context_line":"    fi"},{"line_number":388,"context_line":"    mount_proc_dev_sys"},{"line_number":389,"context_line":"    mount_sshagent"},{"line_number":390,"context_line":"}"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"# Get mount options for mounting /dev/pts"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"00f9eafc_0db3c8fa","line":389,"updated":"2022-08-25 14:30:12.000000000","message":"Is it worth wrapping this in a flag to enable the behavior? Wondering if some users may not want their ssh agent to be exposed in the build environment (at least not directly).","commit_id":"04be4ff3a2c8f1175b76d2a8a724078750c47709"},{"author":{"_account_id":30748,"name":"Marek Chmiel","email":"marek.chmiel@corp.ovh.com","username":"marek.chmiel"},"change_message_id":"1fb9761e286bf40bb4979d2b67fefb0550bc9aa8","unresolved":true,"context_lines":[{"line_number":386,"context_line":"        echo nameserver 8.8.8.8 \u003e $TMP_MOUNT_PATH/etc/resolv.conf"},{"line_number":387,"context_line":"    fi"},{"line_number":388,"context_line":"    mount_proc_dev_sys"},{"line_number":389,"context_line":"    mount_sshagent"},{"line_number":390,"context_line":"}"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"# Get mount options for mounting /dev/pts"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"38807752_21a42eb5","line":389,"in_reply_to":"00f9eafc_0db3c8fa","updated":"2022-08-25 14:54:45.000000000","message":"Sounds reasonable. I\u0027ll take ssh client approach - enable only if flag is set.","commit_id":"04be4ff3a2c8f1175b76d2a8a724078750c47709"},{"author":{"_account_id":30748,"name":"Marek Chmiel","email":"marek.chmiel@corp.ovh.com","username":"marek.chmiel"},"change_message_id":"2d5baf2d32d7abc1b53df19d7af909a02d142ff8","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        echo nameserver 8.8.8.8 \u003e $TMP_MOUNT_PATH/etc/resolv.conf"},{"line_number":387,"context_line":"    fi"},{"line_number":388,"context_line":"    mount_proc_dev_sys"},{"line_number":389,"context_line":"    mount_sshagent"},{"line_number":390,"context_line":"}"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"# Get mount options for mounting /dev/pts"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"49d41170_8dc1a783","line":389,"in_reply_to":"38807752_21a42eb5","updated":"2022-08-30 12:31:30.000000000","message":"Done","commit_id":"04be4ff3a2c8f1175b76d2a8a724078750c47709"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"178e1c61c7241014c914079797e03120ccfdabf3","unresolved":true,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    mkdir -p $(dirname $target)"},{"line_number":424,"context_line":"    touch $target"},{"line_number":425,"context_line":"    sudo mount --bind \"$SSH_AUTH_SOCK\" $target"},{"line_number":426,"context_line":"}"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"# Recursively unmount directories under a given directory DIR"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"8effda4d_7cb30202","line":425,"updated":"2022-08-25 14:30:12.000000000","message":"Don\u0027t you also need to update the SSH_AUTH_SOCK env var in the build env to have the chrooted environment look in the correct location for the agent info?","commit_id":"04be4ff3a2c8f1175b76d2a8a724078750c47709"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"50862c02ede0f316fb15d2e159b66d04aee4ebaa","unresolved":true,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    mkdir -p $(dirname $target)"},{"line_number":424,"context_line":"    touch $target"},{"line_number":425,"context_line":"    sudo mount --bind \"$SSH_AUTH_SOCK\" $target"},{"line_number":426,"context_line":"}"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"# Recursively unmount directories under a given directory DIR"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bdde8d7f_e38ee6bb","line":425,"in_reply_to":"2ed40e84_aec2daa9","updated":"2022-08-25 15:24:48.000000000","message":"I was half expecting that the env var would be sanitized going into the build. But now I\u0027m not so sure. I guess if this works for you then that isn\u0027t happening.","commit_id":"04be4ff3a2c8f1175b76d2a8a724078750c47709"},{"author":{"_account_id":30748,"name":"Marek Chmiel","email":"marek.chmiel@corp.ovh.com","username":"marek.chmiel"},"change_message_id":"1fb9761e286bf40bb4979d2b67fefb0550bc9aa8","unresolved":true,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    mkdir -p $(dirname $target)"},{"line_number":424,"context_line":"    touch $target"},{"line_number":425,"context_line":"    sudo mount --bind \"$SSH_AUTH_SOCK\" $target"},{"line_number":426,"context_line":"}"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"# Recursively unmount directories under a given directory DIR"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"2ed40e84_aec2daa9","line":425,"in_reply_to":"8effda4d_7cb30202","updated":"2022-08-25 14:54:45.000000000","message":"If you mean the path to the socket should be updated, I handle it by mounting the socket inside chroot filesystem at the same location as in host:\n\n target\u003d\"$TMP_MOUNT_PATH/$SSH_AUTH_SOCK\"\n\nSo after `chroot`, the path is still valid.\n\nOr I missed the point, then please rephrase :-)","commit_id":"04be4ff3a2c8f1175b76d2a8a724078750c47709"},{"author":{"_account_id":30748,"name":"Marek Chmiel","email":"marek.chmiel@corp.ovh.com","username":"marek.chmiel"},"change_message_id":"2d5baf2d32d7abc1b53df19d7af909a02d142ff8","unresolved":false,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    mkdir -p $(dirname $target)"},{"line_number":424,"context_line":"    touch $target"},{"line_number":425,"context_line":"    sudo mount --bind \"$SSH_AUTH_SOCK\" $target"},{"line_number":426,"context_line":"}"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"# Recursively unmount directories under a given directory DIR"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"2c3486cc_dd805424","line":425,"in_reply_to":"bdde8d7f_e38ee6bb","updated":"2022-08-30 12:31:30.000000000","message":"Done","commit_id":"04be4ff3a2c8f1175b76d2a8a724078750c47709"}]}