)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f22b2c8f0d2619d5a6913611ae4ae52a29336df","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add cloud-init growpart element"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It allows for growing specific partitions during the deployment."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I6519fba3e8f1d078b99d3c03f2ac85f7b6e37d8a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"01b8b6e9_4adfed36","line":9,"updated":"2022-10-05 13:57:19.000000000","message":"Just a thought: It might be helpful to include a little bit more, such as why this is helpful or important.","commit_id":"9cfe4d668254605486cf4bb5fc2e5f7e67923da9"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c6181597ba02d0293959a15982b6da84111423e8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add cloud-init growpart element"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It allows for growing specific partitions during the deployment."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I6519fba3e8f1d078b99d3c03f2ac85f7b6e37d8a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7ef6d57d_072a96f1","line":9,"in_reply_to":"01b8b6e9_4adfed36","updated":"2022-10-06 07:55:50.000000000","message":"Done","commit_id":"9cfe4d668254605486cf4bb5fc2e5f7e67923da9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8d63644b09ce8b57b4b3cd547a43713450f9076b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"84a93b19_b4b65507","updated":"2022-09-20 20:28:54.000000000","message":"Seems OK, minor things inline","commit_id":"23c2d1ba8ec09fe831494f317b300a0e01a3075e"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"84150ce843d836b3a40a36b5b5abc76e6adc39e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49a13e41_2c3afc82","in_reply_to":"84a93b19_b4b65507","updated":"2022-09-21 09:29:25.000000000","message":"Ack","commit_id":"23c2d1ba8ec09fe831494f317b300a0e01a3075e"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"ea3ec3e5f92a11e91fbc1052784517cb3a4188cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ff6d414_1abc3545","updated":"2022-09-21 13:23:34.000000000","message":"Linter marks this as an error:\n","commit_id":"d6cb3b1c862b9c8f6bd08068daad084ba0244670"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"60e99bff3954f6e5788a80dd4d3b43532856a783","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e5dd3d8d_e555fcb2","updated":"2022-09-22 20:49:30.000000000","message":"There doesn\u0027t seem to be anything lvm related in this change, can you rename the files 55-growpart-lvm.cfg, 55-growpart-lvm, and the release note to remove \"-lvm\"","commit_id":"69fb75ce458e364ed4f63f6ce1e158371b8001e5"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"be93f2483251a528975cbb13ab2c2179d79acc2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3c70ea13_f16587f1","updated":"2022-09-27 11:09:30.000000000","message":"recheck (dib-nodepool-functional-openstack-rockylinux-8-containerfile-src)","commit_id":"f311d07090ff3a5456c9e9b096c888efc8929427"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"b55d8e7b916f6300a1534cb970df280749c2dc25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6025c9b2_9c372fea","updated":"2022-09-27 12:44:38.000000000","message":"recheck (post_failure tox-py310)","commit_id":"f311d07090ff3a5456c9e9b096c888efc8929427"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"7fcee902c92fd9356776a18febed3984ad181925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5e928996_7db2da38","updated":"2022-10-07 06:43:20.000000000","message":"recheck (retry_limit dib-nodepool-functional-openstack-fedora-36-containerfile-src )","commit_id":"f6440bb0ac819acff8a4d7fa16ca212300cca70e"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"a8c4b77e9a7eb7e8d91545cf3d198df6266b3a81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"81dd46d1_c3b93471","updated":"2022-10-06 13:09:35.000000000","message":"recheck (retry_limit dib-nodepool-functional-openstack-fedora-36-containerfile-src)","commit_id":"f6440bb0ac819acff8a4d7fa16ca212300cca70e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"25be0a86051e96f6c6184a2c6029a9b93b4282d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2ddbe661_c03f0a3f","updated":"2022-10-11 04:19:32.000000000","message":"minor nits inline","commit_id":"c88066bea8e36c4f2470f0be2e5eb7df613c01f5"}],"diskimage_builder/elements/cloud-init-growpart-lvm/README.rst":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8d63644b09ce8b57b4b3cd547a43713450f9076b","unresolved":true,"context_lines":[{"line_number":2,"context_line":"cloud-init-growpart-lvm"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This element enables growpart for OS images with LVM."},{"line_number":6,"context_line":"To enable this element simply include it in the elements list."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"795f3b51_b84c9c60","line":5,"range":{"start_line":5,"start_character":49,"end_line":5,"end_character":52},"updated":"2022-09-20 20:28:54.000000000","message":"Why is this specific to LVM?  It seems like it could just be called \"cloud-init-growpart\" since it can grow any partition?","commit_id":"23c2d1ba8ec09fe831494f317b300a0e01a3075e"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"84150ce843d836b3a40a36b5b5abc76e6adc39e1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"cloud-init-growpart-lvm"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This element enables growpart for OS images with LVM."},{"line_number":6,"context_line":"To enable this element simply include it in the elements list."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a38186b3_2c5e1237","line":5,"range":{"start_line":5,"start_character":49,"end_line":5,"end_character":52},"in_reply_to":"795f3b51_b84c9c60","updated":"2022-09-21 09:29:25.000000000","message":"Ack","commit_id":"23c2d1ba8ec09fe831494f317b300a0e01a3075e"}],"diskimage_builder/elements/cloud-init-growpart-lvm/post-install.d/55-growpart-lvm":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8d63644b09ce8b57b4b3cd547a43713450f9076b","unresolved":true,"context_lines":[{"line_number":6,"context_line":"set -euo pipefail"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [[ -n ${DIB_CLOUD_INIT_GROWPART_DEVICES} ]]; then"},{"line_number":9,"context_line":"    if [ -d /etc/cloud/cloud.cfg.d ]; then"},{"line_number":10,"context_line":"        cat \u003e /etc/cloud/cloud.cfg.d/55-growpart-lvm.cfg \u003c\u003cEOF"},{"line_number":11,"context_line":"#cloud-config"},{"line_number":12,"context_line":"growpart:"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"043be635_def00484","line":9,"updated":"2022-09-20 20:28:54.000000000","message":"This check seems good, but probably it should fail if it can\u0027t write this out?  Seems like a fatal problem for enabling this.","commit_id":"23c2d1ba8ec09fe831494f317b300a0e01a3075e"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"84150ce843d836b3a40a36b5b5abc76e6adc39e1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -euo pipefail"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [[ -n ${DIB_CLOUD_INIT_GROWPART_DEVICES} ]]; then"},{"line_number":9,"context_line":"    if [ -d /etc/cloud/cloud.cfg.d ]; then"},{"line_number":10,"context_line":"        cat \u003e /etc/cloud/cloud.cfg.d/55-growpart-lvm.cfg \u003c\u003cEOF"},{"line_number":11,"context_line":"#cloud-config"},{"line_number":12,"context_line":"growpart:"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a9127b7_464557b3","line":9,"in_reply_to":"043be635_def00484","updated":"2022-09-21 09:29:25.000000000","message":"Done","commit_id":"23c2d1ba8ec09fe831494f317b300a0e01a3075e"}],"diskimage_builder/elements/cloud-init-growpart-lvm/releasenotes/notes/added_growpart_for_lvm-0ce76ba71710c720.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8d63644b09ce8b57b4b3cd547a43713450f9076b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added growpart for LVM element."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2e78062f_55f98506","line":4,"updated":"2022-09-20 20:28:54.000000000","message":"Release note is fine, but it should be more specific like \"Added the \u003celement-name\u003e element to \u003cexplain what it does\u003e\"","commit_id":"23c2d1ba8ec09fe831494f317b300a0e01a3075e"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"84150ce843d836b3a40a36b5b5abc76e6adc39e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added growpart for LVM element."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d7d44bf5_6b599b5a","line":4,"in_reply_to":"2e78062f_55f98506","updated":"2022-09-21 09:29:25.000000000","message":"Done","commit_id":"23c2d1ba8ec09fe831494f317b300a0e01a3075e"}],"diskimage_builder/elements/cloud-init-growpart/README.rst":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"76af396b62507f12e2315e5544a34747ef572b8d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"Specific partitions during the deployment process."},{"line_number":7,"context_line":"To enable this element simply include it in the elements list."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Dependencies:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"d7b68582_43fae80f","line":9,"updated":"2022-09-21 22:04:39.000000000","message":"Can there be a link to the cloud-init docs for this growpart mechanism?","commit_id":"421d3f46b420ba5318e828dab86cd8fff68b6ed1"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"00f34e1dae4c67c92f3b3cb10052aa5036f08651","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Specific partitions during the deployment process."},{"line_number":7,"context_line":"To enable this element simply include it in the elements list."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Dependencies:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"6cc9b932_a2d0c60e","line":9,"in_reply_to":"d7b68582_43fae80f","updated":"2022-09-22 07:29:06.000000000","message":"Done","commit_id":"421d3f46b420ba5318e828dab86cd8fff68b6ed1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f22b2c8f0d2619d5a6913611ae4ae52a29336df","unresolved":true,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This element enables growpart for OS images. It allows to grow"},{"line_number":6,"context_line":"Specific partitions during the deployment process."},{"line_number":7,"context_line":"To enable this element simply include it in the elements list."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"}],"source_content_type":"text/x-rst","patch_set":11,"id":"d98151ea_f22333db","line":6,"updated":"2022-10-05 13:57:19.000000000","message":"So this *likely* needs to also indicate the way this will fail. If the partition structure is different due to the underlying device when the OS boots.\n\nExample: Create image anticipating without LVM thinking all local storage is NVMe devices. Machine is deployed, however the image is written to a fibre channel device, or a SAS/SATA SSD controller. The device names supplied will just not work, and that is a limitation which should be communicated. In depth knowledge of what the deployed machine will look like is needed for this is needed.  A better, albeit way more complex path would be to allow a user to define filesystem mount points, and have a script populate it upon first boot before cloud-init starts.","commit_id":"9cfe4d668254605486cf4bb5fc2e5f7e67923da9"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c6181597ba02d0293959a15982b6da84111423e8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This element enables growpart for OS images. It allows to grow"},{"line_number":6,"context_line":"Specific partitions during the deployment process."},{"line_number":7,"context_line":"To enable this element simply include it in the elements list."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"}],"source_content_type":"text/x-rst","patch_set":11,"id":"e1386ae4_978b990e","line":6,"in_reply_to":"d98151ea_f22333db","updated":"2022-10-06 07:55:50.000000000","message":"Done","commit_id":"9cfe4d668254605486cf4bb5fc2e5f7e67923da9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f22b2c8f0d2619d5a6913611ae4ae52a29336df","unresolved":true,"context_lines":[{"line_number":6,"context_line":"Specific partitions during the deployment process."},{"line_number":7,"context_line":"To enable this element simply include it in the elements list."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"},{"line_number":10,"context_line":"  Cloud-init growpart module documentation - https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight\u003dgrowpart#growpart"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Dependencies:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"8fe7d1b4_1a0bbaac","line":9,"range":{"start_line":9,"start_character":122,"end_line":9,"end_character":124},"updated":"2022-10-05 13:57:19.000000000","message":"nit: You likely want to avoid the use of the word \"it\", because not all readers will understand what \"it\" refers to. It is generally better to point back exactly what your referring, so in this case, \"to grow the partition(s).\" instead of \"it.\"","commit_id":"9cfe4d668254605486cf4bb5fc2e5f7e67923da9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f22b2c8f0d2619d5a6913611ae4ae52a29336df","unresolved":true,"context_lines":[{"line_number":6,"context_line":"Specific partitions during the deployment process."},{"line_number":7,"context_line":"To enable this element simply include it in the elements list."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"},{"line_number":10,"context_line":"  Cloud-init growpart module documentation - https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight\u003dgrowpart#growpart"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Dependencies:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"895fd230_01fec6ac","line":9,"range":{"start_line":9,"start_character":139,"end_line":9,"end_character":141},"updated":"2022-10-05 13:57:19.000000000","message":"s/it/the variable/ ?","commit_id":"9cfe4d668254605486cf4bb5fc2e5f7e67923da9"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c6181597ba02d0293959a15982b6da84111423e8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Specific partitions during the deployment process."},{"line_number":7,"context_line":"To enable this element simply include it in the elements list."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"},{"line_number":10,"context_line":"  Cloud-init growpart module documentation - https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight\u003dgrowpart#growpart"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Dependencies:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"66e68eae_6f13b431","line":9,"range":{"start_line":9,"start_character":139,"end_line":9,"end_character":141},"in_reply_to":"895fd230_01fec6ac","updated":"2022-10-06 07:55:50.000000000","message":"Done","commit_id":"9cfe4d668254605486cf4bb5fc2e5f7e67923da9"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c6181597ba02d0293959a15982b6da84111423e8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Specific partitions during the deployment process."},{"line_number":7,"context_line":"To enable this element simply include it in the elements list."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"},{"line_number":10,"context_line":"  Cloud-init growpart module documentation - https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight\u003dgrowpart#growpart"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Dependencies:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"c6f8e9b0_67191df3","line":9,"range":{"start_line":9,"start_character":122,"end_line":9,"end_character":124},"in_reply_to":"8fe7d1b4_1a0bbaac","updated":"2022-10-06 07:55:50.000000000","message":"Done","commit_id":"9cfe4d668254605486cf4bb5fc2e5f7e67923da9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f22b2c8f0d2619d5a6913611ae4ae52a29336df","unresolved":true,"context_lines":[{"line_number":7,"context_line":"To enable this element simply include it in the elements list."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"},{"line_number":10,"context_line":"  Cloud-init growpart module documentation - https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight\u003dgrowpart#growpart"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Dependencies:"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"a11f7181_b1fc62ab","line":10,"updated":"2022-10-05 13:57:19.000000000","message":"It might be helpful to include an example, just so people correctly understand what exactly is expected and in what format. \"/dev/lvm/a-b /dev/lvm/a-c\", or is it comma separated, etc.","commit_id":"9cfe4d668254605486cf4bb5fc2e5f7e67923da9"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c6181597ba02d0293959a15982b6da84111423e8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"To enable this element simply include it in the elements list."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order for cloud-init to grow it. **Populating it is mandatory.**"},{"line_number":10,"context_line":"  Cloud-init growpart module documentation - https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight\u003dgrowpart#growpart"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Dependencies:"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7fc9d312_2f2f26d4","line":10,"in_reply_to":"a11f7181_b1fc62ab","updated":"2022-10-06 07:55:50.000000000","message":"Done","commit_id":"9cfe4d668254605486cf4bb5fc2e5f7e67923da9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"25be0a86051e96f6c6184a2c6029a9b93b4282d9","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order to be grown by cloud-init. **Populating this variable is mandatory.**"},{"line_number":12,"context_line":"  Cloud-init growpart module documentation - https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight\u003dgrowpart#growpart"},{"line_number":13,"context_line":"  Example configuration:"},{"line_number":14,"context_line":"  ``DIB_CLOUD_INIT_GROWPART_DEVICES:"},{"line_number":15,"context_line":"  - /dev/sda2"},{"line_number":16,"context_line":"  - /dev/vda3``"}],"source_content_type":"text/x-rst","patch_set":15,"id":"2c2af23f_611def46","line":13,"updated":"2022-10-11 04:19:32.000000000","message":"none of this really renders all that great; you can see this in the docs site preview https://83dc8d33393f11a7ffdd-c71a952889311e645cb3f8efebdefee7.ssl.cf1.rackcdn.com/855856/15/check/openstack-tox-docs/2b08b7b/docs/elements/cloud-init-growpart/README.html\n\ncould we at least pull this out into a code-section with ``` and fix up the spacing a bit.","commit_id":"c88066bea8e36c4f2470f0be2e5eb7df613c01f5"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"446455db2f2a56f68f64cf4554ee950933b2828b","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order to be grown by cloud-init. **Populating this variable is mandatory.**"},{"line_number":12,"context_line":"  Cloud-init growpart module documentation - https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight\u003dgrowpart#growpart"},{"line_number":13,"context_line":"  Example configuration:"},{"line_number":14,"context_line":"  ``DIB_CLOUD_INIT_GROWPART_DEVICES:"},{"line_number":15,"context_line":"  - /dev/sda2"},{"line_number":16,"context_line":"  - /dev/vda3``"}],"source_content_type":"text/x-rst","patch_set":15,"id":"8334efce_a330641a","line":13,"in_reply_to":"2c2af23f_611def46","updated":"2022-10-11 14:59:54.000000000","message":"The ``` does not work, I deleted that section as it looks clunky.","commit_id":"c88066bea8e36c4f2470f0be2e5eb7df613c01f5"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2f17a2734382aaf63ee07f3a0dce1def982653b6","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* ``DIB_CLOUD_INIT_GROWPART_DEVICES``: List of partition names that needs to be populated in order to be grown by cloud-init. **Populating this variable is mandatory.**"},{"line_number":12,"context_line":"  Cloud-init growpart module documentation - https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight\u003dgrowpart#growpart"},{"line_number":13,"context_line":"  Example configuration:"},{"line_number":14,"context_line":"  ``DIB_CLOUD_INIT_GROWPART_DEVICES:"},{"line_number":15,"context_line":"  - /dev/sda2"},{"line_number":16,"context_line":"  - /dev/vda3``"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5b24d867_cbee0e41","line":13,"in_reply_to":"8334efce_a330641a","updated":"2022-10-13 03:01:24.000000000","message":"sorry in RST it would be\n\n .. code-block::\n\nthere\u0027s several other examples","commit_id":"c88066bea8e36c4f2470f0be2e5eb7df613c01f5"}],"diskimage_builder/elements/cloud-init-growpart/post-install.d/55-growpart":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f22b2c8f0d2619d5a6913611ae4ae52a29336df","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ -n ${DIB_CLOUD_INIT_GROWPART_DEVICES} ]]; then"},{"line_number":10,"context_line":"    if [ -d /etc/cloud/cloud.cfg.d ]; then"},{"line_number":11,"context_line":"        cat \u003e /etc/cloud/cloud.cfg.d/55-growpart.cfg \u003c\u003cEOF"},{"line_number":12,"context_line":"#cloud-config"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"9d9b38e0_41296780","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":52},"updated":"2022-10-05 13:57:19.000000000","message":"For what it is worth, you might want to just switch this around so you exit and error reporting is not at the bottom of the file. It is a little hard to read as a result.","commit_id":"9cfe4d668254605486cf4bb5fc2e5f7e67923da9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"25be0a86051e96f6c6184a2c6029a9b93b4282d9","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        exit 1"},{"line_number":21,"context_line":"    fi"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    echo \"You must set the device list: \\\"$DIB_CLOUD_INIT_GROWPART_DEVICES\\\".\""},{"line_number":24,"context_line":"    exit 1"},{"line_number":25,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5190f7fb_8c06aeb4","line":23,"updated":"2022-10-11 04:19:32.000000000","message":"very minor thing, but this is going to try and expand this.  I\u0027d just say\n\n Set the device list in DIB_CLOUD_INIT_GROWPART_DEVICES\n\nit\u0027s clear enough.","commit_id":"c88066bea8e36c4f2470f0be2e5eb7df613c01f5"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"446455db2f2a56f68f64cf4554ee950933b2828b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        exit 1"},{"line_number":21,"context_line":"    fi"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    echo \"You must set the device list: \\\"$DIB_CLOUD_INIT_GROWPART_DEVICES\\\".\""},{"line_number":24,"context_line":"    exit 1"},{"line_number":25,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"307cb56f_5c1346da","line":23,"in_reply_to":"5190f7fb_8c06aeb4","updated":"2022-10-11 14:59:54.000000000","message":"Done","commit_id":"c88066bea8e36c4f2470f0be2e5eb7df613c01f5"}],"diskimage_builder/elements/cloud-init-growpart/post-install.d/55-growpart-lvm":[{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"ea3ec3e5f92a11e91fbc1052784517cb3a4188cc","unresolved":true,"context_lines":[{"line_number":9,"context_line":"if [[ -n ${DIB_CLOUD_INIT_GROWPART_DEVICES} ]]; then"},{"line_number":10,"context_line":"    if [ -d /etc/cloud/cloud.cfg.d ]; then"},{"line_number":11,"context_line":"        cat \u003e /etc/cloud/cloud.cfg.d/55-growpart-lvm.cfg \u003c\u003cEOF"},{"line_number":12,"context_line":"#cloud-config"},{"line_number":13,"context_line":"growpart:"},{"line_number":14,"context_line":"  mode: auto"},{"line_number":15,"context_line":"  devices: $DIB_CLOUD_INIT_GROWPART_DEVICES"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"8f7c3fd6_e1bb3d37","line":12,"updated":"2022-09-21 13:23:34.000000000","message":"Zuul marks lack of spaces here as an error:\n2022-09-21 11:30:38.499644 | ubuntu-focal | ERROR: diskimage_builder/elements/cloud-init-growpart/post-install.d/55-growpart-lvm should use 4 spaces indent\n2022-09-21 11:30:38.501258 | ubuntu-focal | 13:  mode: auto\n2022-09-21 11:30:38.501309 | ubuntu-focal | 14:  devices: $DIB_CLOUD_INIT_GROWPART_DEVICES\n2022-09-21 11:30:38.501333 | ubuntu-focal | 15:  ignore_growroot_disabled: false\n\nHowever if I will put in those spaces the file will be created with 4 spaces so this is not an error for me.","commit_id":"d6cb3b1c862b9c8f6bd08068daad084ba0244670"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"50f43098eab6d8f8f62fec25284fc0e98d480846","unresolved":false,"context_lines":[{"line_number":9,"context_line":"if [[ -n ${DIB_CLOUD_INIT_GROWPART_DEVICES} ]]; then"},{"line_number":10,"context_line":"    if [ -d /etc/cloud/cloud.cfg.d ]; then"},{"line_number":11,"context_line":"        cat \u003e /etc/cloud/cloud.cfg.d/55-growpart-lvm.cfg \u003c\u003cEOF"},{"line_number":12,"context_line":"#cloud-config"},{"line_number":13,"context_line":"growpart:"},{"line_number":14,"context_line":"  mode: auto"},{"line_number":15,"context_line":"  devices: $DIB_CLOUD_INIT_GROWPART_DEVICES"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"aa3820e1_1e8e45ba","line":12,"in_reply_to":"8f7c3fd6_e1bb3d37","updated":"2022-09-21 14:05:21.000000000","message":"Ack","commit_id":"d6cb3b1c862b9c8f6bd08068daad084ba0244670"}],"diskimage_builder/elements/cloud-init-growpart/releasenotes/notes/added_growpart_for_lvm-0ce76ba71710c720.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bed9d5b7e62faffc48456286bebcefbf3e1c2c39","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added growpart element. It allows for growing specific partitions"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"734a05f0_3f5d87c9","line":1,"updated":"2022-10-10 15:08:39.000000000","message":"Missing newline at end of file.","commit_id":"c88066bea8e36c4f2470f0be2e5eb7df613c01f5"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"446455db2f2a56f68f64cf4554ee950933b2828b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added growpart element. It allows for growing specific partitions"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"698138f0_fb2b962d","line":1,"in_reply_to":"734a05f0_3f5d87c9","updated":"2022-10-11 14:59:54.000000000","message":"Done","commit_id":"c88066bea8e36c4f2470f0be2e5eb7df613c01f5"}]}