)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35208,"name":"Frikin Evgenii","email":"frikin.evgenii@huawei.com","username":"efrikin"},"change_message_id":"581d69bf3363e024f94ebd9a70e5f6dbd16ea1cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"001c26b3_53405e8f","updated":"2022-09-12 12:47:23.000000000","message":"recheck TIMED_OUT","commit_id":"4fca817f9b39a9f194cb7b35a59221d8ad9714fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"851f8aaf5a8446568653f66b46aef140b87f0eeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"29111a1e_655cf0ff","updated":"2022-10-05 13:42:12.000000000","message":"Overall LGTM, with the exception of the indication that the new option is required. It doesn\u0027t actually appear required at all, and I think the documentation should represent that.","commit_id":"4f3e99a6c11b0ce17d1be1e1d4311e573a7db338"},{"author":{"_account_id":35208,"name":"Frikin Evgenii","email":"frikin.evgenii@huawei.com","username":"efrikin"},"change_message_id":"1500b1d3888b65eea0bf995f7fc1470e6f75e8c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ab5d831c_435c05f1","updated":"2022-09-21 12:41:58.000000000","message":"recheck TIMED_OUT","commit_id":"4f3e99a6c11b0ce17d1be1e1d4311e573a7db338"},{"author":{"_account_id":35208,"name":"Frikin Evgenii","email":"frikin.evgenii@huawei.com","username":"efrikin"},"change_message_id":"92a1dda22d3538209a7dc49c778bcbc171738593","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"301b84b0_c477f01f","updated":"2022-12-07 06:10:31.000000000","message":"recheck RETRY_LIMIT","commit_id":"05c2828ddec875c56c2c9dd8b69a8f5313b35bd2"},{"author":{"_account_id":35208,"name":"Frikin Evgenii","email":"frikin.evgenii@huawei.com","username":"efrikin"},"change_message_id":"c3841c7dccf1bd157f143608729b3fa9a473b82b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"21256ba3_e1e80c69","updated":"2022-12-12 03:22:25.000000000","message":"recheck RETRY_LIMIT\n","commit_id":"05c2828ddec875c56c2c9dd8b69a8f5313b35bd2"},{"author":{"_account_id":35208,"name":"Frikin Evgenii","email":"frikin.evgenii@huawei.com","username":"efrikin"},"change_message_id":"016895ea3723373ac2885fd1de7ccd73c3e23945","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6660ce0b_c0d76f70","updated":"2022-12-08 01:42:41.000000000","message":"recheck RETRY_LIMIT\n","commit_id":"05c2828ddec875c56c2c9dd8b69a8f5313b35bd2"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"09032ba3491a96df08142652ce4d25cdfd0cdb1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1d248f8c_ad063ff3","updated":"2022-12-16 03:29:58.000000000","message":"recheck jobs have been fixed","commit_id":"05c2828ddec875c56c2c9dd8b69a8f5313b35bd2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e75dc458b36b2d5e5525df39dd1a54bc95914afc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9f15bba5_48ecb215","updated":"2022-12-16 14:40:47.000000000","message":"Honestly, I\u0027m not a fan of the variable name, but overall, the concept is valid, and the docs are improved. +2 from me.","commit_id":"a9edef6548091796711fec34f1d490596146c5b0"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1c2f8fde604271e938dc0a0ed1908b190e755b9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d1c13153_1335249f","updated":"2022-12-21 04:10:55.000000000","message":"Since this is behind an \u003d\u003d7 and we need to do magic to get python3 installed on centos7 i guess this alright.  it doesn\u0027t feel like things will work well without a network connection, but if this helps then OK","commit_id":"a9edef6548091796711fec34f1d490596146c5b0"}],"diskimage_builder/elements/yum/README.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"851f8aaf5a8446568653f66b46aef140b87f0eeb","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Provide yum specific image building glue."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RHEL/Fedora/CentOS and other yum based distributions need specific yum customizations."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Customizations include caching of downloaded yum packages outside of the build chroot"},{"line_number":10,"context_line":"so that they can be reused by subsequent image builds. The cache increases image building"},{"line_number":11,"context_line":"speed when building multiple images, especially on slow connections."},{"line_number":12,"context_line":"This is more effective than using an HTTP proxy as a yum cache since the same rpm from"},{"line_number":13,"context_line":"different mirrors is often requested."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Custom yum repository configurations can also be applied by defining ``DIB_YUM_REPO_CONF``"},{"line_number":16,"context_line":"to a space separated list of repo configuration files. The files will be copied to"},{"line_number":17,"context_line":"``/etc/yum.repos.d/`` during the image build, and then removed at the end of the build."},{"line_number":18,"context_line":"Each repo file should be named differently to avoid a filename collision."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The yum repository can also be configured by defining ``DIB_YUM_REPO_PACKAGE`` as a yum"},{"line_number":21,"context_line":"available package or a URL to an rpm file. This package can install repo files with"},{"line_number":22,"context_line":"any associated keys and certificates."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Environment Variables"},{"line_number":25,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2c7246cf_451162a2","line":22,"range":{"start_line":7,"start_character":0,"end_line":22,"end_character":37},"updated":"2022-10-05 13:42:12.000000000","message":"nit to ignore: Is there a particular reason the line wrapping was changed? Just thinking that we generally attempt to avoid doing so.","commit_id":"4f3e99a6c11b0ce17d1be1e1d4311e573a7db338"},{"author":{"_account_id":35208,"name":"Frikin Evgenii","email":"frikin.evgenii@huawei.com","username":"efrikin"},"change_message_id":"209eb59d5218eeeaa09cfd67a1d0f9ef09f4530c","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Provide yum specific image building glue."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RHEL/Fedora/CentOS and other yum based distributions need specific yum customizations."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Customizations include caching of downloaded yum packages outside of the build chroot"},{"line_number":10,"context_line":"so that they can be reused by subsequent image builds. The cache increases image building"},{"line_number":11,"context_line":"speed when building multiple images, especially on slow connections."},{"line_number":12,"context_line":"This is more effective than using an HTTP proxy as a yum cache since the same rpm from"},{"line_number":13,"context_line":"different mirrors is often requested."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Custom yum repository configurations can also be applied by defining ``DIB_YUM_REPO_CONF``"},{"line_number":16,"context_line":"to a space separated list of repo configuration files. The files will be copied to"},{"line_number":17,"context_line":"``/etc/yum.repos.d/`` during the image build, and then removed at the end of the build."},{"line_number":18,"context_line":"Each repo file should be named differently to avoid a filename collision."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The yum repository can also be configured by defining ``DIB_YUM_REPO_PACKAGE`` as a yum"},{"line_number":21,"context_line":"available package or a URL to an rpm file. This package can install repo files with"},{"line_number":22,"context_line":"any associated keys and certificates."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Environment Variables"},{"line_number":25,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4c3c1991_266ec525","line":22,"range":{"start_line":7,"start_character":0,"end_line":22,"end_character":37},"in_reply_to":"2c7246cf_451162a2","updated":"2022-10-06 03:25:52.000000000","message":"Thank for feedback. \nThis was copy-paste. I have fixed it","commit_id":"4f3e99a6c11b0ce17d1be1e1d4311e573a7db338"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"851f8aaf5a8446568653f66b46aef140b87f0eeb","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  :Example: ``DIB_DNF_MODULE_STREAMS\u003d\u0027virt:8.2 container-tools:3.0\u0027``"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DIB_CENTOS_7_PREINSTALL_EPEL_URL_PACKAGE"},{"line_number":37,"context_line":"  :Required: Yes"},{"line_number":38,"context_line":"  :Default: https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm"},{"line_number":39,"context_line":"  :Description: The environment variable is used to override default value in pre-install "},{"line_number":40,"context_line":"                stage to install epel repository from custom source"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6ede78d3_8f3b1ae5","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":16},"updated":"2022-10-05 13:42:12.000000000","message":"I think you mean no in that it is not required?  Also only seems required for the Centos7 matching code path. Realistically, since there is a default, this seems misleading and should be  \"No\", imho.","commit_id":"4f3e99a6c11b0ce17d1be1e1d4311e573a7db338"},{"author":{"_account_id":35208,"name":"Frikin Evgenii","email":"frikin.evgenii@huawei.com","username":"efrikin"},"change_message_id":"209eb59d5218eeeaa09cfd67a1d0f9ef09f4530c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  :Example: ``DIB_DNF_MODULE_STREAMS\u003d\u0027virt:8.2 container-tools:3.0\u0027``"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DIB_CENTOS_7_PREINSTALL_EPEL_URL_PACKAGE"},{"line_number":37,"context_line":"  :Required: Yes"},{"line_number":38,"context_line":"  :Default: https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm"},{"line_number":39,"context_line":"  :Description: The environment variable is used to override default value in pre-install "},{"line_number":40,"context_line":"                stage to install epel repository from custom source"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6d8d7456_bd6eaa3c","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":16},"in_reply_to":"6ede78d3_8f3b1ae5","updated":"2022-10-06 03:25:52.000000000","message":"Thank you for feedback.\nYou are right.\nThis is my mistake. I have changed \"Required\" field from \"Yes\" to \"No\"","commit_id":"4f3e99a6c11b0ce17d1be1e1d4311e573a7db338"}],"diskimage_builder/elements/yum/pre-install.d/01-00-centos-python3":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"94ab1963eb53b2f9be15bac15a6ebbdf9f820739","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    # early stage."},{"line_number":18,"context_line":"    yum install -y python3"},{"line_number":19,"context_line":"    # NOTE(dpawlik) The epel-release package is not available in RHEL."},{"line_number":20,"context_line":"    yum install -y ${DIB_YUM_URL_EPEL_PACKAGE:-https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm}"},{"line_number":21,"context_line":"    yum install -y python36-PyYAML"},{"line_number":22,"context_line":"    yum remove -y epel-release"},{"line_number":23,"context_line":"elif [[ ${DISTRO_NAME} \u003d~ (centos|rhel) \u0026\u0026 ${DIB_RELEASE} \u003e 7 ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"560a28ba_c1e1e5f8","line":20,"updated":"2022-09-20 20:08:24.000000000","message":"This at a minimum needs documentation.  The namespace for this seems too wide, it\u0027s only applying in the CentOS 7 case which is a hack to get Python 3.6, it would want to be DIB_CENTOS_7_PREINSTALL_EPEL_PACKAGE or something a bit more targeted.","commit_id":"4fca817f9b39a9f194cb7b35a59221d8ad9714fe"},{"author":{"_account_id":35208,"name":"Frikin Evgenii","email":"frikin.evgenii@huawei.com","username":"efrikin"},"change_message_id":"b43a1d218e3780cd91e14b0a29a148344c88b626","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    # early stage."},{"line_number":18,"context_line":"    yum install -y python3"},{"line_number":19,"context_line":"    # NOTE(dpawlik) The epel-release package is not available in RHEL."},{"line_number":20,"context_line":"    yum install -y ${DIB_YUM_URL_EPEL_PACKAGE:-https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm}"},{"line_number":21,"context_line":"    yum install -y python36-PyYAML"},{"line_number":22,"context_line":"    yum remove -y epel-release"},{"line_number":23,"context_line":"elif [[ ${DISTRO_NAME} \u003d~ (centos|rhel) \u0026\u0026 ${DIB_RELEASE} \u003e 7 ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"281ab465_4df60d08","line":20,"in_reply_to":"560a28ba_c1e1e5f8","updated":"2022-09-21 10:01:23.000000000","message":"\u003e This at a minimum needs documentation.  The namespace for this seems too wide, it\u0027s only applying in the CentOS 7 case which is a hack to get Python 3.6, it would want to be DIB_CENTOS_7_PREINSTALL_EPEL_PACKAGE or something a bit more targeted.\n\nThank for your feedback.\n\nI changed variable name and added to documentation.","commit_id":"4fca817f9b39a9f194cb7b35a59221d8ad9714fe"}]}