)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14473,"name":"David Wahlstrom","email":"david.wahlstrom@gmail.com","username":"drwahl"},"change_message_id":"0108a6b6f6e12f59c631416d784ed93a0ef9e55c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a3374c2_89d94d06","updated":"2023-01-05 02:45:17.000000000","message":"I\u0027m not sure why the logger.info call was removed, but we should keep that to help debug things.","commit_id":"a7fb911b6d717a2b1424a73170afd92abed7917d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d3a935358b3cdd4884f91d1780d38bc9793bdd24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c08b05af_cc0ecb21","updated":"2023-01-20 15:00:13.000000000","message":"mount actions not really needed, they can bring some problems\nwe need fstab support here too","commit_id":"159b1aefdbde2c70cb08c03b2402c420f4fd9299"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"968a24ece432db9def554fd24f2bf4cbe48ffad1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c87f670b_04759c65","updated":"2023-03-06 05:32:42.000000000","message":"There\u0027s quite a lot of unit tests under diskimage_builder/block_device/tests\n\nI\u0027d like to see this added to one of the configs. I think probably test_mount_order.py might be the right place, though I\u0027m open to suggestions.  If feels like we could check the semantics implemented here of creating the directory, but not mounting the swap partition in some of that testing?","commit_id":"8ce9bd0494ee5747a2a76dc9ee2c3680ea68bfc9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2f82c78a7d5f4019654fea49eed1fb0e8e81362d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8d69330b_359fbd54","updated":"2023-02-02 20:50:47.000000000","message":"recheck TIMED_OUT","commit_id":"8ce9bd0494ee5747a2a76dc9ee2c3680ea68bfc9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ccdfe69bba39d8e7c9ca8e68b2c42f2c38a7981d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4ffe87d0_f622bb41","in_reply_to":"59700c10_d45ac76d","updated":"2023-03-06 13:46:15.000000000","message":"Done","commit_id":"8ce9bd0494ee5747a2a76dc9ee2c3680ea68bfc9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3b992f4466e5e1bcc60a64ec2365605dd83330bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"59700c10_d45ac76d","in_reply_to":"c87f670b_04759c65","updated":"2023-03-06 09:34:36.000000000","message":"Ack","commit_id":"8ce9bd0494ee5747a2a76dc9ee2c3680ea68bfc9"}],"diskimage_builder/block_device/level3/mount.py":[{"author":{"_account_id":14473,"name":"David Wahlstrom","email":"david.wahlstrom@gmail.com","username":"drwahl"},"change_message_id":"0108a6b6f6e12f59c631416d784ed93a0ef9e55c","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        if (self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] \u003d\u003d \u0027swap\u0027):"},{"line_number":84,"context_line":"          exec_sudo([\"swapon\", self.state[\u0027filesys\u0027][self.base][\u0027device\u0027]])"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"          exec_sudo([\"mount\", self.state[\u0027filesys\u0027][self.base][\u0027device\u0027],"},{"line_number":87,"context_line":"                     mount_point])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if \u0027mount\u0027 not in self.state:"}],"source_content_type":"text/x-python","patch_set":1,"id":"77b2227e_3bdbba2a","line":86,"updated":"2023-01-05 02:45:17.000000000","message":"Can we capture some debug here with `logger.info`?","commit_id":"a7fb911b6d717a2b1424a73170afd92abed7917d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ac0271f976de7dcbd3fc631cb8fd7e56eb10e1d0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        if (self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] \u003d\u003d \u0027swap\u0027):"},{"line_number":84,"context_line":"          exec_sudo([\"swapon\", self.state[\u0027filesys\u0027][self.base][\u0027device\u0027]])"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"          exec_sudo([\"mount\", self.state[\u0027filesys\u0027][self.base][\u0027device\u0027],"},{"line_number":87,"context_line":"                     mount_point])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if \u0027mount\u0027 not in self.state:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a74c11a2_2a046f52","line":86,"in_reply_to":"77b2227e_3bdbba2a","updated":"2023-02-02 19:18:44.000000000","message":"exec_sudo have debug logging if needed. mkfs executed with -q (silent) option to minimise unneeded output.","commit_id":"a7fb911b6d717a2b1424a73170afd92abed7917d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d3a935358b3cdd4884f91d1780d38bc9793bdd24","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            # file system tree."},{"line_number":82,"context_line":"            exec_sudo([\u0027mkdir\u0027, \u0027-p\u0027, mount_point])"},{"line_number":83,"context_line":"        logger.info(\"Mounting [%s] to [%s]\", self.name, mount_point)"},{"line_number":84,"context_line":"        if (self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] \u003d\u003d \u0027swap\u0027):"},{"line_number":85,"context_line":"            exec_sudo([\"swapon\", self.state[\u0027filesys\u0027][self.base][\u0027device\u0027]])"},{"line_number":86,"context_line":"        else:"},{"line_number":87,"context_line":"            exec_sudo([\"mount\", self.state[\u0027filesys\u0027][self.base][\u0027device\u0027],"},{"line_number":88,"context_line":"                       mount_point])"}],"source_content_type":"text/x-python","patch_set":7,"id":"30db5692_43766283","line":85,"range":{"start_line":84,"start_character":8,"end_line":85,"end_character":77},"updated":"2023-01-20 15:00:13.000000000","message":"no need to activate swap during image creation, there might be some problems with deactivating it on cleanup","commit_id":"159b1aefdbde2c70cb08c03b2402c420f4fd9299"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ac0271f976de7dcbd3fc631cb8fd7e56eb10e1d0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            # file system tree."},{"line_number":82,"context_line":"            exec_sudo([\u0027mkdir\u0027, \u0027-p\u0027, mount_point])"},{"line_number":83,"context_line":"        logger.info(\"Mounting [%s] to [%s]\", self.name, mount_point)"},{"line_number":84,"context_line":"        if (self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] \u003d\u003d \u0027swap\u0027):"},{"line_number":85,"context_line":"            exec_sudo([\"swapon\", self.state[\u0027filesys\u0027][self.base][\u0027device\u0027]])"},{"line_number":86,"context_line":"        else:"},{"line_number":87,"context_line":"            exec_sudo([\"mount\", self.state[\u0027filesys\u0027][self.base][\u0027device\u0027],"},{"line_number":88,"context_line":"                       mount_point])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3d3159e9_b3b8710e","line":85,"range":{"start_line":84,"start_character":8,"end_line":85,"end_character":77},"in_reply_to":"30db5692_43766283","updated":"2023-02-02 19:18:44.000000000","message":"done in patch set 8.","commit_id":"159b1aefdbde2c70cb08c03b2402c420f4fd9299"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d3a935358b3cdd4884f91d1780d38bc9793bdd24","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        if self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] not in (\u0027vfat\u0027, \u0027swap\u0027):"},{"line_number":113,"context_line":"            exec_sudo([\"fstrim\", \"--verbose\","},{"line_number":114,"context_line":"                       self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"},{"line_number":115,"context_line":"        if (self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] \u003d\u003d \u0027swap\u0027):"},{"line_number":116,"context_line":"            exec_sudo([\"swapoff\", self.state[\u0027filesys\u0027][self.base][\u0027device\u0027]])"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            exec_sudo([\"umount\", self.state[\u0027mount\u0027][self.mount_point]"},{"line_number":119,"context_line":"                      [\u0027path\u0027]])"}],"source_content_type":"text/x-python","patch_set":7,"id":"d08516e7_12e50428","line":116,"range":{"start_line":115,"start_character":7,"end_line":116,"end_character":78},"updated":"2023-01-20 15:00:13.000000000","message":"ditto","commit_id":"159b1aefdbde2c70cb08c03b2402c420f4fd9299"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ac0271f976de7dcbd3fc631cb8fd7e56eb10e1d0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        if self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] not in (\u0027vfat\u0027, \u0027swap\u0027):"},{"line_number":113,"context_line":"            exec_sudo([\"fstrim\", \"--verbose\","},{"line_number":114,"context_line":"                       self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"},{"line_number":115,"context_line":"        if (self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] \u003d\u003d \u0027swap\u0027):"},{"line_number":116,"context_line":"            exec_sudo([\"swapoff\", self.state[\u0027filesys\u0027][self.base][\u0027device\u0027]])"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            exec_sudo([\"umount\", self.state[\u0027mount\u0027][self.mount_point]"},{"line_number":119,"context_line":"                      [\u0027path\u0027]])"}],"source_content_type":"text/x-python","patch_set":7,"id":"2b3cba77_7e7ef95c","line":116,"range":{"start_line":115,"start_character":7,"end_line":116,"end_character":78},"in_reply_to":"d08516e7_12e50428","updated":"2023-02-02 19:18:44.000000000","message":"done in patch set 8.","commit_id":"159b1aefdbde2c70cb08c03b2402c420f4fd9299"}]}