)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"59a5e610dda068e1fc0e3d4d8c46642493967894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"723b9a41_c9936877","updated":"2023-03-02 02:50:58.000000000","message":"The failure in dib-nodepool-functional-openstack-ubuntu-xenial-src looks legitimate, otherwise this looks mostly good.\n\nCould you also create a release note using the \"reno\" tool?","commit_id":"0d1c13aa2e97109c02738f215ce1454ddc016543"},{"author":{"_account_id":35820,"name":"Espen Flage-Larsen","display_name":"espenfl","email":"flagre@gmail.com","username":"espenfl","status":"Sigma2"},"change_message_id":"412c3a17934be9d62b7d3615e6e05cac99c4d8d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"37b6f91e_e83b1e73","in_reply_to":"723b9a41_c9936877","updated":"2023-08-25 09:45:21.000000000","message":"Will look into that failure. Happy to add a release not, any directions/docs on how to do it the right way? This is a bit new to me.","commit_id":"0d1c13aa2e97109c02738f215ce1454ddc016543"}],"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"59a5e610dda068e1fc0e3d4d8c46642493967894","unresolved":true,"context_lines":[{"line_number":38,"context_line":"elif [[ \"${DIB_BLOCK_DEVICE}\" \u003d\u003d \"efi\" ]]; then"},{"line_number":39,"context_line":"    install-packages -m bootloader grub-efi \"grub-efi-${ARCH}\""},{"line_number":40,"context_line":"else"},{"line_number":41,"context_line":"    install-packages -m bootloader grub-pc grub-efi \"grub-efi-${ARCH}\""},{"line_number":42,"context_line":"fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Some use grub2 in executable names, some do not, check both"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"60ae11e4_0dfb500c","line":41,"updated":"2023-03-02 02:50:58.000000000","message":"I mentioned EFI support for debian/ubuntu on IRC, I\u0027ll give a little more context here in case you wanted to add support in a future change.\n\nOn Red Hat derived distros, installing package grub-efi-${ARCH} will install files in /boot/efi/${EFI_BOOT_DIR} and /boot/efi/BOOT and it will be ready for secure-boot capable efi boot.\n\nOn debian/ubuntu, grub-efi-${ARCH} installs these files only to /usr, and something else needs to copy these files to /boot/efi/${EFI_BOOT_DIR} and /boot/efi/BOOT. This file copying for debian/ubuntu is what we need.","commit_id":"0d1c13aa2e97109c02738f215ce1454ddc016543"},{"author":{"_account_id":35820,"name":"Espen Flage-Larsen","display_name":"espenfl","email":"flagre@gmail.com","username":"espenfl","status":"Sigma2"},"change_message_id":"412c3a17934be9d62b7d3615e6e05cac99c4d8d9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"elif [[ \"${DIB_BLOCK_DEVICE}\" \u003d\u003d \"efi\" ]]; then"},{"line_number":39,"context_line":"    install-packages -m bootloader grub-efi \"grub-efi-${ARCH}\""},{"line_number":40,"context_line":"else"},{"line_number":41,"context_line":"    install-packages -m bootloader grub-pc grub-efi \"grub-efi-${ARCH}\""},{"line_number":42,"context_line":"fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Some use grub2 in executable names, some do not, check both"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"49f228ec_a35ffe61","line":41,"in_reply_to":"60ae11e4_0dfb500c","updated":"2023-08-25 09:45:21.000000000","message":"Thanks. Unfortunately I have limited knowledge on these things. Two things: is this only relevant for secure boot (i.e. debian/ubuntu do support EFI, just not in an secure boot compatible way)? I noticed when modifying an original ISO from 22.04 that that was strictly EFI based.","commit_id":"0d1c13aa2e97109c02738f215ce1454ddc016543"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"59a5e610dda068e1fc0e3d4d8c46642493967894","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    GRUB_DEFAULT\u003d/etc/default/grub.d/99-dib-bootloader.cfg"},{"line_number":90,"context_line":"fi"},{"line_number":91,"context_line":"    "},{"line_number":92,"context_line":"# This is not a valid tag according to https://www.gnu.org/software/grub/manual/grub/grub.html#Simple-configuration"},{"line_number":93,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":94,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":95,"context_line":"echo \"GRUB_TIMEOUT\u003d${DIB_GRUB_TIMEOUT:-5}\" \u003e\u003e ${GRUB_DEFAULT}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9e271473_dd249a79","line":92,"updated":"2023-03-02 02:50:58.000000000","message":"What does \"This\" refer to here? GRUB_DEVICE? It is likely no longer required in the BLS case but I\u0027m not sure about others.","commit_id":"0d1c13aa2e97109c02738f215ce1454ddc016543"},{"author":{"_account_id":35820,"name":"Espen Flage-Larsen","display_name":"espenfl","email":"flagre@gmail.com","username":"espenfl","status":"Sigma2"},"change_message_id":"412c3a17934be9d62b7d3615e6e05cac99c4d8d9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    GRUB_DEFAULT\u003d/etc/default/grub.d/99-dib-bootloader.cfg"},{"line_number":90,"context_line":"fi"},{"line_number":91,"context_line":"    "},{"line_number":92,"context_line":"# This is not a valid tag according to https://www.gnu.org/software/grub/manual/grub/grub.html#Simple-configuration"},{"line_number":93,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":94,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":95,"context_line":"echo \"GRUB_TIMEOUT\u003d${DIB_GRUB_TIMEOUT:-5}\" \u003e\u003e ${GRUB_DEFAULT}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"f41159af_17c161b9","line":92,"in_reply_to":"9e271473_dd249a79","updated":"2023-08-25 09:45:21.000000000","message":"This comment is stuck from initial devs to keep notes. This is wrong for a release and I will remove it.","commit_id":"0d1c13aa2e97109c02738f215ce1454ddc016543"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"59a5e610dda068e1fc0e3d4d8c46642493967894","unresolved":true,"context_lines":[{"line_number":90,"context_line":"fi"},{"line_number":91,"context_line":"    "},{"line_number":92,"context_line":"# This is not a valid tag according to https://www.gnu.org/software/grub/manual/grub/grub.html#Simple-configuration"},{"line_number":93,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":94,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":95,"context_line":"echo \"GRUB_TIMEOUT\u003d${DIB_GRUB_TIMEOUT:-5}\" \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":96,"context_line":"echo \u0027GRUB_TERMINAL\u003d\"serial console\"\u0027 \u003e\u003e ${GRUB_DEFAULT}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"190b2635_f3e29f9f","line":93,"updated":"2023-03-02 02:50:58.000000000","message":"appending to a non-existent file is causing a failure https://zuul.opendev.org/t/openstack/build/6b8c608f11624b2692d963583ff8cb96/log/nodepool/builds/test-image-0000000001.log#4488","commit_id":"0d1c13aa2e97109c02738f215ce1454ddc016543"},{"author":{"_account_id":35820,"name":"Espen Flage-Larsen","display_name":"espenfl","email":"flagre@gmail.com","username":"espenfl","status":"Sigma2"},"change_message_id":"412c3a17934be9d62b7d3615e6e05cac99c4d8d9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"fi"},{"line_number":91,"context_line":"    "},{"line_number":92,"context_line":"# This is not a valid tag according to https://www.gnu.org/software/grub/manual/grub/grub.html#Simple-configuration"},{"line_number":93,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":94,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":95,"context_line":"echo \"GRUB_TIMEOUT\u003d${DIB_GRUB_TIMEOUT:-5}\" \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":96,"context_line":"echo \u0027GRUB_TERMINAL\u003d\"serial console\"\u0027 \u003e\u003e ${GRUB_DEFAULT}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"a5befa92_c0acf6b3","line":93,"in_reply_to":"190b2635_f3e29f9f","updated":"2023-08-25 09:45:21.000000000","message":"Will look into this. Joining IRC to do some discussions on this.","commit_id":"0d1c13aa2e97109c02738f215ce1454ddc016543"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"59a5e610dda068e1fc0e3d4d8c46642493967894","unresolved":true,"context_lines":[{"line_number":126,"context_line":"GRUB_CMDLINE_LINUX_DEFAULT\u003d\"console\u003dtty0 console\u003d${SERIAL_CONSOLE} no_timer_check\""},{"line_number":127,"context_line":"echo \"GRUB_CMDLINE_LINUX_DEFAULT\u003d\\\"${GRUB_CMDLINE_LINUX_DEFAULT} ${DIB_BOOTLOADER_DEFAULT_CMDLINE}\\\"\" \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":128,"context_line":"# Word default to 8 bit, parity to no and stop bit to 1, so we do not provide."},{"line_number":129,"context_line":"echo \"GRUB_SERIAL_COMMAND\u003d\\\"serial --speed\u003d${DIB_BOOTLOADER_SERIAL_CONSOLE_SPEED} --unit\u003d${DIB_BOOTLOADER_SERIAL_CONSOLE_UNIT}\\\"\"\u003e\u003e ${GRUB_DEFAULT}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# os-prober leaks /dev/sda into config file in dual-boot host"},{"line_number":132,"context_line":"# Disable grub-os-prober to avoid the issue  while running"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"16ba12e5_a6148242","line":129,"updated":"2023-03-02 02:50:58.000000000","message":"Is it safe in all cases to drop --word\u003d8 --parity\u003dno --stop\u003d1?","commit_id":"0d1c13aa2e97109c02738f215ce1454ddc016543"},{"author":{"_account_id":35820,"name":"Espen Flage-Larsen","display_name":"espenfl","email":"flagre@gmail.com","username":"espenfl","status":"Sigma2"},"change_message_id":"412c3a17934be9d62b7d3615e6e05cac99c4d8d9","unresolved":false,"context_lines":[{"line_number":126,"context_line":"GRUB_CMDLINE_LINUX_DEFAULT\u003d\"console\u003dtty0 console\u003d${SERIAL_CONSOLE} no_timer_check\""},{"line_number":127,"context_line":"echo \"GRUB_CMDLINE_LINUX_DEFAULT\u003d\\\"${GRUB_CMDLINE_LINUX_DEFAULT} ${DIB_BOOTLOADER_DEFAULT_CMDLINE}\\\"\" \u003e\u003e ${GRUB_DEFAULT}"},{"line_number":128,"context_line":"# Word default to 8 bit, parity to no and stop bit to 1, so we do not provide."},{"line_number":129,"context_line":"echo \"GRUB_SERIAL_COMMAND\u003d\\\"serial --speed\u003d${DIB_BOOTLOADER_SERIAL_CONSOLE_SPEED} --unit\u003d${DIB_BOOTLOADER_SERIAL_CONSOLE_UNIT}\\\"\"\u003e\u003e ${GRUB_DEFAULT}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# os-prober leaks /dev/sda into config file in dual-boot host"},{"line_number":132,"context_line":"# Disable grub-os-prober to avoid the issue  while running"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9e287e4b_197737e6","line":129,"in_reply_to":"16ba12e5_a6148242","updated":"2023-08-25 09:45:21.000000000","message":"Not sure, but according to the GRUB manual these are defaults and have been for some time. Maybe we should put in back in to be sure to not break a corner case?","commit_id":"0d1c13aa2e97109c02738f215ce1454ddc016543"}]}