)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a9a215c3a83959d560a33530d6134c7db5a24fbc","unresolved":true,"context_lines":[{"line_number":10,"context_line":"redhat style distribution, dracut\u0027s internal code looks to validate"},{"line_number":11,"context_line":"the kernel hmac signature in before proceeding to userspace."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It does this by looking at the /boot/ folder file for the kernel."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"And it normally does this with the root filesystem. Except if the"},{"line_number":16,"context_line":"kernel is not on the root filesystem, and is instead on a /boot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b72094eb_4c75a28b","line":13,"updated":"2023-03-08 03:08:36.000000000","message":"More specifically I guess it does this by looking for a matching .hmac checksum file in the /boot directory of the device listed in the \"boot\u003d\" kernel-comamnd-line argument?","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9fc55b1610a2c529511003bfa39422dcd7e3f93e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"redhat style distribution, dracut\u0027s internal code looks to validate"},{"line_number":11,"context_line":"the kernel hmac signature in before proceeding to userspace."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It does this by looking at the /boot/ folder file for the kernel."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"And it normally does this with the root filesystem. Except if the"},{"line_number":16,"context_line":"kernel is not on the root filesystem, and is instead on a /boot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0358eefe_571ee381","line":13,"in_reply_to":"1d1baaa7_d913b945","updated":"2023-03-08 17:39:42.000000000","message":"Done","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"090cfe2dc6e2503638b9d2ee1fb756708a0ef37f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"redhat style distribution, dracut\u0027s internal code looks to validate"},{"line_number":11,"context_line":"the kernel hmac signature in before proceeding to userspace."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It does this by looking at the /boot/ folder file for the kernel."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"And it normally does this with the root filesystem. Except if the"},{"line_number":16,"context_line":"kernel is not on the root filesystem, and is instead on a /boot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1d1baaa7_d913b945","line":13,"in_reply_to":"b72094eb_4c75a28b","updated":"2023-03-08 16:29:47.000000000","message":"yes, exactly.","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a9a215c3a83959d560a33530d6134c7db5a24fbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7ea074e4_71abbd45","updated":"2023-03-08 03:08:36.000000000","message":"couple of typo level things inline, but also some questions.  particularly I wonder if using a label for the boot partition from the block-device config file is a better interface for this?","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b35c80b34ce4a1b8beacdd8caaec4a7f360ddc57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cf8e9391_9a110f34","updated":"2023-03-07 01:34:56.000000000","message":"recheck timeouts","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6c7dc7a558b1055dfbf5214a7f8496a20fb2f962","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"035a7569_8e3a9cf5","updated":"2023-03-15 03:27:26.000000000","message":"Thanks, I quite like the way it looks at the /boot entry from the config and gets the label from there","commit_id":"c1f709a39fa3436396f95bbf03337af09ad05b5b"}],"diskimage_builder/block_device/blockdevice.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"01ba8e5f0b015b9dd3b6ae77c230a4b6ec02e666","unresolved":true,"context_lines":[{"line_number":317,"context_line":"            return 0"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if symbol \u003d\u003d \"boot-label\":"},{"line_number":320,"context_line":"            boot_label \u003d self._config_get_mount(\"/boot\")"},{"line_number":321,"context_line":"            boot_fs \u003d self._config_get_mkfs(boot_mount[\u0027base\u0027])"},{"line_number":322,"context_line":"            logger.debug(\"boot-label [%s]\", boot_fs[\u0027label\u0027])"},{"line_number":323,"context_line":"            print(\"%s\" % boot_fs[\u0027label\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"de2f9c26_976aaf2b","line":320,"range":{"start_line":320,"start_character":12,"end_line":320,"end_character":22},"updated":"2023-03-08 18:49:43.000000000","message":"boot_mount","commit_id":"77e3d709406854ab87ea29b75c2a9191a5d3c925"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ae68494e145eedf0f761173fe19e4626fefeeb98","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            return 0"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if symbol \u003d\u003d \"boot-label\":"},{"line_number":320,"context_line":"            boot_label \u003d self._config_get_mount(\"/boot\")"},{"line_number":321,"context_line":"            boot_fs \u003d self._config_get_mkfs(boot_mount[\u0027base\u0027])"},{"line_number":322,"context_line":"            logger.debug(\"boot-label [%s]\", boot_fs[\u0027label\u0027])"},{"line_number":323,"context_line":"            print(\"%s\" % boot_fs[\u0027label\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"fd09b7b9_5f0fb7a2","line":320,"range":{"start_line":320,"start_character":12,"end_line":320,"end_character":22},"in_reply_to":"de2f9c26_976aaf2b","updated":"2023-03-14 15:44:26.000000000","message":"Done","commit_id":"77e3d709406854ab87ea29b75c2a9191a5d3c925"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"01ba8e5f0b015b9dd3b6ae77c230a4b6ec02e666","unresolved":true,"context_lines":[{"line_number":319,"context_line":"        if symbol \u003d\u003d \"boot-label\":"},{"line_number":320,"context_line":"            boot_label \u003d self._config_get_mount(\"/boot\")"},{"line_number":321,"context_line":"            boot_fs \u003d self._config_get_mkfs(boot_mount[\u0027base\u0027])"},{"line_number":322,"context_line":"            logger.debug(\"boot-label [%s]\", boot_fs[\u0027label\u0027])"},{"line_number":323,"context_line":"            print(\"%s\" % boot_fs[\u0027label\u0027])"},{"line_number":324,"context_line":"            return 0"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"de46b266_386cd95f","line":322,"updated":"2023-03-08 18:49:43.000000000","message":"so, we inherently don\u0027t have a label in the filesystem entry 😭","commit_id":"77e3d709406854ab87ea29b75c2a9191a5d3c925"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ae68494e145eedf0f761173fe19e4626fefeeb98","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        if symbol \u003d\u003d \"boot-label\":"},{"line_number":320,"context_line":"            boot_label \u003d self._config_get_mount(\"/boot\")"},{"line_number":321,"context_line":"            boot_fs \u003d self._config_get_mkfs(boot_mount[\u0027base\u0027])"},{"line_number":322,"context_line":"            logger.debug(\"boot-label [%s]\", boot_fs[\u0027label\u0027])"},{"line_number":323,"context_line":"            print(\"%s\" % boot_fs[\u0027label\u0027])"},{"line_number":324,"context_line":"            return 0"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"62400a31_254364bd","line":322,"in_reply_to":"de46b266_386cd95f","updated":"2023-03-14 15:44:26.000000000","message":"Done","commit_id":"77e3d709406854ab87ea29b75c2a9191a5d3c925"}],"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6365266bc84d5c168f050e4df9dee95b642092bc","unresolved":true,"context_lines":[{"line_number":98,"context_line":"if ! mountpoint -q /boot; then"},{"line_number":99,"context_line":"    # Collect whatever value is in the first column of the fstab to be saved"},{"line_number":100,"context_line":"    # as the boot argument, which is required if someone tries to turn FIPS"},{"line_number":101,"context_line":"    # on this machine, as otherwise dracut will refuse to boot hte machine."},{"line_number":102,"context_line":"    BOOT_FS\u003d\"boot\u003d$(cat /etc/fstab | grep -v \"efi\" | grep \"/boot\" | awk \u0027{print $1}\u0027)\""},{"line_number":103,"context_line":"else"},{"line_number":104,"context_line":"    BOOT_FS\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"b2363086_65149f5f","line":101,"updated":"2023-03-03 22:35:49.000000000","message":"we need to remove any prior boot\u003d field from the command line which may *already* be in /etc/default/grub, before proceeding. Doing so would allow us to have an explicit fips element I think.","commit_id":"67bfa73479ea0b711638fe664f90fecd83f9271a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9fe893293f7c42213989616ed62f7fea6e72933","unresolved":false,"context_lines":[{"line_number":98,"context_line":"if ! mountpoint -q /boot; then"},{"line_number":99,"context_line":"    # Collect whatever value is in the first column of the fstab to be saved"},{"line_number":100,"context_line":"    # as the boot argument, which is required if someone tries to turn FIPS"},{"line_number":101,"context_line":"    # on this machine, as otherwise dracut will refuse to boot hte machine."},{"line_number":102,"context_line":"    BOOT_FS\u003d\"boot\u003d$(cat /etc/fstab | grep -v \"efi\" | grep \"/boot\" | awk \u0027{print $1}\u0027)\""},{"line_number":103,"context_line":"else"},{"line_number":104,"context_line":"    BOOT_FS\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1bb5f7af_7a6e4240","line":101,"in_reply_to":"b2363086_65149f5f","updated":"2023-03-06 16:31:02.000000000","message":"Done","commit_id":"67bfa73479ea0b711638fe664f90fecd83f9271a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"590673d2abf275119ed28f8ca2efe36dbad3ea7f","unresolved":true,"context_lines":[{"line_number":93,"context_line":"# earlier or in a prior version of the disk image, since we re-pack the image."},{"line_number":94,"context_line":"# Matches a boot filed, with match type label of 4-9 characters upper case,"},{"line_number":95,"context_line":"# and a UUID."},{"line_number":96,"context_line":"sed -i \u0027s/\\ boot\u003d[A-Z]\\{4,9\\}\u003d[0-9A-Fa-f]\\{8\\}-[0-9A-Fa-f]\\{4\\}-[0-9A-Fa-f]\\{4\\}-[0-9A-Fa-f]\\{4\\}-[0-9A-Fa-f]\\{12\\}//\u0027 /etc/default/grub"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# NOTE(TheJulia): When using FIPS, dracut wants to evaluate"},{"line_number":99,"context_line":"# the hmac files for the kernel. However, if /boot is located"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"6b427161_c1757cd7","line":96,"updated":"2023-03-03 22:27:51.000000000","message":"Should we just match boot\u003d.* until we get a space? It might be more future-proof, since this will potentially break if some value is put in a format we don\u0027t expect.","commit_id":"cdad74c4a21f0df74dc473d4aa3536304707c24d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6365266bc84d5c168f050e4df9dee95b642092bc","unresolved":true,"context_lines":[{"line_number":93,"context_line":"# earlier or in a prior version of the disk image, since we re-pack the image."},{"line_number":94,"context_line":"# Matches a boot filed, with match type label of 4-9 characters upper case,"},{"line_number":95,"context_line":"# and a UUID."},{"line_number":96,"context_line":"sed -i \u0027s/\\ boot\u003d[A-Z]\\{4,9\\}\u003d[0-9A-Fa-f]\\{8\\}-[0-9A-Fa-f]\\{4\\}-[0-9A-Fa-f]\\{4\\}-[0-9A-Fa-f]\\{4\\}-[0-9A-Fa-f]\\{12\\}//\u0027 /etc/default/grub"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# NOTE(TheJulia): When using FIPS, dracut wants to evaluate"},{"line_number":99,"context_line":"# the hmac files for the kernel. However, if /boot is located"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"74c85eed_ca060391","line":96,"in_reply_to":"6b427161_c1757cd7","updated":"2023-03-03 22:35:49.000000000","message":"++ I agree, boot\u003d/dev/device could be a thing.","commit_id":"cdad74c4a21f0df74dc473d4aa3536304707c24d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9fc55b1610a2c529511003bfa39422dcd7e3f93e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"# earlier or in a prior version of the disk image, since we re-pack the image."},{"line_number":94,"context_line":"# Matches a boot filed, with match type label of 4-9 characters upper case,"},{"line_number":95,"context_line":"# and a UUID."},{"line_number":96,"context_line":"sed -i \u0027s/\\ boot\u003d[A-Z]\\{4,9\\}\u003d[0-9A-Fa-f]\\{8\\}-[0-9A-Fa-f]\\{4\\}-[0-9A-Fa-f]\\{4\\}-[0-9A-Fa-f]\\{4\\}-[0-9A-Fa-f]\\{12\\}//\u0027 /etc/default/grub"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# NOTE(TheJulia): When using FIPS, dracut wants to evaluate"},{"line_number":99,"context_line":"# the hmac files for the kernel. However, if /boot is located"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"202eb637_46978add","line":96,"in_reply_to":"74c85eed_ca060391","updated":"2023-03-08 17:39:42.000000000","message":"Done","commit_id":"cdad74c4a21f0df74dc473d4aa3536304707c24d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a9a215c3a83959d560a33530d6134c7db5a24fbc","unresolved":true,"context_lines":[{"line_number":91,"context_line":"# NOTE(TheJulia): We need to remove any boot entry from the /etc/default/grub"},{"line_number":92,"context_line":"# file that may already exist, such as what was added by fips being setup on"},{"line_number":93,"context_line":"# earlier or in a prior version of the disk image, since we re-pack the image."},{"line_number":94,"context_line":"# Matches a boot filed, with match type label of 4-9 characters upper case,"},{"line_number":95,"context_line":"# and a UUID."},{"line_number":96,"context_line":"# Removes entry trailing with a space, or any entry where boot is set as"},{"line_number":97,"context_line":"# the last argument on the line."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7d81cbc4_d5b06de0","line":94,"range":{"start_line":94,"start_character":16,"end_line":94,"end_character":22},"updated":"2023-03-08 03:08:36.000000000","message":"field?","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a9a215c3a83959d560a33530d6134c7db5a24fbc","unresolved":true,"context_lines":[{"line_number":91,"context_line":"# NOTE(TheJulia): We need to remove any boot entry from the /etc/default/grub"},{"line_number":92,"context_line":"# file that may already exist, such as what was added by fips being setup on"},{"line_number":93,"context_line":"# earlier or in a prior version of the disk image, since we re-pack the image."},{"line_number":94,"context_line":"# Matches a boot filed, with match type label of 4-9 characters upper case,"},{"line_number":95,"context_line":"# and a UUID."},{"line_number":96,"context_line":"# Removes entry trailing with a space, or any entry where boot is set as"},{"line_number":97,"context_line":"# the last argument on the line."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"df6cc105_52a7c3b4","line":94,"range":{"start_line":94,"start_character":29,"end_line":94,"end_character":74},"updated":"2023-03-08 03:08:36.000000000","message":"this doesn\u0027t seem right for the latest patchset?","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9fc55b1610a2c529511003bfa39422dcd7e3f93e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"# NOTE(TheJulia): We need to remove any boot entry from the /etc/default/grub"},{"line_number":92,"context_line":"# file that may already exist, such as what was added by fips being setup on"},{"line_number":93,"context_line":"# earlier or in a prior version of the disk image, since we re-pack the image."},{"line_number":94,"context_line":"# Matches a boot filed, with match type label of 4-9 characters upper case,"},{"line_number":95,"context_line":"# and a UUID."},{"line_number":96,"context_line":"# Removes entry trailing with a space, or any entry where boot is set as"},{"line_number":97,"context_line":"# the last argument on the line."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"4317930e_c46bf019","line":94,"range":{"start_line":94,"start_character":16,"end_line":94,"end_character":22},"in_reply_to":"7d81cbc4_d5b06de0","updated":"2023-03-08 17:39:42.000000000","message":"Done","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"090cfe2dc6e2503638b9d2ee1fb756708a0ef37f","unresolved":true,"context_lines":[{"line_number":91,"context_line":"# NOTE(TheJulia): We need to remove any boot entry from the /etc/default/grub"},{"line_number":92,"context_line":"# file that may already exist, such as what was added by fips being setup on"},{"line_number":93,"context_line":"# earlier or in a prior version of the disk image, since we re-pack the image."},{"line_number":94,"context_line":"# Matches a boot filed, with match type label of 4-9 characters upper case,"},{"line_number":95,"context_line":"# and a UUID."},{"line_number":96,"context_line":"# Removes entry trailing with a space, or any entry where boot is set as"},{"line_number":97,"context_line":"# the last argument on the line."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"f81597d7_8bfbf5d6","line":94,"range":{"start_line":94,"start_character":29,"end_line":94,"end_character":74},"in_reply_to":"df6cc105_52a7c3b4","updated":"2023-03-08 16:29:47.000000000","message":"ahh, I need to fix that. In such a rush with my overflowing plate I didn\u0027t think to revise the comment.","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9fc55b1610a2c529511003bfa39422dcd7e3f93e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"# NOTE(TheJulia): We need to remove any boot entry from the /etc/default/grub"},{"line_number":92,"context_line":"# file that may already exist, such as what was added by fips being setup on"},{"line_number":93,"context_line":"# earlier or in a prior version of the disk image, since we re-pack the image."},{"line_number":94,"context_line":"# Matches a boot filed, with match type label of 4-9 characters upper case,"},{"line_number":95,"context_line":"# and a UUID."},{"line_number":96,"context_line":"# Removes entry trailing with a space, or any entry where boot is set as"},{"line_number":97,"context_line":"# the last argument on the line."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1003f844_75727fb2","line":94,"range":{"start_line":94,"start_character":29,"end_line":94,"end_character":74},"in_reply_to":"f81597d7_8bfbf5d6","updated":"2023-03-08 17:39:42.000000000","message":"Done","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a9a215c3a83959d560a33530d6134c7db5a24fbc","unresolved":true,"context_lines":[{"line_number":95,"context_line":"# and a UUID."},{"line_number":96,"context_line":"# Removes entry trailing with a space, or any entry where boot is set as"},{"line_number":97,"context_line":"# the last argument on the line."},{"line_number":98,"context_line":"sed -i \u0027s/\\(boot\u003d.\\+\\ \\|\\ boot\u003d[0-9A-Za-z/\u003d\\-]\\+\\)//\u0027 /etc/default/grub"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# NOTE(TheJulia): When using FIPS, dracut wants to evaluate"},{"line_number":101,"context_line":"# the hmac files for the kernel. However, if /boot is located"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"2034c7a4_53e8caf4","line":98,"updated":"2023-03-08 03:08:36.000000000","message":"I guess that from https://www.kernel.org/doc/html/v4.14/admin-guide/kernel-parameters.html this also matches\n\nreboot\u003d\nrcupdate.rcu_normal_after_boot\u003d\n\nbecause it will essentially match anything ending with \"boot\u003d\" right?\n\nI\u0027m not sure I\u0027m following where this *won\u0027t* have a leading space?  i.e. is it more correct to just match \" boot\u003d.+\"?","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"090cfe2dc6e2503638b9d2ee1fb756708a0ef37f","unresolved":true,"context_lines":[{"line_number":95,"context_line":"# and a UUID."},{"line_number":96,"context_line":"# Removes entry trailing with a space, or any entry where boot is set as"},{"line_number":97,"context_line":"# the last argument on the line."},{"line_number":98,"context_line":"sed -i \u0027s/\\(boot\u003d.\\+\\ \\|\\ boot\u003d[0-9A-Za-z/\u003d\\-]\\+\\)//\u0027 /etc/default/grub"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# NOTE(TheJulia): When using FIPS, dracut wants to evaluate"},{"line_number":101,"context_line":"# the hmac files for the kernel. However, if /boot is located"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ad210812_5e89bd7a","line":98,"in_reply_to":"2034c7a4_53e8caf4","updated":"2023-03-08 16:29:47.000000000","message":"Great idea to look up other params! We likely need to double check dracut, although if we add space delineation then it should be fine. For some reason, my brain kept thinking it was necessary not to. I guess the worst that could happen is a double space maybe... which we could still clean up.","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9fc55b1610a2c529511003bfa39422dcd7e3f93e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"# and a UUID."},{"line_number":96,"context_line":"# Removes entry trailing with a space, or any entry where boot is set as"},{"line_number":97,"context_line":"# the last argument on the line."},{"line_number":98,"context_line":"sed -i \u0027s/\\(boot\u003d.\\+\\ \\|\\ boot\u003d[0-9A-Za-z/\u003d\\-]\\+\\)//\u0027 /etc/default/grub"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# NOTE(TheJulia): When using FIPS, dracut wants to evaluate"},{"line_number":101,"context_line":"# the hmac files for the kernel. However, if /boot is located"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"6169bde3_6adc06c7","line":98,"in_reply_to":"ad210812_5e89bd7a","updated":"2023-03-08 17:39:42.000000000","message":"FWIW, if we just do \"boot\u003d.+\", then we end up matching everything potentially after which is why the existing regex matches a space afterwards, and then the restricted character match regex before including /, \u003d, and -. to match devices, label type designators, as well as UUIDs with, and without a space at the trailing end. Also, not match \" explicitly, so we don\u0027t break the file being understood by other scripting.","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a9a215c3a83959d560a33530d6134c7db5a24fbc","unresolved":true,"context_lines":[{"line_number":104,"context_line":"# filesystem, and convey this fact as a boot argument so dracut"},{"line_number":105,"context_line":"# does not halt the system."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"if mountpoint -q /boot; then"},{"line_number":108,"context_line":"    # Collect whatever value is in the first column of the fstab to be saved"},{"line_number":109,"context_line":"    # as the boot argument, which is required if someone tries to turn FIPS"},{"line_number":110,"context_line":"    # on this machine, as otherwise dracut will refuse to boot hte machine."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"64b2c95b_0faf0034","line":107,"updated":"2023-03-08 03:08:36.000000000","message":"Instead of this, would it be better to use a LABEL\u003d of the /boot device as specified in the block-device config?\n\nI\u0027m thinking it would work similar to how we get the root label now.  basically you\u0027d define the boot partition label in the block device config, and it would be read into a variable in the same place we read them now @\n\nhttps://opendev.org/openstack/diskimage-builder/src/branch/master/diskimage_builder/lib/disk-image-create#L337\n\nso you\u0027d have a \"boot-label\" in the config, and then read that into a variable DIB_BOOT_LABEL.  Then in here, you would set \"boot\u003dLABEL\u003d${DIB_BOOT_LABEL}\n\nIn the block-device config, you make sure your boot volume has the right label set, which can be set in the mkfs args?\n\nThis feels like a more abstract interface to me, that might serve us better if we need to deal with this across multiple distros?","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"090cfe2dc6e2503638b9d2ee1fb756708a0ef37f","unresolved":true,"context_lines":[{"line_number":104,"context_line":"# filesystem, and convey this fact as a boot argument so dracut"},{"line_number":105,"context_line":"# does not halt the system."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"if mountpoint -q /boot; then"},{"line_number":108,"context_line":"    # Collect whatever value is in the first column of the fstab to be saved"},{"line_number":109,"context_line":"    # as the boot argument, which is required if someone tries to turn FIPS"},{"line_number":110,"context_line":"    # on this machine, as otherwise dracut will refuse to boot hte machine."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"a2f11a9e_fc8ec979","line":107,"in_reply_to":"64b2c95b_0faf0034","updated":"2023-03-08 16:29:47.000000000","message":"I think that makes a lot of sense, I just didn\u0027t have a good idea of where to look. Although part of me worries we might miss a case doing so, but we likely would anyway.","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9fc55b1610a2c529511003bfa39422dcd7e3f93e","unresolved":true,"context_lines":[{"line_number":104,"context_line":"# filesystem, and convey this fact as a boot argument so dracut"},{"line_number":105,"context_line":"# does not halt the system."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"if mountpoint -q /boot; then"},{"line_number":108,"context_line":"    # Collect whatever value is in the first column of the fstab to be saved"},{"line_number":109,"context_line":"    # as the boot argument, which is required if someone tries to turn FIPS"},{"line_number":110,"context_line":"    # on this machine, as otherwise dracut will refuse to boot hte machine."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ad0b2865_9a062f61","line":107,"in_reply_to":"a2f11a9e_fc8ec979","updated":"2023-03-08 17:39:42.000000000","message":"it could be set with mkfs args, or it defaults to mkfs_boot with my barebones block config locally, so I *think* it will work either way and I think the more abstract path is actually better.","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ae68494e145eedf0f761173fe19e4626fefeeb98","unresolved":false,"context_lines":[{"line_number":104,"context_line":"# filesystem, and convey this fact as a boot argument so dracut"},{"line_number":105,"context_line":"# does not halt the system."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"if mountpoint -q /boot; then"},{"line_number":108,"context_line":"    # Collect whatever value is in the first column of the fstab to be saved"},{"line_number":109,"context_line":"    # as the boot argument, which is required if someone tries to turn FIPS"},{"line_number":110,"context_line":"    # on this machine, as otherwise dracut will refuse to boot hte machine."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"b9779357_784f2504","line":107,"in_reply_to":"ad0b2865_9a062f61","updated":"2023-03-14 15:44:26.000000000","message":"Done","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a9a215c3a83959d560a33530d6134c7db5a24fbc","unresolved":true,"context_lines":[{"line_number":107,"context_line":"if mountpoint -q /boot; then"},{"line_number":108,"context_line":"    # Collect whatever value is in the first column of the fstab to be saved"},{"line_number":109,"context_line":"    # as the boot argument, which is required if someone tries to turn FIPS"},{"line_number":110,"context_line":"    # on this machine, as otherwise dracut will refuse to boot hte machine."},{"line_number":111,"context_line":"    BOOT_FS\u003d\"boot\u003d$(cat /etc/fstab | grep -v \"efi\" | grep \"/boot\" | awk \u0027{print $1}\u0027)\""},{"line_number":112,"context_line":"else"},{"line_number":113,"context_line":"    BOOT_FS\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ac1a4b26_cc19181d","line":110,"range":{"start_line":110,"start_character":62,"end_line":110,"end_character":67},"updated":"2023-03-08 03:08:36.000000000","message":"the","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9fc55b1610a2c529511003bfa39422dcd7e3f93e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"if mountpoint -q /boot; then"},{"line_number":108,"context_line":"    # Collect whatever value is in the first column of the fstab to be saved"},{"line_number":109,"context_line":"    # as the boot argument, which is required if someone tries to turn FIPS"},{"line_number":110,"context_line":"    # on this machine, as otherwise dracut will refuse to boot hte machine."},{"line_number":111,"context_line":"    BOOT_FS\u003d\"boot\u003d$(cat /etc/fstab | grep -v \"efi\" | grep \"/boot\" | awk \u0027{print $1}\u0027)\""},{"line_number":112,"context_line":"else"},{"line_number":113,"context_line":"    BOOT_FS\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"075be4bb_aa447ebd","line":110,"range":{"start_line":110,"start_character":62,"end_line":110,"end_character":67},"in_reply_to":"ac1a4b26_cc19181d","updated":"2023-03-08 17:39:42.000000000","message":"Done","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"}],"releasenotes/notes/fix-grub-boot-kernel-commandline-1f94e49884c517c0.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a9a215c3a83959d560a33530d6134c7db5a24fbc","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the GRUB2 bootloader kernel command line where a prior ``boot``"},{"line_number":5,"context_line":"    parameter could have caused issues with the bootloader config,"},{"line_number":6,"context_line":"    and now assert the boot parameter if a */boot* partition is present"},{"line_number":7,"context_line":"    in the resulting use of the ``bootloader`` element with any"},{"line_number":8,"context_line":"    custom partitioning."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fac1c472_2c1c13f2","line":6,"updated":"2023-03-08 03:08:36.000000000","message":"this seems like it\u0027s missing a few joining words here?","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ae68494e145eedf0f761173fe19e4626fefeeb98","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the GRUB2 bootloader kernel command line where a prior ``boot``"},{"line_number":5,"context_line":"    parameter could have caused issues with the bootloader config,"},{"line_number":6,"context_line":"    and now assert the boot parameter if a */boot* partition is present"},{"line_number":7,"context_line":"    in the resulting use of the ``bootloader`` element with any"},{"line_number":8,"context_line":"    custom partitioning."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4903ad9b_71255180","line":6,"in_reply_to":"c7c3ec79_b03f6894","updated":"2023-03-14 15:44:26.000000000","message":"Done","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"090cfe2dc6e2503638b9d2ee1fb756708a0ef37f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the GRUB2 bootloader kernel command line where a prior ``boot``"},{"line_number":5,"context_line":"    parameter could have caused issues with the bootloader config,"},{"line_number":6,"context_line":"    and now assert the boot parameter if a */boot* partition is present"},{"line_number":7,"context_line":"    in the resulting use of the ``bootloader`` element with any"},{"line_number":8,"context_line":"    custom partitioning."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c7c3ec79_b03f6894","line":6,"in_reply_to":"fac1c472_2c1c13f2","updated":"2023-03-08 16:29:47.000000000","message":"Likely, I got interrupted ~10 times while working on this last week.","commit_id":"3a5f5554f30a13b69f432c046351cb85af5e73c1"}]}