)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"fa703a5ec1569714a483850e0a0f5c80ee217834","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f863dfef_d6771536","updated":"2023-04-10 23:12:50.000000000","message":"I feel like I\u0027m missing the bigger picture for this mstflint element as well as the rdma-core one[1].\n\nAll they do is install a package, so unless there is a plan to change that over time, could they just be installed with disk-image-create -p?\n\nAlso there is a suggestion this might only be required by ironic-python-agent? If so maybe these elements belong in ironic-python-agent-builder[2] instead of diskimage-builder. Some more context of purpose and roadmap would be useful here.\n\n[1] https://review.opendev.org/c/openstack/diskimage-builder/+/879920\n[2] https://opendev.org/openstack/ironic-python-agent-builder/src/branch/master/dib","commit_id":"94651741410ca386edcb5d803cd6fe9c5e93515c"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9dc0ec5f276ce9370c8d330cf1ce1182b691cad0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c400d87_ff6ef0cd","updated":"2023-04-10 19:01:25.000000000","message":"can we extend it to support the secure boot option https://github.com/Mellanox/mstflint/tree/master/kernel has flag in the element?","commit_id":"94651741410ca386edcb5d803cd6fe9c5e93515c"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"cdf6f85ad1805ca70a19e50c12a1d6221c6da797","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"91ecaf48_530bc298","in_reply_to":"f863dfef_d6771536","updated":"2023-04-13 07:44:52.000000000","message":"Thanks, Steve for your point.\nFor mstflint, as Moshe mentioned, we may need to build it from source to support the secure boot option, so we still need this element but yes I\u0027ll move it to ironic-python-agent-builder.\nFor rdma-core I\u0027ll abandon it as it\u0027s only installing a package","commit_id":"94651741410ca386edcb5d803cd6fe9c5e93515c"}],"diskimage_builder/elements/mstflint/README.rst":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9dc0ec5f276ce9370c8d330cf1ce1182b691cad0","unresolved":true,"context_lines":[{"line_number":2,"context_line":"MSTFLINT pkg install"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This element will install mstflint tool to configure Nvidia FW NICs"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b474b23c_ff2da5c7","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":67},"updated":"2023-04-10 19:01:25.000000000","message":"maybe we should explain it requires for the IPA changes to burn and config Nvidia FW","commit_id":"94651741410ca386edcb5d803cd6fe9c5e93515c"}]}