)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5ded09623621dc8415b5abb06f7d28a0a38a29c6","unresolved":true,"context_lines":[{"line_number":12,"context_line":"comma-separated list of the values, but only ``sha256`` and ``md5``"},{"line_number":13,"context_line":"supported. For backward compatibility using ``DIB_CHECKSUM\u003d1`` or option"},{"line_number":14,"context_line":"``--checksum`` in the command line still can be used to generate all"},{"line_number":15,"context_line":"supported checksums."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2dd1c60e3bfd9c823a7382b1390b1d40c52a5c97"},{"line_number":18,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"0ec2631c_36deb203","line":15,"updated":"2023-06-23 16:45:35.000000000","message":"Can you explain why? The commit message does  good job of explaining what and how but doesn\u0027t indicate why this is necessary.","commit_id":"9d261bd9192e3acfd1b62e4d5366a56f47f4451a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"22f855ffa42abae2301979422a1d941d1ac555ca","unresolved":false,"context_lines":[{"line_number":12,"context_line":"comma-separated list of the values, but only ``sha256`` and ``md5``"},{"line_number":13,"context_line":"supported. For backward compatibility using ``DIB_CHECKSUM\u003d1`` or option"},{"line_number":14,"context_line":"``--checksum`` in the command line still can be used to generate all"},{"line_number":15,"context_line":"supported checksums."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2dd1c60e3bfd9c823a7382b1390b1d40c52a5c97"},{"line_number":18,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5c9e27ec_94157130","line":15,"in_reply_to":"0ec2631c_36deb203","updated":"2023-06-23 20:41:41.000000000","message":"explain why we need backward compatibility? or why there is need in nowadays MD5 checksum? or why we need all possible checksum files at once? there are so many questions and this change will extend the usage of the checksum files generation procedure to meet all possible answers.","commit_id":"9d261bd9192e3acfd1b62e4d5366a56f47f4451a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f3972efa8cf93d407af4d15202d573b7a5d4e331","unresolved":false,"context_lines":[{"line_number":12,"context_line":"comma-separated list of the values, but only ``sha256`` and ``md5``"},{"line_number":13,"context_line":"supported. For backward compatibility using ``DIB_CHECKSUM\u003d1`` or option"},{"line_number":14,"context_line":"``--checksum`` in the command line still can be used to generate all"},{"line_number":15,"context_line":"supported checksums."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2dd1c60e3bfd9c823a7382b1390b1d40c52a5c97"},{"line_number":18,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"44e65b2c_a9942020","line":15,"in_reply_to":"1f28646e_f9d45e68","updated":"2023-07-12 16:18:59.000000000","message":"I think this is better, thanks!","commit_id":"9d261bd9192e3acfd1b62e4d5366a56f47f4451a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b77be6743df7b8ea1f0bc097b891e63a36bfe9bc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"comma-separated list of the values, but only ``sha256`` and ``md5``"},{"line_number":13,"context_line":"supported. For backward compatibility using ``DIB_CHECKSUM\u003d1`` or option"},{"line_number":14,"context_line":"``--checksum`` in the command line still can be used to generate all"},{"line_number":15,"context_line":"supported checksums."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2dd1c60e3bfd9c823a7382b1390b1d40c52a5c97"},{"line_number":18,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"f0dc63f1_394511da","line":15,"in_reply_to":"4a2b5047_d8e98da7","updated":"2023-06-23 21:55:31.000000000","message":"okay, the main idea was to have an ability generate the only one checksum file (I need only SHA256) by setting an environment variable and to retain the backward compatibility (not break other projects which uses diskimage-builder). As an additional feature we have the simple way to completely deprecate MD5 later.","commit_id":"9d261bd9192e3acfd1b62e4d5366a56f47f4451a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"dfd3cd89df97f25a3018a7d3974aad845d55a7eb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"comma-separated list of the values, but only ``sha256`` and ``md5``"},{"line_number":13,"context_line":"supported. For backward compatibility using ``DIB_CHECKSUM\u003d1`` or option"},{"line_number":14,"context_line":"``--checksum`` in the command line still can be used to generate all"},{"line_number":15,"context_line":"supported checksums."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2dd1c60e3bfd9c823a7382b1390b1d40c52a5c97"},{"line_number":18,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"4a2b5047_d8e98da7","line":15,"in_reply_to":"5c9e27ec_94157130","updated":"2023-06-23 21:42:47.000000000","message":"Explain why this change is being made. As a reviewer I\u0027m hesitant to approve a change if I don\u0027t understand the motivation to make it. Currently dib produces the hashes that you need and this change doesn\u0027t add any new hashes. I want to understand why you feel this change is helpful.\n\nSaying there are so many questions and this answers all of them doesn\u0027t actually help me understand anything...","commit_id":"9d261bd9192e3acfd1b62e4d5366a56f47f4451a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"74507bc20a37d6924002223d688cfabc0aaedfda","unresolved":true,"context_lines":[{"line_number":12,"context_line":"comma-separated list of the values, but only ``sha256`` and ``md5``"},{"line_number":13,"context_line":"supported. For backward compatibility using ``DIB_CHECKSUM\u003d1`` or option"},{"line_number":14,"context_line":"``--checksum`` in the command line still can be used to generate all"},{"line_number":15,"context_line":"supported checksums."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2dd1c60e3bfd9c823a7382b1390b1d40c52a5c97"},{"line_number":18,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1f28646e_f9d45e68","line":15,"in_reply_to":"b49813b5_f88d3630","updated":"2023-07-08 17:26:30.000000000","message":"Hi Julia, is it ok now?","commit_id":"9d261bd9192e3acfd1b62e4d5366a56f47f4451a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2ab2f2b8db0ed089b2f56e08b3405ebde47bd84b","unresolved":true,"context_lines":[{"line_number":12,"context_line":"comma-separated list of the values, but only ``sha256`` and ``md5``"},{"line_number":13,"context_line":"supported. For backward compatibility using ``DIB_CHECKSUM\u003d1`` or option"},{"line_number":14,"context_line":"``--checksum`` in the command line still can be used to generate all"},{"line_number":15,"context_line":"supported checksums."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2dd1c60e3bfd9c823a7382b1390b1d40c52a5c97"},{"line_number":18,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"b49813b5_f88d3630","line":15,"in_reply_to":"f0dc63f1_394511da","updated":"2023-07-07 18:49:50.000000000","message":"Clark\u0027s point was more that the committed commit message *should* detail why, the motivation as to the change. In this case, to me, it seems sort of obvious. MD5 is not a great idea, we keep it for backwards compatability reasons, but many people need/want/are using sha256 or sha512, and ideally we *should* generate them upfront.\n\nTypically, style wise, I explain how I got to needing the patch in the first paragraph, and then I move on to what and how.","commit_id":"9d261bd9192e3acfd1b62e4d5366a56f47f4451a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"33502bb2810e76ce80572797d14a9fb302a29efa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e230e97_18d320ed","updated":"2023-04-23 21:27:30.000000000","message":"This is very good, we can deprecate generating md5 without changing any existing behaviour.\n\nAre you interested in making the same change to ironic-python-agent-builder? https://opendev.org/openstack/ironic-python-agent-builder/src/branch/master/dib/ironic-ramdisk-base/cleanup.d/99-ramdisk-create#L89","commit_id":"179fc456291dfe9376418f7a0bf0ee765b8e4d83"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"0e4c0ea4331f19c8894961e7c77406b4ad90c5fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d02c437d_190fc73c","in_reply_to":"6e230e97_18d320ed","updated":"2023-04-23 21:39:41.000000000","message":"ok","commit_id":"179fc456291dfe9376418f7a0bf0ee765b8e4d83"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fcd273b22aa0eeb070dd3f1de64a477387262fd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a8fb79d8_56e447cf","in_reply_to":"d02c437d_190fc73c","updated":"2023-04-23 21:47:42.000000000","message":"https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/881299","commit_id":"179fc456291dfe9376418f7a0bf0ee765b8e4d83"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d7c78bbc3acd780bde937e4b0820b1a9dfa56d3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"647859ef_d029a379","updated":"2023-04-26 13:01:33.000000000","message":"recheck docker pull errors","commit_id":"b0376aa7a1b42c768e7f9734d70590e25df24eb9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7c9c969cf80a0572f6ed73cf7317424b81990cbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4b283e66_53457a85","updated":"2023-04-26 16:40:33.000000000","message":"recheck docker-compose pull error","commit_id":"b0376aa7a1b42c768e7f9734d70590e25df24eb9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b990e5e4ca7bec11c2884db8a9904e9138f881ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6b6995de_d5286de9","updated":"2023-04-26 18:09:04.000000000","message":"recheck docker-compose pull error","commit_id":"b0376aa7a1b42c768e7f9734d70590e25df24eb9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b2a3090697010d5e17d63cb14e24482d12e369c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f4920a72_29907f87","updated":"2023-04-26 21:24:07.000000000","message":"recheck docker-compose pull error","commit_id":"b0376aa7a1b42c768e7f9734d70590e25df24eb9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"755cec2b2c2fffa18d88e18305b853f3342b0922","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ae94fb6b_e5c760e2","updated":"2023-05-25 21:49:28.000000000","message":"recheck","commit_id":"14faaee7766211de57a15786bc35b0ee34a08b01"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"efafedb8866a3312db057bcd234fe8c43628c049","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d3e30e40_a096147e","updated":"2023-05-25 12:12:11.000000000","message":"recheck","commit_id":"14faaee7766211de57a15786bc35b0ee34a08b01"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"590aebd0e28f84b75ff246e9fe089e70bd21e127","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0791187b_d8e40324","updated":"2023-05-24 21:53:36.000000000","message":"recheck mirror.gra1.ovh.opendev.org errors","commit_id":"14faaee7766211de57a15786bc35b0ee34a08b01"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ba615ad4194bac5195c4129155aa77847c7d24eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a99a79ba_d910c809","in_reply_to":"0791187b_d8e40324","updated":"2023-05-24 22:25:49.000000000","message":"the gate is currently broken until we can resolve some issues with docker and 883798","commit_id":"14faaee7766211de57a15786bc35b0ee34a08b01"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ca2d101717656034cec83c830c6e082c2066b41f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fd439866_b259db05","in_reply_to":"a99a79ba_d910c809","updated":"2023-05-24 22:34:55.000000000","message":"seems strange, not only fedora failed","commit_id":"14faaee7766211de57a15786bc35b0ee34a08b01"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4e3314d058969e4c91c7173cff32a6adc274689c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"762642a2_7b91c5bb","updated":"2023-05-27 22:53:29.000000000","message":"recheck nodepool-build-image-siblings success but dib-nodepool-functional-openstack-* failed about siblings... strange","commit_id":"9dabe73df2b4b39a54326b1bbb958b74857dcb09"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f8bc6aa1b7958d3bb52ce0dc74af8716f1daf76b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"564757ec_72a6ed30","updated":"2023-05-29 09:25:10.000000000","message":"recheck test mirrors looks like fixed","commit_id":"b25d7377c155907e1b3302f82026877ce7f44581"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3bfe899339f8172595516e8b7da3d00299beae49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1ed39d51_07b24a86","updated":"2023-05-30 17:32:46.000000000","message":"recheck","commit_id":"4c99fcf90fee6f0137ef9ccd70cbfd2c5df8554f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2ab2f2b8db0ed089b2f56e08b3405ebde47bd84b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"627f1cb0_4d52b2a4","updated":"2023-07-07 18:49:50.000000000","message":"I\u0027m good with the change, but lets do a quick revision on the commit message to provide further clarity since few know where gerrit is when they are just looking at a git mirror.","commit_id":"9d261bd9192e3acfd1b62e4d5366a56f47f4451a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"021aaa4af8492ba0216357093b3683e37d97b333","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"342acddd_30d1c84e","updated":"2023-06-01 20:16:26.000000000","message":"recheck fedora and nodepool fixes merged","commit_id":"9d261bd9192e3acfd1b62e4d5366a56f47f4451a"}],"diskimage_builder/diskimage_builder.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"07daa2f835af29fd55954867764276f0f7d243c9","unresolved":true,"context_lines":[{"line_number":331,"context_line":"    ArgFlag("},{"line_number":332,"context_line":"        \"checksum-md5\","},{"line_number":333,"context_line":"        \"Generate only MD5 checksum file for the created image.\","},{"line_number":334,"context_line":"    ),"},{"line_number":335,"context_line":"    ArgInt("},{"line_number":336,"context_line":"        \"image-size\","},{"line_number":337,"context_line":"        \"Image size in GB for the created image.\","}],"source_content_type":"text/x-python","patch_set":4,"id":"89cddfe6_56af51db","line":334,"updated":"2023-04-27 04:42:20.000000000","message":"I do not feel like hard-coding the algorithms into the arguments is a good interface.  I\u0027d be happier with marking \"--checksum\" as deprecated (but keep it, and the behaviour that DIB_CHECKSUM\u003d1 does all checksums), and make the interface be a comma-separated list of checksums you do want created via `DIB_CHECKSUM\u003dmd5,sha256,...` (basically Steve\u0027s suggestion too)\n\nAs I said there are legitimate uses for needing both types of checksums, and I think giving ourselves flexibility to implement different types is better.","commit_id":"b0376aa7a1b42c768e7f9734d70590e25df24eb9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1676311d1f108259d214d0d148830ab1bc0ed34b","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    ArgFlag("},{"line_number":332,"context_line":"        \"checksum-md5\","},{"line_number":333,"context_line":"        \"Generate only MD5 checksum file for the created image.\","},{"line_number":334,"context_line":"    ),"},{"line_number":335,"context_line":"    ArgInt("},{"line_number":336,"context_line":"        \"image-size\","},{"line_number":337,"context_line":"        \"Image size in GB for the created image.\","}],"source_content_type":"text/x-python","patch_set":4,"id":"6e2a6544_eb703a64","line":334,"in_reply_to":"89cddfe6_56af51db","updated":"2023-05-24 20:35:13.000000000","message":"Done","commit_id":"b0376aa7a1b42c768e7f9734d70590e25df24eb9"}],"diskimage_builder/lib/common-functions":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"df0a3dac8439b1e5fc298d3e52eb8a2e059118ac","unresolved":true,"context_lines":[{"line_number":74,"context_line":"      # no tty).  Waiting for just these processes is a bit of hacky"},{"line_number":75,"context_line":"      # workaround ..."},{"line_number":76,"context_line":"      declare -a wait_for"},{"line_number":77,"context_line":"      [ \"$DIB_CHECKSUM\" \u003d\u003d \"sha256\" ] || md5sum $1 \u003e $1.md5 \u0026 wait_for+\u003d($!)"},{"line_number":78,"context_line":"      [ \"$DIB_CHECKSUM\" \u003d\u003d \"md5\" ] || sha256sum $1 \u003e $1.sha256 \u0026 wait_for+\u003d($!)"},{"line_number":79,"context_line":"      wait \"${wait_for[@]}\""},{"line_number":80,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"b1d10528_3f519dc7","line":77,"updated":"2023-04-24 06:28:28.000000000","message":"How is this maintaining the backwards compatibility of doing both if DIB_CHECKSUM\u003d1?","commit_id":"056bab5eeed3b992390adde765397ea83f661289"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6406271374cef95afbc6b47a941ddc1e6d67ea00","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      # no tty).  Waiting for just these processes is a bit of hacky"},{"line_number":75,"context_line":"      # workaround ..."},{"line_number":76,"context_line":"      declare -a wait_for"},{"line_number":77,"context_line":"      [ \"$DIB_CHECKSUM\" \u003d\u003d \"sha256\" ] || md5sum $1 \u003e $1.md5 \u0026 wait_for+\u003d($!)"},{"line_number":78,"context_line":"      [ \"$DIB_CHECKSUM\" \u003d\u003d \"md5\" ] || sha256sum $1 \u003e $1.sha256 \u0026 wait_for+\u003d($!)"},{"line_number":79,"context_line":"      wait \"${wait_for[@]}\""},{"line_number":80,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"c2079dc5_f66a15fe","line":77,"in_reply_to":"b1d10528_3f519dc7","updated":"2023-04-24 06:43:51.000000000","message":"this is backward compatible. if DIB_CHECKSUM\u003d1 the both md5sum and sha256sum executed.","commit_id":"056bab5eeed3b992390adde765397ea83f661289"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e39271187ae16cd721ac7adfaf72857576e34a8b","unresolved":true,"context_lines":[{"line_number":74,"context_line":"      # no tty).  Waiting for just these processes is a bit of hacky"},{"line_number":75,"context_line":"      # workaround ..."},{"line_number":76,"context_line":"      declare -a wait_for"},{"line_number":77,"context_line":"      [ \"$DIB_CHECKSUM\" \u003d\u003d \"sha256\" ] || md5sum $1 \u003e $1.md5 \u0026 wait_for+\u003d($!)"},{"line_number":78,"context_line":"      [ \"$DIB_CHECKSUM\" \u003d\u003d \"md5\" ] || sha256sum $1 \u003e $1.sha256 \u0026 wait_for+\u003d($!)"},{"line_number":79,"context_line":"      wait \"${wait_for[@]}\""},{"line_number":80,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ec8a72d5_760d2314","line":77,"in_reply_to":"c2079dc5_f66a15fe","updated":"2023-04-24 11:04:27.000000000","message":"ok ... I see it now; easy to miss when you\u0027re reading it.  for mine, for a few lines an if statement is more maintainable.  Also this restricts you to one or the other -- we might need other hashes in the future, so if we\u0027re not going to just do them all as we do now, we should make it so we can choose any combo.\n\nThere\u0027s no documentation that DIB_CHECKSUM is a 0/1 variable -- the only way it\u0027s been exposed in a documented fashion is via \"--checksum\".  However, clearly it is used as an env variable in several places so we should match \"1\".  \n\nI think I\u0027d prefer to just see something like a new --checksum-algs\u003d\u003calg,...\u003e.  Leave --checksum alone and people that want different options can use the new arg.\n\n```\n# for backwards compat 1 selects md5/sha256\nif [[ ${DIB_CHECKSUM} \u003d\u003d \"1\" ]]; then\n  DIB_CHECKSUM_ALGS\u003d\"sha256,md5sum\"\nfi\n\nif [[ $DIB_CHECKSUM_ALGS \u003d~ sha256 ]]; then\n ...\nfi\n\nif [[ $DIB_CHECKSUM_ALGS \u003d~ md5sum ]]; then\n ...\nfi\n```","commit_id":"056bab5eeed3b992390adde765397ea83f661289"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fc10a8dad0e20040d95a55f0200c148a34353ac3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      # no tty).  Waiting for just these processes is a bit of hacky"},{"line_number":75,"context_line":"      # workaround ..."},{"line_number":76,"context_line":"      declare -a wait_for"},{"line_number":77,"context_line":"      [ \"$DIB_CHECKSUM\" \u003d\u003d \"sha256\" ] || md5sum $1 \u003e $1.md5 \u0026 wait_for+\u003d($!)"},{"line_number":78,"context_line":"      [ \"$DIB_CHECKSUM\" \u003d\u003d \"md5\" ] || sha256sum $1 \u003e $1.sha256 \u0026 wait_for+\u003d($!)"},{"line_number":79,"context_line":"      wait \"${wait_for[@]}\""},{"line_number":80,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba25edeb_a39a84c6","line":77,"in_reply_to":"ec8a72d5_760d2314","updated":"2023-04-24 11:28:57.000000000","message":"we really need to complicate what is already there? I will add the new options with  documentation as a followup. please merge this.","commit_id":"056bab5eeed3b992390adde765397ea83f661289"}],"releasenotes/notes/dib-checksum-3d0d9af8778176be.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"df0a3dac8439b1e5fc298d3e52eb8a2e059118ac","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    specific the variable can be set tp the ``sha256`` or ``md5`` value to"},{"line_number":6,"context_line":"    generate the only one checksum file specified. The default behavior is set"},{"line_number":7,"context_line":"    it to the ``1`` or use ``--checksum`` command line option to generate all"},{"line_number":8,"context_line":"    checksum files."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"755f3099_e129466d","line":8,"updated":"2023-04-24 06:28:28.000000000","message":"This should be documented somewhere; it\u0027s not discoverable at all.  I\u0027m not sure we really intended to export DIB_CHECKSUM (rather have people use it via --checksum) but that ship has surely sailed.\n\nThis should also incorporate with the new diskimage_builder/diskimage_builder.py tool.  \n\nI think probably the best way to deal with it is to add an argument something like ```--checksum-algorithms```.  Or the `--checksum` flag could gain an optional argument, I guess.  Whatever is easier but maintains backwards compat.","commit_id":"056bab5eeed3b992390adde765397ea83f661289"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"40a3e110dae4a4f260c6dda8bd5b0dafe7d138a0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    specific the variable can be set tp the ``sha256`` or ``md5`` value to"},{"line_number":6,"context_line":"    generate the only one checksum file specified. The default behavior is set"},{"line_number":7,"context_line":"    it to the ``1`` or use ``--checksum`` command line option to generate all"},{"line_number":8,"context_line":"    checksum files."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a48443a1_3cc7e193","line":8,"in_reply_to":"23696a5b_7d0871e7","updated":"2023-04-26 23:33:11.000000000","message":"Anyway I\u0027ve added both env variable and command line options (as Ian ask), so let\u0027s merge this change, and depricate whatever we want in the future patchests.","commit_id":"056bab5eeed3b992390adde765397ea83f661289"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6406271374cef95afbc6b47a941ddc1e6d67ea00","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    specific the variable can be set tp the ``sha256`` or ``md5`` value to"},{"line_number":6,"context_line":"    generate the only one checksum file specified. The default behavior is set"},{"line_number":7,"context_line":"    it to the ``1`` or use ``--checksum`` command line option to generate all"},{"line_number":8,"context_line":"    checksum files."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8345b551_7d09adb0","line":8,"in_reply_to":"755f3099_e129466d","updated":"2023-04-24 06:43:51.000000000","message":"imho no need in several checksum files at all. this change was made for deprecate the md5sum in future and to maintain backward compatibility. but if you prefer, I can made the checksum flag with and optional argument.","commit_id":"056bab5eeed3b992390adde765397ea83f661289"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eaef54b1ecade53b8d02283ed4c61ad3c38323ce","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    specific the variable can be set tp the ``sha256`` or ``md5`` value to"},{"line_number":6,"context_line":"    generate the only one checksum file specified. The default behavior is set"},{"line_number":7,"context_line":"    it to the ``1`` or use ``--checksum`` command line option to generate all"},{"line_number":8,"context_line":"    checksum files."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"23696a5b_7d0871e7","line":8,"in_reply_to":"7d1615c2_dc7eed74","updated":"2023-04-26 23:23:11.000000000","message":"We could consider documenting DIB_CHECKSUM as the recommended way of driving checksum behaviour and deprecate --checksum. We have so many env vars driving behaviour in diskimage-builder I don\u0027t think formally including this one is a real issue.","commit_id":"056bab5eeed3b992390adde765397ea83f661289"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e39271187ae16cd721ac7adfaf72857576e34a8b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    specific the variable can be set tp the ``sha256`` or ``md5`` value to"},{"line_number":6,"context_line":"    generate the only one checksum file specified. The default behavior is set"},{"line_number":7,"context_line":"    it to the ``1`` or use ``--checksum`` command line option to generate all"},{"line_number":8,"context_line":"    checksum files."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d5edfd3e_d993159c","line":8,"in_reply_to":"8345b551_7d09adb0","updated":"2023-04-24 11:04:27.000000000","message":"I forget as it\u0027s been many years, but at some point we *needed* sha256 and md5 for shade and various clouds which is why it was like this.  We may well still need it for old clouds... As noted above we might as well make it flexible if we\u0027re going to change the \"just make them all\" model.\n\nbut the bigger point is the new diskimage_buidler tool i think forces this as a boolean in the yaml, so it can only choose both or none.","commit_id":"056bab5eeed3b992390adde765397ea83f661289"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fc10a8dad0e20040d95a55f0200c148a34353ac3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    specific the variable can be set tp the ``sha256`` or ``md5`` value to"},{"line_number":6,"context_line":"    generate the only one checksum file specified. The default behavior is set"},{"line_number":7,"context_line":"    it to the ``1`` or use ``--checksum`` command line option to generate all"},{"line_number":8,"context_line":"    checksum files."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7d1615c2_dc7eed74","line":8,"in_reply_to":"d5edfd3e_d993159c","updated":"2023-04-24 11:28:57.000000000","message":"new diskimage_buidler support will be added also as a new patchset.","commit_id":"056bab5eeed3b992390adde765397ea83f661289"}]}