)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"795cb1f6607cc959d43ed15d4c7c2f4b35d5b9be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"caa578a4_d39284da","updated":"2023-05-26 03:35:34.000000000","message":"I like the idea behind this.  IIRC the \"default\" platform is amd64 not x86_64 so creating and using DIB_CONTAINERFILE_PLATFORM would allow you to do that mapping.","commit_id":"eaa7d000be312539f573f7d56c8360235fe3ee1d"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"491a4957dac974997ba94b24be923788252b9640","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea4e6304_849e3b9a","updated":"2023-06-05 15:35:05.000000000","message":"Looks good to me.","commit_id":"c19a458d59b28df9fa00eecac3a33feb8d2adda4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0dc5335dbbb065bbb2c3bc7fd954940a1169dbf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"01f5b870_50351e05","updated":"2023-07-17 14:02:53.000000000","message":"Would it make sense to have a release note?","commit_id":"0e06b4ad1a3846c7722b8771f47780a3f1fa5b85"},{"author":{"_account_id":34411,"name":"Neil Hanlon","email":"neil@shrug.pw","username":"nhanlon"},"change_message_id":"2acdfd2f7a57c99f0212878d03a35df96551cd56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ea1aab6_0a5d3d63","in_reply_to":"01f5b870_50351e05","updated":"2023-09-27 19:35:09.000000000","message":"I can add one, if that is wanted. It seems something probably worthy of a release note.","commit_id":"0e06b4ad1a3846c7722b8771f47780a3f1fa5b85"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"01ef1c809e56238329c7cf1345d447c8b7d5be5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c8f96a93_60019d14","updated":"2024-06-24 07:26:47.000000000","message":"... And then I noticed this is in merge conflict.","commit_id":"67ab4733a76e967fb43673d82ecb10256267b034"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9be374a11833a00a519544d2e3f489573a4c2b35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"43b28f6f_69e7462a","updated":"2024-06-26 00:20:49.000000000","message":"recheck","commit_id":"67ab4733a76e967fb43673d82ecb10256267b034"}],"diskimage_builder/elements/containerfile/root.d/08-containerfile":[{"author":{"_account_id":34411,"name":"Neil Hanlon","email":"neil@shrug.pw","username":"nhanlon"},"change_message_id":"167306708e9a20ea4c23cc5240c2d77bcdc28816","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"trap \"podman_cleanup\" EXIT"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"${_sudo} ${DIB_CONTAINERFILE_RUNTIME} build ${DIB_CONTAINERFILE_RUNTIME_NETWORK} --platform\u003dlinux/$ARCH -t ${_podman_build_image} -f $DIB_CONTAINERFILE_DOCKERFILE $DIB_CONTAINER_CONTEXT"},{"line_number":97,"context_line":"${_sudo} ${DIB_CONTAINERFILE_RUNTIME} run ${DIB_CONTAINERFILE_RUNTIME_NETWORK} --name ${_podman_export_container} -d ${_podman_build_image} /bin/sh"},{"line_number":98,"context_line":"# NOTE(ianw) 2021-11-10 the tar must always be sudo to write out the chroot files"},{"line_number":99,"context_line":"# as other uids"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"a63b5bb2_dd9b8f52","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":185},"updated":"2023-05-26 02:57:02.000000000","message":"this should be broken out into a named variable like DIB_CONTAINERFILE_PLATFORM or similar... will update this patch tomorrow.","commit_id":"eaa7d000be312539f573f7d56c8360235fe3ee1d"},{"author":{"_account_id":34411,"name":"Neil Hanlon","email":"neil@shrug.pw","username":"nhanlon"},"change_message_id":"44dd5e8ee010d7da4de85014de79fa8d0adb41d3","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"trap \"podman_cleanup\" EXIT"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"${_sudo} ${DIB_CONTAINERFILE_RUNTIME} build ${DIB_CONTAINERFILE_RUNTIME_NETWORK} --platform\u003dlinux/$ARCH -t ${_podman_build_image} -f $DIB_CONTAINERFILE_DOCKERFILE $DIB_CONTAINER_CONTEXT"},{"line_number":97,"context_line":"${_sudo} ${DIB_CONTAINERFILE_RUNTIME} run ${DIB_CONTAINERFILE_RUNTIME_NETWORK} --name ${_podman_export_container} -d ${_podman_build_image} /bin/sh"},{"line_number":98,"context_line":"# NOTE(ianw) 2021-11-10 the tar must always be sudo to write out the chroot files"},{"line_number":99,"context_line":"# as other uids"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"14904230_aa15b380","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":185},"in_reply_to":"a63b5bb2_dd9b8f52","updated":"2023-05-26 15:30:13.000000000","message":"Done","commit_id":"eaa7d000be312539f573f7d56c8360235fe3ee1d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0dc5335dbbb065bbb2c3bc7fd954940a1169dbf3","unresolved":true,"context_lines":[{"line_number":70,"context_line":"fi"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Enable cross-platform builds by invoking the builds with a different platform"},{"line_number":73,"context_line":"# NOTE(nhanlon) 2023-05-26: this is not perfect, as the platform argument can "},{"line_number":74,"context_line":"# have multiple \"spellings\", but this should trivially work for the platforms "},{"line_number":75,"context_line":"# DIB cares about"},{"line_number":76,"context_line":"DIB_CONTAINERFILE_PLATFORM\u003d${DIB_CONTAINERFILE_PLATFORM:-\"--platform\u003dlinux/${ARCH}\"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"98681ffe_69728a2e","line":73,"updated":"2023-07-17 14:02:53.000000000","message":"Nit: This and the next line have excess whitespace at the end of the line.","commit_id":"0e06b4ad1a3846c7722b8771f47780a3f1fa5b85"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"95df1eac93b5d911b87a7f3a08a771cc9efd6c27","unresolved":false,"context_lines":[{"line_number":70,"context_line":"fi"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Enable cross-platform builds by invoking the builds with a different platform"},{"line_number":73,"context_line":"# NOTE(nhanlon) 2023-05-26: this is not perfect, as the platform argument can "},{"line_number":74,"context_line":"# have multiple \"spellings\", but this should trivially work for the platforms "},{"line_number":75,"context_line":"# DIB cares about"},{"line_number":76,"context_line":"DIB_CONTAINERFILE_PLATFORM\u003d${DIB_CONTAINERFILE_PLATFORM:-\"--platform\u003dlinux/${ARCH}\"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"b6a802ed_ba2ff10f","line":73,"in_reply_to":"98681ffe_69728a2e","updated":"2023-08-16 10:00:22.000000000","message":"Done","commit_id":"0e06b4ad1a3846c7722b8771f47780a3f1fa5b85"}]}
