)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35960,"name":"Robin Jarry","email":"rjarry@redhat.com","username":"rjarry","status":"Red Hat"},"change_message_id":"ef188bd6141d5b0ba0b9da6e6811aa26906e238d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fcf0c905_7a5b39cb","updated":"2023-05-30 20:26:10.000000000","message":"Hey Steve, thanks for the patch. I just have one remark.","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"fce5b99a31311b7f92558ac953b778657e39b465","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eca0b069_60d58628","updated":"2023-05-31 13:42:31.000000000","message":"LGTM, we may want to follow up with a separate change removing nomodeset from defaults.","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"346f09a9d6879b7907a605b79b51c861e6e3d181","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cfb575fc_6fe23add","updated":"2023-06-01 01:03:36.000000000","message":"We might want a release note because this changes the behavior.","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"acc4add35588691e3cd400efed24e5c5846e9ccc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2d76b134_d77e3eb7","in_reply_to":"eca0b069_60d58628","updated":"2024-08-15 18:25:42.000000000","message":"++","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"}],"diskimage_builder/elements/bootloader/README.rst":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ea5eaf860dc34e0bb43a2f31540dd44b352032be","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  5 seconds.  Set this to 0 (no timeout) for fast boot times."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ``DIB_BOOTLOADER_DEFAULT_CMDLINE`` sets parameters that are appended"},{"line_number":14,"context_line":"to the ``GRUB_CMDLINE_LINUX_DEFAULT`` values in ``grub.cfg`` configuration. It"},{"line_number":15,"context_line":"defaults to ``nofb nomodeset gfxpayload\u003dtext`` when it is unset."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* ``DIB_BOOTLOADER_SERIAL_CONSOLE`` sets the serial device to be"},{"line_number":18,"context_line":"  used as a console. It defaults to ``hvc0`` for PowerPC, "}],"source_content_type":"text/x-rst","patch_set":1,"id":"301b1b46_9c5155bf","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":64},"updated":"2023-05-29 21:56:04.000000000","message":"not clear, and would confusing folks not familiar with tripleo workflow. this should describe both usages of the variable.","commit_id":"05227479c34ee2c1922a43b14b4510e0d7aebf04"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"46c4cead5e2b4f8102a414cd256b28a1811301d6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  5 seconds.  Set this to 0 (no timeout) for fast boot times."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ``DIB_BOOTLOADER_DEFAULT_CMDLINE`` sets parameters that are appended"},{"line_number":14,"context_line":"to the ``GRUB_CMDLINE_LINUX_DEFAULT`` values in ``grub.cfg`` configuration. It"},{"line_number":15,"context_line":"defaults to ``nofb nomodeset gfxpayload\u003dtext`` when it is unset."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* ``DIB_BOOTLOADER_SERIAL_CONSOLE`` sets the serial device to be"},{"line_number":18,"context_line":"  used as a console. It defaults to ``hvc0`` for PowerPC, "}],"source_content_type":"text/x-rst","patch_set":1,"id":"259843fd_ed017916","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":64},"in_reply_to":"08d03554_f6142337","updated":"2023-05-29 22:02:52.000000000","message":"Done","commit_id":"05227479c34ee2c1922a43b14b4510e0d7aebf04"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"04512ba51b0188813f618c6a45a96bf38ac86ffc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  5 seconds.  Set this to 0 (no timeout) for fast boot times."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ``DIB_BOOTLOADER_DEFAULT_CMDLINE`` sets parameters that are appended"},{"line_number":14,"context_line":"to the ``GRUB_CMDLINE_LINUX_DEFAULT`` values in ``grub.cfg`` configuration. It"},{"line_number":15,"context_line":"defaults to ``nofb nomodeset gfxpayload\u003dtext`` when it is unset."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* ``DIB_BOOTLOADER_SERIAL_CONSOLE`` sets the serial device to be"},{"line_number":18,"context_line":"  used as a console. It defaults to ``hvc0`` for PowerPC, "}],"source_content_type":"text/x-rst","patch_set":1,"id":"3bf27d47_62c81c4e","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":64},"in_reply_to":"259843fd_ed017916","updated":"2023-05-29 22:46:19.000000000","message":"much better","commit_id":"05227479c34ee2c1922a43b14b4510e0d7aebf04"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8579dc4fcacfefc1096535d8948c273d2f43fddd","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  5 seconds.  Set this to 0 (no timeout) for fast boot times."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ``DIB_BOOTLOADER_DEFAULT_CMDLINE`` sets parameters that are appended"},{"line_number":14,"context_line":"to the ``GRUB_CMDLINE_LINUX_DEFAULT`` values in ``grub.cfg`` configuration. It"},{"line_number":15,"context_line":"defaults to ``nofb nomodeset gfxpayload\u003dtext`` when it is unset."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* ``DIB_BOOTLOADER_SERIAL_CONSOLE`` sets the serial device to be"},{"line_number":18,"context_line":"  used as a console. It defaults to ``hvc0`` for PowerPC, "}],"source_content_type":"text/x-rst","patch_set":1,"id":"08d03554_f6142337","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":64},"in_reply_to":"301b1b46_9c5155bf","updated":"2023-05-29 22:01:04.000000000","message":"Done, I\u0027ve repeated the sentence on line 22","commit_id":"05227479c34ee2c1922a43b14b4510e0d7aebf04"}],"diskimage_builder/elements/bootloader/environment.d/10-bootloader-default-cmdline":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"fce5b99a31311b7f92558ac953b778657e39b465","unresolved":false,"context_lines":[{"line_number":1,"context_line":"if [ ! -v DIB_BOOTLOADER_DEFAULT_CMDLINE ]; then"},{"line_number":2,"context_line":"    # DIB_BOOTLOADER_DEFAULT_CMDLINE is unset"},{"line_number":3,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d\"nofb nomodeset gfxpayload\u003dtext\""},{"line_number":4,"context_line":"else"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7cd07eb1_facb1f06","line":1,"range":{"start_line":1,"start_character":7,"end_line":1,"end_character":9},"updated":"2023-05-31 13:42:31.000000000","message":"BASH(1) manual:\n-v varname\n              True if the shell variable varname is set (has been assigned a value).\n\nNice, I was not aware of this.","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"},{"author":{"_account_id":35960,"name":"Robin Jarry","email":"rjarry@redhat.com","username":"rjarry","status":"Red Hat"},"change_message_id":"ef188bd6141d5b0ba0b9da6e6811aa26906e238d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"if [ ! -v DIB_BOOTLOADER_DEFAULT_CMDLINE ]; then"},{"line_number":2,"context_line":"    # DIB_BOOTLOADER_DEFAULT_CMDLINE is unset"},{"line_number":3,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d\"nofb nomodeset gfxpayload\u003dtext\""},{"line_number":4,"context_line":"else"},{"line_number":5,"context_line":"    # DIB_BOOTLOADER_DEFAULT_CMDLINE is set to empty string or other value"},{"line_number":6,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d${DIB_BOOTLOADER_DEFAULT_CMDLINE}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9b7631c9_f3fc53b9","line":3,"updated":"2023-05-30 20:26:10.000000000","message":"We should get rid of that nomodeset option for good. What about removing this?","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"acc4add35588691e3cd400efed24e5c5846e9ccc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"if [ ! -v DIB_BOOTLOADER_DEFAULT_CMDLINE ]; then"},{"line_number":2,"context_line":"    # DIB_BOOTLOADER_DEFAULT_CMDLINE is unset"},{"line_number":3,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d\"nofb nomodeset gfxpayload\u003dtext\""},{"line_number":4,"context_line":"else"},{"line_number":5,"context_line":"    # DIB_BOOTLOADER_DEFAULT_CMDLINE is set to empty string or other value"},{"line_number":6,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d${DIB_BOOTLOADER_DEFAULT_CMDLINE}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"32e59f7a_d9eb98c2","line":3,"in_reply_to":"9b7631c9_f3fc53b9","updated":"2024-08-15 18:25:42.000000000","message":"I think we should just nuke the options entirely. It doesn\u0027t make sense to keep them moving forward since they are operationally counter prodictive to the prior console fixes. Specifically, we *want* the frame buffer to reduce the interrupt hit on the outputs.","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f3f58280efbda27f5e5b7ea253d01536995cc66f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"if [ ! -v DIB_BOOTLOADER_DEFAULT_CMDLINE ]; then"},{"line_number":2,"context_line":"    # DIB_BOOTLOADER_DEFAULT_CMDLINE is unset"},{"line_number":3,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d\"nofb nomodeset gfxpayload\u003dtext\""},{"line_number":4,"context_line":"else"},{"line_number":5,"context_line":"    # DIB_BOOTLOADER_DEFAULT_CMDLINE is set to empty string or other value"},{"line_number":6,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d${DIB_BOOTLOADER_DEFAULT_CMDLINE}"},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":"export DIB_BOOTLOADER_SERIAL_CONSOLE\u003d${DIB_BOOTLOADER_SERIAL_CONSOLE:-\"\"}"},{"line_number":9,"context_line":"if [ ! -v DIB_BOOTLOADER_VIRTUAL_TERMINAL ]; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"c6a5660e_d7b6391d","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":75},"updated":"2023-05-29 22:50:40.000000000","message":"imho these three lines can be ommited","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b27ba5e122a9ba7ad1d0d921f08e7e9f31482b90","unresolved":false,"context_lines":[{"line_number":1,"context_line":"if [ ! -v DIB_BOOTLOADER_DEFAULT_CMDLINE ]; then"},{"line_number":2,"context_line":"    # DIB_BOOTLOADER_DEFAULT_CMDLINE is unset"},{"line_number":3,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d\"nofb nomodeset gfxpayload\u003dtext\""},{"line_number":4,"context_line":"else"},{"line_number":5,"context_line":"    # DIB_BOOTLOADER_DEFAULT_CMDLINE is set to empty string or other value"},{"line_number":6,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d${DIB_BOOTLOADER_DEFAULT_CMDLINE}"},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":"export DIB_BOOTLOADER_SERIAL_CONSOLE\u003d${DIB_BOOTLOADER_SERIAL_CONSOLE:-\"\"}"},{"line_number":9,"context_line":"if [ ! -v DIB_BOOTLOADER_VIRTUAL_TERMINAL ]; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"25302305_0e6842b2","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":75},"in_reply_to":"2adca8c8_6305e25d","updated":"2023-05-29 23:21:50.000000000","message":"Ack","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"3afe07f4286d1cccbd837a073a7387c7ac12a046","unresolved":true,"context_lines":[{"line_number":1,"context_line":"if [ ! -v DIB_BOOTLOADER_DEFAULT_CMDLINE ]; then"},{"line_number":2,"context_line":"    # DIB_BOOTLOADER_DEFAULT_CMDLINE is unset"},{"line_number":3,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d\"nofb nomodeset gfxpayload\u003dtext\""},{"line_number":4,"context_line":"else"},{"line_number":5,"context_line":"    # DIB_BOOTLOADER_DEFAULT_CMDLINE is set to empty string or other value"},{"line_number":6,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d${DIB_BOOTLOADER_DEFAULT_CMDLINE}"},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":"export DIB_BOOTLOADER_SERIAL_CONSOLE\u003d${DIB_BOOTLOADER_SERIAL_CONSOLE:-\"\"}"},{"line_number":9,"context_line":"if [ ! -v DIB_BOOTLOADER_VIRTUAL_TERMINAL ]; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"2adca8c8_6305e25d","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":75},"in_reply_to":"c6a5660e_d7b6391d","updated":"2023-05-29 23:11:48.000000000","message":"This is how environment.d works. The environment values come from the build host, outside the chroot. By doing an export those values are now available inside the chroot and can be used by later phases (in this case the finalise phase in finalise.d/50-bootloader)","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6d96f1d20cafbe507cf2a3e202a960bfb4439896","unresolved":true,"context_lines":[{"line_number":9,"context_line":"if [ ! -v DIB_BOOTLOADER_VIRTUAL_TERMINAL ]; then"},{"line_number":10,"context_line":"    # DIB_BOOTLOADER_VIRTUAL_TERMINAL is unset"},{"line_number":11,"context_line":"    export DIB_BOOTLOADER_VIRTUAL_TERMINAL\u003dtty0"},{"line_number":12,"context_line":"else"},{"line_number":13,"context_line":"    # DIB_BOOTLOADER_VIRTUAL_TERMINAL is set to empty string or other value"},{"line_number":14,"context_line":"    export DIB_BOOTLOADER_VIRTUAL_TERMINAL\u003d${DIB_BOOTLOADER_VIRTUAL_TERMINAL}"},{"line_number":15,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9fe2d015_ef9d8d9e","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":77},"updated":"2023-05-29 22:52:43.000000000","message":"these too","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b27ba5e122a9ba7ad1d0d921f08e7e9f31482b90","unresolved":false,"context_lines":[{"line_number":9,"context_line":"if [ ! -v DIB_BOOTLOADER_VIRTUAL_TERMINAL ]; then"},{"line_number":10,"context_line":"    # DIB_BOOTLOADER_VIRTUAL_TERMINAL is unset"},{"line_number":11,"context_line":"    export DIB_BOOTLOADER_VIRTUAL_TERMINAL\u003dtty0"},{"line_number":12,"context_line":"else"},{"line_number":13,"context_line":"    # DIB_BOOTLOADER_VIRTUAL_TERMINAL is set to empty string or other value"},{"line_number":14,"context_line":"    export DIB_BOOTLOADER_VIRTUAL_TERMINAL\u003d${DIB_BOOTLOADER_VIRTUAL_TERMINAL}"},{"line_number":15,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"f104bd9e_4487a3a9","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":77},"in_reply_to":"9fe2d015_ef9d8d9e","updated":"2023-05-29 23:21:50.000000000","message":"Ack","commit_id":"ffeebbae8a8911df5a2067d1c0725208e2b6efb4"}]}