)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b7a90c475f18b6f6769c188585c8781d625e07db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"94cefe14_c03667c5","updated":"2023-08-28 17:54:37.000000000","message":"that looks quite reasonable to me","commit_id":"1a17eef9715a16a0cb729415bdc45d493e484652"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7698acc13b640a67856f7c97507e44bf819c69f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2e2e93d6_b3bf1fe3","updated":"2023-09-05 18:27:24.000000000","message":"Looks good to me, but realistically there should be a release note added. If you revise this again, please add one.","commit_id":"18b08476b35ff11078286d41e123366c589f92cf"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"855a4a6a12401f9ae0309e8defc4aba8a796c3bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0c10a269_b1264c67","in_reply_to":"2e2e93d6_b3bf1fe3","updated":"2023-09-06 13:53:42.000000000","message":"Fixed !","commit_id":"18b08476b35ff11078286d41e123366c589f92cf"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"855a4a6a12401f9ae0309e8defc4aba8a796c3bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7dcfae28_67b30ab9","updated":"2023-09-06 13:53:42.000000000","message":"Release notes added. I think it is now ready for merging","commit_id":"8b42ba73bc4f1c1bb9bd4d5f9454845d4ff4abad"},{"author":{"_account_id":36317,"name":"Armagan Karatosun","display_name":"armagankaratosun","email":"armagankaratosun@hotmail.com","username":"armagankaratosun"},"change_message_id":"6e3f6696e8870356ea55b5629136815505f124ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"60d04620_a74b5191","updated":"2023-09-11 08:16:55.000000000","message":"looks reasonable","commit_id":"8b42ba73bc4f1c1bb9bd4d5f9454845d4ff4abad"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"33803a9eae84bcd580a9925b3b5d1907fa521d96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ed52fa82_c242e049","updated":"2023-09-06 15:02:40.000000000","message":"recheck","commit_id":"8b42ba73bc4f1c1bb9bd4d5f9454845d4ff4abad"}],"diskimage_builder/elements/fail2ban/post-install.d/80-enable-fail2ban-service":[{"author":{"_account_id":36317,"name":"Armagan Karatosun","display_name":"armagankaratosun","email":"armagankaratosun@hotmail.com","username":"armagankaratosun"},"change_message_id":"d546642f462bf3f517bb4b95eabf1b5daa1560ff","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"case \"$DIB_INIT_SYSTEM\" in"},{"line_number":26,"context_line":"    systemd)"},{"line_number":27,"context_line":"        if [[ $DISTRO_NAME \u003d~ (ubuntu|rocky|debian)$ ]]; then"},{"line_number":28,"context_line":"            systemctl enable fail2ban.service"},{"line_number":29,"context_line":"        fi"},{"line_number":30,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"117a7046_21c3da75","line":27,"updated":"2023-08-24 09:20:57.000000000","message":"Either we need to consider adding more distros (e.g., centos, rhel, etc.) here or should consider having a more elegant way to figure out whether we have systemd or not, instead of depending on the distro. I think the 2nd approach would be more bulletproof.","commit_id":"073cce5ebb67f57eb3eebe2dc5575b17e0b80c9a"},{"author":{"_account_id":36317,"name":"Armagan Karatosun","display_name":"armagankaratosun","email":"armagankaratosun@hotmail.com","username":"armagankaratosun"},"change_message_id":"c8c687588cf9861e92c237df109eb5c57af7cd75","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"case \"$DIB_INIT_SYSTEM\" in"},{"line_number":26,"context_line":"    systemd)"},{"line_number":27,"context_line":"        if [[ $DISTRO_NAME \u003d~ (ubuntu|rocky|debian)$ ]]; then"},{"line_number":28,"context_line":"            systemctl enable fail2ban.service"},{"line_number":29,"context_line":"        fi"},{"line_number":30,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"13336449_b05a5f76","line":27,"in_reply_to":"117a7046_21c3da75","updated":"2023-08-24 19:53:28.000000000","message":"Done","commit_id":"073cce5ebb67f57eb3eebe2dc5575b17e0b80c9a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"34f5a225f8965a0eb789177fed4692732c771c24","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"for file in $DIB_FAIL2BAN_CONF; do"},{"line_number":44,"context_line":"    if [ -f $file ]; then"},{"line_number":45,"context_line":"        echo \"$file is not a valid fail2ban file\""},{"line_number":46,"context_line":"        echo \"We need a proper file DIB_FAIL2BAN.CONF\""},{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"a8f52bb8_91ed28a6","line":45,"updated":"2023-09-15 16:45:03.000000000","message":"nit: This implies you\u0027re checking syntax and not location; if you have to revise this I\u0027d suggest explicitly stating that the file doesn\u0027t exist or is not found.","commit_id":"8b42ba73bc4f1c1bb9bd4d5f9454845d4ff4abad"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"721ce7801d19844b67641cad1ee82d6ee5d70be5","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"for file in $DIB_FAIL2BAN_CONF; do"},{"line_number":44,"context_line":"    if [ -f $file ]; then"},{"line_number":45,"context_line":"        echo \"$file is not a valid fail2ban file\""},{"line_number":46,"context_line":"        echo \"We need a proper file DIB_FAIL2BAN.CONF\""},{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a3fd395_6cd3f870","line":45,"in_reply_to":"a8f52bb8_91ed28a6","updated":"2023-09-27 12:46:15.000000000","message":"I will try to merge this as it is for now. If I get more reviews which require more edits I will update the error msg. \nthx","commit_id":"8b42ba73bc4f1c1bb9bd4d5f9454845d4ff4abad"}],"diskimage_builder/elements/fail2ban/root.d/60-copy-fail2ban-config":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"10c37d19c1f2a1a75fed4dc3f24f93a460819d6a","unresolved":true,"context_lines":[{"line_number":23,"context_line":"set -eu"},{"line_number":24,"context_line":"set -o pipefail"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"if [[ -n ${DIB_FAIL2BAN_CONF:-} ]]; then"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    sudo mkdir $TARGET_ROOT/etc/fail2ban"},{"line_number":29,"context_line":"    sudo cp ${DIB_FAIL2BAN_CONF} $TARGET_ROOT/etc/fail2ban/jail.local"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"0acb6aea_e2f084e3","line":26,"updated":"2023-10-06 13:30:46.000000000","message":"I suspect this is where a use of the element would fail without this value, and I think it would be good to provide some human friendly output if not defined, otherwise is there a default configuration which can be used? They really are larger questions than this patch though.","commit_id":"8b42ba73bc4f1c1bb9bd4d5f9454845d4ff4abad"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"386f5fb57e48afb3042e5d1466944e0939cb4f3b","unresolved":true,"context_lines":[{"line_number":23,"context_line":"set -eu"},{"line_number":24,"context_line":"set -o pipefail"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"if [[ -n ${DIB_FAIL2BAN_CONF:-} ]]; then"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    sudo mkdir $TARGET_ROOT/etc/fail2ban"},{"line_number":29,"context_line":"    sudo cp ${DIB_FAIL2BAN_CONF} $TARGET_ROOT/etc/fail2ban/jail.local"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"6ca4feeb_66396459","line":26,"in_reply_to":"0acb6aea_e2f084e3","updated":"2023-11-25 20:33:11.000000000","message":"This question bothered for a while to be honest.\nIt is true that if you dont define it, the element fails. That however is specified clearly in the Readme file of the element so I thought it would be enough.\nIf you still think that an output is needed I will add it though.\nNow as far as a default goes, we \"could\" maybe find some nice files online but that would I think defeat the purpose, which is to provide a custom file anyway.\nI am open to suggestions.\nAs you said though this is a just a small helpful element and for sure there are larger questions.","commit_id":"8b42ba73bc4f1c1bb9bd4d5f9454845d4ff4abad"}]}