)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"843125403d69a084180e5576f7840d4e6a5167d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"35a1e24d_d039205c","updated":"2023-12-14 15:00:29.000000000","message":"looks good, I think we need the multipath -r command as well.\nAnd some #noqa 😊","commit_id":"c3da182254f7da794b6cd2cf96163076403bdf5f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0eb9fe1331dd1fea40f1ab4f378a67ff53b5cddf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0f07c37f_9e80b3b2","updated":"2023-12-15 15:51:31.000000000","message":"Removing my vote, we have new information in the dowstream bugreport.\nThis might need more work.","commit_id":"ae2823a86e44335bbb9de52a74ade844a49280fd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5319572e787bc8bdaef2145fa61c74605dc99abb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3743641a_f032b282","updated":"2023-12-15 15:30:20.000000000","message":"lgtm","commit_id":"ae2823a86e44335bbb9de52a74ade844a49280fd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ee1e4da28b585573526edd967eff83f03d2cadbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"99936734_f37593cd","updated":"2024-01-08 09:12:24.000000000","message":"Looks good to me.","commit_id":"b35e7db0fde88bd9a1f8ef3eac2024c1183b202b"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"98f8c158cab0f16d9dc3b10b40691e7c3bce9eb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bb49386d_a6c14f3d","updated":"2024-01-04 19:43:28.000000000","message":"We have confirmation from a san backed deployment that this is working now","commit_id":"b35e7db0fde88bd9a1f8ef3eac2024c1183b202b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"42a799ef08d503ddb99b11b1f86c05b04ebcaf6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7114278c_94dc83a3","updated":"2024-01-04 19:58:29.000000000","message":"Yeah, that failure looks unrelated, and I can\u0027t help but wonder if we\u0027re really approaching time to drop the centos7 stuffs.  Overall, the changes seem to make sense to me.","commit_id":"b35e7db0fde88bd9a1f8ef3eac2024c1183b202b"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4ee9c6e775756ab5d56cc1cd4f6c84193314c928","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d7df4569_85287ec9","updated":"2024-01-04 19:42:43.000000000","message":"recheck dib-nodepool-functional-openstack-centos-7-src","commit_id":"b35e7db0fde88bd9a1f8ef3eac2024c1183b202b"}],"diskimage_builder/elements/growvols/static/usr/local/sbin/growvols":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0daa678765c1dbbf34f293c9f24a83878c8a972d","unresolved":true,"context_lines":[{"line_number":327,"context_line":"    if disk[\u0027TYPE\u0027] \u003d\u003d \u0027disk\u0027:"},{"line_number":328,"context_line":"        disk_name \u003d disk[\u0027KNAME\u0027]"},{"line_number":329,"context_line":"        return len([d for d in devices if d[\u0027PKNAME\u0027] \u003d\u003d disk_name]) + 1"},{"line_number":330,"context_line":"    if disk[\u0027TYPE\u0027] \u003d\u003d \u0027mpath\u0027:"},{"line_number":331,"context_line":"        max_dm \u003d 0"},{"line_number":332,"context_line":"        for d in devices:"},{"line_number":333,"context_line":"            dev_name \u003d d[\u0027KNAME\u0027]"},{"line_number":334,"context_line":"            if not dev_name.startswith(\u0027dm-\u0027):"},{"line_number":335,"context_line":"                continue"},{"line_number":336,"context_line":"            max_dm \u003d max(max_dm, int(dev_name[3:]))"},{"line_number":337,"context_line":"        return max_dm + 1"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"def find_next_device_name(devices, disk, partnum):"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"e0cae10f_5f4ab3b1","line":337,"range":{"start_line":330,"start_character":0,"end_line":337,"end_character":25},"updated":"2023-12-14 00:17:45.000000000","message":"I don\u0027t think we can use dm-N to figure out the next partition number.\nIf we look at the blow data we have \"dm-1\" to \"dm-5\" - partitions on dm-0 (mpatha). Then \"dm-6\", \"dm-7\" etc is LVM on one of those partitions \"dm-4\", and dm-8 is LVM but on \"dm-7\". We have dm-N all the way to dm-16. AFICT we also have duplicates in the lsblk output.\n\nWould we not end up returning 17 here? - and use that as the partition number in the sgdisk command?\n\nDon\u0027t we need to find the device with TYPE\u003d\"mpath\", then use it\u0027s NAME as the basename for partitions. Names are configurable in multipath.conf (see `alias_prefix` in Manual page multipath.conf(5) - it is also possible to alias devices based on WWID so it can be mpath devices are named \"green\", \"yellow\", \"blue\"). Partitions will be the ones with \"PKNAME\" \u003d\u003d \"KNAME of the mpath device\".\n\n\n```\nKNAME\u003d\"dm-0\" PKNAME\u003d\"sda\" NAME\u003d\"mpatha\" LABEL\u003d\"\" TYPE\u003d\"mpath\" FSTYPE\u003d\"\" MOUNTPOINT\u003d\"\"\nKNAME\u003d\"dm-1\" PKNAME\u003d\"dm-0\" NAME\u003d\"mpatha1\" LABEL\u003d\"MKFS_ESP\" TYPE\u003d\"part\" FSTYPE\u003d\"vfat\" MOUNTPOINT\u003d\"/boot/efi\"\nKNAME\u003d\"dm-2\" PKNAME\u003d\"dm-0\" NAME\u003d\"mpatha2\" LABEL\u003d\"\" TYPE\u003d\"part\" FSTYPE\u003d\"\" MOUNTPOINT\u003d\"\"\nKNAME\u003d\"dm-3\" PKNAME\u003d\"dm-0\" NAME\u003d\"mpatha3\" LABEL\u003d\"mkfs_boot\" TYPE\u003d\"part\" FSTYPE\u003d\"ext4\" MOUNTPOINT\u003d\"/boot\"\nKNAME\u003d\"dm-4\" PKNAME\u003d\"dm-0\" NAME\u003d\"mpatha4\" LABEL\u003d\"\" TYPE\u003d\"part\" FSTYPE\u003d\"LVM2_member\" MOUNTPOINT\u003d\"\"\nKNAME\u003d\"dm-5\" PKNAME\u003d\"dm-0\" NAME\u003d\"mpatha5\" LABEL\u003d\"config-2\" TYPE\u003d\"part\" FSTYPE\u003d\"iso9660\" MOUNTPOINT\u003d\"\"\n```\n\nDuplicates for each \"path\" PKNAMES sda/sdb/sdc/sdd - partitions (mpathN) is listed again in output.\n```\nKNAME\u003d\"dm-0\" PKNAME\u003d\"sdb\" NAME\u003d\"mpatha\" LABEL\u003d\"\" TYPE\u003d\"mpath\" FSTYPE\u003d\"\" MOUNTPOINT\u003d\"\"\nKNAME\u003d\"dm-1\" PKNAME\u003d\"dm-0\" NAME\u003d\"mpatha1\" LABEL\u003d\"MKFS_ESP\" TYPE\u003d\"part\" FSTYPE\u003d\"vfat\" MOUNTPOINT\u003d\"/boot/efi\"\nKNAME\u003d\"dm-0\" PKNAME\u003d\"sdc\" NAME\u003d\"mpatha\" LABEL\u003d\"\" TYPE\u003d\"mpath\" FSTYPE\u003d\"\" MOUNTPOINT\u003d\"\"\nKNAME\u003d\"dm-1\" PKNAME\u003d\"dm-0\" NAME\u003d\"mpatha1\" LABEL\u003d\"MKFS_ESP\" TYPE\u003d\"part\" FSTYPE\u003d\"vfat\" MOUNTPOINT\u003d\"/boot/efi\"\nKNAME\u003d\"dm-0\" PKNAME\u003d\"sdd\" NAME\u003d\"mpatha\" LABEL\u003d\"\" TYPE\u003d\"mpath\" FSTYPE\u003d\"\" MOUNTPOINT\u003d\"\"\nKNAME\u003d\"dm-1\" PKNAME\u003d\"dm-0\" NAME\u003d\"mpatha1\" LABEL\u003d\"MKFS_ESP\" TYPE\u003d\"part\" FSTYPE\u003d\"vfat\" MOUNTPOINT\u003d\"/boot/efi\"\n```\n\ndm-N used for other device stuff as well, like LVM etc.\n```\nKNAME\u003d\"dm-6\" PKNAME\u003d\"dm-4\" NAME\u003d\"vg-lv_thinpool_tmeta\" LABEL\u003d\"\" TYPE\u003d\"lvm\" FSTYPE\u003d\"\" MOUNTPOINT\u003d\"\"\nKNAME\u003d\"dm-7\" PKNAME\u003d\"dm-4\" NAME\u003d\"vg-lv_thinpool_tdata\" LABEL\u003d\"\" TYPE\u003d\"lvm\" FSTYPE\u003d\"\" MOUNTPOINT\u003d\"\"\nKNAME\u003d\"dm-8\" PKNAME\u003d\"dm-7\" NAME\u003d\"vg-lv_thinpool-tpool\" LABEL\u003d\"\" TYPE\u003d\"lvm\" FSTYPE\u003d\"\" MOUNTPOINT\u003d\"\"\n\u003c ... \u003e\nKNAME\u003d\"dm-16\" PKNAME\u003d\"dm-8\" NAME\u003d\"vg-lv_srv\" LABEL\u003d\"fs_srv\" TYPE\u003d\"lvm\" FSTYPE\u003d\"xfs\" MOUNTPOINT\u003d\"/srv\"\n```\n\n\nI think, if we change the code to:\n```\nif disk[\u0027TYPE\u0027] \u003d\u003d \u0027mpath\u0027:\n    max_partnum \u003d 0\n    disk_name_length \u003d len(disk[\u0027NAME\u0027])\n    seen_devs \u003d set()\n    for d in devices:\n        if d[\u0027PKNAME\u0027] !\u003d disk[\u0027KNAME\u0027]:\n            continue\n        dev_name \u003d d[\u0027NAME\u0027]\n        if dev_name in seen_devs:\n            continue\n        seen_devs.add(dev_name)\n        max_partnum \u003d max(max_partnum, int(dev_name[disk_name_length:]))\n    return max_partnum + 1\n```\n\nI did a \"poc\" here: https://paste.opendev.org/show/b40gQGnwV7JkGY9ruuYh/","commit_id":"be023161c019c1693d1f0fb8d9de17a055edd89c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"94e3cb4e09f0e18f13bae5b0a337f5667b6ef857","unresolved":false,"context_lines":[{"line_number":327,"context_line":"    if disk[\u0027TYPE\u0027] \u003d\u003d \u0027disk\u0027:"},{"line_number":328,"context_line":"        disk_name \u003d disk[\u0027KNAME\u0027]"},{"line_number":329,"context_line":"        return len([d for d in devices if d[\u0027PKNAME\u0027] \u003d\u003d disk_name]) + 1"},{"line_number":330,"context_line":"    if disk[\u0027TYPE\u0027] \u003d\u003d \u0027mpath\u0027:"},{"line_number":331,"context_line":"        max_dm \u003d 0"},{"line_number":332,"context_line":"        for d in devices:"},{"line_number":333,"context_line":"            dev_name \u003d d[\u0027KNAME\u0027]"},{"line_number":334,"context_line":"            if not dev_name.startswith(\u0027dm-\u0027):"},{"line_number":335,"context_line":"                continue"},{"line_number":336,"context_line":"            max_dm \u003d max(max_dm, int(dev_name[3:]))"},{"line_number":337,"context_line":"        return max_dm + 1"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"def find_next_device_name(devices, disk, partnum):"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3dc61627_056e236d","line":337,"range":{"start_line":330,"start_character":0,"end_line":337,"end_character":25},"in_reply_to":"e0cae10f_5f4ab3b1","updated":"2023-12-14 01:18:39.000000000","message":"Done","commit_id":"be023161c019c1693d1f0fb8d9de17a055edd89c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"94e3cb4e09f0e18f13bae5b0a337f5667b6ef857","unresolved":true,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"def find_next_device_name(devices, disk, partnum):"},{"line_number":341,"context_line":"    if disk[\u0027TYPE\u0027] \u003d\u003d \u0027disk\u0027:"},{"line_number":342,"context_line":"        disk_name \u003d disk[\u0027KNAME\u0027]"},{"line_number":343,"context_line":"        existing_partnum \u003d partnum - 1"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # try partition scheme for SATA etc, then NVMe"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"d133aad0_9c7f05ea","line":342,"updated":"2023-12-14 01:18:39.000000000","message":"Given the above comment on find_next_partnum then this  should be restored to the original, which should return device name mpath6. Also it loks like the disk_name should come from NAME instead of KNAME, which should continue to work for SATA, NVMe by the looks of it","commit_id":"be023161c019c1693d1f0fb8d9de17a055edd89c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6b7fa90b9d1e2fe4a10703a34a64df89cbfcdec0","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"def find_next_device_name(devices, disk, partnum):"},{"line_number":341,"context_line":"    if disk[\u0027TYPE\u0027] \u003d\u003d \u0027disk\u0027:"},{"line_number":342,"context_line":"        disk_name \u003d disk[\u0027KNAME\u0027]"},{"line_number":343,"context_line":"        existing_partnum \u003d partnum - 1"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # try partition scheme for SATA etc, then NVMe"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"56fc6f0e_ef714aee","line":342,"in_reply_to":"d133aad0_9c7f05ea","updated":"2023-12-14 20:50:13.000000000","message":"Done","commit_id":"be023161c019c1693d1f0fb8d9de17a055edd89c"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"843125403d69a084180e5576f7840d4e6a5167d5","unresolved":true,"context_lines":[{"line_number":258,"context_line":"                break"},{"line_number":259,"context_line":"            if device[\u0027TYPE\u0027] \u003d\u003d \u0027disk\u0027:"},{"line_number":260,"context_line":"                break"},{"line_number":261,"context_line":"            if device[\u0027TYPE\u0027] \u003d\u003d \u0027mpath\u0027:"},{"line_number":262,"context_line":"                break"},{"line_number":263,"context_line":"            if not device[\u0027PKNAME\u0027]:"},{"line_number":264,"context_line":"                break"},{"line_number":265,"context_line":"        if not device:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3e46155a_c481e041","line":262,"range":{"start_line":261,"start_character":12,"end_line":262,"end_character":21},"updated":"2023-12-14 15:00:29.000000000","message":"cool, this will enable us to autodetect the mpath device based on \u0027/\u0027 mountpoint - so adding the device to opts is not neccecary.","commit_id":"c3da182254f7da794b6cd2cf96163076403bdf5f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"720421650169ea53a081660728dac8979a8d4a6e","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                break"},{"line_number":259,"context_line":"            if device[\u0027TYPE\u0027] \u003d\u003d \u0027disk\u0027:"},{"line_number":260,"context_line":"                break"},{"line_number":261,"context_line":"            if device[\u0027TYPE\u0027] \u003d\u003d \u0027mpath\u0027:"},{"line_number":262,"context_line":"                break"},{"line_number":263,"context_line":"            if not device[\u0027PKNAME\u0027]:"},{"line_number":264,"context_line":"                break"},{"line_number":265,"context_line":"        if not device:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"124ddb75_93290bbc","line":262,"range":{"start_line":261,"start_character":12,"end_line":262,"end_character":21},"in_reply_to":"3e46155a_c481e041","updated":"2023-12-14 15:00:59.000000000","message":"marking resolved ...","commit_id":"c3da182254f7da794b6cd2cf96163076403bdf5f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"843125403d69a084180e5576f7840d4e6a5167d5","unresolved":true,"context_lines":[{"line_number":562,"context_line":"        \u0027--change-name\u003d%d:growvols\u0027 % partnum,"},{"line_number":563,"context_line":"        \u0027/dev/%s\u0027 % disk_name"},{"line_number":564,"context_line":"    ], \u0027Create new partition %s\u0027 % devname))"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    commands.append(Command("},{"line_number":567,"context_line":"        [\u0027partprobe\u0027],"},{"line_number":568,"context_line":"        \u0027Inform the OS of partition table changes\u0027))"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"8f512e6f_f4791b49","line":565,"updated":"2023-12-14 15:00:29.000000000","message":"I think we need to add command `multipath -r` to \"force the multipathd daemon to refresh all multipaths\" here (or after the partprobe)? Conditioned on `disk[\u0027TYPE\u0027] \u003d\u003d \u0027mpath\u0027` ?","commit_id":"c3da182254f7da794b6cd2cf96163076403bdf5f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6b7fa90b9d1e2fe4a10703a34a64df89cbfcdec0","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        \u0027--change-name\u003d%d:growvols\u0027 % partnum,"},{"line_number":563,"context_line":"        \u0027/dev/%s\u0027 % disk_name"},{"line_number":564,"context_line":"    ], \u0027Create new partition %s\u0027 % devname))"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    commands.append(Command("},{"line_number":567,"context_line":"        [\u0027partprobe\u0027],"},{"line_number":568,"context_line":"        \u0027Inform the OS of partition table changes\u0027))"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"2a634af5_5acfebdb","line":565,"in_reply_to":"8f512e6f_f4791b49","updated":"2023-12-14 20:50:13.000000000","message":"Done","commit_id":"c3da182254f7da794b6cd2cf96163076403bdf5f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b99c5001cc610f9ec4d32e9c45d4c4388f8ed64f","unresolved":true,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    devices \u003d find_devices()"},{"line_number":519,"context_line":"    disk \u003d find_disk(opts, devices)"},{"line_number":520,"context_line":"    disk_name \u003d disk[\u0027KNAME\u0027]"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    grow_gpt(disk_name)"},{"line_number":523,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"2047f110_c4a74ea7","line":520,"updated":"2023-12-15 22:13:41.000000000","message":"Maybe all that is needed is to use the appropriate disk_name in the multipath case, so:\n\nif disk[\u0027TYPE\u0027] \u003d\u003d \u0027mpath\u0027:\n    disk_name \u003d disk[\u0027PKNAME\u0027]\nelse:\n    disk_name \u003d disk[\u0027KNAME\u0027]","commit_id":"ae2823a86e44335bbb9de52a74ade844a49280fd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d7d9b91f40cb9c3a4cac26d8573f122cda06a5b5","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    devices \u003d find_devices()"},{"line_number":519,"context_line":"    disk \u003d find_disk(opts, devices)"},{"line_number":520,"context_line":"    disk_name \u003d disk[\u0027KNAME\u0027]"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    grow_gpt(disk_name)"},{"line_number":523,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"6b2e3004_b144179a","line":520,"in_reply_to":"2047f110_c4a74ea7","updated":"2023-12-21 21:51:39.000000000","message":"This isn\u0027t necessary, it appears that the devices are the same","commit_id":"ae2823a86e44335bbb9de52a74ade844a49280fd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0c03cbb1693ed09514cc857b6fce43e4e3ca79d9","unresolved":true,"context_lines":[{"line_number":551,"context_line":"        size_bytes -\u003d size_bytes % PHYSICAL_EXTENT_BYTES"},{"line_number":552,"context_line":"        # reduce for metadata overhead"},{"line_number":553,"context_line":"        size_bytes -\u003d PHYSICAL_EXTENT_BYTES"},{"line_number":554,"context_line":"    dev_path \u003d \u0027/dev/%s\u0027 % devname"},{"line_number":555,"context_line":"    grow_vols \u003d find_grow_vols(opts, devices, group, size_bytes)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    commands \u003d []"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7c237be6_723192de","line":554,"updated":"2023-12-21 08:52:26.000000000","message":"I think we need to have another condition on disk[\u0027TYPE\u0027] \u003d\u003d \u0027mpath\u0027 here.\nIf it is mpath, we need to set ``dev_path \u003d \u0027/dev/mapper/%s\u0027 % devname``","commit_id":"ae2823a86e44335bbb9de52a74ade844a49280fd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d7d9b91f40cb9c3a4cac26d8573f122cda06a5b5","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        size_bytes -\u003d size_bytes % PHYSICAL_EXTENT_BYTES"},{"line_number":552,"context_line":"        # reduce for metadata overhead"},{"line_number":553,"context_line":"        size_bytes -\u003d PHYSICAL_EXTENT_BYTES"},{"line_number":554,"context_line":"    dev_path \u003d \u0027/dev/%s\u0027 % devname"},{"line_number":555,"context_line":"    grow_vols \u003d find_grow_vols(opts, devices, group, size_bytes)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    commands \u003d []"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5448b17c_63c34f98","line":554,"in_reply_to":"7c237be6_723192de","updated":"2023-12-21 21:51:39.000000000","message":"Done","commit_id":"ae2823a86e44335bbb9de52a74ade844a49280fd"}]}