)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"673984d6774bebc2730698ed04424a6602b27bd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4647399c_fa6e69d0","updated":"2024-02-05 21:19:44.000000000","message":"Was the chmod +x on disk-image-create intentional? I have no issue with making that file executable but want to make sure this wasn\u0027t a mistake.","commit_id":"ca9c1550b6ec2f464e727af2c67783ff6ae3d782"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"02a9ff8780e0136cb5162e84519b6856897f52fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b0003a52_de97ceb5","in_reply_to":"01ac5f95_d8e16ec1","updated":"2024-02-06 16:59:18.000000000","message":"I think the idea was that you should be using the python package installed disk-image-create command to eventually drive the disk-image-create shell script which is made executable in this change rather than invoking it directly. However, making this script executable won\u0027t prevent people from doing that anyway so is a mostly harmless change.","commit_id":"ca9c1550b6ec2f464e727af2c67783ff6ae3d782"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bf125cfd762dbcacd375fbbf7028fce78b7554e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"01ac5f95_d8e16ec1","in_reply_to":"4647399c_fa6e69d0","updated":"2024-02-05 22:07:32.000000000","message":"It was required to make it work out of the box in a venv. It was originally accidentally committed, but on reflection: it should just work in a venv, so setting +x is the right thing to do.","commit_id":"ca9c1550b6ec2f464e727af2c67783ff6ae3d782"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"94821fd808662ea16b7129a18090f825b0598a6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c8f6d8c9_ca7b2068","updated":"2024-02-06 19:36:58.000000000","message":"recheck I think there might have been an error getting the fedora image version?","commit_id":"9e0ff1f5b3594072f2904c02d7e0c70ad2199f3f"}],"diskimage_builder/elements/gentoo/bin/install-packages":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"054f056122aadac2eba992f7a6e30895f53f5c36","unresolved":true,"context_lines":[{"line_number":27,"context_line":"if ! declare -p GENTOO_EMERGE_ENV  2\u003e /dev/null | grep -q \u0027^declare \\-a\u0027; then"},{"line_number":28,"context_line":"    declare -a GENTOO_EMERGE_ENV"},{"line_number":29,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"USE\u003d\\\"-build\\\"\")"},{"line_number":30,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"FEATURES\u003d\\\"binpkg-multi-instance -buildpkg parallel-fetch parallel-install\\\"\")"},{"line_number":31,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PKGDIR\u003d\\\"/tmp/portage-pkgdir\\\"\")"},{"line_number":32,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"DISTDIR\u003d\\\"/tmp/portage-distdir\\\"\")"},{"line_number":33,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PORTDIR\u003d\\\"/tmp/portage-portdir\\\"\")"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"2888ef8f_fdd38e36","line":30,"updated":"2024-02-05 20:34:19.000000000","message":"accidental change, remove","commit_id":"66a1a29b841e46dd44c1aa9e47f93f71e8a56315"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fd265009905c23acc09a87b5938bdb27a0c259f6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"if ! declare -p GENTOO_EMERGE_ENV  2\u003e /dev/null | grep -q \u0027^declare \\-a\u0027; then"},{"line_number":28,"context_line":"    declare -a GENTOO_EMERGE_ENV"},{"line_number":29,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"USE\u003d\\\"-build\\\"\")"},{"line_number":30,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"FEATURES\u003d\\\"binpkg-multi-instance -buildpkg parallel-fetch parallel-install\\\"\")"},{"line_number":31,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PKGDIR\u003d\\\"/tmp/portage-pkgdir\\\"\")"},{"line_number":32,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"DISTDIR\u003d\\\"/tmp/portage-distdir\\\"\")"},{"line_number":33,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PORTDIR\u003d\\\"/tmp/portage-portdir\\\"\")"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5d3c188f_86b35dfd","line":30,"in_reply_to":"2888ef8f_fdd38e36","updated":"2024-02-05 20:35:43.000000000","message":"Done","commit_id":"66a1a29b841e46dd44c1aa9e47f93f71e8a56315"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0765dc0e210e3d1f73c07d10e6ad0e0dd50ea0e3","unresolved":true,"context_lines":[{"line_number":20,"context_line":"set -eu"},{"line_number":21,"context_line":"set -o pipefail"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"unset YACC LEX"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# env is not sourced with user specified package inclusions"},{"line_number":26,"context_line":"# set the default bash array if GENTOO_EMERGE_ENV is not defined as an array"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"03faac30_fc465f20","line":23,"updated":"2024-02-05 21:36:52.000000000","message":"What is the purpose of this unset? At least on my machine YACC and LEX are not generally set. Is this a problem when running dib on gentoo to build gentoo and the host system vars leak into the chroot?","commit_id":"ca9c1550b6ec2f464e727af2c67783ff6ae3d782"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"29a423fbcbde7df494690e71516df37baac2956a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"set -eu"},{"line_number":21,"context_line":"set -o pipefail"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"unset YACC LEX"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# env is not sourced with user specified package inclusions"},{"line_number":26,"context_line":"# set the default bash array if GENTOO_EMERGE_ENV is not defined as an array"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"18bc8dc4_28085b09","line":23,"in_reply_to":"03faac30_fc465f20","updated":"2024-02-05 22:06:52.000000000","message":"Sam says: tl;dr: yes, if you have app-alternatives/{yacc,lex} not set to the defaults, an env var is set to use them, but those may not be within the dib image\n\nThis matches my understanding of behavior here, but should probably be commented. Adding a comment.","commit_id":"ca9c1550b6ec2f464e727af2c67783ff6ae3d782"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9581f928e018d3919525df814af9c6228ba0efea","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    eval export \"${GENTOO_EMERGE_ENV[i]}\""},{"line_number":43,"context_line":"done"},{"line_number":44,"context_line":"# set default opts"},{"line_number":45,"context_line":"GENTOO_EMERGE_DEFAULT_OPTS\u003d${GENTOO_EMERGE_DEFAULT_OPTS:-\"--binpkg-respect-use --rebuilt-binaries\u003dy --usepkg\u003dy --with-bdeps\u003dy --binpkg-changed-deps\u003dy --jobs\u003d2 --verbose --jobs\u003d1 --autounmask\u003dn\"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"ACTION\u003d\u0027install\u0027"},{"line_number":48,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"344b8788_4ac5ef13","line":45,"updated":"2024-02-05 22:11:22.000000000","message":"jobs\u003d2 and jobs\u003d1 is wrong?","commit_id":"77a831c69271abf4f98c4ae1e1baf1fa3ebe0254"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"11690a00e8621ed9325569ff5e94d6d1eea712de","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    eval export \"${GENTOO_EMERGE_ENV[i]}\""},{"line_number":43,"context_line":"done"},{"line_number":44,"context_line":"# set default opts"},{"line_number":45,"context_line":"GENTOO_EMERGE_DEFAULT_OPTS\u003d${GENTOO_EMERGE_DEFAULT_OPTS:-\"--binpkg-respect-use --rebuilt-binaries\u003dy --usepkg\u003dy --with-bdeps\u003dy --binpkg-changed-deps\u003dy --jobs\u003d2 --verbose --jobs\u003d1 --autounmask\u003dn\"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"ACTION\u003d\u0027install\u0027"},{"line_number":48,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"8a37eb8b_3727ed99","line":45,"in_reply_to":"344b8788_4ac5ef13","updated":"2024-02-05 22:12:05.000000000","message":"Done","commit_id":"77a831c69271abf4f98c4ae1e1baf1fa3ebe0254"}],"diskimage_builder/elements/gentoo/environment.d/00-gentoo-envars.bash":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"054f056122aadac2eba992f7a6e30895f53f5c36","unresolved":true,"context_lines":[{"line_number":11,"context_line":"if ! declare -p GENTOO_EMERGE_ENV  2\u003e /dev/null | grep -q \u0027^declare \\-a\u0027; then"},{"line_number":12,"context_line":"    declare -a GENTOO_EMERGE_ENV"},{"line_number":13,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"USE\u003d\\\"-build\\\"\")"},{"line_number":14,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"FEATURES\u003d\\\"binpkg-multi-instance -buildpkg binpkg-request-signature getbinpkg parallel-fetch parallel-install\\\"\")"},{"line_number":15,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PKGDIR\u003d\\\"/tmp/portage-pkgdir\\\"\")"},{"line_number":16,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"DISTDIR\u003d\\\"/tmp/portage-distdir\\\"\")"},{"line_number":17,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PORTDIR\u003d\\\"/tmp/portage-portdir\\\"\")"}],"source_content_type":"text/x-sh","patch_set":2,"id":"69107329_ac2a69b5","line":14,"updated":"2024-02-05 20:34:19.000000000","message":"accidental change, revert","commit_id":"66a1a29b841e46dd44c1aa9e47f93f71e8a56315"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fd265009905c23acc09a87b5938bdb27a0c259f6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"if ! declare -p GENTOO_EMERGE_ENV  2\u003e /dev/null | grep -q \u0027^declare \\-a\u0027; then"},{"line_number":12,"context_line":"    declare -a GENTOO_EMERGE_ENV"},{"line_number":13,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"USE\u003d\\\"-build\\\"\")"},{"line_number":14,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"FEATURES\u003d\\\"binpkg-multi-instance -buildpkg binpkg-request-signature getbinpkg parallel-fetch parallel-install\\\"\")"},{"line_number":15,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PKGDIR\u003d\\\"/tmp/portage-pkgdir\\\"\")"},{"line_number":16,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"DISTDIR\u003d\\\"/tmp/portage-distdir\\\"\")"},{"line_number":17,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PORTDIR\u003d\\\"/tmp/portage-portdir\\\"\")"}],"source_content_type":"text/x-sh","patch_set":2,"id":"be8cbfb4_63534cf2","line":14,"in_reply_to":"69107329_ac2a69b5","updated":"2024-02-05 20:35:43.000000000","message":"Done","commit_id":"66a1a29b841e46dd44c1aa9e47f93f71e8a56315"}]}