)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d8b492423eed6b6d1d9e19ff3a1a57d5e6a8410c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix regexp for Fedora element SUBRELEASE parsing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current regexp  is catching a wrong extra record for HTML-based mirrors [1]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Modifying regexp allows to workaround fetching extra string."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f91432c0_4f59dc34","line":9,"updated":"2024-07-18 18:07:03.000000000","message":"Nit, the original regexp was based on what the html based mirrors responded with. The problem more appears to be that some mirrors use different html construction than others and this isn\u0027t a universal html problem.","commit_id":"7cd5268d15d378f41e75b994a5929debfd025139"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3ed3b07d521469296fb418c589f57affdd379fc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"856e9a60_7c2ac44c","updated":"2024-06-25 17:31:26.000000000","message":"recheck functional test job has been fixed","commit_id":"03d7dcbf1a0f80e5211ec9655b7b01b05c223ba8"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"cf947b55749b102f84e21c1864fb3e97eed2a80c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"485ffed9_d8fc7e59","updated":"2024-07-16 18:21:55.000000000","message":"recheck see if xenial build failure is intermittent","commit_id":"7cd5268d15d378f41e75b994a5929debfd025139"}],"diskimage_builder/elements/fedora/root.d/10-fedora-cloud-image":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d8b492423eed6b6d1d9e19ff3a1a57d5e6a8410c","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    esac"},{"line_number":54,"context_line":"    # We have curl write headers to stderr so that we can debug fedora"},{"line_number":55,"context_line":"    # mirror locations that don\u0027t have valid subreleases in their paths."},{"line_number":56,"context_line":"    SUBRELEASE\u003d$(head -1 \u003c \u003c(curl -Lis -D /dev/stderr $DIB_CLOUD_IMAGES/ | grep -o -P \u0027(?\u003c\u003dFedora-Cloud-Base-\u0027${DIB_RELEASE}\u0027-).*?(?\u003d.\u0027${ARCH}\u0027.qcow2)\u0027 | sort -r))"},{"line_number":57,"context_line":"    BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-Fedora-Cloud-Base-$DIB_RELEASE-$SUBRELEASE.$ARCH.qcow2}"},{"line_number":58,"context_line":"    BASE_IMAGE_TAR\u003dFedora-Cloud-Base-$DIB_RELEASE-$SUBRELEASE.$ARCH.tgz"},{"line_number":59,"context_line":"    IMAGE_LOCATION\u003d$DIB_CLOUD_IMAGES/$BASE_IMAGE_FILE"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"cc1737cf_a514655e","line":56,"updated":"2024-07-18 18:07:03.000000000","message":"I think the goal with the `\"` was to match the actual url contents in the `\u003ca\u003e` anchor `href` strings and not the human readable version between the `\u003ca\u003e` and `\u003c/a\u003e`. Unfortunately, this means the `.*` in the middle of the regex can overmatch if the html served by some mirrors doesn\u0027t match what we expect here (in particular it seems some mirrors put a number of entries on a single line).\n\nAll that to say I think this is probably fine as a workaround. A proper fix would be to improve the regex to better match the content in the href string between the anchor tags. But that is tricky due to regexes being greedy by default and needing to be flexible to match different mirror responses.","commit_id":"7cd5268d15d378f41e75b994a5929debfd025139"}]}