)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":35960,"name":"Robin Jarry","email":"rjarry@redhat.com","username":"rjarry","status":"Red Hat"},"change_message_id":"672b122466f45b911d8625041898d4b262e36e3b","unresolved":true,"context_lines":[{"line_number":11,"context_line":"is changed later which would could re-introduce arguments not desired"},{"line_number":12,"context_line":"which come from the source image."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Since we assert, bsaed upon user supplied input, new console configuration"},{"line_number":15,"context_line":"we now strip the console configuration from /etc/default/grub configuration"},{"line_number":16,"context_line":"before starting to work on putting in place the user\u0027s desired end state."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"538af930_734497e8","line":14,"updated":"2024-06-27 16:52:53.000000000","message":"based","commit_id":"9b3c51650576d829c041804d4a70eef5a12cad10"},{"author":{"_account_id":35960,"name":"Robin Jarry","email":"rjarry@redhat.com","username":"rjarry","status":"Red Hat"},"change_message_id":"d1aa55cc0df5f71a6081809b2f695519e1d68271","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is changed later which would could re-introduce arguments not desired"},{"line_number":12,"context_line":"which come from the source image."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Since we assert, bsaed upon user supplied input, new console configuration"},{"line_number":15,"context_line":"we now strip the console configuration from /etc/default/grub configuration"},{"line_number":16,"context_line":"before starting to work on putting in place the user\u0027s desired end state."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f1d09a5a_da068fb3","line":14,"in_reply_to":"538af930_734497e8","updated":"2024-06-28 14:02:12.000000000","message":"Done","commit_id":"9b3c51650576d829c041804d4a70eef5a12cad10"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1073ab4d8c93d9b8b4cf1c8f91bb455767de224d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2d754b82_92436996","updated":"2024-06-28 15:15:00.000000000","message":"2024-06-28 14:19:37.574 | + sed -i \u0027s/\\\u003cconsole\u003d[[:alnum:],]*[[:space:]]*//g\u0027 /etc/default/grub\n2024-06-28 14:19:37.575 | sed: can\u0027t read /etc/default/grub: No such file or directory","commit_id":"0d90f3f5dfa8fa50324a92f054875471959d96e0"},{"author":{"_account_id":35960,"name":"Robin Jarry","email":"rjarry@redhat.com","username":"rjarry","status":"Red Hat"},"change_message_id":"28b65f7ce99677620b9198ccc638997e26dcc9a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f090f2c7_8636a2d9","updated":"2024-06-28 14:01:47.000000000","message":"Thanks @juliaashleykreger@gmail.com !","commit_id":"0d90f3f5dfa8fa50324a92f054875471959d96e0"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"06603ced19cda6f71efbda33125c0c58626eca63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3c4a8054_228dd04d","updated":"2024-06-30 21:13:23.000000000","message":"Looks good, thanks","commit_id":"abe2a4e2399d0cd47fb9e7733d0871465b7e1853"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c1d113a98350c53889289fe244436d23c15075f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93f982ba_18c8b8a5","updated":"2024-07-04 00:42:18.000000000","message":"recheck centos 7 jobs are gone","commit_id":"abe2a4e2399d0cd47fb9e7733d0871465b7e1853"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b58d94a8646b2b2fd689c07b43e505bf4d027512","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5dc11bc1_994dc2f8","updated":"2024-07-03 02:48:39.000000000","message":"recheck centos7 Could not resolve host: mirrorlist.centos.org","commit_id":"abe2a4e2399d0cd47fb9e7733d0871465b7e1853"}],"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":35960,"name":"Robin Jarry","email":"rjarry@redhat.com","username":"rjarry","status":"Red Hat"},"change_message_id":"672b122466f45b911d8625041898d4b262e36e3b","unresolved":true,"context_lines":[{"line_number":94,"context_line":"# ... and also matches"},{"line_number":95,"context_line":"# \u0027console\u003dttyS0,112500n81 console\u003dttyS1,n8 console\u003dtty0\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"sed -i \u0027s/console\u003d[[:alpha:]]*[[:digit:]]*[,]\\?[[:digit:]]*[[:alpha:]]\\?[[:digit:]]\\?[[:space:]]\\+//ig\u0027 /etc/default/grub"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e /etc/default/grub"},{"line_number":100,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c34f2543_b1c8c08d","line":97,"updated":"2024-06-27 16:52:53.000000000","message":"Wouldn\u0027t it be simpler/safer?\n\n```suggestion\nsed -i \"s/\\\u003cconsole\u003d[^[:space:]\\\"\u0027]\\+\\\u003e//g\" /etc/default/grub\n```","commit_id":"9b3c51650576d829c041804d4a70eef5a12cad10"},{"author":{"_account_id":35960,"name":"Robin Jarry","email":"rjarry@redhat.com","username":"rjarry","status":"Red Hat"},"change_message_id":"d1aa55cc0df5f71a6081809b2f695519e1d68271","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# ... and also matches"},{"line_number":95,"context_line":"# \u0027console\u003dttyS0,112500n81 console\u003dttyS1,n8 console\u003dtty0\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"sed -i \u0027s/console\u003d[[:alpha:]]*[[:digit:]]*[,]\\?[[:digit:]]*[[:alpha:]]\\?[[:digit:]]\\?[[:space:]]\\+//ig\u0027 /etc/default/grub"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e /etc/default/grub"},{"line_number":100,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c775ff08_3f169f1f","line":97,"in_reply_to":"5bc46e79_472da7a4","updated":"2024-06-28 14:02:12.000000000","message":"Done","commit_id":"9b3c51650576d829c041804d4a70eef5a12cad10"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1073ab4d8c93d9b8b4cf1c8f91bb455767de224d","unresolved":true,"context_lines":[{"line_number":94,"context_line":"# ... and also matches"},{"line_number":95,"context_line":"# \u0027console\u003dttyS0,112500n81 console\u003dttyS1,n8 console\u003dtty0\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"sed -i \u0027s/console\u003d[[:alpha:]]*[[:digit:]]*[,]\\?[[:digit:]]*[[:alpha:]]\\?[[:digit:]]\\?[[:space:]]\\+//ig\u0027 /etc/default/grub"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e /etc/default/grub"},{"line_number":100,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ed5f954b_e5996daa","line":97,"in_reply_to":"5bc46e79_472da7a4","updated":"2024-06-28 15:15:00.000000000","message":"hmm, alnum was not in the reference I was looking at, neat!","commit_id":"9b3c51650576d829c041804d4a70eef5a12cad10"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4380e43a311b1586276fe934d7e5c3d09e86bcf3","unresolved":true,"context_lines":[{"line_number":94,"context_line":"# ... and also matches"},{"line_number":95,"context_line":"# \u0027console\u003dttyS0,112500n81 console\u003dttyS1,n8 console\u003dtty0\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"sed -i \u0027s/console\u003d[[:alpha:]]*[[:digit:]]*[,]\\?[[:digit:]]*[[:alpha:]]\\?[[:digit:]]\\?[[:space:]]\\+//ig\u0027 /etc/default/grub"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e /etc/default/grub"},{"line_number":100,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ab2d3e03_f2a3c910","line":97,"in_reply_to":"780fde8e_f18cbcf9","updated":"2024-06-27 17:21:25.000000000","message":"I\u0027m not so sure about what your proposing, since it embeds \"\u0027 as characters as well, which means for the web evaluator I\u0027m using also had to be double quoted to be happy enough to parse the data.\n\nAlso, what your proposing orphans spaces it looks like in my local testing. :\\  I guess I\u0027m much more a fan of explicitly matching through the format which is what I proposed, which actually seems safer to me because it is only matching a spaces at the very end to prevent spaces from being orphaned.","commit_id":"9b3c51650576d829c041804d4a70eef5a12cad10"},{"author":{"_account_id":35960,"name":"Robin Jarry","email":"rjarry@redhat.com","username":"rjarry","status":"Red Hat"},"change_message_id":"1ab7c6823d358575a3cddc2aef59d7a5fd803689","unresolved":true,"context_lines":[{"line_number":94,"context_line":"# ... and also matches"},{"line_number":95,"context_line":"# \u0027console\u003dttyS0,112500n81 console\u003dttyS1,n8 console\u003dtty0\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"sed -i \u0027s/console\u003d[[:alpha:]]*[[:digit:]]*[,]\\?[[:digit:]]*[[:alpha:]]\\?[[:digit:]]\\?[[:space:]]\\+//ig\u0027 /etc/default/grub"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e /etc/default/grub"},{"line_number":100,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5bc46e79_472da7a4","line":97,"in_reply_to":"ab2d3e03_f2a3c910","updated":"2024-06-27 21:32:11.000000000","message":"Ok, I was thinking ahead with weird console\u003d arguments. But you are probably correct. Could you at least make the expression simpler?\n\n```suggestion\nsed -i \u0027s/\\\u003cconsole\u003d[[:alnum:],]*[[:space:]]*//g\u0027 /etc/default/grub\n```","commit_id":"9b3c51650576d829c041804d4a70eef5a12cad10"},{"author":{"_account_id":35960,"name":"Robin Jarry","email":"rjarry@redhat.com","username":"rjarry","status":"Red Hat"},"change_message_id":"ebfa864d9197222d368f19ecff4ac46c32905a10","unresolved":true,"context_lines":[{"line_number":94,"context_line":"# ... and also matches"},{"line_number":95,"context_line":"# \u0027console\u003dttyS0,112500n81 console\u003dttyS1,n8 console\u003dtty0\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"sed -i \u0027s/console\u003d[[:alpha:]]*[[:digit:]]*[,]\\?[[:digit:]]*[[:alpha:]]\\?[[:digit:]]\\?[[:space:]]\\+//ig\u0027 /etc/default/grub"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e /etc/default/grub"},{"line_number":100,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"780fde8e_f18cbcf9","line":97,"in_reply_to":"c34f2543_b1c8c08d","updated":"2024-06-27 17:09:08.000000000","message":"scratch that, here\u0027s what I propose:\n\n```suggestion\nsed -Ei \"s/\\\u003cconsole\u003d[^[:space:]\\\"\u0027]*\\\u003e//g\" /etc/default/grub\n```\n\nAnd here is a small test with a posix shell and with bash:\n\n```sh\n# console.sh\n\ntmp\u003d$(mktemp)\norig\u003d$tmp.orig\n\ntrap \u0027rm -f $tmp*\u0027 EXIT\n\ncat \u003e \"$tmp\" \u003c\u003c\u0027EOF\u0027\nGRUB_TIMEOUT\u003d5\nGRUB_DISTRIBUTOR\u003d\"$(sed \u0027s, release .*$,,g\u0027 /etc/system-release)\"\nGRUB_DEFAULT\u003dsaved\nGRUB_DISABLE_SUBMENU\u003dtrue\n# foo baz bar \"console\u003dtty0\"\nGRUB_TERMINAL_OUTPUT\u003d\"console\"  console\u003d\nGRUB_CMDLINE_LINUX\u003d\"console\u003dttyS0,115200n81 console.foo\u003d0 console\u003dusb0 consolenahjustkidding\u003d0 \"\nGRUB_DISABLE_RECOVERY\u003d\"true\"\nGRUB_ENABLE_BLSCFG\u003dtrue\nEOF\n\nsed -E -i.orig \"s/\\\u003cconsole\u003d[^[:space:]\\\"\u0027]*\\\u003e//g\" \"$tmp\"\n\ndiff -u \"$tmp.orig\" \"$tmp\"\n```\n\n```\nrjarry@ringo:~$ dash -x console.sh \n+ mktemp\n+ tmp\u003d/tmp/tmp.F0rWMyWUWL\n+ orig\u003d/tmp/tmp.F0rWMyWUWL.orig\n+ trap rm -f $tmp* EXIT\n+ cat\n+ sed -E -i.orig s/\\\u003cconsole\u003d[^[:space:]\"\u0027]*\\\u003e//g /tmp/tmp.F0rWMyWUWL\n+ diff -u /tmp/tmp.F0rWMyWUWL.orig /tmp/tmp.F0rWMyWUWL\n--- /tmp/tmp.F0rWMyWUWL.orig\t2024-06-27 19:06:00.089733614 +0200\n+++ /tmp/tmp.F0rWMyWUWL\t2024-06-27 19:06:00.094733615 +0200\n@@ -2,8 +2,8 @@\n GRUB_DISTRIBUTOR\u003d\"$(sed \u0027s, release .*$,,g\u0027 /etc/system-release)\"\n GRUB_DEFAULT\u003dsaved\n GRUB_DISABLE_SUBMENU\u003dtrue\n-# foo baz bar \"console\u003dtty0\"\n+# foo baz bar \"\"\n GRUB_TERMINAL_OUTPUT\u003d\"console\"  console\u003d\n-GRUB_CMDLINE_LINUX\u003d\"console\u003dttyS0,115200n81 console.foo\u003d0 console\u003dusb0 consolenahjustkidding\u003d0 \"\n+GRUB_CMDLINE_LINUX\u003d\" console.foo\u003d0  consolenahjustkidding\u003d0 \"\n GRUB_DISABLE_RECOVERY\u003d\"true\"\n GRUB_ENABLE_BLSCFG\u003dtrue\n+ rm -f /tmp/tmp.F0rWMyWUWL /tmp/tmp.F0rWMyWUWL.orig\nrjarry@ringo:~$ bash -x console.sh \n++ mktemp\n+ tmp\u003d/tmp/tmp.LkiK5z2MSc\n+ orig\u003d/tmp/tmp.LkiK5z2MSc.orig\n+ trap \u0027rm -f $tmp*\u0027 EXIT\n+ cat\n+ sed -E -i.orig \u0027s/\\\u003cconsole\u003d[^[:space:]\"\u0027\\\u0027\u0027]*\\\u003e//g\u0027 /tmp/tmp.LkiK5z2MSc\n+ diff -u /tmp/tmp.LkiK5z2MSc.orig /tmp/tmp.LkiK5z2MSc\n--- /tmp/tmp.LkiK5z2MSc.orig\t2024-06-27 19:07:08.832744413 +0200\n+++ /tmp/tmp.LkiK5z2MSc\t2024-06-27 19:07:08.839744414 +0200\n@@ -2,8 +2,8 @@\n GRUB_DISTRIBUTOR\u003d\"$(sed \u0027s, release .*$,,g\u0027 /etc/system-release)\"\n GRUB_DEFAULT\u003dsaved\n GRUB_DISABLE_SUBMENU\u003dtrue\n-# foo baz bar \"console\u003dtty0\"\n+# foo baz bar \"\"\n GRUB_TERMINAL_OUTPUT\u003d\"console\"  console\u003d\n-GRUB_CMDLINE_LINUX\u003d\"console\u003dttyS0,115200n81 console.foo\u003d0 console\u003dusb0 consolenahjustkidding\u003d0 \"\n+GRUB_CMDLINE_LINUX\u003d\" console.foo\u003d0  consolenahjustkidding\u003d0 \"\n GRUB_DISABLE_RECOVERY\u003d\"true\"\n GRUB_ENABLE_BLSCFG\u003dtrue\n+ rm -f /tmp/tmp.LkiK5z2MSc /tmp/tmp.LkiK5z2MSc.orig\n```","commit_id":"9b3c51650576d829c041804d4a70eef5a12cad10"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"320e3d79e949a4d07e40aa22d84559437a780943","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# ... and also matches"},{"line_number":95,"context_line":"# \u0027console\u003dttyS0,112500n81 console\u003dttyS1,n8 console\u003dtty0\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"sed -i \u0027s/console\u003d[[:alpha:]]*[[:digit:]]*[,]\\?[[:digit:]]*[[:alpha:]]\\?[[:digit:]]\\?[[:space:]]\\+//ig\u0027 /etc/default/grub"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e /etc/default/grub"},{"line_number":100,"context_line":"echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"74fa3d0a_91816f30","line":97,"in_reply_to":"ed5f954b_e5996daa","updated":"2024-06-28 15:20:58.000000000","message":"Done","commit_id":"9b3c51650576d829c041804d4a70eef5a12cad10"}]}