)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"17d977271a3a5b80ae44795900af010fcfba7342","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6a1d97d_88783c6f","updated":"2024-07-11 22:40:07.000000000","message":"I need to fix gentoo generally first before going down this road","commit_id":"c5305653c8a017dfed861f513bd58f07d9d61b20"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"459caee9eb982c99cac27174ed847719f8063781","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"10db4fd1_bbdba24c","updated":"2024-07-11 23:41:41.000000000","message":"I need to:\n- remove broken 17.0/17.1 stages (and replace them *all* with their 23.0 equivalents\n- merge this with https://review.opendev.org/c/openstack/diskimage-builder/+/924014 so maybe CI can pass","commit_id":"4f019dabef3d0a4d3a5a579b2fc7890b554725bb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b07debce38926a19e8888458599eb436ab317985","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0b13db68_3db926e6","in_reply_to":"10db4fd1_bbdba24c","updated":"2024-11-20 16:09:40.000000000","message":"Done","commit_id":"4f019dabef3d0a4d3a5a579b2fc7890b554725bb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9b4013679a352a2251a0112d25527681d93f8b16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5fb8c6fb_7e92335e","updated":"2024-07-15 14:16:06.000000000","message":"Need to fix https://opendev.org/openstack/diskimage-builder/src/branch/master/diskimage_builder/elements/gentoo/environment.d/00-gentoo-envars.bash#L4","commit_id":"40b1476d5a6c1e9a42ddb7000bc41f0247cde2f0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43988c1fe3377bdd133cb4d71f5ba9b2f9bf8ecf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"158ea932_b1e3123c","updated":"2024-08-26 14:32:10.000000000","message":"Issuing a -1 for revision need. Overall, Looks pretty good to me.","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"25947a9cb8a577538010d61435aae456eb72891e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"85415ffa_49d4c1d4","updated":"2024-07-26 17:46:44.000000000","message":"Thanks for reviews, I\u0027ll take a look at CI failures and feedback and go from there.","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cad4a2b3fb6b1d28cbc498d17210cea6d2f8e2ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b98c7bfb_852161f0","updated":"2024-11-15 15:42:51.000000000","message":"Note to self: looks like I need to ensure the on-boot automation is working properly; e.g. ensure cloud-init is installed as well as whatever tool it uses to expand parititons","commit_id":"afafab32048f22383a33fe1f827a1cfb21dc21aa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"43502082e21d0e3014556643a43695b60951c6ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8e9d96d2_819c29e0","updated":"2024-11-15 10:28:39.000000000","message":"gentoo job is still failing","commit_id":"afafab32048f22383a33fe1f827a1cfb21dc21aa"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cad4a2b3fb6b1d28cbc498d17210cea6d2f8e2ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"cce8b5db_4f3658a6","in_reply_to":"8e9d96d2_819c29e0","updated":"2024-11-15 15:42:51.000000000","message":"Thanks for the -1, I don\u0027t want this to merge until that job is passing :D","commit_id":"afafab32048f22383a33fe1f827a1cfb21dc21aa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"12e142b46fd0fca96a511456ace572a10a69a959","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c284669b_be1d09d2","in_reply_to":"cce8b5db_4f3658a6","updated":"2024-11-15 16:54:57.000000000","message":"yeah, I\u0027ve too often seen people just think \"this patch looks good, CI is +1, let\u0027s merge it\", so I prefer to make it more visible if I can","commit_id":"afafab32048f22383a33fe1f827a1cfb21dc21aa"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ceaa4afc3d7c9c854f9ee207f1e8a64e3609be56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"59bd4fd1_7b3256b8","updated":"2024-11-18 23:19:21.000000000","message":"For some reason; /usr/local/bin/growroot isn\u0027t ending up in the final FS:\n\ndevuser@localhost ~ $ ls -la /usr/local/bin/     \ntotal 68\ndrwxr-xr-x 2 root root 4096 Nov 18 22:49 .\ndrwxr-xr-x 6 root root 4096 Nov 17 17:07 ..\n-rwxr-xr-x 1 root root 3810 Nov 18 22:45 cache-url\n-rwxrwxr-x 1 root root   24 Nov 18 22:45 dib-init-system\n-rwxr-xr-x 1 root root 1407 Nov 18 22:45 fix_shm\nlrwxrwxrwx 1 root root   20 Nov 18 22:49 glean -\u003e /usr/glean/bin/glean\nlrwxrwxrwx 1 root root   28 Nov 18 22:49 glean-install -\u003e /usr/glean/bin/glean-install\nlrwxrwxrwx 1 root root   23 Nov 18 22:49 glean.sh -\u003e /usr/glean/bin/glean.sh\n-rwxr-xr-x 1 root root 5446 Nov 18 22:45 install-packages\n-rwxr-xr-x 1 root root 1548 Nov 18 22:45 package-installs\n-rwxr-xr-x 1 root root 8639 Nov 18 22:45 package-installs-squash\n-rwxr-xr-x 1 root root 4917 Nov 18 22:45 package-installs-v2\n-rwxr-xr-x 1 root root 1417 Nov 18 22:45 package-uninstalls\n-rwxr-xr-x 1 root root 6883 Nov 18 22:45 pkg-map\n-rwxr-xr-x 1 root root  948 Nov 18 22:45 unfix_shm","commit_id":"7cae9ab82796aac4ed8611c81574e133747ab673"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"4c6979840017e22bd70ef905a4c74b40ea92e140","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"de688c32_6b36c7e2","updated":"2024-11-19 21:22:55.000000000","message":"Figured out the growroot issue. \n\nI was being led on a wild goose chase looking for /usr/local/bin/growroot EVEN THOUGH it was clearly installed to /usr/local/sbin/. Once I figured that out, I fixed the devuser element so  I could sudo as the devuser, and got a clear error about runscript not existing ... which led me to: https://github.com/OpenRC/openrc/commit/3470eda3f5cea437a6de132b1ead3f27effd3902 (tl;dr /sbin/runscript was deprecated in a Dec 2013 release)\n\nSo all is working now. Only remaining known-issue I see is the end resulting image has an invalid profile setting, probably due to our temporary portage tree being put into a weird place -- I\u0027ve documented this issue and punted on it as it\u0027s trivially fixed on first boot (and you already have to sync in a new  portage tree anyway)","commit_id":"cfa1837d5bc0f08e3e32f4b3c8b0ae06d52ac10c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b07debce38926a19e8888458599eb436ab317985","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d5b1b2ba_df0f32b8","in_reply_to":"de688c32_6b36c7e2","updated":"2024-11-20 16:09:40.000000000","message":"Done","commit_id":"cfa1837d5bc0f08e3e32f4b3c8b0ae06d52ac10c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b07debce38926a19e8888458599eb436ab317985","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"f710cd71_446e62e3","updated":"2024-11-20 16:09:40.000000000","message":"Will push a revision.","commit_id":"52f003e83b4bcf42096be53a7530b62d0298e793"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"fcfcf7e512e7b04ad92317d442366856601bc359","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"02fd2619_ad0c5963","updated":"2024-11-20 02:15:42.000000000","message":"couple of minor comments, biggest thing is probably release notes","commit_id":"52f003e83b4bcf42096be53a7530b62d0298e793"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"a8778b57a118bf6feded601e6541b8622a4e85d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"950b04bc_c2460cf7","updated":"2024-11-21 00:22:52.000000000","message":"thanks, looks good","commit_id":"f831b3d0b6bbbc15afd4596c18982bc582d9a4bf"}],"diskimage_builder/elements/devuser/install.d/50-devuser":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7d1a141620ae529d0b96aba3e69f4798bd944a25","unresolved":true,"context_lines":[{"line_number":19,"context_line":"set -x"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if [ -n \"${DIB_DEV_USER_PWDLESS_SUDO}\" ]; then"},{"line_number":22,"context_line":"    mkdir -p /etc/sudoers.d/"},{"line_number":23,"context_line":"    cat \u003e /etc/sudoers.d/${DIB_DEV_USER_USERNAME} \u003c\u003c EOF"},{"line_number":24,"context_line":"${DIB_DEV_USER_USERNAME} ALL\u003d(ALL) NOPASSWD:ALL"},{"line_number":25,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":21,"id":"3591c2a3_6a27b946","line":22,"updated":"2024-11-25 22:12:53.000000000","message":"What permissions does /etc/sudoers.d/ end up with here as we don\u0027t use sudo and we\u0027re likely using the default umask? My local system has this set to `root:root 0750`. But also if /etc/sudoers.d/ doesn\u0027t exist does the sudo config load the configuration in that dir? This feels like it could be incomplete.\n\nI suspect for any platforms that already assume sudo this is a noop so I don\u0027t know that we need to fix anything here. More worried that gentoo might end up in a less than ideal spot.","commit_id":"f831b3d0b6bbbc15afd4596c18982bc582d9a4bf"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1cb1e366f2a74af340a092361443348a64c52cca","unresolved":true,"context_lines":[{"line_number":19,"context_line":"set -x"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if [ -n \"${DIB_DEV_USER_PWDLESS_SUDO}\" ]; then"},{"line_number":22,"context_line":"    mkdir -p /etc/sudoers.d/"},{"line_number":23,"context_line":"    cat \u003e /etc/sudoers.d/${DIB_DEV_USER_USERNAME} \u003c\u003c EOF"},{"line_number":24,"context_line":"${DIB_DEV_USER_USERNAME} ALL\u003d(ALL) NOPASSWD:ALL"},{"line_number":25,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":21,"id":"9c7e0084_37fa567f","line":22,"in_reply_to":"3591c2a3_6a27b946","updated":"2024-11-25 22:15:40.000000000","message":"This 100% works; I\u0027ve tested it -- this change was added out of neccessity during my troubleshooting. The default gentoo -- and default upstream -- config loads from /etc/sudoers.d/* if it exists; but it just doesn\u0027t by default on gentoo.","commit_id":"f831b3d0b6bbbc15afd4596c18982bc582d9a4bf"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f3356ea514b526c1fdfe4a78ea51f9edc8aa7dde","unresolved":true,"context_lines":[{"line_number":19,"context_line":"set -x"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if [ -n \"${DIB_DEV_USER_PWDLESS_SUDO}\" ]; then"},{"line_number":22,"context_line":"    mkdir -p /etc/sudoers.d/"},{"line_number":23,"context_line":"    cat \u003e /etc/sudoers.d/${DIB_DEV_USER_USERNAME} \u003c\u003c EOF"},{"line_number":24,"context_line":"${DIB_DEV_USER_USERNAME} ALL\u003d(ALL) NOPASSWD:ALL"},{"line_number":25,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":21,"id":"e137fa56_9ed8e3e5","line":22,"in_reply_to":"9c7e0084_37fa567f","updated":"2024-11-25 22:20:46.000000000","message":"I\u0027ve double checked that perms and ownership aren\u0027t touched if mkdir -p noops so this should be safe for all existing platforms that already have the dir in place.","commit_id":"f831b3d0b6bbbc15afd4596c18982bc582d9a4bf"}],"diskimage_builder/elements/gentoo/README.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f510c83dddc022a711c14a252c9756f842484e09","unresolved":true,"context_lines":[{"line_number":34,"context_line":"* Gentoo supports many different versions of python, in order to select one"},{"line_number":35,"context_line":"  you may use the `GENTOO_PYTHON_TARGETS` environment variable to select"},{"line_number":36,"context_line":"  the versions of python you want on your image.  The format of this variable"},{"line_number":37,"context_line":"  is a string as follows `\"python2_7 python3_6\"`."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* You can enable overlays using the `GENTOO_OVERLAYS` variable.  In it you"},{"line_number":40,"context_line":"  should put a space separated list of overlays.  The overlays must be in the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"fff13d65_a2053c09","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":46},"updated":"2024-07-19 19:58:13.000000000","message":"maybe replace this with a more current example?","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64850d54026003f77bb32b022d5f601d83ca387d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* Gentoo supports many different versions of python, in order to select one"},{"line_number":35,"context_line":"  you may use the `GENTOO_PYTHON_TARGETS` environment variable to select"},{"line_number":36,"context_line":"  the versions of python you want on your image.  The format of this variable"},{"line_number":37,"context_line":"  is a string as follows `\"python2_7 python3_6\"`."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* You can enable overlays using the `GENTOO_OVERLAYS` variable.  In it you"},{"line_number":40,"context_line":"  should put a space separated list of overlays.  The overlays must be in the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"58d767be_454b80ae","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":46},"in_reply_to":"792071b2_92ecf211","updated":"2024-11-14 23:09:24.000000000","message":"Done","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64850d54026003f77bb32b022d5f601d83ca387d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* Gentoo supports many different versions of python, in order to select one"},{"line_number":35,"context_line":"  you may use the `GENTOO_PYTHON_TARGETS` environment variable to select"},{"line_number":36,"context_line":"  the versions of python you want on your image.  The format of this variable"},{"line_number":37,"context_line":"  is a string as follows `\"python2_7 python3_6\"`."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* You can enable overlays using the `GENTOO_OVERLAYS` variable.  In it you"},{"line_number":40,"context_line":"  should put a space separated list of overlays.  The overlays must be in the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ed32af15_0904e3bd","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":46},"in_reply_to":"792071b2_92ecf211","updated":"2024-11-14 23:09:24.000000000","message":"Done","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43988c1fe3377bdd133cb4d71f5ba9b2f9bf8ecf","unresolved":true,"context_lines":[{"line_number":34,"context_line":"* Gentoo supports many different versions of python, in order to select one"},{"line_number":35,"context_line":"  you may use the `GENTOO_PYTHON_TARGETS` environment variable to select"},{"line_number":36,"context_line":"  the versions of python you want on your image.  The format of this variable"},{"line_number":37,"context_line":"  is a string as follows `\"python2_7 python3_6\"`."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* You can enable overlays using the `GENTOO_OVERLAYS` variable.  In it you"},{"line_number":40,"context_line":"  should put a space separated list of overlays.  The overlays must be in the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"792071b2_92ecf211","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":46},"in_reply_to":"fff13d65_a2053c09","updated":"2024-08-26 14:32:10.000000000","message":"This can also be done separately.","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"}],"diskimage_builder/elements/gentoo/bin/install-packages":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f510c83dddc022a711c14a252c9756f842484e09","unresolved":true,"context_lines":[{"line_number":132,"context_line":"        if [[ ! -f ${PORTDIR}/profiles ]]; then"},{"line_number":133,"context_line":"            emerge-webrsync -q"},{"line_number":134,"context_line":"        fi"},{"line_number":135,"context_line":"        # Gentoo\u0027s concept of package installation is slightly different."},{"line_number":136,"context_line":"        # We need to deselect all packages to clean, then use depclean to "},{"line_number":137,"context_line":"        # clean out undesired packages and their dependcies. It\u0027s the only"},{"line_number":138,"context_line":"        # reliable way to avoid `emerge` erroring a package isn\u0027t installed"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"411f7bf9_97753774","line":135,"updated":"2024-07-19 19:58:13.000000000","message":"different from what?","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"25947a9cb8a577538010d61435aae456eb72891e","unresolved":true,"context_lines":[{"line_number":132,"context_line":"        if [[ ! -f ${PORTDIR}/profiles ]]; then"},{"line_number":133,"context_line":"            emerge-webrsync -q"},{"line_number":134,"context_line":"        fi"},{"line_number":135,"context_line":"        # Gentoo\u0027s concept of package installation is slightly different."},{"line_number":136,"context_line":"        # We need to deselect all packages to clean, then use depclean to "},{"line_number":137,"context_line":"        # clean out undesired packages and their dependcies. It\u0027s the only"},{"line_number":138,"context_line":"        # reliable way to avoid `emerge` erroring a package isn\u0027t installed"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"e34ae23b_dbff2cff","line":135,"in_reply_to":"411f7bf9_97753774","updated":"2024-07-26 17:46:44.000000000","message":"Gentoo calculates the whole dependency set, potentially including build dependencies depending on options, everytime you perform a meaningful action. \n\nHere, we essentially are setting up state:\n- remove packages we don\u0027t want from the \"packages we don\u0027t want\" file\n- atomically (in one transaction) remove them all\n\nThis lets us remove \"N\" packages in linear time, and gives more reliable behavior overall.","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64850d54026003f77bb32b022d5f601d83ca387d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        if [[ ! -f ${PORTDIR}/profiles ]]; then"},{"line_number":133,"context_line":"            emerge-webrsync -q"},{"line_number":134,"context_line":"        fi"},{"line_number":135,"context_line":"        # Gentoo\u0027s concept of package installation is slightly different."},{"line_number":136,"context_line":"        # We need to deselect all packages to clean, then use depclean to "},{"line_number":137,"context_line":"        # clean out undesired packages and their dependcies. It\u0027s the only"},{"line_number":138,"context_line":"        # reliable way to avoid `emerge` erroring a package isn\u0027t installed"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"76fa749b_166913d7","line":135,"in_reply_to":"e34ae23b_dbff2cff","updated":"2024-11-14 23:09:24.000000000","message":"Done","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f510c83dddc022a711c14a252c9756f842484e09","unresolved":true,"context_lines":[{"line_number":133,"context_line":"            emerge-webrsync -q"},{"line_number":134,"context_line":"        fi"},{"line_number":135,"context_line":"        # Gentoo\u0027s concept of package installation is slightly different."},{"line_number":136,"context_line":"        # We need to deselect all packages to clean, then use depclean to "},{"line_number":137,"context_line":"        # clean out undesired packages and their dependcies. It\u0027s the only"},{"line_number":138,"context_line":"        # reliable way to avoid `emerge` erroring a package isn\u0027t installed"},{"line_number":139,"context_line":"        # on removal."}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"fd8e90c4_2f15cdfb","line":136,"updated":"2024-07-19 19:58:13.000000000","message":"nit: trailing space","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64850d54026003f77bb32b022d5f601d83ca387d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            emerge-webrsync -q"},{"line_number":134,"context_line":"        fi"},{"line_number":135,"context_line":"        # Gentoo\u0027s concept of package installation is slightly different."},{"line_number":136,"context_line":"        # We need to deselect all packages to clean, then use depclean to "},{"line_number":137,"context_line":"        # clean out undesired packages and their dependcies. It\u0027s the only"},{"line_number":138,"context_line":"        # reliable way to avoid `emerge` erroring a package isn\u0027t installed"},{"line_number":139,"context_line":"        # on removal."}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9e42a9f8_1861225c","line":136,"in_reply_to":"fd8e90c4_2f15cdfb","updated":"2024-11-14 23:09:24.000000000","message":"Done","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f510c83dddc022a711c14a252c9756f842484e09","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        fi"},{"line_number":135,"context_line":"        # Gentoo\u0027s concept of package installation is slightly different."},{"line_number":136,"context_line":"        # We need to deselect all packages to clean, then use depclean to "},{"line_number":137,"context_line":"        # clean out undesired packages and their dependcies. It\u0027s the only"},{"line_number":138,"context_line":"        # reliable way to avoid `emerge` erroring a package isn\u0027t installed"},{"line_number":139,"context_line":"        # on removal."},{"line_number":140,"context_line":"        for PKG in ${PKGS}; do"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"d21aa3f5_db341228","line":137,"range":{"start_line":137,"start_character":49,"end_line":137,"end_character":59},"updated":"2024-07-19 19:58:13.000000000","message":"dependencies","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64850d54026003f77bb32b022d5f601d83ca387d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        fi"},{"line_number":135,"context_line":"        # Gentoo\u0027s concept of package installation is slightly different."},{"line_number":136,"context_line":"        # We need to deselect all packages to clean, then use depclean to "},{"line_number":137,"context_line":"        # clean out undesired packages and their dependcies. It\u0027s the only"},{"line_number":138,"context_line":"        # reliable way to avoid `emerge` erroring a package isn\u0027t installed"},{"line_number":139,"context_line":"        # on removal."},{"line_number":140,"context_line":"        for PKG in ${PKGS}; do"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"49408050_eb138940","line":137,"range":{"start_line":137,"start_character":49,"end_line":137,"end_character":59},"in_reply_to":"d21aa3f5_db341228","updated":"2024-11-14 23:09:24.000000000","message":"Done","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f510c83dddc022a711c14a252c9756f842484e09","unresolved":true,"context_lines":[{"line_number":139,"context_line":"        # on removal."},{"line_number":140,"context_line":"        for PKG in ${PKGS}; do"},{"line_number":141,"context_line":"            # Removes the package from \"world\" list of desired packages"},{"line_number":142,"context_line":"            install_gentoo_packages --deselect $PKG "},{"line_number":143,"context_line":"        done"},{"line_number":144,"context_line":"        # Uninstalls any packages not in \"world\" and their dependencies"},{"line_number":145,"context_line":"        install_gentoo_packages --depclean"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"05a93cb8_58e00ecf","line":142,"updated":"2024-07-19 19:58:13.000000000","message":"nit: trailing space","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64850d54026003f77bb32b022d5f601d83ca387d","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # on removal."},{"line_number":140,"context_line":"        for PKG in ${PKGS}; do"},{"line_number":141,"context_line":"            # Removes the package from \"world\" list of desired packages"},{"line_number":142,"context_line":"            install_gentoo_packages --deselect $PKG "},{"line_number":143,"context_line":"        done"},{"line_number":144,"context_line":"        # Uninstalls any packages not in \"world\" and their dependencies"},{"line_number":145,"context_line":"        install_gentoo_packages --depclean"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"aa42dae3_d25e2eb5","line":142,"in_reply_to":"05a93cb8_58e00ecf","updated":"2024-11-14 23:09:24.000000000","message":"Done","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"}],"diskimage_builder/elements/gentoo/environment.d/00-gentoo-envars.bash":[{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"fcfcf7e512e7b04ad92317d442366856601bc359","unresolved":true,"context_lines":[{"line_number":7,"context_line":"export GENTOO_OVERLAYS\u003d${GENTOO_OVERLAYS:-\u0027\u0027}"},{"line_number":8,"context_line":"export GENTOO_EMERGE_DEFAULT_OPTS\u003d${GENTOO_EMERGE_DEFAULT_OPTS:-\"--binpkg-respect-use --rebuilt-binaries\u003dy --usepkg\u003dy --with-bdeps\u003dy --binpkg-changed-deps\u003dy --quiet --jobs\u003d2 --autounmask\u003dn\"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [[ \"${ARCH}\" \u003d\u003d \u0027amd64\u0027 ]]; then"},{"line_number":11,"context_line":"    export GENTOO_ARCH\u003d\u0027amd64\u0027"},{"line_number":12,"context_line":"elif [[ \"${ARCH}\" \u003d\u003d \u0027arm64\u0027 ]]; then"},{"line_number":13,"context_line":"    # NOTE(JayF): This does not currently support aarch64_be, Gentoo\u0027s"}],"source_content_type":"text/x-sh","patch_set":19,"id":"6387e505_c4fbebb1","line":10,"updated":"2024-11-20 02:15:42.000000000","message":"Is there a reason you don\u0027t use $ARCH by itself and instead create $GENTOO_ARCH?","commit_id":"52f003e83b4bcf42096be53a7530b62d0298e793"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"72fcb129b5a4f05030890137c802a50b809c50b5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"export GENTOO_OVERLAYS\u003d${GENTOO_OVERLAYS:-\u0027\u0027}"},{"line_number":8,"context_line":"export GENTOO_EMERGE_DEFAULT_OPTS\u003d${GENTOO_EMERGE_DEFAULT_OPTS:-\"--binpkg-respect-use --rebuilt-binaries\u003dy --usepkg\u003dy --with-bdeps\u003dy --binpkg-changed-deps\u003dy --quiet --jobs\u003d2 --autounmask\u003dn\"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [[ \"${ARCH}\" \u003d\u003d \u0027amd64\u0027 ]]; then"},{"line_number":11,"context_line":"    export GENTOO_ARCH\u003d\u0027amd64\u0027"},{"line_number":12,"context_line":"elif [[ \"${ARCH}\" \u003d\u003d \u0027arm64\u0027 ]]; then"},{"line_number":13,"context_line":"    # NOTE(JayF): This does not currently support aarch64_be, Gentoo\u0027s"}],"source_content_type":"text/x-sh","patch_set":19,"id":"ffd76c80_3910097e","line":10,"in_reply_to":"5b380d45_9af54c0e","updated":"2024-11-20 17:40:37.000000000","message":"Done","commit_id":"52f003e83b4bcf42096be53a7530b62d0298e793"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b07debce38926a19e8888458599eb436ab317985","unresolved":true,"context_lines":[{"line_number":7,"context_line":"export GENTOO_OVERLAYS\u003d${GENTOO_OVERLAYS:-\u0027\u0027}"},{"line_number":8,"context_line":"export GENTOO_EMERGE_DEFAULT_OPTS\u003d${GENTOO_EMERGE_DEFAULT_OPTS:-\"--binpkg-respect-use --rebuilt-binaries\u003dy --usepkg\u003dy --with-bdeps\u003dy --binpkg-changed-deps\u003dy --quiet --jobs\u003d2 --autounmask\u003dn\"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [[ \"${ARCH}\" \u003d\u003d \u0027amd64\u0027 ]]; then"},{"line_number":11,"context_line":"    export GENTOO_ARCH\u003d\u0027amd64\u0027"},{"line_number":12,"context_line":"elif [[ \"${ARCH}\" \u003d\u003d \u0027arm64\u0027 ]]; then"},{"line_number":13,"context_line":"    # NOTE(JayF): This does not currently support aarch64_be, Gentoo\u0027s"}],"source_content_type":"text/x-sh","patch_set":19,"id":"5b380d45_9af54c0e","line":10,"in_reply_to":"6387e505_c4fbebb1","updated":"2024-11-20 16:09:40.000000000","message":"I think originally I was writing this to *also support* the 32 bit ARM + BE ARM variants, but given I\u0027m unconditionally setting GENTOO_ARCH I apparently have lost that. Generally, my assumption is what Gentoo uses to identify an arch may not match what DIB uses to identify an arch. I can remove this as it\u0027s not needed for the options we support.","commit_id":"52f003e83b4bcf42096be53a7530b62d0298e793"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"72fcb129b5a4f05030890137c802a50b809c50b5","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    declare -a GENTOO_EMERGE_ENV"},{"line_number":31,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"USE\u003d\\\"-build\\\"\")"},{"line_number":32,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"FEATURES\u003d\\\"binpkg-multi-instance buildpkg parallel-fetch parallel-install\\\"\")"},{"line_number":33,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PKGDIR\u003d\\\"/tmp/portage-pkgdir\\\"\")"},{"line_number":34,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"DISTDIR\u003d\\\"/tmp/portage-distdir\\\"\")"},{"line_number":35,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PORTDIR\u003d\\\"/tmp/portage-portdir\\\"\")"},{"line_number":36,"context_line":"    export GENTOO_EMERGE_ENV"}],"source_content_type":"text/x-sh","patch_set":19,"id":"5744d4f3_ec5515a6","line":33,"updated":"2024-11-20 17:40:37.000000000","message":"Note: the PORTDIR being in /tmp is what causes the side effect of the profile being invalid in the image, since the profile is a symlink into the portage tree. I think a follow on change to fix this would be manually setting the symlink to the gentoo-default location (/var/db/repos/gentoo/path/to/profile) as one of the final steps in the build.","commit_id":"52f003e83b4bcf42096be53a7530b62d0298e793"}],"diskimage_builder/elements/gentoo/root.d/10-gentoo-image":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f510c83dddc022a711c14a252c9756f842484e09","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    F_SUFFIX\u003d\"${F_SUFFIX}-openrc\""},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DIB_CLOUD_SOURCE\u003d${DIB_CLOUD_SOURCE:-\"http://distfiles.gentoo.org/releases/${GENTOO_ARCH}/autobuilds/latest-stage3-${GENTOO_ARCH}${F_SUFFIX}.txt\"}"},{"line_number":35,"context_line":"echo \"Fetching available stages from ${DIB_CLOUD_SOURCE} for profile ${GENTOO_PROFILE}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"STAGE_LIST\u003d$(curl \"${DIB_CLOUD_SOURCE}\" -s -f || true)"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"da4424e7_e75a6f3c","line":34,"range":{"start_line":34,"start_character":38,"end_line":34,"end_character":42},"updated":"2024-07-19 19:58:13.000000000","message":"this seems to redirect to https, so use that from the start?","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64850d54026003f77bb32b022d5f601d83ca387d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    F_SUFFIX\u003d\"${F_SUFFIX}-openrc\""},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DIB_CLOUD_SOURCE\u003d${DIB_CLOUD_SOURCE:-\"http://distfiles.gentoo.org/releases/${GENTOO_ARCH}/autobuilds/latest-stage3-${GENTOO_ARCH}${F_SUFFIX}.txt\"}"},{"line_number":35,"context_line":"echo \"Fetching available stages from ${DIB_CLOUD_SOURCE} for profile ${GENTOO_PROFILE}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"STAGE_LIST\u003d$(curl \"${DIB_CLOUD_SOURCE}\" -s -f || true)"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"29b33347_1ef0f837","line":34,"range":{"start_line":34,"start_character":38,"end_line":34,"end_character":42},"in_reply_to":"3462334f_ed0248fa","updated":"2024-11-14 23:09:24.000000000","message":"Done","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64850d54026003f77bb32b022d5f601d83ca387d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    F_SUFFIX\u003d\"${F_SUFFIX}-openrc\""},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DIB_CLOUD_SOURCE\u003d${DIB_CLOUD_SOURCE:-\"http://distfiles.gentoo.org/releases/${GENTOO_ARCH}/autobuilds/latest-stage3-${GENTOO_ARCH}${F_SUFFIX}.txt\"}"},{"line_number":35,"context_line":"echo \"Fetching available stages from ${DIB_CLOUD_SOURCE} for profile ${GENTOO_PROFILE}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"STAGE_LIST\u003d$(curl \"${DIB_CLOUD_SOURCE}\" -s -f || true)"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"91561ac6_bceb2a96","line":34,"range":{"start_line":34,"start_character":38,"end_line":34,"end_character":42},"in_reply_to":"3462334f_ed0248fa","updated":"2024-11-14 23:09:24.000000000","message":"Done","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43988c1fe3377bdd133cb4d71f5ba9b2f9bf8ecf","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    F_SUFFIX\u003d\"${F_SUFFIX}-openrc\""},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DIB_CLOUD_SOURCE\u003d${DIB_CLOUD_SOURCE:-\"http://distfiles.gentoo.org/releases/${GENTOO_ARCH}/autobuilds/latest-stage3-${GENTOO_ARCH}${F_SUFFIX}.txt\"}"},{"line_number":35,"context_line":"echo \"Fetching available stages from ${DIB_CLOUD_SOURCE} for profile ${GENTOO_PROFILE}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"STAGE_LIST\u003d$(curl \"${DIB_CLOUD_SOURCE}\" -s -f || true)"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3462334f_ed0248fa","line":34,"range":{"start_line":34,"start_character":38,"end_line":34,"end_character":42},"in_reply_to":"da4424e7_e75a6f3c","updated":"2024-08-26 14:32:10.000000000","message":"++","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f510c83dddc022a711c14a252c9756f842484e09","unresolved":true,"context_lines":[{"line_number":45,"context_line":"UPSTREAM_FILENAME\u003d$(echo \"${STAGE_LIST}\" | grep -B1 \u0027BEGIN PGP SIGNATURE\u0027 | head -n1 | cut -d\\  -f1)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"echo \"Chose ${UPSTREAM_FILENAME} as candidate stage tarball\""},{"line_number":48,"context_line":"BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-\"http://distfiles.gentoo.org/releases/${GENTOO_ARCH}/autobuilds/${UPSTREAM_FILENAME}\"}"},{"line_number":49,"context_line":"BASE_IMAGE_FILE_SUFFIX\u003d${BASE_IMAGE_FILE_SUFFIX:-\"$(basename \"${BASE_IMAGE_FILE}\" | cut -d. -f 2,3)\"}"},{"line_number":50,"context_line":"FILENAME_BASE\u003d\"gentoo-${GENTOO_PROFILE//\\//\\-}.${BASE_IMAGE_FILE_SUFFIX}\""},{"line_number":51,"context_line":"SIGNATURE_FILE\u003d\"${SIGNATURE_FILE:-${BASE_IMAGE_FILE}.asc}\""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"aeafab82_89f0778a","line":48,"updated":"2024-07-19 19:58:13.000000000","message":"dito","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64850d54026003f77bb32b022d5f601d83ca387d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"UPSTREAM_FILENAME\u003d$(echo \"${STAGE_LIST}\" | grep -B1 \u0027BEGIN PGP SIGNATURE\u0027 | head -n1 | cut -d\\  -f1)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"echo \"Chose ${UPSTREAM_FILENAME} as candidate stage tarball\""},{"line_number":48,"context_line":"BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-\"http://distfiles.gentoo.org/releases/${GENTOO_ARCH}/autobuilds/${UPSTREAM_FILENAME}\"}"},{"line_number":49,"context_line":"BASE_IMAGE_FILE_SUFFIX\u003d${BASE_IMAGE_FILE_SUFFIX:-\"$(basename \"${BASE_IMAGE_FILE}\" | cut -d. -f 2,3)\"}"},{"line_number":50,"context_line":"FILENAME_BASE\u003d\"gentoo-${GENTOO_PROFILE//\\//\\-}.${BASE_IMAGE_FILE_SUFFIX}\""},{"line_number":51,"context_line":"SIGNATURE_FILE\u003d\"${SIGNATURE_FILE:-${BASE_IMAGE_FILE}.asc}\""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"f89f3e07_aab5c11d","line":48,"in_reply_to":"aeafab82_89f0778a","updated":"2024-11-14 23:09:24.000000000","message":"Done","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f510c83dddc022a711c14a252c9756f842484e09","unresolved":true,"context_lines":[{"line_number":82,"context_line":"# you want systemd-networkd as the network manager and create a"},{"line_number":83,"context_line":"# broken symlink to /run/... if the base image doesn\u0027t have one."},{"line_number":84,"context_line":"# This broken link confuses things like dhclient."},{"line_number":85,"context_line":"# [1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1197204W"},{"line_number":86,"context_line":"echo -e \"# This file intentionally left blank\\n\" | sudo tee \"${TARGET_ROOT}\"/etc/resolv.conf"},{"line_number":87,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"a87de2dc_380e939e","line":85,"range":{"start_line":85,"start_character":57,"end_line":85,"end_character":58},"updated":"2024-07-19 19:58:13.000000000","message":"this breaks the bz url, editing error?","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64850d54026003f77bb32b022d5f601d83ca387d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# you want systemd-networkd as the network manager and create a"},{"line_number":83,"context_line":"# broken symlink to /run/... if the base image doesn\u0027t have one."},{"line_number":84,"context_line":"# This broken link confuses things like dhclient."},{"line_number":85,"context_line":"# [1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1197204W"},{"line_number":86,"context_line":"echo -e \"# This file intentionally left blank\\n\" | sudo tee \"${TARGET_ROOT}\"/etc/resolv.conf"},{"line_number":87,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"769b4d2e_54e506db","line":85,"range":{"start_line":85,"start_character":57,"end_line":85,"end_character":58},"in_reply_to":"a87de2dc_380e939e","updated":"2024-11-14 23:09:24.000000000","message":"Done","commit_id":"939a27e9c01aaf06cbef79a34c84bb1deafd15b8"}],"diskimage_builder/elements/growroot/init-scripts/openrc/growroot":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7d1a141620ae529d0b96aba3e69f4798bd944a25","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/sbin/openrc-run"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"start() {"},{"line_number":4,"context_line":"    /usr/local/sbin/growroot"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"1006ef8f_4e8c142e","line":1,"updated":"2024-11-25 22:12:53.000000000","message":"Similar to the sudoer setup this element could theoretically be used by other platforms too. That said I think gentoo is the only one using openrc? Calling it out in case this path isn\u0027t consistent across the platforms that may or may not be using openrc.","commit_id":"f831b3d0b6bbbc15afd4596c18982bc582d9a4bf"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1cb1e366f2a74af340a092361443348a64c52cca","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/sbin/openrc-run"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"start() {"},{"line_number":4,"context_line":"    /usr/local/sbin/growroot"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"c55216ad_9ac917ea","line":1,"in_reply_to":"1006ef8f_4e8c142e","updated":"2024-11-25 22:15:40.000000000","message":"This fix was taken directly from openrc upstream, not from a gentoo-specific source. Runscript was deprecated over ten years ago -- I\u0027m fairly sure nobody was using this element on anything openrc at all or else they would\u0027ve seen the breakage.","commit_id":"f831b3d0b6bbbc15afd4596c18982bc582d9a4bf"}],"releasenotes/notes/gentoo-profile-23.0-99357c919639bd3f.yaml":[{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"fcfcf7e512e7b04ad92317d442366856601bc359","unresolved":true,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - Supports Gentoo profile 23.0 and removes support for the nonworking"},{"line_number":3,"context_line":"    17.1 and 17.0 profiles."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"8cc1adc3_7198dfb6","line":2,"updated":"2024-11-20 02:15:42.000000000","message":"I think I\u0027d like to a bit more here.","commit_id":"52f003e83b4bcf42096be53a7530b62d0298e793"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b07debce38926a19e8888458599eb436ab317985","unresolved":true,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - Supports Gentoo profile 23.0 and removes support for the nonworking"},{"line_number":3,"context_line":"    17.1 and 17.0 profiles."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"0fa8af9f_1ad9d58a","line":2,"in_reply_to":"8cc1adc3_7198dfb6","updated":"2024-11-20 16:09:40.000000000","message":"Fair enough, I wrote this when the patch was /much/ smaller.","commit_id":"52f003e83b4bcf42096be53a7530b62d0298e793"}]}
