)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c6c69c8dcacb207b68244a332bbea11fcd838458","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6830e2d6_d10cadd8","updated":"2024-07-12 16:40:17.000000000","message":"-1 for the super minor release notes bug. Otherwise I think this looks fine.","commit_id":"16d5ed906d20034f86f6a1e760fff378e9b9c967"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f9cdff2b7f2c735425c698dbb7db0894ee6341f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"732362ed_c5bcbfb1","updated":"2024-08-15 18:32:36.000000000","message":"-1 for the simple revision on the reported element name, otherwise LGTM.","commit_id":"f83c94da6d430ffbbee4d436098ebf20dd7cb4f7"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"ac5713673f5c84b9bbfb1afa95a37c8915cf9caf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ff7ce9cd_bff3c5d9","in_reply_to":"6e88ae0c_2ae09ea3","updated":"2024-09-02 13:29:25.000000000","message":"If there is a suggestion for a new element name, I am open. Otherwise I think we can just merge.","commit_id":"f83c94da6d430ffbbee4d436098ebf20dd7cb4f7"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"d07bd6804f0c01ee362714b2051e7bc1761faeb9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6e88ae0c_2ae09ea3","in_reply_to":"732362ed_c5bcbfb1","updated":"2024-08-17 16:47:24.000000000","message":"I am not sure what you mean by \"simple revision\".\nCan you please elaborate on this comment a bit?","commit_id":"f83c94da6d430ffbbee4d436098ebf20dd7cb4f7"}],"diskimage_builder/elements/autoupdates/pkg-map":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c6c69c8dcacb207b68244a332bbea11fcd838458","unresolved":true,"context_lines":[{"line_number":6,"context_line":"        \"debian\":{"},{"line_number":7,"context_line":"            \"autoupdates\": \"unattended-upgrades\""},{"line_number":8,"context_line":"        },"},{"line_number":9,"context_line":"        \"suse\": {"},{"line_number":10,"context_line":"            \"autoupdates\": \"\""},{"line_number":11,"context_line":"        },"},{"line_number":12,"context_line":"        \"gentoo\": {"},{"line_number":13,"context_line":"            \"autoupdates\": \"\""},{"line_number":14,"context_line":"        }"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"}"},{"line_number":17,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"f61b95ed_17596786","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":9},"updated":"2024-07-12 16:40:17.000000000","message":"Do we add these families here so that if the element is enabled on these platforms we get the nicer error message from 82-enable-autoupdate rather than failures from the package managers on these platforms being unable to install `autoupdates`?","commit_id":"16d5ed906d20034f86f6a1e760fff378e9b9c967"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f9cdff2b7f2c735425c698dbb7db0894ee6341f2","unresolved":true,"context_lines":[{"line_number":6,"context_line":"        \"debian\":{"},{"line_number":7,"context_line":"            \"autoupdates\": \"unattended-upgrades\""},{"line_number":8,"context_line":"        },"},{"line_number":9,"context_line":"        \"suse\": {"},{"line_number":10,"context_line":"            \"autoupdates\": \"\""},{"line_number":11,"context_line":"        },"},{"line_number":12,"context_line":"        \"gentoo\": {"},{"line_number":13,"context_line":"            \"autoupdates\": \"\""},{"line_number":14,"context_line":"        }"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"}"},{"line_number":17,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"f5ab8d25_71f0db87","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":9},"in_reply_to":"4045b278_b0ff9e94","updated":"2024-08-15 18:32:36.000000000","message":"I think this is likely okay. The big thing is if the overall script will fail and provide runtime execution feedback so users can understand if it is supported, or not.","commit_id":"16d5ed906d20034f86f6a1e760fff378e9b9c967"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"ac5713673f5c84b9bbfb1afa95a37c8915cf9caf","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        \"debian\":{"},{"line_number":7,"context_line":"            \"autoupdates\": \"unattended-upgrades\""},{"line_number":8,"context_line":"        },"},{"line_number":9,"context_line":"        \"suse\": {"},{"line_number":10,"context_line":"            \"autoupdates\": \"\""},{"line_number":11,"context_line":"        },"},{"line_number":12,"context_line":"        \"gentoo\": {"},{"line_number":13,"context_line":"            \"autoupdates\": \"\""},{"line_number":14,"context_line":"        }"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"}"},{"line_number":17,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"744737f4_7ec342ec","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":9},"in_reply_to":"f5ab8d25_71f0db87","updated":"2024-09-02 13:29:25.000000000","message":"I think this will work as it is. I have added more verbose output in other places.","commit_id":"16d5ed906d20034f86f6a1e760fff378e9b9c967"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"17ef46e14d95d616075e2a8c71bfd3b77a888a73","unresolved":true,"context_lines":[{"line_number":6,"context_line":"        \"debian\":{"},{"line_number":7,"context_line":"            \"autoupdates\": \"unattended-upgrades\""},{"line_number":8,"context_line":"        },"},{"line_number":9,"context_line":"        \"suse\": {"},{"line_number":10,"context_line":"            \"autoupdates\": \"\""},{"line_number":11,"context_line":"        },"},{"line_number":12,"context_line":"        \"gentoo\": {"},{"line_number":13,"context_line":"            \"autoupdates\": \"\""},{"line_number":14,"context_line":"        }"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"}"},{"line_number":17,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"4045b278_b0ff9e94","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":9},"in_reply_to":"f61b95ed_17596786","updated":"2024-07-14 21:35:19.000000000","message":"I actually dont know 😞. I copied this from another element, and I assumed that it is so for future development. As far as this element is concerned, it is only tested in Ubuntu, Rocky and Centos, If you feel that I should remove it, I will.\nI suspect though, that if you try to build a gentoo image for example, The element wail fail https://review.opendev.org/c/openstack/diskimage-builder/+/924069/3/diskimage_builder/elements/autoupdates/post-install.d/82-enable-autoupdate#31","commit_id":"16d5ed906d20034f86f6a1e760fff378e9b9c967"}],"diskimage_builder/elements/autoupdates/post-install.d/82-enable-autoupdate":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f9cdff2b7f2c735425c698dbb7db0894ee6341f2","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        elif [[ $DISTRO_NAME \u003d~ (centos|rocky|rhel|openeuler)$ ]]; then"},{"line_number":29,"context_line":"            systemctl enable dnf-automatic.timer"},{"line_number":30,"context_line":"        else"},{"line_number":31,"context_line":"            echo \"unsupported distro for automatic updates\""},{"line_number":32,"context_line":"            exit 1"},{"line_number":33,"context_line":"        fi"},{"line_number":34,"context_line":"esac"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"0bb596b9_6b697ab4","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":18},"updated":"2024-08-15 18:32:36.000000000","message":"Specifically, this is good since it provided as overall feedback to the user. We might want this to be slightly more verbose, and to utilize the specific element name is used.","commit_id":"f83c94da6d430ffbbee4d436098ebf20dd7cb4f7"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"ac5713673f5c84b9bbfb1afa95a37c8915cf9caf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        elif [[ $DISTRO_NAME \u003d~ (centos|rocky|rhel|openeuler)$ ]]; then"},{"line_number":29,"context_line":"            systemctl enable dnf-automatic.timer"},{"line_number":30,"context_line":"        else"},{"line_number":31,"context_line":"            echo \"unsupported distro for automatic updates\""},{"line_number":32,"context_line":"            exit 1"},{"line_number":33,"context_line":"        fi"},{"line_number":34,"context_line":"esac"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"95e3c9af_05b0f27b","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":18},"in_reply_to":"0bb596b9_6b697ab4","updated":"2024-09-02 13:29:25.000000000","message":"I made this more verbose","commit_id":"f83c94da6d430ffbbee4d436098ebf20dd7cb4f7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"2e55aece9274ade48dee46e8947f3275e62e68cb","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    systemd)"},{"line_number":26,"context_line":"        if [[ $DISTRO_NAME \u003d~ (ubuntu|debian)$ ]]; then"},{"line_number":27,"context_line":"            systemctl enable unattended-upgrades.service"},{"line_number":28,"context_line":"        elif [[ $DISTRO_NAME \u003d~ (centos|rocky|rhel|openeuler)$ ]]; then"},{"line_number":29,"context_line":"            systemctl enable dnf-automatic.timer"},{"line_number":30,"context_line":"        else"},{"line_number":31,"context_line":"            echo \"The \u0027autoupdates\u0027 element does not support this distribution.\""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"c20ecee6_b0444af7","line":28,"updated":"2024-09-03 02:44:35.000000000","message":"nit: fedora can be in the list too","commit_id":"7e1bb7483189d078d7e4539c73f797b5f6c079ca"}],"diskimage_builder/elements/autoupdates/root.d/61-create-update-config":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c6c69c8dcacb207b68244a332bbea11fcd838458","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if [[ -n ${DIB_DEB_UPDATES_CONF:-} ]]; then"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    sudo cp ${DIB_DEB_UPDATES_CONF} $TARGET_ROOT/etc/apt/apt.conf.d/50unattended-upgrades"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"fi"},{"line_number":29,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"789c7aaa_874769a7","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":8},"updated":"2024-07-12 16:40:17.000000000","message":"I guess sudo is required because while we are copying into the TARGET_ROOT that filesystem tree already has ownership of things like apt.config.d/ set such that only root can write to the directory?","commit_id":"16d5ed906d20034f86f6a1e760fff378e9b9c967"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"17ef46e14d95d616075e2a8c71bfd3b77a888a73","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if [[ -n ${DIB_DEB_UPDATES_CONF:-} ]]; then"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    sudo cp ${DIB_DEB_UPDATES_CONF} $TARGET_ROOT/etc/apt/apt.conf.d/50unattended-upgrades"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"fi"},{"line_number":29,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"dccf55e4_ae3a53b4","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":8},"in_reply_to":"789c7aaa_874769a7","updated":"2024-07-14 21:35:19.000000000","message":"Yes I think so","commit_id":"16d5ed906d20034f86f6a1e760fff378e9b9c967"}],"releasenotes/notes/add-autoupdates-element-8225a5d8b19cec74.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c6c69c8dcacb207b68244a332bbea11fcd838458","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    A new element ``autoupdates`` is added to DIB. This element, with proper"},{"line_number":5,"context_line":"    configuration, will enable and configure cloud images to have a system that"},{"line_number":6,"context_line":"    automatically updates the image, from the upstream binaries. To this end,"},{"line_number":7,"context_line":"    ``DIB_DEB_UPDATES_CONF`` or ``DIB_DEB_UPDATES_CONF`` must be set during build time."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The ``autoupdates`` element has only been tested in Rocky and Ubuntu images."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0d6c2d50_17d69e63","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":54},"updated":"2024-07-12 16:40:17.000000000","message":"This variable is the same as the previous one in the sentence. I suspect it was meant to be the `DIB_YUM_UPDATES_CONF` variable.","commit_id":"16d5ed906d20034f86f6a1e760fff378e9b9c967"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"17ef46e14d95d616075e2a8c71bfd3b77a888a73","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    A new element ``autoupdates`` is added to DIB. This element, with proper"},{"line_number":5,"context_line":"    configuration, will enable and configure cloud images to have a system that"},{"line_number":6,"context_line":"    automatically updates the image, from the upstream binaries. To this end,"},{"line_number":7,"context_line":"    ``DIB_DEB_UPDATES_CONF`` or ``DIB_DEB_UPDATES_CONF`` must be set during build time."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The ``autoupdates`` element has only been tested in Rocky and Ubuntu images."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"971e2524_8c70aeb7","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":54},"in_reply_to":"0d6c2d50_17d69e63","updated":"2024-07-14 21:35:19.000000000","message":"Acknowledged","commit_id":"16d5ed906d20034f86f6a1e760fff378e9b9c967"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a33732f9fd37376e004c124f4a394787487e02ad","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    A new element ``autoupdates`` is added to DIB. This element, with proper"},{"line_number":5,"context_line":"    configuration, will enable and configure cloud images to have a system that"},{"line_number":6,"context_line":"    automatically updates the image, from the upstream binaries. To this end,"},{"line_number":7,"context_line":"    ``DIB_DEB_UPDATES_CONF`` or ``DIB_YUMiUPDATES_CONF`` must be set during build time."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The ``autoupdates`` element has only been tested in Rocky and Ubuntu images."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c3a81179_d043b162","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":44},"updated":"2024-07-15 05:51:30.000000000","message":"YUMi Updates 😊","commit_id":"8aaa51de3f0518a9d192d7d03bc7fdeffde8b5cc"},{"author":{"_account_id":22540,"name":"Harry Kominos","display_name":"hkominos","email":"hkominos@gmail.com","username":"hkominos"},"change_message_id":"fd79b9499819667b8e695f295a79ab099d29ed4b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    A new element ``autoupdates`` is added to DIB. This element, with proper"},{"line_number":5,"context_line":"    configuration, will enable and configure cloud images to have a system that"},{"line_number":6,"context_line":"    automatically updates the image, from the upstream binaries. To this end,"},{"line_number":7,"context_line":"    ``DIB_DEB_UPDATES_CONF`` or ``DIB_YUMiUPDATES_CONF`` must be set during build time."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The ``autoupdates`` element has only been tested in Rocky and Ubuntu images."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2a08a47b_03f1d0c7","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":44},"in_reply_to":"c3a81179_d043b162","updated":"2024-07-15 13:36:37.000000000","message":"Fair point 😊","commit_id":"8aaa51de3f0518a9d192d7d03bc7fdeffde8b5cc"}]}