)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"46495c467880dbfbc8957458d41f7f2dad4093a7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Manuel CREACH \u003cmcr.opensource@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-12 14:39:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"On nodes with Fiber Channel multipath, , the growvols command is failing sometimes with the following stack trace :"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Traceback (most recent call last):"},{"line_number":10,"context_line":"  File \"/usr/local/sbin/growvols\", line 650, in \u003cmodule\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"82cdc64e_9d579775","line":7,"updated":"2024-07-12 16:29:42.000000000","message":"Nit we typically expect commit messages to come with a subject line before jumping into the details. For this commit something like\n\n```\nFix growvols partition number detection\n```\n\nwould be appropriate.","commit_id":"15e68d57ff9ef4a13d1b4d0cd5f62fa9c966231d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a385d835b52a0cb90be675bf8da70d43dde716e3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Manuel CREACH \u003cmcr.opensource@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-12 14:39:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"On nodes with Fiber Channel multipath, , the growvols command is failing sometimes with the following stack trace :"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Traceback (most recent call last):"},{"line_number":10,"context_line":"  File \"/usr/local/sbin/growvols\", line 650, in \u003cmodule\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e8244d3c_270c5878","line":7,"in_reply_to":"82cdc64e_9d579775","updated":"2025-05-05 22:13:06.000000000","message":"Done","commit_id":"15e68d57ff9ef4a13d1b4d0cd5f62fa9c966231d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a385d835b52a0cb90be675bf8da70d43dde716e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dda82aae_9144f09a","updated":"2025-05-05 22:13:06.000000000","message":"Since some time has gone without any updated, I decided to address comments and try to improve the fix to also support a custom configures partition_delimiter.","commit_id":"ffa41396580fc3e449662d8d4ac761549867aa55"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b2aabbc20d8d661c2d57993df70d342680a0b110","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4a12c924_da56d870","updated":"2025-05-06 08:24:56.000000000","message":"recheck","commit_id":"ff5c11c0952771ce1ae85078a347dc471da68ba1"}],"diskimage_builder/elements/growvols/static/usr/local/sbin/growvols":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"46495c467880dbfbc8957458d41f7f2dad4093a7","unresolved":true,"context_lines":[{"line_number":338,"context_line":"            if dev_name in seen_devs:"},{"line_number":339,"context_line":"                continue"},{"line_number":340,"context_line":"            seen_devs.add(dev_name)"},{"line_number":341,"context_line":"            max_partnum \u003d max(max_partnum, int(dev_name[disk_name_length:].replace(\"p\", \"\")))"},{"line_number":342,"context_line":"        return max_partnum + 1"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"842cf7d2_62ec7b41","line":341,"updated":"2024-07-12 16:29:42.000000000","message":"In addition to addressing the linter length check it might also be a good idea to have a small comment here explaining why the string modification is necessary. It may not be apparent to future developers particularly if they don\u0027t have any local disks that result in using the p prefix for the partition number.","commit_id":"15e68d57ff9ef4a13d1b4d0cd5f62fa9c966231d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a385d835b52a0cb90be675bf8da70d43dde716e3","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            if dev_name in seen_devs:"},{"line_number":339,"context_line":"                continue"},{"line_number":340,"context_line":"            seen_devs.add(dev_name)"},{"line_number":341,"context_line":"            max_partnum \u003d max(max_partnum, int(dev_name[disk_name_length:].replace(\"p\", \"\")))"},{"line_number":342,"context_line":"        return max_partnum + 1"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"93134164_6451f4a7","line":341,"in_reply_to":"37daf62a_c85a2aa9","updated":"2025-05-05 22:13:06.000000000","message":"Marking this resolved, this change need re-reviewing.","commit_id":"15e68d57ff9ef4a13d1b4d0cd5f62fa9c966231d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6f2ba2878ed96ee4c3c95ebb63ad81f36adec472","unresolved":true,"context_lines":[{"line_number":338,"context_line":"            if dev_name in seen_devs:"},{"line_number":339,"context_line":"                continue"},{"line_number":340,"context_line":"            seen_devs.add(dev_name)"},{"line_number":341,"context_line":"            max_partnum \u003d max(max_partnum, int(dev_name[disk_name_length:].replace(\"p\", \"\")))"},{"line_number":342,"context_line":"        return max_partnum + 1"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"37daf62a_c85a2aa9","line":341,"in_reply_to":"842cf7d2_62ec7b41","updated":"2025-04-28 13:25:09.000000000","message":"+1 to adding a comment above this line.\n\nI guess the kernel naming will always add the `p` prefix, so replace is probably ok. Might want to use a regular expression instead to get only the numbers of the end of the string in case the kernel can use a different prefix?","commit_id":"15e68d57ff9ef4a13d1b4d0cd5f62fa9c966231d"}],"diskimage_builder/elements/growvols/tests/test_growvols.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f835ea77c5a972860e9ce8af0b12b04bef029072","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        local_lsblk \u003d local_lsblk.replace(\u0027mpatha2\u0027, \u0027mpath2p2\u0027)"},{"line_number":498,"context_line":"        local_lsblk \u003d local_lsblk.replace(\u0027mpatha3\u0027, \u0027mpath2p3\u0027)"},{"line_number":499,"context_line":"        local_lsblk \u003d local_lsblk.replace(\u0027mpatha4\u0027, \u0027mpath2p4\u0027)"},{"line_number":500,"context_line":"        local_lsblk \u003d local_lsblk.replace(\u0027mpatha\u0027, \u0027mpath2\u0027)"},{"line_number":501,"context_line":"        devices \u003d list(growvols.parse_shell_vars(local_lsblk))"},{"line_number":502,"context_line":"        disk \u003d growvols.find_disk(opts, devices)"},{"line_number":503,"context_line":"        self.assertEqual(6, growvols.find_next_partnum(devices, disk))"}],"source_content_type":"text/x-python","patch_set":4,"id":"61c5eeed_4bdadf17","line":500,"range":{"start_line":500,"start_character":8,"end_line":500,"end_character":61},"updated":"2025-05-06 00:19:12.000000000","message":"I moved this replace to the end, otherwise the other replaces don\u0027t do what I intended ...","commit_id":"ff5c11c0952771ce1ae85078a347dc471da68ba1"}]}