)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9a6d1345a4c120a4ab4494ad7241152e47db6452","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove vm element from rocky-container image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use case is for building Rocky based IPA images where we need to use the"},{"line_number":10,"context_line":"baremetal element instead of vm element."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I43bb19415eb0b9c62e44c131497c28ae260369e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a003bd4a_75342e15","line":10,"updated":"2024-07-18 17:33:01.000000000","message":"I thought the baremetal and vm elements can be used together. The reason for this is the vm element is actually somewhat poorly named and doesn\u0027t really have anything to do with VMs but creating a complete image with partitions in it? Can anyone confirm or deny that? if there is an actual conflict we should write a followup to document that in the READMEs of the two elements.\n\nThat said I think this change is fine. None of the other distro element-deps lists include vm so we can give people more flexibility. I just want to see the messaging around why we\u0027re doing this improved if there isn\u0027t an actual conflict here so that we don\u0027t create the impression there is one.","commit_id":"56713c942770c69cf3e93787edf7d703b5735da5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"98fa2ee5e104f0e7247695367ca457a2889d9d80","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove vm element from rocky-container image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use case is for building Rocky based IPA images where we need to use the"},{"line_number":10,"context_line":"baremetal element instead of vm element."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I43bb19415eb0b9c62e44c131497c28ae260369e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"76d3c06a_e291e39d","line":10,"in_reply_to":"051edfab_dfb910eb","updated":"2024-09-18 10:54:14.000000000","message":"I\u0027ve used your suggested commit message (which was very clear by the way), but have also extended the change to other container based distro elements. Thanks.","commit_id":"56713c942770c69cf3e93787edf7d703b5735da5"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5db34e9d63ca4e186d3b55a7fabcb3c1c2868b97","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove vm element from rocky-container image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use case is for building Rocky based IPA images where we need to use the"},{"line_number":10,"context_line":"baremetal element instead of vm element."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I43bb19415eb0b9c62e44c131497c28ae260369e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"051edfab_dfb910eb","line":10,"in_reply_to":"a003bd4a_75342e15","updated":"2024-07-18 17:51:25.000000000","message":"Ya after some discussion on IRC it seems like the baremetal and vm elements should be compatible. To avoid further confusion on this point can we update the commit message to say something like:\n\n```\nRemove vm element from rocky-container image\n\nThe vm element sets up disk partitioning and bootloader installation in dib\nbuilt images. The rocky-container distro element is unique among distro\nelements in that it has a hard dependency on the vm element. Some dib users\nmay not need a complete disk image with partition tables and bootloaders; we\nremove the vm element to give them that flexibility.\n```\n\nThat hopefully avoids confusion around compatibility between the vm element and the baremetal element. Separately dib should probably start to consider renaming the vm element to something like \"partition_image\" and then \"vm\" can be an alias to that old name. I don\u0027t know what is involved in making that happen and we will need to be careful to avoid breaking existing image builds, but I suspect this is doable.","commit_id":"56713c942770c69cf3e93787edf7d703b5735da5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5db34e9d63ca4e186d3b55a7fabcb3c1c2868b97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d8120cc1_b992eb5c","updated":"2024-07-18 17:51:25.000000000","message":"-1 for the requested commit message updates. Otherwise I think the change itself looks good.","commit_id":"56713c942770c69cf3e93787edf7d703b5735da5"}],"releasenotes/notes/removes-vm-element-from-rocky-container-607cc59df13921d7.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5db34e9d63ca4e186d3b55a7fabcb3c1c2868b97","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    It is now possible to use the ``rocky-container`` element in conjuction"},{"line_number":11,"context_line":"    with  the ``baremetal`` element. This is useful for builing Rocky 9 images"},{"line_number":12,"context_line":"    that bundle Ironic Python Agent."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"71dfc635_8ccffec7","line":12,"updated":"2024-07-18 17:51:25.000000000","message":"Per the commit message comment can we drop this fixes block in the release notes?","commit_id":"56713c942770c69cf3e93787edf7d703b5735da5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"98fa2ee5e104f0e7247695367ca457a2889d9d80","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    It is now possible to use the ``rocky-container`` element in conjuction"},{"line_number":11,"context_line":"    with  the ``baremetal`` element. This is useful for builing Rocky 9 images"},{"line_number":12,"context_line":"    that bundle Ironic Python Agent."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7b99e902_dcae0459","line":12,"in_reply_to":"71dfc635_8ccffec7","updated":"2024-09-18 10:54:14.000000000","message":"Done","commit_id":"56713c942770c69cf3e93787edf7d703b5735da5"}]}